address some nits after the TESTrun storm

Remove a stray .md file and restore some comments from the removed .sh
files so future folk can see where the conditional tests come from, not
just the mere fact of their existence. Remove the unused fragile shebang
from testfuncs.pm.

[skip ci]

diff --git a/TESTING.md b/TESTING.md
deleted file mode 100644 (file)
index 3eaa4cb..0000000
--- a/TESTING.md
+++ /dev/null
@@ -1,2 +0,0 @@
-
-* requires YAML.pm, from libyaml-perl (perl-YAML on RHEL)

diff --git a/tests/crypto.tests b/tests/crypto.tests
index f0ab6f3cba8032bcae82e2f877863ea646f958ca..dc16edbd77074cd1b6d919234c46919b58dc9a5d 100644 (file)
--- a/tests/crypto.tests
+++ b/tests/crypto.tests
@@ -1,5 +1,8 @@
 # -*- perl -*-
 
+# Only attempt OpenSSL-specific tests when compiled with the library.
+# Reading the secret(s) from a file does not work with Capsicum.
+
 $testlist = [
     {
         config_set => 'HAVE_LIBCRYPTO',

diff --git a/tests/isis-seg-fault-1-v.tests b/tests/isis-seg-fault-1-v.tests
index b19d6dac98060fe064f5b50474990195cc3b55af..f90fc4a79331ab4d35aa4cda66e2ccf280c748b4 100644 (file)
--- a/tests/isis-seg-fault-1-v.tests
+++ b/tests/isis-seg-fault-1-v.tests
@@ -1,5 +1,9 @@
 # -*- perl -*-
 
+# This "verbose" ISIS protocol test involves a float calculation that
+# may produce a slightly different result if the compiler is not GCC.
+# Test only with GCC (similar to GitHub issue #333).
+
 $testlist = [
     {
         config_set => 'USING_GCC',

diff --git a/tests/lmp-v.tests b/tests/lmp-v.tests
index 5fa34a70fb699b7c95cc4d794df864b59fce3886..272325126e0580dfd5fa6bf258d21d09616959c4 100644 (file)
--- a/tests/lmp-v.tests
+++ b/tests/lmp-v.tests
@@ -1,5 +1,11 @@
 # -*- perl -*-
 
+# The "verbose" Link Management Protocol test involves a float calculation that
+# may produce a slightly different result depending on the architecture and the
+# compiler (see GitHub issue #333). The reference output was produced using a
+# GCC build and must reproduce correctly on any other GCC build regardless of
+# the architecture.
+
 $testlist = [
     {
         config_set => 'USING_GCC',

diff --git a/tests/testfuncs.pm b/tests/testfuncs.pm
index bed0d04d5189336ce62a7fb940bb4f8511c12167..aa40680f54fdbce12f9c7ada1ef584cee785ca39 100644 (file)
--- a/tests/testfuncs.pm
+++ b/tests/testfuncs.pm
@@ -1,4 +1,4 @@
-#!/usr/bin/perl
+# -*- perl -*-
 
 # expects to be run from the top directory, with "tests" subdirectory.