]> The Tcpdump Group git mirrors - tcpdump/commit
Clean up RX dissector.
authorGuy Harris <[email protected]>
Tue, 21 Nov 2017 20:33:41 +0000 (12:33 -0800)
committerGuy Harris <[email protected]>
Tue, 21 Nov 2017 20:33:55 +0000 (12:33 -0800)
commitfe1c2f0d7fb9221936b0d54a670b9f2eea2b72c4
treeace18c75835593017d1ffe7eed92a59c04c30c8b
parenta7a76012a129ffefb64f102948db63fbc715e45e
Clean up RX dissector.

Use uintN_t and intN_t types rather than u_short and u_int.

Use uint32_t rather than unsigned long, as that's what's intended.

Most fields in RX are unsigned, according to the OpenAFS source; make it
so.  Use EXTRACT_BE_INT32() to extract the one field that isn't.

The length and port numbers passed in from the UDP dissector are
unsigned; make the arguments unsigned.

Use ND_TTEST2 rather than a hand-rolled test.

Use ND_TCHECK_nBITS() rather than ND_TCHECK2() in some cases.
netdissect.h
print-rx.c