]> The Tcpdump Group git mirrors - tcpdump/commit
CVE-2017-12990/Fix printing of ISAKMPv1 Notification payload data.
authorGuy Harris <[email protected]>
Mon, 6 Feb 2017 22:33:50 +0000 (14:33 -0800)
committerDenis Ovsienko <[email protected]>
Sun, 3 Sep 2017 23:08:58 +0000 (00:08 +0100)
commit8bacee1c8e56ff92253366edd22f95b6e2c5e055
treee82d85299bb7366d165fb5ef152c01bcb2e6e8a6
parentba44b757d017e06d01df36c0def8c7ec34490036
CVE-2017-12990/Fix printing of ISAKMPv1 Notification payload data.

The closest thing to a specification for the contents of the payload
data is draft-ietf-ipsec-notifymsg-04, and nothing in there says that it
is ever a complete ISAKMP message, so don't dissect types we don't have
specific code for as a complete ISAKMP message.

While we're at it, fix a comment, and clean up printing of V1 Nonce,
V2 Authentication payloads, and v2 Notice payloads.

This fixes an infinite loop discovered by Forcepoint's security
researchers Otto Airamo & Antti Levomäki.

Add a test using the capture file supplied by the reporter(s).
print-isakmp.c
tests/TESTLIST
tests/isakmp-no-none-np.out [new file with mode: 0644]
tests/isakmp-no-none-np.pcap [new file with mode: 0644]