]> The Tcpdump Group git mirrors - tcpdump/commit
Add __attribute__((format)) to the declarations of the ndo_printf,
authorGuy Harris <[email protected]>
Sun, 24 May 2009 21:06:10 +0000 (14:06 -0700)
committerGuy Harris <[email protected]>
Sun, 24 May 2009 21:06:10 +0000 (14:06 -0700)
commit83236cce6581061123de4d644b2479b389282439
tree0dd07777d4210277e168cc4fe2dffce76fd0ede8
parent4ba67d9a002e30b5873528d9b66711999902878d
Add __attribute__((format)) to the declarations of the ndo_printf,
ndo_error, and ndo_warning function pointers in a netdissect_options
structure.

Fix some errors adding that caught.

Have the RRCP dissector extract fields itself, with the EXTRACT_ macros
and a u_char pointer, rather than printing numbers from a structure
which doesn't put structure members on natural boundaries
(__attribute__((packed)) doesn't help, as not all compilers support it)
- note also that not all processors support dereferencing unaligned
pointers, e.g. SPARC - and assuming some fields are in the "right" byte
order.  Also have it check whether data is available in the packet
before referring to it.
netdissect.h
print-isakmp.c
print-rrcp.c