]> The Tcpdump Group git mirrors - tcpdump/commit
Clean up ISAKMP dissection, use nd_ types and EXTRACT_ macros.
authorGuy Harris <[email protected]>
Mon, 18 Dec 2017 05:49:46 +0000 (21:49 -0800)
committerGuy Harris <[email protected]>
Mon, 18 Dec 2017 05:49:46 +0000 (21:49 -0800)
commit195a4cfd9de46b47ac6794930e19e38ed263b05f
tree868cdc6fead701d776b6c70b2a9e4370bc92ac31
parent3c706445968eb3c53e8a6f11742b62b4f70e8a1f
Clean up ISAKMP dissection, use nd_ types and EXTRACT_ macros.

Add some RFC numbers.

Structures with nd_ types work well if you overlay them on top of the
packet buffer, but not as well with an on-the-stack structure into which
you copy from the packet, which is ugly if you do *both* with the same
structure.  Use overlaying uniformly.

Add EXTRACT_ macros as necessary for the nd_ types.

Make stuff unsigned if it's appropriate.

Use unsigned formats for unsigned values.

A number of routines are passed the length of a payload, so they don't
have to re-fetch that length themselves.  That length has been
pre-checked to make sure it's big enough for the payload header; note
that in comments.
netdissect.h
print-esp.c
print-isakmp.c