]> The Tcpdump Group git mirrors - tcpdump/commit
projects / tcpdump / commit
summary | shortlog | log | commit | commitdiff | tree
(parent: 679a9b4) | patch
OpenFlow 1.0: Fix queue properties decoding.
authorDenis Ovsienko <[email protected]>
Wed, 23 Sep 2020 10:16:59 +0000 (11:16 +0100)
committerDenis Ovsienko <[email protected]>
Thu, 24 Sep 2020 17:58:45 +0000 (18:58 +0100)
commit07ee811374b9ec7e4c152d12fdc2eaf483555215
treed8e29272b98488587582c751520e53263b8e53batree
parent679a9b46ff71e17862f93547fe0631ba07bbe56ecommit | diff
OpenFlow 1.0: Fix queue properties decoding.

In of10_queue_props_print() the "skip" branch tested and skipped 4 bytes
too many, so a malformed queue property would likely result in an odd
truncation or incorrect decoding of subsequent data (this is based on
code analysis only).

Get the offset and the size right and add a comment to explain it. Add
and update other comments to clarify a few similar subtleties that are
easy to get wrong.
print-openflow-1.0.c diff | blob | history
print-openflow.c diff | blob | history
[mirror] the TCPdump network dissector