X-Git-Url: https://git.tcpdump.org/tcpdump/blobdiff_plain/ea759b171c7ee1e8281fd3eaa97a092c522dbdb0..bef667db65b15c89ec6f1cf325b76acd3c0b8748:/print-openflow-1.0.c

diff --git a/print-openflow-1.0.c b/print-openflow-1.0.c
index ee61054c..d7ac8b24 100644
--- a/print-openflow-1.0.c
+++ b/print-openflow-1.0.c
@@ -59,21 +59,19 @@
 /* \summary: OpenFlow protocol version 1.0 printer */
 
 #ifdef HAVE_CONFIG_H
-#include "config.h"
+#include <config.h>
 #endif
 
-#include <netdissect-stdinc.h>
+#include "netdissect-stdinc.h"
 
 #include "netdissect.h"
 #include "extract.h"
 #include "addrtoname.h"
-#include "ether.h"
 #include "ethertype.h"
 #include "ipproto.h"
 #include "oui.h"
 #include "openflow.h"
 
-static const char tstr[] = " [|openflow]";
 
 #define OFPT_HELLO                    0x00
 #define OFPT_ERROR                    0x01
@@ -704,7 +702,7 @@ vlan_str(const uint16_t vid)
 	if (vid == OFP_VLAN_NONE)
 		return "NONE";
 	fmt = (vid > 0 && vid < 0x0fff) ? "%u" : "%u (bogus)";
-	snprintf(buf, sizeof(buf), fmt, vid);
+	nd_snprintf(buf, sizeof(buf), fmt, vid);
 	return buf;
 }
 
@@ -712,7 +710,7 @@ static const char *
 pcp_str(const uint8_t pcp)
 {
 	static char buf[sizeof("255 (bogus)")];
-	snprintf(buf, sizeof(buf), pcp <= 7 ? "%u" : "%u (bogus)", pcp);
+	nd_snprintf(buf, sizeof(buf), pcp <= 7 ? "%u" : "%u (bogus)", pcp);
 	return buf;
 }
 
@@ -727,11 +725,11 @@ of10_bitmap_print(netdissect_options *ndo,
 	/* assigned bits */
 	for (; t->s != NULL; t++)
 		if (v & t->v) {
-			ND_PRINT((ndo, "%s%s", sep, t->s));
+			ND_PRINT("%s%s", sep, t->s);
 			sep = ", ";
 		}
 	/* unassigned bits? */
-	ND_PRINT((ndo, v & u ? ") (bogus)" : ")"));
+	ND_PRINT(v & u ? ") (bogus)" : ")");
 }
 
 static const u_char *
@@ -741,14 +739,14 @@ of10_data_print(netdissect_options *ndo,
 	if (len == 0)
 		return cp;
 	/* data */
-	ND_PRINT((ndo, "\n\t data (%u octets)", len));
-	ND_TCHECK2(*cp, len);
+	ND_PRINT("\n\t data (%u octets)", len);
+	ND_TCHECK_LEN(cp, len);
 	if (ndo->ndo_vflag >= 2)
 		hex_and_ascii_print(ndo, "\n\t  ", cp, len);
 	return cp + len;
 
 trunc:
-	ND_PRINT((ndo, "%s", tstr));
+	nd_print_trunc(ndo);
 	return ep;
 }
 
@@ -762,10 +760,10 @@ of10_bsn_message_print(netdissect_options *ndo,
 	if (len < 4)
 		goto invalid;
 	/* subtype */
-	ND_TCHECK2(*cp, 4);
-	subtype = EXTRACT_BE_32BITS(cp);
+	ND_TCHECK_4(cp);
+	subtype = GET_BE_U_4(cp);
 	cp += 4;
-	ND_PRINT((ndo, "\n\t subtype %s", tok2str(bsn_subtype_str, "unknown (0x%08x)", subtype)));
+	ND_PRINT("\n\t subtype %s", tok2str(bsn_subtype_str, "unknown (0x%08x)", subtype));
 	switch (subtype) {
 	case BSN_GET_IP_MASK_REQUEST:
 		/*
@@ -783,11 +781,11 @@ of10_bsn_message_print(netdissect_options *ndo,
 		if (len != 12)
 			goto invalid;
 		/* index */
-		ND_TCHECK2(*cp, 1);
-		ND_PRINT((ndo, ", index %u", *cp));
+		ND_TCHECK_1(cp);
+		ND_PRINT(", index %u", GET_U_1(cp));
 		cp += 1;
 		/* pad */
-		ND_TCHECK2(*cp, 7);
+		ND_TCHECK_7(cp);
 		cp += 7;
 		break;
 	case BSN_SET_IP_MASK:
@@ -807,15 +805,15 @@ of10_bsn_message_print(netdissect_options *ndo,
 		if (len != 12)
 			goto invalid;
 		/* index */
-		ND_TCHECK2(*cp, 1);
-		ND_PRINT((ndo, ", index %u", *cp));
+		ND_TCHECK_1(cp);
+		ND_PRINT(", index %u", GET_U_1(cp));
 		cp += 1;
 		/* pad */
-		ND_TCHECK2(*cp, 3);
+		ND_TCHECK_3(cp);
 		cp += 3;
 		/* mask */
-		ND_TCHECK2(*cp, 4);
-		ND_PRINT((ndo, ", mask %s", ipaddr_string(ndo, cp)));
+		ND_TCHECK_4(cp);
+		ND_PRINT(", mask %s", ipaddr_string(ndo, cp));
 		cp += 4;
 		break;
 	case BSN_SET_MIRRORING:
@@ -834,11 +832,12 @@ of10_bsn_message_print(netdissect_options *ndo,
 		if (len != 8)
 			goto invalid;
 		/* report_mirror_ports */
-		ND_TCHECK2(*cp, 1);
-		ND_PRINT((ndo, ", report_mirror_ports %s", tok2str(bsn_onoff_str, "bogus (%u)", EXTRACT_8BITS(cp))));
+		ND_TCHECK_1(cp);
+		ND_PRINT(", report_mirror_ports %s",
+			 tok2str(bsn_onoff_str, "bogus (%u)", GET_U_1(cp)));
 		cp += 1;
 		/* pad */
-		ND_TCHECK2(*cp, 3);
+		ND_TCHECK_3(cp);
 		cp += 3;
 		break;
 	case BSN_GET_INTERFACES_REQUEST:
@@ -871,8 +870,8 @@ of10_bsn_message_print(netdissect_options *ndo,
 		if (len != 8)
 			goto invalid;
 		/* vport_no */
-		ND_TCHECK2(*cp, 4);
-		ND_PRINT((ndo, ", vport_no %u", EXTRACT_BE_32BITS(cp)));
+		ND_TCHECK_4(cp);
+		ND_PRINT(", vport_no %u", GET_BE_U_4(cp));
 		cp += 4;
 		break;
 	case BSN_SHELL_COMMAND:
@@ -891,16 +890,16 @@ of10_bsn_message_print(netdissect_options *ndo,
 		if (len < 8)
 			goto invalid;
 		/* service */
-		ND_TCHECK2(*cp, 4);
-		ND_PRINT((ndo, ", service %u", EXTRACT_BE_32BITS(cp)));
+		ND_TCHECK_4(cp);
+		ND_PRINT(", service %u", GET_BE_U_4(cp));
 		cp += 4;
 		/* data */
-		ND_PRINT((ndo, ", data '"));
-		if (fn_printn(ndo, cp, len - 8, ep)) {
-			ND_PRINT((ndo, "'"));
+		ND_PRINT(", data '");
+		if (nd_printn(ndo, cp, len - 8, ep)) {
+			ND_PRINT("'");
 			goto trunc;
 		}
-		ND_PRINT((ndo, "'"));
+		ND_PRINT("'");
 		cp += len - 8;
 		break;
 	case BSN_SHELL_OUTPUT:
@@ -916,12 +915,12 @@ of10_bsn_message_print(netdissect_options *ndo,
 		 */
 		/* already checked that len >= 4 */
 		/* data */
-		ND_PRINT((ndo, ", data '"));
-		if (fn_printn(ndo, cp, len - 4, ep)) {
-			ND_PRINT((ndo, "'"));
+		ND_PRINT(", data '");
+		if (nd_printn(ndo, cp, len - 4, ep)) {
+			ND_PRINT("'");
 			goto trunc;
 		}
-		ND_PRINT((ndo, "'"));
+		ND_PRINT("'");
 		cp += len - 4;
 		break;
 	case BSN_SHELL_STATUS:
@@ -938,22 +937,22 @@ of10_bsn_message_print(netdissect_options *ndo,
 		if (len != 8)
 			goto invalid;
 		/* status */
-		ND_TCHECK2(*cp, 4);
-		ND_PRINT((ndo, ", status 0x%08x", EXTRACT_BE_32BITS(cp)));
+		ND_TCHECK_4(cp);
+		ND_PRINT(", status 0x%08x", GET_BE_U_4(cp));
 		cp += 4;
 		break;
 	default:
-		ND_TCHECK2(*cp, len - 4);
+		ND_TCHECK_LEN(cp, len - 4);
 		cp += len - 4;
 	}
 	return cp;
 
 invalid: /* skip the undersized data */
-	ND_PRINT((ndo, "%s", istr));
-	ND_TCHECK2(*cp0, len);
+	nd_print_invalid(ndo);
+	ND_TCHECK_LEN(cp0, len);
 	return cp0 + len;
 trunc:
-	ND_PRINT((ndo, "%s", tstr));
+	nd_print_trunc(ndo);
 	return ep;
 }
 
@@ -967,10 +966,10 @@ of10_bsn_actions_print(netdissect_options *ndo,
 	if (len < 4)
 		goto invalid;
 	/* subtype */
-	ND_TCHECK2(*cp, 4);
-	subtype = EXTRACT_BE_32BITS(cp);
+	ND_TCHECK_4(cp);
+	subtype = GET_BE_U_4(cp);
 	cp += 4;
-	ND_PRINT((ndo, "\n\t  subtype %s", tok2str(bsn_action_subtype_str, "unknown (0x%08x)", subtype)));
+	ND_PRINT("\n\t  subtype %s", tok2str(bsn_action_subtype_str, "unknown (0x%08x)", subtype));
 	switch (subtype) {
 	case BSN_ACTION_MIRROR:
 		/*
@@ -990,44 +989,45 @@ of10_bsn_actions_print(netdissect_options *ndo,
 		if (len != 16)
 			goto invalid;
 		/* dest_port */
-		ND_TCHECK2(*cp, 4);
-		ND_PRINT((ndo, ", dest_port %u", EXTRACT_BE_32BITS(cp)));
+		ND_TCHECK_4(cp);
+		ND_PRINT(", dest_port %u", GET_BE_U_4(cp));
 		cp += 4;
 		/* vlan_tag */
-		ND_TCHECK2(*cp, 4);
-		vlan_tag = EXTRACT_BE_32BITS(cp);
+		ND_TCHECK_4(cp);
+		vlan_tag = GET_BE_U_4(cp);
 		cp += 4;
 		switch (vlan_tag >> 16) {
 		case 0:
-			ND_PRINT((ndo, ", vlan_tag none"));
+			ND_PRINT(", vlan_tag none");
 			break;
 		case ETHERTYPE_8021Q:
-			ND_PRINT((ndo, ", vlan_tag 802.1Q (%s)", ieee8021q_tci_string(vlan_tag & 0xffff)));
+			ND_PRINT(", vlan_tag 802.1Q (%s)", ieee8021q_tci_string(vlan_tag & 0xffff));
 			break;
 		default:
-			ND_PRINT((ndo, ", vlan_tag unknown (0x%04x)", vlan_tag >> 16));
+			ND_PRINT(", vlan_tag unknown (0x%04x)", vlan_tag >> 16);
 		}
 		/* copy_stage */
-		ND_TCHECK2(*cp, 1);
-		ND_PRINT((ndo, ", copy_stage %s", tok2str(bsn_mirror_copy_stage_str, "unknown (%u)", EXTRACT_8BITS(cp))));
+		ND_TCHECK_1(cp);
+		ND_PRINT(", copy_stage %s",
+			 tok2str(bsn_mirror_copy_stage_str, "unknown (%u)", GET_U_1(cp)));
 		cp += 1;
 		/* pad */
-		ND_TCHECK2(*cp, 3);
+		ND_TCHECK_3(cp);
 		cp += 3;
 		break;
 	default:
-		ND_TCHECK2(*cp, len - 4);
+		ND_TCHECK_LEN(cp, len - 4);
 		cp += len - 4;
 	}
 
 	return cp;
 
 invalid:
-	ND_PRINT((ndo, "%s", istr));
-	ND_TCHECK2(*cp0, len);
+	nd_print_invalid(ndo);
+	ND_TCHECK_LEN(cp0, len);
 	return cp0 + len;
 trunc:
-	ND_PRINT((ndo, "%s", tstr));
+	nd_print_trunc(ndo);
 	return ep;
 }
 
@@ -1041,10 +1041,10 @@ of10_vendor_action_print(netdissect_options *ndo,
 	if (len < 4)
 		goto invalid;
 	/* vendor */
-	ND_TCHECK2(*cp, 4);
-	vendor = EXTRACT_BE_32BITS(cp);
+	ND_TCHECK_4(cp);
+	vendor = GET_BE_U_4(cp);
 	cp += 4;
-	ND_PRINT((ndo, ", vendor 0x%08x (%s)", vendor, of_vendor_name(vendor)));
+	ND_PRINT(", vendor 0x%08x (%s)", vendor, of_vendor_name(vendor));
 	/* data */
 	decoder =
 		vendor == OUI_BSN         ? of10_bsn_actions_print         :
@@ -1052,11 +1052,11 @@ of10_vendor_action_print(netdissect_options *ndo,
 	return decoder(ndo, cp, ep, len - 4);
 
 invalid: /* skip the undersized data */
-	ND_PRINT((ndo, "%s", istr));
-	ND_TCHECK2(*cp, len);
+	nd_print_invalid(ndo);
+	ND_TCHECK_LEN(cp, len);
 	return cp + len;
 trunc:
-	ND_PRINT((ndo, "%s", tstr));
+	nd_print_trunc(ndo);
 	return ep;
 }
 
@@ -1070,10 +1070,10 @@ of10_vendor_message_print(netdissect_options *ndo,
 	if (len < 4)
 		goto invalid;
 	/* vendor */
-	ND_TCHECK2(*cp, 4);
-	vendor = EXTRACT_BE_32BITS(cp);
+	ND_TCHECK_4(cp);
+	vendor = GET_BE_U_4(cp);
 	cp += 4;
-	ND_PRINT((ndo, ", vendor 0x%08x (%s)", vendor, of_vendor_name(vendor)));
+	ND_PRINT(", vendor 0x%08x (%s)", vendor, of_vendor_name(vendor));
 	/* data */
 	decoder =
 		vendor == OUI_BSN         ? of10_bsn_message_print         :
@@ -1081,11 +1081,11 @@ of10_vendor_message_print(netdissect_options *ndo,
 	return decoder(ndo, cp, ep, len - 4);
 
 invalid: /* skip the undersized data */
-	ND_PRINT((ndo, "%s", istr));
-	ND_TCHECK2(*cp, len);
+	nd_print_invalid(ndo);
+	ND_TCHECK_LEN(cp, len);
 	return cp + len;
 trunc:
-	ND_PRINT((ndo, "%s", tstr));
+	nd_print_trunc(ndo);
 	return ep;
 }
 
@@ -1099,19 +1099,19 @@ of10_vendor_data_print(netdissect_options *ndo,
 	if (len < 4)
 		goto invalid;
 	/* vendor */
-	ND_TCHECK2(*cp, 4);
-	vendor = EXTRACT_BE_32BITS(cp);
+	ND_TCHECK_4(cp);
+	vendor = GET_BE_U_4(cp);
 	cp += 4;
-	ND_PRINT((ndo, ", vendor 0x%08x (%s)", vendor, of_vendor_name(vendor)));
+	ND_PRINT(", vendor 0x%08x (%s)", vendor, of_vendor_name(vendor));
 	/* data */
 	return of10_data_print(ndo, cp, ep, len - 4);
 
 invalid: /* skip the undersized data */
-	ND_PRINT((ndo, "%s", istr));
-	ND_TCHECK2(*cp, len);
+	nd_print_invalid(ndo);
+	ND_TCHECK_LEN(cp, len);
 	return cp + len;
 trunc:
-	ND_PRINT((ndo, "%s", tstr));
+	nd_print_trunc(ndo);
 	return ep;
 }
 
@@ -1122,18 +1122,18 @@ of10_packet_data_print(netdissect_options *ndo,
 	if (len == 0)
 		return cp;
 	/* data */
-	ND_PRINT((ndo, "\n\t data (%u octets)", len));
+	ND_PRINT("\n\t data (%u octets)", len);
 	if (ndo->ndo_vflag < 3)
 		return cp + len;
-	ND_TCHECK2(*cp, len);
+	ND_TCHECK_LEN(cp, len);
 	ndo->ndo_vflag -= 3;
-	ND_PRINT((ndo, ", frame decoding below\n"));
+	ND_PRINT(", frame decoding below\n");
 	ether_print(ndo, cp, len, ndo->ndo_snapend - cp, NULL, NULL);
 	ndo->ndo_vflag += 3;
 	return cp + len;
 
 trunc:
-	ND_PRINT((ndo, "%s", tstr));
+	nd_print_trunc(ndo);
 	return ep;
 }
 
@@ -1149,59 +1149,60 @@ of10_phy_ports_print(netdissect_options *ndo,
 		if (len < OF_PHY_PORT_LEN)
 			goto invalid;
 		/* port_no */
-		ND_TCHECK2(*cp, 2);
-		ND_PRINT((ndo, "\n\t  port_no %s", tok2str(ofpp_str, "%u", EXTRACT_BE_16BITS(cp))));
+		ND_TCHECK_2(cp);
+		ND_PRINT("\n\t  port_no %s",
+			 tok2str(ofpp_str, "%u", GET_BE_U_2(cp)));
 		cp += 2;
 		/* hw_addr */
-		ND_TCHECK2(*cp, ETHER_ADDR_LEN);
-		ND_PRINT((ndo, ", hw_addr %s", etheraddr_string(ndo, cp)));
-		cp += ETHER_ADDR_LEN;
+		ND_TCHECK_LEN(cp, MAC_ADDR_LEN);
+		ND_PRINT(", hw_addr %s", etheraddr_string(ndo, cp));
+		cp += MAC_ADDR_LEN;
 		/* name */
-		ND_TCHECK2(*cp, OFP_MAX_PORT_NAME_LEN);
-		ND_PRINT((ndo, ", name '"));
-		fn_print(ndo, cp, cp + OFP_MAX_PORT_NAME_LEN);
-		ND_PRINT((ndo, "'"));
+		ND_TCHECK_LEN(cp, OFP_MAX_PORT_NAME_LEN);
+		ND_PRINT(", name '");
+		nd_print(ndo, cp, cp + OFP_MAX_PORT_NAME_LEN);
+		ND_PRINT("'");
 		cp += OFP_MAX_PORT_NAME_LEN;
 
 		if (ndo->ndo_vflag < 2) {
-			ND_TCHECK2(*cp, 24);
+			ND_TCHECK_LEN(cp, 24);
 			cp += 24;
 			goto next_port;
 		}
 		/* config */
-		ND_TCHECK2(*cp, 4);
-		ND_PRINT((ndo, "\n\t   config 0x%08x", EXTRACT_BE_32BITS(cp)));
-		of10_bitmap_print(ndo, ofppc_bm, EXTRACT_BE_32BITS(cp),
+		ND_TCHECK_4(cp);
+		ND_PRINT("\n\t   config 0x%08x", GET_BE_U_4(cp));
+		of10_bitmap_print(ndo, ofppc_bm, GET_BE_U_4(cp),
 				  OFPPC_U);
 		cp += 4;
 		/* state */
-		ND_TCHECK2(*cp, 4);
-		ND_PRINT((ndo, "\n\t   state 0x%08x", EXTRACT_BE_32BITS(cp)));
-		of10_bitmap_print(ndo, ofpps_bm, EXTRACT_BE_32BITS(cp),
+		ND_TCHECK_4(cp);
+		ND_PRINT("\n\t   state 0x%08x", GET_BE_U_4(cp));
+		of10_bitmap_print(ndo, ofpps_bm, GET_BE_U_4(cp),
 				  OFPPS_U);
 		cp += 4;
 		/* curr */
-		ND_TCHECK2(*cp, 4);
-		ND_PRINT((ndo, "\n\t   curr 0x%08x", EXTRACT_BE_32BITS(cp)));
-		of10_bitmap_print(ndo, ofppf_bm, EXTRACT_BE_32BITS(cp),
+		ND_TCHECK_4(cp);
+		ND_PRINT("\n\t   curr 0x%08x", GET_BE_U_4(cp));
+		of10_bitmap_print(ndo, ofppf_bm, GET_BE_U_4(cp),
 				  OFPPF_U);
 		cp += 4;
 		/* advertised */
-		ND_TCHECK2(*cp, 4);
-		ND_PRINT((ndo, "\n\t   advertised 0x%08x", EXTRACT_BE_32BITS(cp)));
-		of10_bitmap_print(ndo, ofppf_bm, EXTRACT_BE_32BITS(cp),
+		ND_TCHECK_4(cp);
+		ND_PRINT("\n\t   advertised 0x%08x", GET_BE_U_4(cp));
+		of10_bitmap_print(ndo, ofppf_bm, GET_BE_U_4(cp),
 				  OFPPF_U);
 		cp += 4;
 		/* supported */
-		ND_TCHECK2(*cp, 4);
-		ND_PRINT((ndo, "\n\t   supported 0x%08x", EXTRACT_BE_32BITS(cp)));
-		of10_bitmap_print(ndo, ofppf_bm, EXTRACT_BE_32BITS(cp),
+		ND_TCHECK_4(cp);
+		ND_PRINT("\n\t   supported 0x%08x", GET_BE_U_4(cp));
+		of10_bitmap_print(ndo, ofppf_bm, GET_BE_U_4(cp),
 				  OFPPF_U);
 		cp += 4;
 		/* peer */
-		ND_TCHECK2(*cp, 4);
-		ND_PRINT((ndo, "\n\t   peer 0x%08x", EXTRACT_BE_32BITS(cp)));
-		of10_bitmap_print(ndo, ofppf_bm, EXTRACT_BE_32BITS(cp),
+		ND_TCHECK_4(cp);
+		ND_PRINT("\n\t   peer 0x%08x", GET_BE_U_4(cp));
+		of10_bitmap_print(ndo, ofppf_bm, GET_BE_U_4(cp),
 				  OFPPF_U);
 		cp += 4;
 next_port:
@@ -1210,11 +1211,11 @@ next_port:
 	return cp;
 
 invalid: /* skip the undersized trailing data */
-	ND_PRINT((ndo, "%s", istr));
-	ND_TCHECK2(*cp0, len0);
+	nd_print_invalid(ndo);
+	ND_TCHECK_LEN(cp0, len0);
 	return cp0 + len0;
 trunc:
-	ND_PRINT((ndo, "%s", tstr));
+	nd_print_trunc(ndo);
 	return ep;
 }
 
@@ -1233,19 +1234,19 @@ of10_queue_props_print(netdissect_options *ndo,
 		if (len < OF_QUEUE_PROP_HEADER_LEN)
 			goto invalid;
 		/* property */
-		ND_TCHECK2(*cp, 2);
-		property = EXTRACT_BE_16BITS(cp);
+		ND_TCHECK_2(cp);
+		property = GET_BE_U_2(cp);
 		cp += 2;
-		ND_PRINT((ndo, "\n\t   property %s", tok2str(ofpqt_str, "invalid (0x%04x)", property)));
+		ND_PRINT("\n\t   property %s", tok2str(ofpqt_str, "invalid (0x%04x)", property));
 		/* len */
-		ND_TCHECK2(*cp, 2);
-		plen = EXTRACT_BE_16BITS(cp);
+		ND_TCHECK_2(cp);
+		plen = GET_BE_U_2(cp);
 		cp += 2;
-		ND_PRINT((ndo, ", len %u", plen));
+		ND_PRINT(", len %u", plen);
 		if (plen < OF_QUEUE_PROP_HEADER_LEN || plen > len)
 			goto invalid;
 		/* pad */
-		ND_TCHECK2(*cp, 4);
+		ND_TCHECK_4(cp);
 		cp += 4;
 		/* property-specific constraints and decoding */
 		switch (property) {
@@ -1259,25 +1260,25 @@ of10_queue_props_print(netdissect_options *ndo,
 			skip = 1;
 		}
 		if (plen_bogus) {
-			ND_PRINT((ndo, " (bogus)"));
+			ND_PRINT(" (bogus)");
 			skip = 1;
 		}
 		if (skip) {
-			ND_TCHECK2(*cp, plen - 4);
+			ND_TCHECK_LEN(cp, plen - 4);
 			cp += plen - 4;
 			goto next_property;
 		}
 		if (property == OFPQT_MIN_RATE) { /* the only case of property decoding */
 			/* rate */
-			ND_TCHECK2(*cp, 2);
-			rate = EXTRACT_BE_16BITS(cp);
+			ND_TCHECK_2(cp);
+			rate = GET_BE_U_2(cp);
 			cp += 2;
 			if (rate > 1000)
-				ND_PRINT((ndo, ", rate disabled"));
+				ND_PRINT(", rate disabled");
 			else
-				ND_PRINT((ndo, ", rate %u.%u%%", rate / 10, rate % 10));
+				ND_PRINT(", rate %u.%u%%", rate / 10, rate % 10);
 			/* pad */
-			ND_TCHECK2(*cp, 6);
+			ND_TCHECK_6(cp);
 			cp += 6;
 		}
 next_property:
@@ -1286,11 +1287,11 @@ next_property:
 	return cp;
 
 invalid: /* skip the rest of queue properties */
-	ND_PRINT((ndo, "%s", istr));
-	ND_TCHECK2(*cp0, len0);
+	nd_print_invalid(ndo);
+	ND_TCHECK_LEN(cp0, len0);
 	return cp0 + len0;
 trunc:
-	ND_PRINT((ndo, "%s", tstr));
+	nd_print_trunc(ndo);
 	return ep;
 }
 
@@ -1307,22 +1308,22 @@ of10_queues_print(netdissect_options *ndo,
 		if (len < OF_PACKET_QUEUE_LEN)
 			goto invalid;
 		/* queue_id */
-		ND_TCHECK2(*cp, 4);
-		ND_PRINT((ndo, "\n\t  queue_id %u", EXTRACT_BE_32BITS(cp)));
+		ND_TCHECK_4(cp);
+		ND_PRINT("\n\t  queue_id %u", GET_BE_U_4(cp));
 		cp += 4;
 		/* len */
-		ND_TCHECK2(*cp, 2);
-		desclen = EXTRACT_BE_16BITS(cp);
+		ND_TCHECK_2(cp);
+		desclen = GET_BE_U_2(cp);
 		cp += 2;
-		ND_PRINT((ndo, ", len %u", desclen));
+		ND_PRINT(", len %u", desclen);
 		if (desclen < OF_PACKET_QUEUE_LEN || desclen > len)
 			goto invalid;
 		/* pad */
-		ND_TCHECK2(*cp, 2);
+		ND_TCHECK_2(cp);
 		cp += 2;
 		/* properties */
 		if (ndo->ndo_vflag < 2) {
-			ND_TCHECK2(*cp, desclen - OF_PACKET_QUEUE_LEN);
+			ND_TCHECK_LEN(cp, desclen - OF_PACKET_QUEUE_LEN);
 			cp += desclen - OF_PACKET_QUEUE_LEN;
 			goto next_queue;
 		}
@@ -1334,11 +1335,11 @@ next_queue:
 	return cp;
 
 invalid: /* skip the rest of queues */
-	ND_PRINT((ndo, "%s", istr));
-	ND_TCHECK2(*cp0, len0);
+	nd_print_invalid(ndo);
+	ND_TCHECK_LEN(cp0, len0);
 	return cp0 + len0;
 trunc:
-	ND_PRINT((ndo, "%s", tstr));
+	nd_print_trunc(ndo);
 	return ep;
 }
 
@@ -1350,99 +1351,100 @@ of10_match_print(netdissect_options *ndo,
 	uint32_t wildcards;
 	uint16_t dl_type;
 	uint8_t nw_proto;
-	u_char nw_bits;
+	u_int nw_bits;
 	const char *field_name;
 
 	/* wildcards */
-	ND_TCHECK2(*cp, 4);
-	wildcards = EXTRACT_BE_32BITS(cp);
+	ND_TCHECK_4(cp);
+	wildcards = GET_BE_U_4(cp);
 	if (wildcards & OFPFW_U)
-		ND_PRINT((ndo, "%swildcards 0x%08x (bogus)", pfx, wildcards));
+		ND_PRINT("%swildcards 0x%08x (bogus)", pfx, wildcards);
 	cp += 4;
 	/* in_port */
-	ND_TCHECK2(*cp, 2);
+	ND_TCHECK_2(cp);
 	if (! (wildcards & OFPFW_IN_PORT))
-		ND_PRINT((ndo, "%smatch in_port %s", pfx, tok2str(ofpp_str, "%u", EXTRACT_BE_16BITS(cp))));
+		ND_PRINT("%smatch in_port %s", pfx,
+			 tok2str(ofpp_str, "%u", GET_BE_U_2(cp)));
 	cp += 2;
 	/* dl_src */
-	ND_TCHECK2(*cp, ETHER_ADDR_LEN);
+	ND_TCHECK_LEN(cp, MAC_ADDR_LEN);
 	if (! (wildcards & OFPFW_DL_SRC))
-		ND_PRINT((ndo, "%smatch dl_src %s", pfx, etheraddr_string(ndo, cp)));
-	cp += ETHER_ADDR_LEN;
+		ND_PRINT("%smatch dl_src %s", pfx, etheraddr_string(ndo, cp));
+	cp += MAC_ADDR_LEN;
 	/* dl_dst */
-	ND_TCHECK2(*cp, ETHER_ADDR_LEN);
+	ND_TCHECK_LEN(cp, MAC_ADDR_LEN);
 	if (! (wildcards & OFPFW_DL_DST))
-		ND_PRINT((ndo, "%smatch dl_dst %s", pfx, etheraddr_string(ndo, cp)));
-	cp += ETHER_ADDR_LEN;
+		ND_PRINT("%smatch dl_dst %s", pfx, etheraddr_string(ndo, cp));
+	cp += MAC_ADDR_LEN;
 	/* dl_vlan */
-	ND_TCHECK2(*cp, 2);
+	ND_TCHECK_2(cp);
 	if (! (wildcards & OFPFW_DL_VLAN))
-		ND_PRINT((ndo, "%smatch dl_vlan %s", pfx, vlan_str(EXTRACT_BE_16BITS(cp))));
+		ND_PRINT("%smatch dl_vlan %s", pfx, vlan_str(GET_BE_U_2(cp)));
 	cp += 2;
 	/* dl_vlan_pcp */
-	ND_TCHECK2(*cp, 1);
+	ND_TCHECK_1(cp);
 	if (! (wildcards & OFPFW_DL_VLAN_PCP))
-		ND_PRINT((ndo, "%smatch dl_vlan_pcp %s", pfx, pcp_str(*cp)));
+		ND_PRINT("%smatch dl_vlan_pcp %s", pfx, pcp_str(GET_U_1(cp)));
 	cp += 1;
 	/* pad1 */
-	ND_TCHECK2(*cp, 1);
+	ND_TCHECK_1(cp);
 	cp += 1;
 	/* dl_type */
-	ND_TCHECK2(*cp, 2);
-	dl_type = EXTRACT_BE_16BITS(cp);
+	ND_TCHECK_2(cp);
+	dl_type = GET_BE_U_2(cp);
 	cp += 2;
 	if (! (wildcards & OFPFW_DL_TYPE))
-		ND_PRINT((ndo, "%smatch dl_type 0x%04x", pfx, dl_type));
+		ND_PRINT("%smatch dl_type 0x%04x", pfx, dl_type);
 	/* nw_tos */
-	ND_TCHECK2(*cp, 1);
+	ND_TCHECK_1(cp);
 	if (! (wildcards & OFPFW_NW_TOS))
-		ND_PRINT((ndo, "%smatch nw_tos 0x%02x", pfx, *cp));
+		ND_PRINT("%smatch nw_tos 0x%02x", pfx, GET_U_1(cp));
 	cp += 1;
 	/* nw_proto */
-	ND_TCHECK2(*cp, 1);
-	nw_proto = *cp;
+	ND_TCHECK_1(cp);
+	nw_proto = GET_U_1(cp);
 	cp += 1;
 	if (! (wildcards & OFPFW_NW_PROTO)) {
 		field_name = ! (wildcards & OFPFW_DL_TYPE) && dl_type == ETHERTYPE_ARP
 		  ? "arp_opcode" : "nw_proto";
-		ND_PRINT((ndo, "%smatch %s %u", pfx, field_name, nw_proto));
+		ND_PRINT("%smatch %s %u", pfx, field_name, nw_proto);
 	}
 	/* pad2 */
-	ND_TCHECK2(*cp, 2);
+	ND_TCHECK_2(cp);
 	cp += 2;
 	/* nw_src */
-	ND_TCHECK2(*cp, 4);
+	ND_TCHECK_4(cp);
 	nw_bits = (wildcards & OFPFW_NW_SRC_MASK) >> OFPFW_NW_SRC_SHIFT;
 	if (nw_bits < 32)
-		ND_PRINT((ndo, "%smatch nw_src %s/%u", pfx, ipaddr_string(ndo, cp), 32 - nw_bits));
+		ND_PRINT("%smatch nw_src %s/%u", pfx, ipaddr_string(ndo, cp), 32 - nw_bits);
 	cp += 4;
 	/* nw_dst */
-	ND_TCHECK2(*cp, 4);
+	ND_TCHECK_4(cp);
 	nw_bits = (wildcards & OFPFW_NW_DST_MASK) >> OFPFW_NW_DST_SHIFT;
 	if (nw_bits < 32)
-		ND_PRINT((ndo, "%smatch nw_dst %s/%u", pfx, ipaddr_string(ndo, cp), 32 - nw_bits));
+		ND_PRINT("%smatch nw_dst %s/%u", pfx, ipaddr_string(ndo, cp), 32 - nw_bits);
 	cp += 4;
 	/* tp_src */
-	ND_TCHECK2(*cp, 2);
+	ND_TCHECK_2(cp);
 	if (! (wildcards & OFPFW_TP_SRC)) {
 		field_name = ! (wildcards & OFPFW_DL_TYPE) && dl_type == ETHERTYPE_IP
 		  && ! (wildcards & OFPFW_NW_PROTO) && nw_proto == IPPROTO_ICMP
 		  ? "icmp_type" : "tp_src";
-		ND_PRINT((ndo, "%smatch %s %u", pfx, field_name, EXTRACT_BE_16BITS(cp)));
+		ND_PRINT("%smatch %s %u", pfx, field_name, GET_BE_U_2(cp));
 	}
 	cp += 2;
 	/* tp_dst */
-	ND_TCHECK2(*cp, 2);
+	ND_TCHECK_2(cp);
 	if (! (wildcards & OFPFW_TP_DST)) {
 		field_name = ! (wildcards & OFPFW_DL_TYPE) && dl_type == ETHERTYPE_IP
 		  && ! (wildcards & OFPFW_NW_PROTO) && nw_proto == IPPROTO_ICMP
 		  ? "icmp_code" : "tp_dst";
-		ND_PRINT((ndo, "%smatch %s %u", pfx, field_name, EXTRACT_BE_16BITS(cp)));
+		ND_PRINT("%smatch %s %u", pfx, field_name, GET_BE_U_2(cp));
 	}
 	return cp + 2;
 
 trunc:
-	ND_PRINT((ndo, "%s", tstr));
+	nd_print_trunc(ndo);
 	return ep;
 }
 
@@ -1462,15 +1464,15 @@ of10_actions_print(netdissect_options *ndo,
 		if (len < OF_ACTION_HEADER_LEN)
 			goto invalid;
 		/* type */
-		ND_TCHECK2(*cp, 2);
-		type = EXTRACT_BE_16BITS(cp);
+		ND_TCHECK_2(cp);
+		type = GET_BE_U_2(cp);
 		cp += 2;
-		ND_PRINT((ndo, "%saction type %s", pfx, tok2str(ofpat_str, "invalid (0x%04x)", type)));
+		ND_PRINT("%saction type %s", pfx, tok2str(ofpat_str, "invalid (0x%04x)", type));
 		/* length */
-		ND_TCHECK2(*cp, 2);
-		alen = EXTRACT_BE_16BITS(cp);
+		ND_TCHECK_2(cp);
+		alen = GET_BE_U_2(cp);
 		cp += 2;
-		ND_PRINT((ndo, ", len %u", alen));
+		ND_PRINT(", len %u", alen);
 		/* On action size underrun/overrun skip the rest of the action list. */
 		if (alen < OF_ACTION_HEADER_LEN || alen > len)
 			goto invalid;
@@ -1500,11 +1502,11 @@ of10_actions_print(netdissect_options *ndo,
 			skip = 1;
 		}
 		if (alen_bogus) {
-			ND_PRINT((ndo, " (bogus)"));
+			ND_PRINT(" (bogus)");
 			skip = 1;
 		}
 		if (skip) {
-			ND_TCHECK2(*cp, alen - 4);
+			ND_TCHECK_LEN(cp, alen - 4);
 			cp += alen - 4;
 			goto next_action;
 		}
@@ -1512,81 +1514,83 @@ of10_actions_print(netdissect_options *ndo,
 		switch (type) {
 		case OFPAT_OUTPUT:
 			/* port */
-			ND_TCHECK2(*cp, 2);
-			output_port = EXTRACT_BE_16BITS(cp);
+			ND_TCHECK_2(cp);
+			output_port = GET_BE_U_2(cp);
 			cp += 2;
-			ND_PRINT((ndo, ", port %s", tok2str(ofpp_str, "%u", output_port)));
+			ND_PRINT(", port %s", tok2str(ofpp_str, "%u", output_port));
 			/* max_len */
-			ND_TCHECK2(*cp, 2);
+			ND_TCHECK_2(cp);
 			if (output_port == OFPP_CONTROLLER)
-				ND_PRINT((ndo, ", max_len %u", EXTRACT_BE_16BITS(cp)));
+				ND_PRINT(", max_len %u", GET_BE_U_2(cp));
 			cp += 2;
 			break;
 		case OFPAT_SET_VLAN_VID:
 			/* vlan_vid */
-			ND_TCHECK2(*cp, 2);
-			ND_PRINT((ndo, ", vlan_vid %s", vlan_str(EXTRACT_BE_16BITS(cp))));
+			ND_TCHECK_2(cp);
+			ND_PRINT(", vlan_vid %s", vlan_str(GET_BE_U_2(cp)));
 			cp += 2;
 			/* pad */
-			ND_TCHECK2(*cp, 2);
+			ND_TCHECK_2(cp);
 			cp += 2;
 			break;
 		case OFPAT_SET_VLAN_PCP:
 			/* vlan_pcp */
-			ND_TCHECK2(*cp, 1);
-			ND_PRINT((ndo, ", vlan_pcp %s", pcp_str(*cp)));
+			ND_TCHECK_1(cp);
+			ND_PRINT(", vlan_pcp %s", pcp_str(GET_U_1(cp)));
 			cp += 1;
 			/* pad */
-			ND_TCHECK2(*cp, 3);
+			ND_TCHECK_3(cp);
 			cp += 3;
 			break;
 		case OFPAT_SET_DL_SRC:
 		case OFPAT_SET_DL_DST:
 			/* dl_addr */
-			ND_TCHECK2(*cp, ETHER_ADDR_LEN);
-			ND_PRINT((ndo, ", dl_addr %s", etheraddr_string(ndo, cp)));
-			cp += ETHER_ADDR_LEN;
+			ND_TCHECK_LEN(cp, MAC_ADDR_LEN);
+			ND_PRINT(", dl_addr %s", etheraddr_string(ndo, cp));
+			cp += MAC_ADDR_LEN;
 			/* pad */
-			ND_TCHECK2(*cp, 6);
+			ND_TCHECK_6(cp);
 			cp += 6;
 			break;
 		case OFPAT_SET_NW_SRC:
 		case OFPAT_SET_NW_DST:
 			/* nw_addr */
-			ND_TCHECK2(*cp, 4);
-			ND_PRINT((ndo, ", nw_addr %s", ipaddr_string(ndo, cp)));
+			ND_TCHECK_4(cp);
+			ND_PRINT(", nw_addr %s", ipaddr_string(ndo, cp));
 			cp += 4;
 			break;
 		case OFPAT_SET_NW_TOS:
 			/* nw_tos */
-			ND_TCHECK2(*cp, 1);
-			ND_PRINT((ndo, ", nw_tos 0x%02x", *cp));
+			ND_TCHECK_1(cp);
+			ND_PRINT(", nw_tos 0x%02x", GET_U_1(cp));
 			cp += 1;
 			/* pad */
-			ND_TCHECK2(*cp, 3);
+			ND_TCHECK_3(cp);
 			cp += 3;
 			break;
 		case OFPAT_SET_TP_SRC:
 		case OFPAT_SET_TP_DST:
 			/* nw_tos */
-			ND_TCHECK2(*cp, 2);
-			ND_PRINT((ndo, ", tp_port %u", EXTRACT_BE_16BITS(cp)));
+			ND_TCHECK_2(cp);
+			ND_PRINT(", tp_port %u", GET_BE_U_2(cp));
 			cp += 2;
 			/* pad */
-			ND_TCHECK2(*cp, 2);
+			ND_TCHECK_2(cp);
 			cp += 2;
 			break;
 		case OFPAT_ENQUEUE:
 			/* port */
-			ND_TCHECK2(*cp, 2);
-			ND_PRINT((ndo, ", port %s", tok2str(ofpp_str, "%u", EXTRACT_BE_16BITS(cp))));
+			ND_TCHECK_2(cp);
+			ND_PRINT(", port %s",
+				 tok2str(ofpp_str, "%u", GET_BE_U_2(cp)));
 			cp += 2;
 			/* pad */
-			ND_TCHECK2(*cp, 6);
+			ND_TCHECK_6(cp);
 			cp += 6;
 			/* queue_id */
-			ND_TCHECK2(*cp, 4);
-			ND_PRINT((ndo, ", queue_id %s", tok2str(ofpq_str, "%u", EXTRACT_BE_32BITS(cp))));
+			ND_TCHECK_4(cp);
+			ND_PRINT(", queue_id %s",
+				 tok2str(ofpq_str, "%u", GET_BE_U_4(cp)));
 			cp += 4;
 			break;
 		case OFPAT_VENDOR:
@@ -1595,7 +1599,7 @@ of10_actions_print(netdissect_options *ndo,
 			break;
 		case OFPAT_STRIP_VLAN:
 			/* pad */
-			ND_TCHECK2(*cp, 4);
+			ND_TCHECK_4(cp);
 			cp += 4;
 			break;
 		} /* switch */
@@ -1605,11 +1609,11 @@ next_action:
 	return cp;
 
 invalid: /* skip the rest of actions */
-	ND_PRINT((ndo, "%s", istr));
-	ND_TCHECK2(*cp0, len0);
+	nd_print_invalid(ndo);
+	ND_TCHECK_LEN(cp0, len0);
 	return cp0 + len0;
 trunc:
-	ND_PRINT((ndo, "%s", tstr));
+	nd_print_trunc(ndo);
 	return ep;
 }
 
@@ -1619,36 +1623,36 @@ of10_features_reply_print(netdissect_options *ndo,
                           const u_char *cp, const u_char *ep, const u_int len)
 {
 	/* datapath_id */
-	ND_TCHECK2(*cp, 8);
-	ND_PRINT((ndo, "\n\t dpid 0x%016" PRIx64, EXTRACT_BE_64BITS(cp)));
+	ND_TCHECK_8(cp);
+	ND_PRINT("\n\t dpid 0x%016" PRIx64, GET_BE_U_8(cp));
 	cp += 8;
 	/* n_buffers */
-	ND_TCHECK2(*cp, 4);
-	ND_PRINT((ndo, ", n_buffers %u", EXTRACT_BE_32BITS(cp)));
+	ND_TCHECK_4(cp);
+	ND_PRINT(", n_buffers %u", GET_BE_U_4(cp));
 	cp += 4;
 	/* n_tables */
-	ND_TCHECK2(*cp, 1);
-	ND_PRINT((ndo, ", n_tables %u", *cp));
+	ND_TCHECK_1(cp);
+	ND_PRINT(", n_tables %u", GET_U_1(cp));
 	cp += 1;
 	/* pad */
-	ND_TCHECK2(*cp, 3);
+	ND_TCHECK_3(cp);
 	cp += 3;
 	/* capabilities */
-	ND_TCHECK2(*cp, 4);
-	ND_PRINT((ndo, "\n\t capabilities 0x%08x", EXTRACT_BE_32BITS(cp)));
-	of10_bitmap_print(ndo, ofp_capabilities_bm, EXTRACT_BE_32BITS(cp),
+	ND_TCHECK_4(cp);
+	ND_PRINT("\n\t capabilities 0x%08x", GET_BE_U_4(cp));
+	of10_bitmap_print(ndo, ofp_capabilities_bm, GET_BE_U_4(cp),
 			  OFPCAP_U);
 	cp += 4;
 	/* actions */
-	ND_TCHECK2(*cp, 4);
-	ND_PRINT((ndo, "\n\t actions 0x%08x", EXTRACT_BE_32BITS(cp)));
-	of10_bitmap_print(ndo, ofpat_bm, EXTRACT_BE_32BITS(cp), OFPAT_U);
+	ND_TCHECK_4(cp);
+	ND_PRINT("\n\t actions 0x%08x", GET_BE_U_4(cp));
+	of10_bitmap_print(ndo, ofpat_bm, GET_BE_U_4(cp), OFPAT_U);
 	cp += 4;
 	/* ports */
 	return of10_phy_ports_print(ndo, cp, ep, len - OF_SWITCH_FEATURES_LEN);
 
 trunc:
-	ND_PRINT((ndo, "%s", tstr));
+	nd_print_trunc(ndo);
 	return ep;
 }
 
@@ -1663,50 +1667,52 @@ of10_flow_mod_print(netdissect_options *ndo,
 	if (ep == (cp = of10_match_print(ndo, "\n\t ", cp, ep)))
 		return ep; /* end of snapshot */
 	/* cookie */
-	ND_TCHECK2(*cp, 8);
-	ND_PRINT((ndo, "\n\t cookie 0x%016" PRIx64, EXTRACT_BE_64BITS(cp)));
+	ND_TCHECK_8(cp);
+	ND_PRINT("\n\t cookie 0x%016" PRIx64, GET_BE_U_8(cp));
 	cp += 8;
 	/* command */
-	ND_TCHECK2(*cp, 2);
-	command = EXTRACT_BE_16BITS(cp);
-	ND_PRINT((ndo, ", command %s", tok2str(ofpfc_str, "invalid (0x%04x)", command)));
+	ND_TCHECK_2(cp);
+	command = GET_BE_U_2(cp);
+	ND_PRINT(", command %s", tok2str(ofpfc_str, "invalid (0x%04x)", command));
 	cp += 2;
 	/* idle_timeout */
-	ND_TCHECK2(*cp, 2);
-	if (EXTRACT_BE_16BITS(cp))
-		ND_PRINT((ndo, ", idle_timeout %u", EXTRACT_BE_16BITS(cp)));
+	ND_TCHECK_2(cp);
+	if (GET_BE_U_2(cp))
+		ND_PRINT(", idle_timeout %u", GET_BE_U_2(cp));
 	cp += 2;
 	/* hard_timeout */
-	ND_TCHECK2(*cp, 2);
-	if (EXTRACT_BE_16BITS(cp))
-		ND_PRINT((ndo, ", hard_timeout %u", EXTRACT_BE_16BITS(cp)));
+	ND_TCHECK_2(cp);
+	if (GET_BE_U_2(cp))
+		ND_PRINT(", hard_timeout %u", GET_BE_U_2(cp));
 	cp += 2;
 	/* priority */
-	ND_TCHECK2(*cp, 2);
-	if (EXTRACT_BE_16BITS(cp))
-		ND_PRINT((ndo, ", priority %u", EXTRACT_BE_16BITS(cp)));
+	ND_TCHECK_2(cp);
+	if (GET_BE_U_2(cp))
+		ND_PRINT(", priority %u", GET_BE_U_2(cp));
 	cp += 2;
 	/* buffer_id */
-	ND_TCHECK2(*cp, 4);
+	ND_TCHECK_4(cp);
 	if (command == OFPFC_ADD || command == OFPFC_MODIFY ||
 	    command == OFPFC_MODIFY_STRICT)
-		ND_PRINT((ndo, ", buffer_id %s", tok2str(bufferid_str, "0x%08x", EXTRACT_BE_32BITS(cp))));
+		ND_PRINT(", buffer_id %s",
+			 tok2str(bufferid_str, "0x%08x", GET_BE_U_4(cp)));
 	cp += 4;
 	/* out_port */
-	ND_TCHECK2(*cp, 2);
+	ND_TCHECK_2(cp);
 	if (command == OFPFC_DELETE || command == OFPFC_DELETE_STRICT)
-		ND_PRINT((ndo, ", out_port %s", tok2str(ofpp_str, "%u", EXTRACT_BE_16BITS(cp))));
+		ND_PRINT(", out_port %s",
+			 tok2str(ofpp_str, "%u", GET_BE_U_2(cp)));
 	cp += 2;
 	/* flags */
-	ND_TCHECK2(*cp, 2);
-	ND_PRINT((ndo, ", flags 0x%04x", EXTRACT_BE_16BITS(cp)));
-	of10_bitmap_print(ndo, ofpff_bm, EXTRACT_BE_16BITS(cp), OFPFF_U);
+	ND_TCHECK_2(cp);
+	ND_PRINT(", flags 0x%04x", GET_BE_U_2(cp));
+	of10_bitmap_print(ndo, ofpff_bm, GET_BE_U_2(cp), OFPFF_U);
 	cp += 2;
 	/* actions */
 	return of10_actions_print(ndo, "\n\t ", cp, ep, len - OF_FLOW_MOD_LEN);
 
 trunc:
-	ND_PRINT((ndo, "%s", tstr));
+	nd_print_trunc(ndo);
 	return ep;
 }
 
@@ -1716,34 +1722,34 @@ of10_port_mod_print(netdissect_options *ndo,
                     const u_char *cp, const u_char *ep)
 {
 	/* port_no */
-	ND_TCHECK2(*cp, 2);
-	ND_PRINT((ndo, "\n\t port_no %s", tok2str(ofpp_str, "%u", EXTRACT_BE_16BITS(cp))));
+	ND_TCHECK_2(cp);
+	ND_PRINT("\n\t port_no %s", tok2str(ofpp_str, "%u", GET_BE_U_2(cp)));
 	cp += 2;
 	/* hw_addr */
-	ND_TCHECK2(*cp, ETHER_ADDR_LEN);
-	ND_PRINT((ndo, ", hw_addr %s", etheraddr_string(ndo, cp)));
-	cp += ETHER_ADDR_LEN;
+	ND_TCHECK_LEN(cp, MAC_ADDR_LEN);
+	ND_PRINT(", hw_addr %s", etheraddr_string(ndo, cp));
+	cp += MAC_ADDR_LEN;
 	/* config */
-	ND_TCHECK2(*cp, 4);
-	ND_PRINT((ndo, "\n\t config 0x%08x", EXTRACT_BE_32BITS(cp)));
-	of10_bitmap_print(ndo, ofppc_bm, EXTRACT_BE_32BITS(cp), OFPPC_U);
+	ND_TCHECK_4(cp);
+	ND_PRINT("\n\t config 0x%08x", GET_BE_U_4(cp));
+	of10_bitmap_print(ndo, ofppc_bm, GET_BE_U_4(cp), OFPPC_U);
 	cp += 4;
 	/* mask */
-	ND_TCHECK2(*cp, 4);
-	ND_PRINT((ndo, "\n\t mask 0x%08x", EXTRACT_BE_32BITS(cp)));
-	of10_bitmap_print(ndo, ofppc_bm, EXTRACT_BE_32BITS(cp), OFPPC_U);
+	ND_TCHECK_4(cp);
+	ND_PRINT("\n\t mask 0x%08x", GET_BE_U_4(cp));
+	of10_bitmap_print(ndo, ofppc_bm, GET_BE_U_4(cp), OFPPC_U);
 	cp += 4;
 	/* advertise */
-	ND_TCHECK2(*cp, 4);
-	ND_PRINT((ndo, "\n\t advertise 0x%08x", EXTRACT_BE_32BITS(cp)));
-	of10_bitmap_print(ndo, ofppf_bm, EXTRACT_BE_32BITS(cp), OFPPF_U);
+	ND_TCHECK_4(cp);
+	ND_PRINT("\n\t advertise 0x%08x", GET_BE_U_4(cp));
+	of10_bitmap_print(ndo, ofppf_bm, GET_BE_U_4(cp), OFPPF_U);
 	cp += 4;
 	/* pad */
-	ND_TCHECK2(*cp, 4);
+	ND_TCHECK_4(cp);
 	return cp + 4;
 
 trunc:
-	ND_PRINT((ndo, "%s", tstr));
+	nd_print_trunc(ndo);
 	return ep;
 }
 
@@ -1757,15 +1763,15 @@ of10_stats_request_print(netdissect_options *ndo,
 	uint16_t type;
 
 	/* type */
-	ND_TCHECK2(*cp, 2);
-	type = EXTRACT_BE_16BITS(cp);
+	ND_TCHECK_2(cp);
+	type = GET_BE_U_2(cp);
 	cp += 2;
-	ND_PRINT((ndo, "\n\t type %s", tok2str(ofpst_str, "invalid (0x%04x)", type)));
+	ND_PRINT("\n\t type %s", tok2str(ofpst_str, "invalid (0x%04x)", type));
 	/* flags */
-	ND_TCHECK2(*cp, 2);
-	ND_PRINT((ndo, ", flags 0x%04x", EXTRACT_BE_16BITS(cp)));
-	if (EXTRACT_BE_16BITS(cp))
-		ND_PRINT((ndo, " (bogus)"));
+	ND_TCHECK_2(cp);
+	ND_PRINT(", flags 0x%04x", GET_BE_U_2(cp));
+	if (GET_BE_U_2(cp))
+		ND_PRINT(" (bogus)");
 	cp += 2;
 	/* type-specific body of one of fixed lengths */
 	len -= OF_STATS_REQUEST_LEN;
@@ -1783,39 +1789,44 @@ of10_stats_request_print(netdissect_options *ndo,
 		if (ep == (cp = of10_match_print(ndo, "\n\t ", cp, ep)))
 			return ep; /* end of snapshot */
 		/* table_id */
-		ND_TCHECK2(*cp, 1);
-		ND_PRINT((ndo, "\n\t table_id %s", tok2str(tableid_str, "%u", EXTRACT_8BITS(cp))));
+		ND_TCHECK_1(cp);
+		ND_PRINT("\n\t table_id %s",
+			 tok2str(tableid_str, "%u", GET_U_1(cp)));
 		cp += 1;
 		/* pad */
-		ND_TCHECK2(*cp, 1);
+		ND_TCHECK_1(cp);
 		cp += 1;
 		/* out_port */
-		ND_TCHECK2(*cp, 2);
-		ND_PRINT((ndo, ", out_port %s", tok2str(ofpp_str, "%u", EXTRACT_BE_16BITS(cp))));
+		ND_TCHECK_2(cp);
+		ND_PRINT(", out_port %s",
+			 tok2str(ofpp_str, "%u", GET_BE_U_2(cp)));
 		return cp + 2;
 	case OFPST_PORT:
 		if (len != OF_PORT_STATS_REQUEST_LEN)
 			goto invalid;
 		/* port_no */
-		ND_TCHECK2(*cp, 2);
-		ND_PRINT((ndo, "\n\t port_no %s", tok2str(ofpp_str, "%u", EXTRACT_BE_16BITS(cp))));
+		ND_TCHECK_2(cp);
+		ND_PRINT("\n\t port_no %s",
+			 tok2str(ofpp_str, "%u", GET_BE_U_2(cp)));
 		cp += 2;
 		/* pad */
-		ND_TCHECK2(*cp, 6);
+		ND_TCHECK_6(cp);
 		return cp + 6;
 	case OFPST_QUEUE:
 		if (len != OF_QUEUE_STATS_REQUEST_LEN)
 			goto invalid;
 		/* port_no */
-		ND_TCHECK2(*cp, 2);
-		ND_PRINT((ndo, "\n\t port_no %s", tok2str(ofpp_str, "%u", EXTRACT_BE_16BITS(cp))));
+		ND_TCHECK_2(cp);
+		ND_PRINT("\n\t port_no %s",
+			 tok2str(ofpp_str, "%u", GET_BE_U_2(cp)));
 		cp += 2;
 		/* pad */
-		ND_TCHECK2(*cp, 2);
+		ND_TCHECK_2(cp);
 		cp += 2;
 		/* queue_id */
-		ND_TCHECK2(*cp, 4);
-		ND_PRINT((ndo, ", queue_id %s", tok2str(ofpq_str, "%u", EXTRACT_BE_32BITS(cp))));
+		ND_TCHECK_4(cp);
+		ND_PRINT(", queue_id %s",
+			 tok2str(ofpq_str, "%u", GET_BE_U_4(cp)));
 		return cp + 4;
 	case OFPST_VENDOR:
 		return of10_vendor_data_print(ndo, cp, ep, len);
@@ -1823,11 +1834,11 @@ of10_stats_request_print(netdissect_options *ndo,
 	return cp;
 
 invalid: /* skip the message body */
-	ND_PRINT((ndo, "%s", istr));
-	ND_TCHECK2(*cp0, len0);
+	nd_print_invalid(ndo);
+	ND_TCHECK_LEN(cp0, len0);
 	return cp0 + len0;
 trunc:
-	ND_PRINT((ndo, "%s", tstr));
+	nd_print_trunc(ndo);
 	return ep;
 }
 
@@ -1839,42 +1850,42 @@ of10_desc_stats_reply_print(netdissect_options *ndo,
 	if (len != OF_DESC_STATS_LEN)
 		goto invalid;
 	/* mfr_desc */
-	ND_TCHECK2(*cp, DESC_STR_LEN);
-	ND_PRINT((ndo, "\n\t  mfr_desc '"));
-	fn_print(ndo, cp, cp + DESC_STR_LEN);
-	ND_PRINT((ndo, "'"));
+	ND_TCHECK_LEN(cp, DESC_STR_LEN);
+	ND_PRINT("\n\t  mfr_desc '");
+	nd_print(ndo, cp, cp + DESC_STR_LEN);
+	ND_PRINT("'");
 	cp += DESC_STR_LEN;
 	/* hw_desc */
-	ND_TCHECK2(*cp, DESC_STR_LEN);
-	ND_PRINT((ndo, "\n\t  hw_desc '"));
-	fn_print(ndo, cp, cp + DESC_STR_LEN);
-	ND_PRINT((ndo, "'"));
+	ND_TCHECK_LEN(cp, DESC_STR_LEN);
+	ND_PRINT("\n\t  hw_desc '");
+	nd_print(ndo, cp, cp + DESC_STR_LEN);
+	ND_PRINT("'");
 	cp += DESC_STR_LEN;
 	/* sw_desc */
-	ND_TCHECK2(*cp, DESC_STR_LEN);
-	ND_PRINT((ndo, "\n\t  sw_desc '"));
-	fn_print(ndo, cp, cp + DESC_STR_LEN);
-	ND_PRINT((ndo, "'"));
+	ND_TCHECK_LEN(cp, DESC_STR_LEN);
+	ND_PRINT("\n\t  sw_desc '");
+	nd_print(ndo, cp, cp + DESC_STR_LEN);
+	ND_PRINT("'");
 	cp += DESC_STR_LEN;
 	/* serial_num */
-	ND_TCHECK2(*cp, SERIAL_NUM_LEN);
-	ND_PRINT((ndo, "\n\t  serial_num '"));
-	fn_print(ndo, cp, cp + SERIAL_NUM_LEN);
-	ND_PRINT((ndo, "'"));
+	ND_TCHECK_LEN(cp, SERIAL_NUM_LEN);
+	ND_PRINT("\n\t  serial_num '");
+	nd_print(ndo, cp, cp + SERIAL_NUM_LEN);
+	ND_PRINT("'");
 	cp += SERIAL_NUM_LEN;
 	/* dp_desc */
-	ND_TCHECK2(*cp, DESC_STR_LEN);
-	ND_PRINT((ndo, "\n\t  dp_desc '"));
-	fn_print(ndo, cp, cp + DESC_STR_LEN);
-	ND_PRINT((ndo, "'"));
+	ND_TCHECK_LEN(cp, DESC_STR_LEN);
+	ND_PRINT("\n\t  dp_desc '");
+	nd_print(ndo, cp, cp + DESC_STR_LEN);
+	ND_PRINT("'");
 	return cp + DESC_STR_LEN;
 
 invalid: /* skip the message body */
-	ND_PRINT((ndo, "%s", istr));
-	ND_TCHECK2(*cp, len);
+	nd_print_invalid(ndo);
+	ND_TCHECK_LEN(cp, len);
 	return cp + len;
 trunc:
-	ND_PRINT((ndo, "%s", tstr));
+	nd_print_trunc(ndo);
 	return ep;
 }
 
@@ -1891,56 +1902,57 @@ of10_flow_stats_reply_print(netdissect_options *ndo,
 		if (len < OF_FLOW_STATS_LEN)
 			goto invalid;
 		/* length */
-		ND_TCHECK2(*cp, 2);
-		entry_len = EXTRACT_BE_16BITS(cp);
-		ND_PRINT((ndo, "\n\t length %u", entry_len));
+		ND_TCHECK_2(cp);
+		entry_len = GET_BE_U_2(cp);
+		ND_PRINT("\n\t length %u", entry_len);
 		if (entry_len < OF_FLOW_STATS_LEN || entry_len > len)
 			goto invalid;
 		cp += 2;
 		/* table_id */
-		ND_TCHECK2(*cp, 1);
-		ND_PRINT((ndo, ", table_id %s", tok2str(tableid_str, "%u", EXTRACT_8BITS(cp))));
+		ND_TCHECK_1(cp);
+		ND_PRINT(", table_id %s",
+			 tok2str(tableid_str, "%u", GET_U_1(cp)));
 		cp += 1;
 		/* pad */
-		ND_TCHECK2(*cp, 1);
+		ND_TCHECK_1(cp);
 		cp += 1;
 		/* match */
 		if (ep == (cp = of10_match_print(ndo, "\n\t  ", cp, ep)))
 			return ep; /* end of snapshot */
 		/* duration_sec */
-		ND_TCHECK2(*cp, 4);
-		ND_PRINT((ndo, "\n\t  duration_sec %u", EXTRACT_BE_32BITS(cp)));
+		ND_TCHECK_4(cp);
+		ND_PRINT("\n\t  duration_sec %u", GET_BE_U_4(cp));
 		cp += 4;
 		/* duration_nsec */
-		ND_TCHECK2(*cp, 4);
-		ND_PRINT((ndo, ", duration_nsec %u", EXTRACT_BE_32BITS(cp)));
+		ND_TCHECK_4(cp);
+		ND_PRINT(", duration_nsec %u", GET_BE_U_4(cp));
 		cp += 4;
 		/* priority */
-		ND_TCHECK2(*cp, 2);
-		ND_PRINT((ndo, ", priority %u", EXTRACT_BE_16BITS(cp)));
+		ND_TCHECK_2(cp);
+		ND_PRINT(", priority %u", GET_BE_U_2(cp));
 		cp += 2;
 		/* idle_timeout */
-		ND_TCHECK2(*cp, 2);
-		ND_PRINT((ndo, ", idle_timeout %u", EXTRACT_BE_16BITS(cp)));
+		ND_TCHECK_2(cp);
+		ND_PRINT(", idle_timeout %u", GET_BE_U_2(cp));
 		cp += 2;
 		/* hard_timeout */
-		ND_TCHECK2(*cp, 2);
-		ND_PRINT((ndo, ", hard_timeout %u", EXTRACT_BE_16BITS(cp)));
+		ND_TCHECK_2(cp);
+		ND_PRINT(", hard_timeout %u", GET_BE_U_2(cp));
 		cp += 2;
 		/* pad2 */
-		ND_TCHECK2(*cp, 6);
+		ND_TCHECK_6(cp);
 		cp += 6;
 		/* cookie */
-		ND_TCHECK2(*cp, 8);
-		ND_PRINT((ndo, ", cookie 0x%016" PRIx64, EXTRACT_BE_64BITS(cp)));
+		ND_TCHECK_8(cp);
+		ND_PRINT(", cookie 0x%016" PRIx64, GET_BE_U_8(cp));
 		cp += 8;
 		/* packet_count */
-		ND_TCHECK2(*cp, 8);
-		ND_PRINT((ndo, ", packet_count %" PRIu64, EXTRACT_BE_64BITS(cp)));
+		ND_TCHECK_8(cp);
+		ND_PRINT(", packet_count %" PRIu64, GET_BE_U_8(cp));
 		cp += 8;
 		/* byte_count */
-		ND_TCHECK2(*cp, 8);
-		ND_PRINT((ndo, ", byte_count %" PRIu64, EXTRACT_BE_64BITS(cp)));
+		ND_TCHECK_8(cp);
+		ND_PRINT(", byte_count %" PRIu64, GET_BE_U_8(cp));
 		cp += 8;
 		/* actions */
 		if (ep == (cp = of10_actions_print(ndo, "\n\t  ", cp, ep, entry_len - OF_FLOW_STATS_LEN)))
@@ -1951,11 +1963,11 @@ of10_flow_stats_reply_print(netdissect_options *ndo,
 	return cp;
 
 invalid: /* skip the rest of flow statistics entries */
-	ND_PRINT((ndo, "%s", istr));
-	ND_TCHECK2(*cp0, len0);
+	nd_print_invalid(ndo);
+	ND_TCHECK_LEN(cp0, len0);
 	return cp0 + len0;
 trunc:
-	ND_PRINT((ndo, "%s", tstr));
+	nd_print_trunc(ndo);
 	return ep;
 }
 
@@ -1968,27 +1980,27 @@ of10_aggregate_stats_reply_print(netdissect_options *ndo,
 	if (len != OF_AGGREGATE_STATS_REPLY_LEN)
 		goto invalid;
 	/* packet_count */
-	ND_TCHECK2(*cp, 8);
-	ND_PRINT((ndo, "\n\t packet_count %" PRIu64, EXTRACT_BE_64BITS(cp)));
+	ND_TCHECK_8(cp);
+	ND_PRINT("\n\t packet_count %" PRIu64, GET_BE_U_8(cp));
 	cp += 8;
 	/* byte_count */
-	ND_TCHECK2(*cp, 8);
-	ND_PRINT((ndo, ", byte_count %" PRIu64, EXTRACT_BE_64BITS(cp)));
+	ND_TCHECK_8(cp);
+	ND_PRINT(", byte_count %" PRIu64, GET_BE_U_8(cp));
 	cp += 8;
 	/* flow_count */
-	ND_TCHECK2(*cp, 4);
-	ND_PRINT((ndo, ", flow_count %u", EXTRACT_BE_32BITS(cp)));
+	ND_TCHECK_4(cp);
+	ND_PRINT(", flow_count %u", GET_BE_U_4(cp));
 	cp += 4;
 	/* pad */
-	ND_TCHECK2(*cp, 4);
+	ND_TCHECK_4(cp);
 	return cp + 4;
 
 invalid: /* skip the message body */
-	ND_PRINT((ndo, "%s", istr));
-	ND_TCHECK2(*cp, len);
+	nd_print_invalid(ndo);
+	ND_TCHECK_LEN(cp, len);
 	return cp + len;
 trunc:
-	ND_PRINT((ndo, "%s", tstr));
+	nd_print_trunc(ndo);
 	return ep;
 }
 
@@ -2004,39 +2016,40 @@ of10_table_stats_reply_print(netdissect_options *ndo,
 		if (len < OF_TABLE_STATS_LEN)
 			goto invalid;
 		/* table_id */
-		ND_TCHECK2(*cp, 1);
-		ND_PRINT((ndo, "\n\t table_id %s", tok2str(tableid_str, "%u", EXTRACT_8BITS(cp))));
+		ND_TCHECK_1(cp);
+		ND_PRINT("\n\t table_id %s",
+			 tok2str(tableid_str, "%u", GET_U_1(cp)));
 		cp += 1;
 		/* pad */
-		ND_TCHECK2(*cp, 3);
+		ND_TCHECK_3(cp);
 		cp += 3;
 		/* name */
-		ND_TCHECK2(*cp, OFP_MAX_TABLE_NAME_LEN);
-		ND_PRINT((ndo, ", name '"));
-		fn_print(ndo, cp, cp + OFP_MAX_TABLE_NAME_LEN);
-		ND_PRINT((ndo, "'"));
+		ND_TCHECK_LEN(cp, OFP_MAX_TABLE_NAME_LEN);
+		ND_PRINT(", name '");
+		nd_print(ndo, cp, cp + OFP_MAX_TABLE_NAME_LEN);
+		ND_PRINT("'");
 		cp += OFP_MAX_TABLE_NAME_LEN;
 		/* wildcards */
-		ND_TCHECK2(*cp, 4);
-		ND_PRINT((ndo, "\n\t  wildcards 0x%08x", EXTRACT_BE_32BITS(cp)));
-		of10_bitmap_print(ndo, ofpfw_bm, EXTRACT_BE_32BITS(cp),
+		ND_TCHECK_4(cp);
+		ND_PRINT("\n\t  wildcards 0x%08x", GET_BE_U_4(cp));
+		of10_bitmap_print(ndo, ofpfw_bm, GET_BE_U_4(cp),
 				  OFPFW_U);
 		cp += 4;
 		/* max_entries */
-		ND_TCHECK2(*cp, 4);
-		ND_PRINT((ndo, "\n\t  max_entries %u", EXTRACT_BE_32BITS(cp)));
+		ND_TCHECK_4(cp);
+		ND_PRINT("\n\t  max_entries %u", GET_BE_U_4(cp));
 		cp += 4;
 		/* active_count */
-		ND_TCHECK2(*cp, 4);
-		ND_PRINT((ndo, ", active_count %u", EXTRACT_BE_32BITS(cp)));
+		ND_TCHECK_4(cp);
+		ND_PRINT(", active_count %u", GET_BE_U_4(cp));
 		cp += 4;
 		/* lookup_count */
-		ND_TCHECK2(*cp, 8);
-		ND_PRINT((ndo, ", lookup_count %" PRIu64, EXTRACT_BE_64BITS(cp)));
+		ND_TCHECK_8(cp);
+		ND_PRINT(", lookup_count %" PRIu64, GET_BE_U_8(cp));
 		cp += 8;
 		/* matched_count */
-		ND_TCHECK2(*cp, 8);
-		ND_PRINT((ndo, ", matched_count %" PRIu64, EXTRACT_BE_64BITS(cp)));
+		ND_TCHECK_8(cp);
+		ND_PRINT(", matched_count %" PRIu64, GET_BE_U_8(cp));
 		cp += 8;
 
 		len -= OF_TABLE_STATS_LEN;
@@ -2044,11 +2057,11 @@ of10_table_stats_reply_print(netdissect_options *ndo,
 	return cp;
 
 invalid: /* skip the undersized trailing data */
-	ND_PRINT((ndo, "%s", istr));
-	ND_TCHECK2(*cp0, len0);
+	nd_print_invalid(ndo);
+	ND_TCHECK_LEN(cp0, len0);
 	return cp0 + len0;
 trunc:
-	ND_PRINT((ndo, "%s", tstr));
+	nd_print_trunc(ndo);
 	return ep;
 }
 
@@ -2064,64 +2077,65 @@ of10_port_stats_reply_print(netdissect_options *ndo,
 		if (len < OF_PORT_STATS_LEN)
 			goto invalid;
 		/* port_no */
-		ND_TCHECK2(*cp, 2);
-		ND_PRINT((ndo, "\n\t  port_no %s", tok2str(ofpp_str, "%u", EXTRACT_BE_16BITS(cp))));
+		ND_TCHECK_2(cp);
+		ND_PRINT("\n\t  port_no %s",
+			 tok2str(ofpp_str, "%u", GET_BE_U_2(cp)));
 		cp += 2;
 		if (ndo->ndo_vflag < 2) {
-			ND_TCHECK2(*cp, OF_PORT_STATS_LEN - 2);
+			ND_TCHECK_LEN(cp, OF_PORT_STATS_LEN - 2);
 			cp += OF_PORT_STATS_LEN - 2;
 			goto next_port;
 		}
 		/* pad */
-		ND_TCHECK2(*cp, 6);
+		ND_TCHECK_6(cp);
 		cp += 6;
 		/* rx_packets */
-		ND_TCHECK2(*cp, 8);
-		ND_PRINT((ndo, ", rx_packets %" PRIu64, EXTRACT_BE_64BITS(cp)));
+		ND_TCHECK_8(cp);
+		ND_PRINT(", rx_packets %" PRIu64, GET_BE_U_8(cp));
 		cp += 8;
 		/* tx_packets */
-		ND_TCHECK2(*cp, 8);
-		ND_PRINT((ndo, ", tx_packets %" PRIu64, EXTRACT_BE_64BITS(cp)));
+		ND_TCHECK_8(cp);
+		ND_PRINT(", tx_packets %" PRIu64, GET_BE_U_8(cp));
 		cp += 8;
 		/* rx_bytes */
-		ND_TCHECK2(*cp, 8);
-		ND_PRINT((ndo, ", rx_bytes %" PRIu64, EXTRACT_BE_64BITS(cp)));
+		ND_TCHECK_8(cp);
+		ND_PRINT(", rx_bytes %" PRIu64, GET_BE_U_8(cp));
 		cp += 8;
 		/* tx_bytes */
-		ND_TCHECK2(*cp, 8);
-		ND_PRINT((ndo, ", tx_bytes %" PRIu64, EXTRACT_BE_64BITS(cp)));
+		ND_TCHECK_8(cp);
+		ND_PRINT(", tx_bytes %" PRIu64, GET_BE_U_8(cp));
 		cp += 8;
 		/* rx_dropped */
-		ND_TCHECK2(*cp, 8);
-		ND_PRINT((ndo, ", rx_dropped %" PRIu64, EXTRACT_BE_64BITS(cp)));
+		ND_TCHECK_8(cp);
+		ND_PRINT(", rx_dropped %" PRIu64, GET_BE_U_8(cp));
 		cp += 8;
 		/* tx_dropped */
-		ND_TCHECK2(*cp, 8);
-		ND_PRINT((ndo, ", tx_dropped %" PRIu64, EXTRACT_BE_64BITS(cp)));
+		ND_TCHECK_8(cp);
+		ND_PRINT(", tx_dropped %" PRIu64, GET_BE_U_8(cp));
 		cp += 8;
 		/* rx_errors */
-		ND_TCHECK2(*cp, 8);
-		ND_PRINT((ndo, ", rx_errors %" PRIu64, EXTRACT_BE_64BITS(cp)));
+		ND_TCHECK_8(cp);
+		ND_PRINT(", rx_errors %" PRIu64, GET_BE_U_8(cp));
 		cp += 8;
 		/* tx_errors */
-		ND_TCHECK2(*cp, 8);
-		ND_PRINT((ndo, ", tx_errors %" PRIu64, EXTRACT_BE_64BITS(cp)));
+		ND_TCHECK_8(cp);
+		ND_PRINT(", tx_errors %" PRIu64, GET_BE_U_8(cp));
 		cp += 8;
 		/* rx_frame_err */
-		ND_TCHECK2(*cp, 8);
-		ND_PRINT((ndo, ", rx_frame_err %" PRIu64, EXTRACT_BE_64BITS(cp)));
+		ND_TCHECK_8(cp);
+		ND_PRINT(", rx_frame_err %" PRIu64, GET_BE_U_8(cp));
 		cp += 8;
 		/* rx_over_err */
-		ND_TCHECK2(*cp, 8);
-		ND_PRINT((ndo, ", rx_over_err %" PRIu64, EXTRACT_BE_64BITS(cp)));
+		ND_TCHECK_8(cp);
+		ND_PRINT(", rx_over_err %" PRIu64, GET_BE_U_8(cp));
 		cp += 8;
 		/* rx_crc_err */
-		ND_TCHECK2(*cp, 8);
-		ND_PRINT((ndo, ", rx_crc_err %" PRIu64, EXTRACT_BE_64BITS(cp)));
+		ND_TCHECK_8(cp);
+		ND_PRINT(", rx_crc_err %" PRIu64, GET_BE_U_8(cp));
 		cp += 8;
 		/* collisions */
-		ND_TCHECK2(*cp, 8);
-		ND_PRINT((ndo, ", collisions %" PRIu64, EXTRACT_BE_64BITS(cp)));
+		ND_TCHECK_8(cp);
+		ND_PRINT(", collisions %" PRIu64, GET_BE_U_8(cp));
 		cp += 8;
 next_port:
 		len -= OF_PORT_STATS_LEN;
@@ -2129,11 +2143,11 @@ next_port:
 	return cp;
 
 invalid: /* skip the undersized trailing data */
-	ND_PRINT((ndo, "%s", istr));
-	ND_TCHECK2(*cp0, len0);
+	nd_print_invalid(ndo);
+	ND_TCHECK_LEN(cp0, len0);
 	return cp0 + len0;
 trunc:
-	ND_PRINT((ndo, "%s", tstr));
+	nd_print_trunc(ndo);
 	return ep;
 }
 
@@ -2149,27 +2163,28 @@ of10_queue_stats_reply_print(netdissect_options *ndo,
 		if (len < OF_QUEUE_STATS_LEN)
 			goto invalid;
 		/* port_no */
-		ND_TCHECK2(*cp, 2);
-		ND_PRINT((ndo, "\n\t  port_no %s", tok2str(ofpp_str, "%u", EXTRACT_BE_16BITS(cp))));
+		ND_TCHECK_2(cp);
+		ND_PRINT("\n\t  port_no %s",
+			 tok2str(ofpp_str, "%u", GET_BE_U_2(cp)));
 		cp += 2;
 		/* pad */
-		ND_TCHECK2(*cp, 2);
+		ND_TCHECK_2(cp);
 		cp += 2;
 		/* queue_id */
-		ND_TCHECK2(*cp, 4);
-		ND_PRINT((ndo, ", queue_id %u", EXTRACT_BE_32BITS(cp)));
+		ND_TCHECK_4(cp);
+		ND_PRINT(", queue_id %u", GET_BE_U_4(cp));
 		cp += 4;
 		/* tx_bytes */
-		ND_TCHECK2(*cp, 8);
-		ND_PRINT((ndo, ", tx_bytes %" PRIu64, EXTRACT_BE_64BITS(cp)));
+		ND_TCHECK_8(cp);
+		ND_PRINT(", tx_bytes %" PRIu64, GET_BE_U_8(cp));
 		cp += 8;
 		/* tx_packets */
-		ND_TCHECK2(*cp, 8);
-		ND_PRINT((ndo, ", tx_packets %" PRIu64, EXTRACT_BE_64BITS(cp)));
+		ND_TCHECK_8(cp);
+		ND_PRINT(", tx_packets %" PRIu64, GET_BE_U_8(cp));
 		cp += 8;
 		/* tx_errors */
-		ND_TCHECK2(*cp, 8);
-		ND_PRINT((ndo, ", tx_errors %" PRIu64, EXTRACT_BE_64BITS(cp)));
+		ND_TCHECK_8(cp);
+		ND_PRINT(", tx_errors %" PRIu64, GET_BE_U_8(cp));
 		cp += 8;
 
 		len -= OF_QUEUE_STATS_LEN;
@@ -2177,11 +2192,11 @@ of10_queue_stats_reply_print(netdissect_options *ndo,
 	return cp;
 
 invalid: /* skip the undersized trailing data */
-	ND_PRINT((ndo, "%s", istr));
-	ND_TCHECK2(*cp0, len0);
+	nd_print_invalid(ndo);
+	ND_TCHECK_LEN(cp0, len0);
 	return cp0 + len0;
 trunc:
-	ND_PRINT((ndo, "%s", tstr));
+	nd_print_trunc(ndo);
 	return ep;
 }
 
@@ -2194,14 +2209,14 @@ of10_stats_reply_print(netdissect_options *ndo,
 	uint16_t type;
 
 	/* type */
-	ND_TCHECK2(*cp, 2);
-	type = EXTRACT_BE_16BITS(cp);
-	ND_PRINT((ndo, "\n\t type %s", tok2str(ofpst_str, "invalid (0x%04x)", type)));
+	ND_TCHECK_2(cp);
+	type = GET_BE_U_2(cp);
+	ND_PRINT("\n\t type %s", tok2str(ofpst_str, "invalid (0x%04x)", type));
 	cp += 2;
 	/* flags */
-	ND_TCHECK2(*cp, 2);
-	ND_PRINT((ndo, ", flags 0x%04x", EXTRACT_BE_16BITS(cp)));
-	of10_bitmap_print(ndo, ofpsf_reply_bm, EXTRACT_BE_16BITS(cp),
+	ND_TCHECK_2(cp);
+	ND_PRINT(", flags 0x%04x", GET_BE_U_2(cp));
+	of10_bitmap_print(ndo, ofpsf_reply_bm, GET_BE_U_2(cp),
 			  OFPSF_REPLY_U);
 	cp += 2;
 
@@ -2218,11 +2233,11 @@ of10_stats_reply_print(netdissect_options *ndo,
 		if (decoder != NULL)
 			return decoder(ndo, cp, ep, len - OF_STATS_REPLY_LEN);
 	}
-	ND_TCHECK2(*cp0, len);
+	ND_TCHECK_LEN(cp0, len);
 	return cp0 + len;
 
 trunc:
-	ND_PRINT((ndo, "%s", tstr));
+	nd_print_trunc(ndo);
 	return ep;
 }
 
@@ -2236,16 +2251,16 @@ of10_packet_out_print(netdissect_options *ndo,
 	uint16_t actions_len;
 
 	/* buffer_id */
-	ND_TCHECK2(*cp, 4);
-	ND_PRINT((ndo, "\n\t buffer_id 0x%08x", EXTRACT_BE_32BITS(cp)));
+	ND_TCHECK_4(cp);
+	ND_PRINT("\n\t buffer_id 0x%08x", GET_BE_U_4(cp));
 	cp += 4;
 	/* in_port */
-	ND_TCHECK2(*cp, 2);
-	ND_PRINT((ndo, ", in_port %s", tok2str(ofpp_str, "%u", EXTRACT_BE_16BITS(cp))));
+	ND_TCHECK_2(cp);
+	ND_PRINT(", in_port %s", tok2str(ofpp_str, "%u", GET_BE_U_2(cp)));
 	cp += 2;
 	/* actions_len */
-	ND_TCHECK2(*cp, 2);
-	actions_len = EXTRACT_BE_16BITS(cp);
+	ND_TCHECK_2(cp);
+	actions_len = GET_BE_U_2(cp);
 	cp += 2;
 	if (actions_len > len - OF_PACKET_OUT_LEN)
 		goto invalid;
@@ -2256,11 +2271,11 @@ of10_packet_out_print(netdissect_options *ndo,
 	return of10_packet_data_print(ndo, cp, ep, len - OF_PACKET_OUT_LEN - actions_len);
 
 invalid: /* skip the rest of the message body */
-	ND_PRINT((ndo, "%s", istr));
-	ND_TCHECK2(*cp0, len0);
+	nd_print_invalid(ndo);
+	ND_TCHECK_LEN(cp0, len0);
 	return cp0 + len0;
 trunc:
-	ND_PRINT((ndo, "%s", tstr));
+	nd_print_trunc(ndo);
 	return ep;
 }
 
@@ -2270,30 +2285,32 @@ of10_packet_in_print(netdissect_options *ndo,
                      const u_char *cp, const u_char *ep, const u_int len)
 {
 	/* buffer_id */
-	ND_TCHECK2(*cp, 4);
-	ND_PRINT((ndo, "\n\t buffer_id %s", tok2str(bufferid_str, "0x%08x", EXTRACT_BE_32BITS(cp))));
+	ND_TCHECK_4(cp);
+	ND_PRINT("\n\t buffer_id %s",
+		 tok2str(bufferid_str, "0x%08x", GET_BE_U_4(cp)));
 	cp += 4;
 	/* total_len */
-	ND_TCHECK2(*cp, 2);
-	ND_PRINT((ndo, ", total_len %u", EXTRACT_BE_16BITS(cp)));
+	ND_TCHECK_2(cp);
+	ND_PRINT(", total_len %u", GET_BE_U_2(cp));
 	cp += 2;
 	/* in_port */
-	ND_TCHECK2(*cp, 2);
-	ND_PRINT((ndo, ", in_port %s", tok2str(ofpp_str, "%u", EXTRACT_BE_16BITS(cp))));
+	ND_TCHECK_2(cp);
+	ND_PRINT(", in_port %s", tok2str(ofpp_str, "%u", GET_BE_U_2(cp)));
 	cp += 2;
 	/* reason */
-	ND_TCHECK2(*cp, 1);
-	ND_PRINT((ndo, ", reason %s", tok2str(ofpr_str, "invalid (0x%02x)", EXTRACT_8BITS(cp))));
+	ND_TCHECK_1(cp);
+	ND_PRINT(", reason %s",
+		 tok2str(ofpr_str, "invalid (0x%02x)", GET_U_1(cp)));
 	cp += 1;
 	/* pad */
-	ND_TCHECK2(*cp, 1);
+	ND_TCHECK_1(cp);
 	cp += 1;
 	/* data */
 	/* 2 mock octets count in OF_PACKET_IN_LEN but not in len */
 	return of10_packet_data_print(ndo, cp, ep, len - (OF_PACKET_IN_LEN - 2));
 
 trunc:
-	ND_PRINT((ndo, "%s", tstr));
+	nd_print_trunc(ndo);
 	return ep;
 }
 
@@ -2306,48 +2323,49 @@ of10_flow_removed_print(netdissect_options *ndo,
 	if (ep == (cp = of10_match_print(ndo, "\n\t ", cp, ep)))
 		return ep; /* end of snapshot */
 	/* cookie */
-	ND_TCHECK2(*cp, 8);
-	ND_PRINT((ndo, "\n\t cookie 0x%016" PRIx64, EXTRACT_BE_64BITS(cp)));
+	ND_TCHECK_8(cp);
+	ND_PRINT("\n\t cookie 0x%016" PRIx64, GET_BE_U_8(cp));
 	cp += 8;
 	/* priority */
-	ND_TCHECK2(*cp, 2);
-	if (EXTRACT_BE_16BITS(cp))
-		ND_PRINT((ndo, ", priority %u", EXTRACT_BE_16BITS(cp)));
+	ND_TCHECK_2(cp);
+	if (GET_BE_U_2(cp))
+		ND_PRINT(", priority %u", GET_BE_U_2(cp));
 	cp += 2;
 	/* reason */
-	ND_TCHECK2(*cp, 1);
-	ND_PRINT((ndo, ", reason %s", tok2str(ofprr_str, "unknown (0x%02x)", EXTRACT_8BITS(cp))));
+	ND_TCHECK_1(cp);
+	ND_PRINT(", reason %s",
+		 tok2str(ofprr_str, "unknown (0x%02x)", GET_U_1(cp)));
 	cp += 1;
 	/* pad */
-	ND_TCHECK2(*cp, 1);
+	ND_TCHECK_1(cp);
 	cp += 1;
 	/* duration_sec */
-	ND_TCHECK2(*cp, 4);
-	ND_PRINT((ndo, ", duration_sec %u", EXTRACT_BE_32BITS(cp)));
+	ND_TCHECK_4(cp);
+	ND_PRINT(", duration_sec %u", GET_BE_U_4(cp));
 	cp += 4;
 	/* duration_nsec */
-	ND_TCHECK2(*cp, 4);
-	ND_PRINT((ndo, ", duration_nsec %u", EXTRACT_BE_32BITS(cp)));
+	ND_TCHECK_4(cp);
+	ND_PRINT(", duration_nsec %u", GET_BE_U_4(cp));
 	cp += 4;
 	/* idle_timeout */
-	ND_TCHECK2(*cp, 2);
-	if (EXTRACT_BE_16BITS(cp))
-		ND_PRINT((ndo, ", idle_timeout %u", EXTRACT_BE_16BITS(cp)));
+	ND_TCHECK_2(cp);
+	if (GET_BE_U_2(cp))
+		ND_PRINT(", idle_timeout %u", GET_BE_U_2(cp));
 	cp += 2;
 	/* pad2 */
-	ND_TCHECK2(*cp, 2);
+	ND_TCHECK_2(cp);
 	cp += 2;
 	/* packet_count */
-	ND_TCHECK2(*cp, 8);
-	ND_PRINT((ndo, ", packet_count %" PRIu64, EXTRACT_BE_64BITS(cp)));
+	ND_TCHECK_8(cp);
+	ND_PRINT(", packet_count %" PRIu64, GET_BE_U_8(cp));
 	cp += 8;
 	/* byte_count */
-	ND_TCHECK2(*cp, 8);
-	ND_PRINT((ndo, ", byte_count %" PRIu64, EXTRACT_BE_64BITS(cp)));
+	ND_TCHECK_8(cp);
+	ND_PRINT(", byte_count %" PRIu64, GET_BE_U_8(cp));
 	return cp + 8;
 
 trunc:
-	ND_PRINT((ndo, "%s", tstr));
+	nd_print_trunc(ndo);
 	return ep;
 }
 
@@ -2360,12 +2378,12 @@ of10_error_print(netdissect_options *ndo,
 	const struct tok *code_str;
 
 	/* type */
-	ND_TCHECK2(*cp, 2);
-	type = EXTRACT_BE_16BITS(cp);
+	ND_TCHECK_2(cp);
+	type = GET_BE_U_2(cp);
 	cp += 2;
-	ND_PRINT((ndo, "\n\t type %s", tok2str(ofpet_str, "invalid (0x%04x)", type)));
+	ND_PRINT("\n\t type %s", tok2str(ofpet_str, "invalid (0x%04x)", type));
 	/* code */
-	ND_TCHECK2(*cp, 2);
+	ND_TCHECK_2(cp);
 	code_str =
 		type == OFPET_HELLO_FAILED    ? ofphfc_str  :
 		type == OFPET_BAD_REQUEST     ? ofpbrc_str  :
@@ -2374,13 +2392,14 @@ of10_error_print(netdissect_options *ndo,
 		type == OFPET_PORT_MOD_FAILED ? ofppmfc_str :
 		type == OFPET_QUEUE_OP_FAILED ? ofpqofc_str :
 		empty_str;
-	ND_PRINT((ndo, ", code %s", tok2str(code_str, "invalid (0x%04x)", EXTRACT_BE_16BITS(cp))));
+	ND_PRINT(", code %s",
+		 tok2str(code_str, "invalid (0x%04x)", GET_BE_U_2(cp)));
 	cp += 2;
 	/* data */
 	return of10_data_print(ndo, cp, ep, len - OF_ERROR_MSG_LEN);
 
 trunc:
-	ND_PRINT((ndo, "%s", tstr));
+	nd_print_trunc(ndo);
 	return ep;
 }
 
@@ -2399,8 +2418,8 @@ of10_header_body_print(netdissect_options *ndo,
 	 * invalid, proceed to the next message. */
 
 	/* [OF10] Section 5.1 */
-	ND_PRINT((ndo, "\n\tversion 1.0, type %s, length %u, xid 0x%08x",
-	       tok2str(ofpt_str, "invalid (0x%02x)", type), len, xid));
+	ND_PRINT("\n\tversion 1.0, type %s, length %u, xid 0x%08x",
+	       tok2str(ofpt_str, "invalid (0x%02x)", type), len, xid);
 	switch (type) {
 	/* OpenFlow header only. */
 	case OFPT_FEATURES_REQUEST: /* [OF10] Section 5.3.1 */
@@ -2419,12 +2438,13 @@ of10_header_body_print(netdissect_options *ndo,
 		if (ndo->ndo_vflag < 1)
 			goto next_message;
 		/* flags */
-		ND_TCHECK2(*cp, 2);
-		ND_PRINT((ndo, "\n\t flags %s", tok2str(ofp_config_str, "invalid (0x%04x)", EXTRACT_BE_16BITS(cp))));
+		ND_TCHECK_2(cp);
+		ND_PRINT("\n\t flags %s",
+			 tok2str(ofp_config_str, "invalid (0x%04x)", GET_BE_U_2(cp)));
 		cp += 2;
 		/* miss_send_len */
-		ND_TCHECK2(*cp, 2);
-		ND_PRINT((ndo, ", miss_send_len %u", EXTRACT_BE_16BITS(cp)));
+		ND_TCHECK_2(cp);
+		ND_PRINT(", miss_send_len %u", GET_BE_U_2(cp));
 		return cp + 2;
 	case OFPT_PORT_MOD:
 		if (len != OF_PORT_MOD_LEN)
@@ -2438,11 +2458,12 @@ of10_header_body_print(netdissect_options *ndo,
 		if (ndo->ndo_vflag < 1)
 			goto next_message;
 		/* port */
-		ND_TCHECK2(*cp, 2);
-		ND_PRINT((ndo, "\n\t port_no %s", tok2str(ofpp_str, "%u", EXTRACT_BE_16BITS(cp))));
+		ND_TCHECK_2(cp);
+		ND_PRINT("\n\t port_no %s",
+			 tok2str(ofpp_str, "%u", GET_BE_U_2(cp)));
 		cp += 2;
 		/* pad */
-		ND_TCHECK2(*cp, 2);
+		ND_TCHECK_2(cp);
 		return cp + 2;
 	case OFPT_FLOW_REMOVED:
 		if (len != OF_FLOW_REMOVED_LEN)
@@ -2456,11 +2477,12 @@ of10_header_body_print(netdissect_options *ndo,
 		if (ndo->ndo_vflag < 1)
 			goto next_message;
 		/* reason */
-		ND_TCHECK2(*cp, 1);
-		ND_PRINT((ndo, "\n\t reason %s", tok2str(ofppr_str, "invalid (0x%02x)", EXTRACT_8BITS(cp))));
+		ND_TCHECK_1(cp);
+		ND_PRINT("\n\t reason %s",
+			 tok2str(ofppr_str, "invalid (0x%02x)", GET_U_1(cp)));
 		cp += 1;
 		/* pad */
-		ND_TCHECK2(*cp, 7);
+		ND_TCHECK_7(cp);
 		cp += 7;
 		/* desc */
 		return of10_phy_ports_print(ndo, cp, ep, OF_PHY_PORT_LEN);
@@ -2547,11 +2569,12 @@ of10_header_body_print(netdissect_options *ndo,
 		if (ndo->ndo_vflag < 1)
 			goto next_message;
 		/* port */
-		ND_TCHECK2(*cp, 2);
-		ND_PRINT((ndo, "\n\t port_no %s", tok2str(ofpp_str, "%u", EXTRACT_BE_16BITS(cp))));
+		ND_TCHECK_2(cp);
+		ND_PRINT("\n\t port_no %s",
+			 tok2str(ofpp_str, "%u", GET_BE_U_2(cp)));
 		cp += 2;
 		/* pad */
-		ND_TCHECK2(*cp, 6);
+		ND_TCHECK_6(cp);
 		cp += 6;
 		/* queues */
 		return of10_queues_print(ndo, cp, ep, len - OF_QUEUE_GET_CONFIG_REPLY_LEN);
@@ -2559,11 +2582,11 @@ of10_header_body_print(netdissect_options *ndo,
 	goto next_message;
 
 invalid: /* skip the message body */
-	ND_PRINT((ndo, "%s", istr));
+	nd_print_invalid(ndo);
 next_message:
-	ND_TCHECK2(*cp0, len0 - OF_HEADER_LEN);
+	ND_TCHECK_LEN(cp0, len0 - OF_HEADER_LEN);
 	return cp0 + len0 - OF_HEADER_LEN;
 trunc:
-	ND_PRINT((ndo, "%s", tstr));
+	nd_print_trunc(ndo);
 	return ep;
 }