X-Git-Url: https://git.tcpdump.org/tcpdump/blobdiff_plain/ce1fc8263da72437c1df54b8b3ee682413d9e6ed..refs/pull/471/head:/print-chdlc.c diff --git a/print-chdlc.c b/print-chdlc.c index f8400747..ef22a36d 100644 --- a/print-chdlc.c +++ b/print-chdlc.c @@ -23,9 +23,9 @@ #include "config.h" #endif -#include +#include -#include "interface.h" +#include "netdissect.h" #include "addrtoname.h" #include "ethertype.h" #include "extract.h" @@ -55,7 +55,8 @@ chdlc_if_print(netdissect_options *ndo, const struct pcap_pkthdr *h, register co } u_int -chdlc_print(netdissect_options *ndo, register const u_char *p, u_int length) { +chdlc_print(netdissect_options *ndo, register const u_char *p, u_int length) +{ u_int proto; proto = EXTRACT_16BITS(&p[2]); @@ -74,11 +75,9 @@ chdlc_print(netdissect_options *ndo, register const u_char *p, u_int length) { case ETHERTYPE_IP: ip_print(ndo, p, length); break; -#ifdef INET6 case ETHERTYPE_IPV6: ip6_print(ndo, p, length); break; -#endif case CHDLC_TYPE_SLARP: chdlc_slarp_print(ndo, p, length); break; @@ -89,16 +88,16 @@ chdlc_print(netdissect_options *ndo, register const u_char *p, u_int length) { #endif case ETHERTYPE_MPLS: case ETHERTYPE_MPLS_MULTI: - mpls_print(p, length); + mpls_print(ndo, p, length); break; case ETHERTYPE_ISO: /* is the fudge byte set ? lets verify by spotting ISO headers */ if (*(p+1) == 0x81 || *(p+1) == 0x82 || *(p+1) == 0x83) - isoclns_print(p+1, length-1, length-1); + isoclns_print(ndo, p + 1, length - 1, length - 1); else - isoclns_print(p, length, length); + isoclns_print(ndo, p, length, length); break; default: if (!ndo->ndo_eflag) @@ -113,19 +112,19 @@ chdlc_print(netdissect_options *ndo, register const u_char *p, u_int length) { * The fixed-length portion of a SLARP packet. */ struct cisco_slarp { - u_int8_t code[4]; + uint8_t code[4]; #define SLARP_REQUEST 0 #define SLARP_REPLY 1 #define SLARP_KEEPALIVE 2 union { struct { - u_int8_t addr[4]; - u_int8_t mask[4]; + uint8_t addr[4]; + uint8_t mask[4]; } addr; struct { - u_int8_t myseq[4]; - u_int8_t yourseq[4]; - u_int8_t rel[2]; + uint8_t myseq[4]; + uint8_t yourseq[4]; + uint8_t rel[2]; } keep; } un; }; @@ -160,8 +159,8 @@ chdlc_slarp_print(netdissect_options *ndo, const u_char *cp, u_int length) break; case SLARP_REPLY: ND_PRINT((ndo, "reply %s/%s", - ipaddr_string(&slarp->un.addr.addr), - ipaddr_string(&slarp->un.addr.mask))); + ipaddr_string(ndo, &slarp->un.addr.addr), + ipaddr_string(ndo, &slarp->un.addr.mask))); break; case SLARP_KEEPALIVE: ND_PRINT((ndo, "keepalive: mineseen=0x%08x, yourseen=0x%08x, reliability=0x%04x", @@ -171,8 +170,7 @@ chdlc_slarp_print(netdissect_options *ndo, const u_char *cp, u_int length) if (length >= SLARP_MAX_LEN) { /* uptime-stamp is optional */ cp += SLARP_MIN_LEN; - if (!ND_TTEST2(*cp, 4)) - goto trunc; + ND_TCHECK2(*cp, 4); sec = EXTRACT_32BITS(cp) / 1000; min = sec / 60; sec -= min * 60; hrs = min / 60; min -= hrs * 60;