X-Git-Url: https://git.tcpdump.org/tcpdump/blobdiff_plain/c6d3ff424a838df85b2396e479dcf47ea5bfb043..a63600a1fc28dbc7ae7ce9f996829c49a25fb33c:/print-aodv.c?ds=inline

diff --git a/print-aodv.c b/print-aodv.c
index 92d21859..b014c49c 100644
--- a/print-aodv.c
+++ b/print-aodv.c
@@ -30,251 +30,363 @@
  * POSSIBILITY OF SUCH DAMAGE.
  */
 
-#ifndef lint
-static const char rcsid[] =
-    "@(#) $Header: /tcpdump/master/tcpdump/print-aodv.c,v 1.4 2003-09-06 22:16:56 guy Exp $ (LBL)";
-#endif
+/* \summary: Ad hoc On-Demand Distance Vector (AODV) Routing printer */
+/* specification: RFC 3561 */
 
 #ifdef HAVE_CONFIG_H
-#include "config.h"
+#include <config.h>
 #endif
 
-#include <tcpdump-stdinc.h>
-
-#include <stddef.h>
-#include <stdio.h>
-#include <ctype.h>
-#include <string.h>
+#include "netdissect-stdinc.h"
 
-#include "interface.h"
+#include "netdissect.h"
 #include "addrtoname.h"
-#include "extract.h"			/* must come after interface.h */
+#include "extract.h"
+
+struct aodv_rreq {
+	nd_uint8_t	rreq_type;	/* AODV message type (1) */
+	nd_uint8_t	rreq_flags;	/* various flags */
+	nd_uint8_t	rreq_zero0;	/* reserved, set to zero */
+	nd_uint8_t	rreq_hops;	/* number of hops from originator */
+	nd_uint32_t	rreq_id;	/* request ID */
+	nd_ipv4		rreq_da;	/* destination IPv4 address */
+	nd_uint32_t	rreq_ds;	/* destination sequence number */
+	nd_ipv4		rreq_oa;	/* originator IPv4 address */
+	nd_uint32_t	rreq_os;	/* originator sequence number */
+};
+struct aodv_rreq6 {
+	nd_uint8_t	rreq_type;	/* AODV message type (1) */
+	nd_uint8_t	rreq_flags;	/* various flags */
+	nd_uint8_t	rreq_zero0;	/* reserved, set to zero */
+	nd_uint8_t	rreq_hops;	/* number of hops from originator */
+	nd_uint32_t	rreq_id;	/* request ID */
+	nd_ipv6		rreq_da;	/* destination IPv6 address */
+	nd_uint32_t	rreq_ds;	/* destination sequence number */
+	nd_ipv6		rreq_oa;	/* originator IPv6 address */
+	nd_uint32_t	rreq_os;	/* originator sequence number */
+};
+
+#define	RREQ_JOIN	0x80		/* join (reserved for multicast */
+#define	RREQ_REPAIR	0x40		/* repair (reserved for multicast */
+#define	RREQ_GRAT	0x20		/* gratuitous RREP */
+#define	RREQ_DEST	0x10		/* destination only */
+#define	RREQ_UNKNOWN	0x08		/* unknown destination sequence num */
+#define	RREQ_FLAGS_MASK	0xF8		/* mask for rreq_flags */
+
+struct aodv_rrep {
+	nd_uint8_t	rrep_type;	/* AODV message type (2) */
+	nd_uint8_t	rrep_flags;	/* various flags */
+	nd_uint8_t	rrep_ps;	/* prefix size */
+	nd_uint8_t	rrep_hops;	/* number of hops from o to d */
+	nd_ipv4		rrep_da;	/* destination IPv4 address */
+	nd_uint32_t	rrep_ds;	/* destination sequence number */
+	nd_ipv4		rrep_oa;	/* originator IPv4 address */
+	nd_uint32_t	rrep_life;	/* lifetime of this route */
+};
+struct aodv_rrep6 {
+	nd_uint8_t	rrep_type;	/* AODV message type (2) */
+	nd_uint8_t	rrep_flags;	/* various flags */
+	nd_uint8_t	rrep_ps;	/* prefix size */
+	nd_uint8_t	rrep_hops;	/* number of hops from o to d */
+	nd_ipv6		rrep_da;	/* destination IPv6 address */
+	nd_uint32_t	rrep_ds;	/* destination sequence number */
+	nd_ipv6		rrep_oa;	/* originator IPv6 address */
+	nd_uint32_t	rrep_life;	/* lifetime of this route */
+};
+
+#define	RREP_REPAIR		0x80	/* repair (reserved for multicast */
+#define	RREP_ACK		0x40	/* acknowledgement required */
+#define	RREP_FLAGS_MASK		0xC0	/* mask for rrep_flags */
+#define	RREP_PREFIX_MASK	0x1F	/* mask for prefix size */
+
+struct rerr_unreach {
+	nd_ipv4		u_da;	/* IPv4 address */
+	nd_uint32_t	u_ds;	/* sequence number */
+};
+struct rerr_unreach6 {
+	nd_ipv6		u_da;	/* IPv6 address */
+	nd_uint32_t	u_ds;	/* sequence number */
+};
+
+struct aodv_rerr {
+	nd_uint8_t	rerr_type;	/* AODV message type (3 or 18) */
+	nd_uint8_t	rerr_flags;	/* various flags */
+	nd_uint8_t	rerr_zero0;	/* reserved, set to zero */
+	nd_uint8_t	rerr_dc;	/* destination count */
+};
+
+#define RERR_NODELETE		0x80	/* don't delete the link */
+#define RERR_FLAGS_MASK		0x80	/* mask for rerr_flags */
 
-#include "aodv.h"
+struct aodv_rrep_ack {
+	nd_uint8_t	ra_type;
+	nd_uint8_t	ra_zero0;
+};
+
+#define	AODV_RREQ		1	/* route request */
+#define	AODV_RREP		2	/* route response */
+#define	AODV_RERR		3	/* error report */
+#define	AODV_RREP_ACK		4	/* route response acknowledgement */
+static const struct tok msg_type_str[] = {
+	{ AODV_RREQ,     "rreq" },
+	{ AODV_RREP,     "rrep" },
+	{ AODV_RERR,     "rerr" },
+	{ AODV_RREP_ACK, "rrep-ack" },
+	{ 0, NULL }
+};
+
+struct aodv_ext {
+	nd_uint8_t	type;		/* extension type */
+	nd_uint8_t	length;		/* extension length */
+};
+
+struct aodv_hello {
+	struct	aodv_ext	eh;		/* extension header */
+	nd_uint32_t		interval;	/* expect my next hello in
+						 * (n) ms
+						 * NOTE: this is not aligned */
+};
+
+#define	AODV_EXT_HELLO	1
 
 static void
-aodv_extension(struct aodv_ext *ep, u_int length)
+aodv_extension(netdissect_options *ndo,
+               const struct aodv_ext *ep, u_int length)
 {
-	u_int i;
-	struct aodv_hello *ah;
+	const struct aodv_hello *ah;
+	uint8_t ext_type, ext_length;
 
-	switch (ep->type) {
+	ext_type = GET_U_1(ep->type);
+	ext_length = GET_U_1(ep->length);
+	switch (ext_type) {
 	case AODV_EXT_HELLO:
-		if (snapend < (u_char *) ep) {
-			printf(" [|hello]");
-			return;
-		}
-		i = min(length, (u_int)(snapend - (u_char *) ep));
-		if (i < sizeof(struct aodv_hello)) {
-			printf(" [|hello]");
-			return;
+		ah = (const struct aodv_hello *)(const void *)ep;
+		ND_ICHECKMSG_ZU("ext data length", length, <,
+				sizeof(struct aodv_hello));
+		if (ext_length < 4) {
+			ND_PRINT("\n\text HELLO - bad length %u", ext_length);
+			goto invalid;
 		}
-		i -= sizeof(struct aodv_hello);
-		ah = (void *) ep;
-		printf("\n\text HELLO %d ms",
-			EXTRACT_32BITS(ah->interval));
+		ND_PRINT("\n\text HELLO %u ms",
+		    GET_BE_U_4(ah->interval));
 		break;
 
 	default:
-		printf("\n\text %d %d", ep->type, ep->length);
+		ND_PRINT("\n\text %u %u", ext_type, ext_length);
 		break;
 	}
+	return;
+
+invalid:
+	nd_print_invalid(ndo);
 }
 
 static void
-aodv_rreq(union aodv *ap, const u_char *dat, u_int length, void *ip6
-#ifndef INET6
-	_U_
-#endif
-	)
+aodv_rreq(netdissect_options *ndo, const u_char *dat, u_int length)
 {
 	u_int i;
+	const struct aodv_rreq *ap = (const struct aodv_rreq *)dat;
 
-	if (snapend < dat) {
-		printf(" [|aodv]");
-		return;
-	}
-	i = min(length, (u_int)(snapend - dat));
-	if (i < sizeof(ap->rreq)) {
-		printf(" [|rreq]");
-		return;
-	}
-	i -= sizeof(ap->rreq);
-#ifdef INET6
-	if (ip6 != NULL) {
-		printf(" rreq %d %s%s%s%s%shops %d id 0x%08lx\n"
-			"\tdst %s seq %ld src %s seq %ld", length,
-			ap->rreq6.rreq_type & RREQ_JOIN ? "[J]" : "",
-			ap->rreq6.rreq_type & RREQ_REPAIR ? "[R]" : "",
-			ap->rreq6.rreq_type & RREQ_GRAT ? "[G]" : "",
-			ap->rreq6.rreq_type & RREQ_DEST ? "[D]" : "",
-			ap->rreq6.rreq_type & RREQ_UNKNOWN ? "[U] " : " ",
-			ap->rreq6.rreq_hops,
-			(unsigned long)EXTRACT_32BITS(ap->rreq6.rreq_id),
-			ip6addr_string(&ap->rreq6.rreq_da),
-			(unsigned long)EXTRACT_32BITS(ap->rreq6.rreq_ds),
-			ip6addr_string(&ap->rreq6.rreq_oa),
-			(unsigned long)EXTRACT_32BITS(ap->rreq6.rreq_os));
-		if (i >= sizeof(ap->rreq6) + sizeof(struct aodv_ext)) {
-			aodv_extension((void *) (&ap->rreq6 + 1),
-					length - sizeof(ap->rreq6));
-		}
-		} else
-#endif
-	{
-		printf(" rreq %d %s%s%s%s%shops %d id 0x%08x\n"
-			"\tdst %s seq %d src %s seq %d", length,
-			ap->rreq.rreq_type & RREQ_JOIN ? "[J]" : "",
-			ap->rreq.rreq_type & RREQ_REPAIR ? "[R]" : "",
-			ap->rreq.rreq_type & RREQ_GRAT ? "[G]" : "",
-			ap->rreq.rreq_type & RREQ_DEST ? "[D]" : "",
-			ap->rreq.rreq_type & RREQ_UNKNOWN ? "[U] " : " ",
-			ap->rreq.rreq_hops,
-			EXTRACT_32BITS(ap->rreq.rreq_id),
-			ipaddr_string(ap->rreq.rreq_da),
-			EXTRACT_32BITS(ap->rreq.rreq_ds),
-			ipaddr_string(ap->rreq.rreq_oa),
-			EXTRACT_32BITS(ap->rreq.rreq_os));
-		if (i >= sizeof(ap->rreq) + sizeof(struct aodv_ext)) {
-			aodv_extension((void *) (&ap->rreq + 1),
-					length - sizeof(ap->rreq));
-		}
-	}
+	ND_ICHECKMSG_ZU("message length", length, <, sizeof(*ap));
+	ND_PRINT(" %u %s%s%s%s%shops %u id 0x%08x\n"
+	    "\tdst %s seq %u src %s seq %u", length,
+	    GET_U_1(ap->rreq_type) & RREQ_JOIN ? "[J]" : "",
+	    GET_U_1(ap->rreq_type) & RREQ_REPAIR ? "[R]" : "",
+	    GET_U_1(ap->rreq_type) & RREQ_GRAT ? "[G]" : "",
+	    GET_U_1(ap->rreq_type) & RREQ_DEST ? "[D]" : "",
+	    GET_U_1(ap->rreq_type) & RREQ_UNKNOWN ? "[U] " : " ",
+	    GET_U_1(ap->rreq_hops),
+	    GET_BE_U_4(ap->rreq_id),
+	    GET_IPADDR_STRING(ap->rreq_da),
+	    GET_BE_U_4(ap->rreq_ds),
+	    GET_IPADDR_STRING(ap->rreq_oa),
+	    GET_BE_U_4(ap->rreq_os));
+	i = length - sizeof(*ap);
+	if (i >= sizeof(struct aodv_ext))
+		aodv_extension(ndo, (const struct aodv_ext *)(dat + sizeof(*ap)), i);
+	return;
+
+invalid:
+	nd_print_invalid(ndo);
 }
 
 static void
-aodv_rrep(union aodv *ap, const u_char *dat, u_int length, void *ip6
-#ifndef INET6
-	_U_
-#endif
-	)
+aodv_rrep(netdissect_options *ndo, const u_char *dat, u_int length)
 {
 	u_int i;
+	const struct aodv_rrep *ap = (const struct aodv_rrep *)dat;
 
-	if (snapend < dat) {
-		printf(" [|aodv]");
-		return;
-	}
-	i = min(length, (u_int)(snapend - dat));
-	if (i < sizeof(ap->rrep)) {
-		printf(" [|rrep]");
-		return;
-	}
-	i -= sizeof(ap->rrep);
-#ifdef INET6
-	if (ip6 != NULL) {
-		printf(" rrep %d %s%sprefix %d hops %d\n"
-		       "\tdst %s dseq %d src %s %d ms", length,
-			ap->rrep6.rrep_type & RREP_REPAIR ? "[R]" : "",
-			ap->rrep6.rrep_type & RREP_ACK ? "[A] " : " ",
-			ap->rrep6.rrep_ps & RREP_PREFIX_MASK,
-			ap->rrep6.rrep_hops,
-			ip6addr_string(&ap->rrep6.rrep_da),
-			EXTRACT_32BITS(ap->rrep6.rrep_ds),
-			ip6addr_string(&ap->rrep6.rrep_oa),
-			EXTRACT_32BITS(ap->rrep6.rrep_life));
-		if (i >= sizeof(ap->rrep6) + sizeof(struct aodv_ext)) {
-			aodv_extension((void *) (&ap->rrep6 + 1),
-					length - sizeof(ap->rrep6));
-		}
-	} else
-#endif
-	{
-		printf(" rrep %d %s%sprefix %d hops %d\n"
-		       "\tdst %s dseq %d src %s %d ms", length,
-			ap->rrep.rrep_type & RREP_REPAIR ? "[R]" : "",
-			ap->rrep.rrep_type & RREP_ACK ? "[A] " : " ",
-			ap->rrep.rrep_ps & RREP_PREFIX_MASK,
-			ap->rrep.rrep_hops,
-			ipaddr_string(ap->rrep.rrep_da),
-			EXTRACT_32BITS(ap->rrep.rrep_ds),
-			ipaddr_string(ap->rrep.rrep_oa),
-			EXTRACT_32BITS(ap->rrep.rrep_life));
-		if (i >= sizeof(ap->rrep) + sizeof(struct aodv_ext)) {
-			aodv_extension((void *) (&ap->rrep + 1),
-					length - sizeof(ap->rrep));
-		}
-	}
+	ND_ICHECKMSG_ZU("message length", length, <, sizeof(*ap));
+	ND_PRINT(" %u %s%sprefix %u hops %u\n"
+	    "\tdst %s dseq %u src %s %u ms", length,
+	    GET_U_1(ap->rrep_type) & RREP_REPAIR ? "[R]" : "",
+	    GET_U_1(ap->rrep_type) & RREP_ACK ? "[A] " : " ",
+	    GET_U_1(ap->rrep_ps) & RREP_PREFIX_MASK,
+	    GET_U_1(ap->rrep_hops),
+	    GET_IPADDR_STRING(ap->rrep_da),
+	    GET_BE_U_4(ap->rrep_ds),
+	    GET_IPADDR_STRING(ap->rrep_oa),
+	    GET_BE_U_4(ap->rrep_life));
+	i = length - sizeof(*ap);
+	if (i >= sizeof(struct aodv_ext))
+		aodv_extension(ndo, (const struct aodv_ext *)(dat + sizeof(*ap)), i);
+	return;
+
+invalid:
+	nd_print_invalid(ndo);
 }
 
 static void
-aodv_rerr(union aodv *ap, u_int length, void *ip6
-#ifndef INET6
-	_U_
-#endif
-	)
+aodv_rerr(netdissect_options *ndo, const u_char *dat, u_int length)
 {
-	int i, j, n, trunc;
-	struct rerr_unreach *dp = NULL;
-#ifdef INET6
-	struct rerr_unreach6 *dp6 = NULL;
-#endif
+	u_int i, dc;
+	const struct aodv_rerr *ap = (const struct aodv_rerr *)dat;
+	const struct rerr_unreach *dp;
 
-	i = length - offsetof(struct aodv_rerr, r);
-#ifdef INET6
-	if (ip6 != NULL) {
-		j = sizeof(ap->rerr.r.dest6[0]);
-		dp6 = &ap->rerr.r.dest6[0];
-	} else
-#endif
-	{
-		j = sizeof(ap->rerr.r.dest[0]);
-		dp = &ap->rerr.r.dest[0];
+	ND_ICHECKMSG_ZU("message length", length, <, sizeof(*ap));
+	ND_PRINT(" %s [items %u] [%u]:",
+	    GET_U_1(ap->rerr_flags) & RERR_NODELETE ? "[D]" : "",
+	    GET_U_1(ap->rerr_dc), length);
+	dp = (const struct rerr_unreach *)(dat + sizeof(*ap));
+	i = length - sizeof(*ap);
+	for (dc = GET_U_1(ap->rerr_dc); dc != 0; dc--) {
+		ND_ICHECKMSG_ZU("remaining length", i, <, sizeof(*dp));
+		ND_PRINT(" {%s}(%u)", GET_IPADDR_STRING(dp->u_da),
+		    GET_BE_U_4(dp->u_ds));
+		dp++;
+		i -= sizeof(*dp);
 	}
-	n = ap->rerr.rerr_dc * j;
-	printf(" rerr %s [items %d] [%d]:",
-		ap->rerr.rerr_flags & RERR_NODELETE ? "[D]" : "",
-		ap->rerr.rerr_dc, length);
-	trunc = n - (i/j);
-#ifdef INET6
-	if (ip6 != NULL) {
-		for (; i -= j >= 0; ++dp6) {
-			printf(" {%s}(%d)", ip6addr_string(&dp6->u_da),
-				EXTRACT_32BITS(dp6->u_ds));
-		}
-	} else
-#endif
-	{
-		for (; i -= j >= 0; ++dp) {
-			printf(" {%s}(%d)", ipaddr_string(dp->u_da),
-				EXTRACT_32BITS(dp->u_ds));
-		}
+	return;
+
+invalid:
+	nd_print_invalid(ndo);
+}
+
+static void
+aodv_v6_rreq(netdissect_options *ndo, const u_char *dat, u_int length)
+{
+	u_int i;
+	const struct aodv_rreq6 *ap = (const struct aodv_rreq6 *)dat;
+
+	ND_ICHECKMSG_ZU("message length", length, <, sizeof(*ap));
+	ND_PRINT(" %u %s%s%s%s%shops %u id 0x%08x\n"
+	    "\tdst %s seq %u src %s seq %u", length,
+	    GET_U_1(ap->rreq_type) & RREQ_JOIN ? "[J]" : "",
+	    GET_U_1(ap->rreq_type) & RREQ_REPAIR ? "[R]" : "",
+	    GET_U_1(ap->rreq_type) & RREQ_GRAT ? "[G]" : "",
+	    GET_U_1(ap->rreq_type) & RREQ_DEST ? "[D]" : "",
+	    GET_U_1(ap->rreq_type) & RREQ_UNKNOWN ? "[U] " : " ",
+	    GET_U_1(ap->rreq_hops),
+	    GET_BE_U_4(ap->rreq_id),
+	    GET_IP6ADDR_STRING(ap->rreq_da),
+	    GET_BE_U_4(ap->rreq_ds),
+	    GET_IP6ADDR_STRING(ap->rreq_oa),
+	    GET_BE_U_4(ap->rreq_os));
+	i = length - sizeof(*ap);
+	if (i >= sizeof(struct aodv_ext))
+		aodv_extension(ndo, (const struct aodv_ext *)(dat + sizeof(*ap)), i);
+	return;
+
+invalid:
+	nd_print_invalid(ndo);
+}
+
+static void
+aodv_v6_rrep(netdissect_options *ndo, const u_char *dat, u_int length)
+{
+	u_int i;
+	const struct aodv_rrep6 *ap = (const struct aodv_rrep6 *)dat;
+
+	ND_ICHECKMSG_ZU("message length", length, <, sizeof(*ap));
+	ND_PRINT(" %u %s%sprefix %u hops %u\n"
+	   "\tdst %s dseq %u src %s %u ms", length,
+	    GET_U_1(ap->rrep_type) & RREP_REPAIR ? "[R]" : "",
+	    GET_U_1(ap->rrep_type) & RREP_ACK ? "[A] " : " ",
+	    GET_U_1(ap->rrep_ps) & RREP_PREFIX_MASK,
+	    GET_U_1(ap->rrep_hops),
+	    GET_IP6ADDR_STRING(ap->rrep_da),
+	    GET_BE_U_4(ap->rrep_ds),
+	    GET_IP6ADDR_STRING(ap->rrep_oa),
+	    GET_BE_U_4(ap->rrep_life));
+	i = length - sizeof(*ap);
+	if (i >= sizeof(struct aodv_ext))
+		aodv_extension(ndo, (const struct aodv_ext *)(dat + sizeof(*ap)), i);
+	return;
+
+invalid:
+	nd_print_invalid(ndo);
+}
+
+static void
+aodv_v6_rerr(netdissect_options *ndo, const u_char *dat, u_int length)
+{
+	u_int i, dc;
+	const struct aodv_rerr *ap = (const struct aodv_rerr *)dat;
+	const struct rerr_unreach6 *dp6;
+
+	ND_ICHECKMSG_ZU("message length", length, <, sizeof(*ap));
+	ND_PRINT(" %s [items %u] [%u]:",
+	    GET_U_1(ap->rerr_flags) & RERR_NODELETE ? "[D]" : "",
+	    GET_U_1(ap->rerr_dc), length);
+	dp6 = (const struct rerr_unreach6 *)(const void *)(ap + 1);
+	i = length - sizeof(*ap);
+	for (dc = GET_U_1(ap->rerr_dc); dc != 0; dc--) {
+		ND_ICHECKMSG_ZU("remaining length", i, <, sizeof(*dp6));
+		ND_PRINT(" {%s}(%u)", GET_IP6ADDR_STRING(dp6->u_da),
+			 GET_BE_U_4(dp6->u_ds));
+		dp6++;
+		i -= sizeof(*dp6);
 	}
-	if (trunc)
-		printf("[|rerr]");
+	return;
+
+invalid:
+	nd_print_invalid(ndo);
 }
 
 void
-aodv_print(const u_char *dat, u_int length, void *ip6)
+aodv_print(netdissect_options *ndo,
+           const u_char *dat, u_int length, int is_ip6)
 {
-	union aodv *ap;
+	uint8_t msg_type;
 
-	ap = (union aodv *)dat;
-	if (snapend < dat) {
-		printf(" [|aodv]");
-		return;
-	}
-	if (min(length, (u_int)(snapend - dat)) < sizeof(ap->rrep_ack)) {
-		printf(" [|aodv]");
-		return;
-	}
-	printf(" aodv");
+	ndo->ndo_protocol = "aodv";
+	ND_PRINT(" aodv");
+
+	/*
+	 * The message type is the first byte; make sure we have it
+	 * and then fetch it.
+	 */
+	msg_type = GET_U_1(dat);
+	ND_PRINT(" %s", tok2str(msg_type_str, "type %u", msg_type));
+
+	switch (msg_type) {
 
-	switch (ap->rerr.rerr_type) {
 	case AODV_RREQ:
-		aodv_rreq(ap, dat, length, ip6);
+		if (is_ip6)
+			aodv_v6_rreq(ndo, dat, length);
+		else
+			aodv_rreq(ndo, dat, length);
 		break;
+
 	case AODV_RREP:
-		aodv_rrep(ap, dat, length, ip6);
+		if (is_ip6)
+			aodv_v6_rrep(ndo, dat, length);
+		else
+			aodv_rrep(ndo, dat, length);
 		break;
+
 	case AODV_RERR:
-		aodv_rerr(ap, length, ip6);
+		if (is_ip6)
+			aodv_v6_rerr(ndo, dat, length);
+		else
+			aodv_rerr(ndo, dat, length);
 		break;
+
 	case AODV_RREP_ACK:
-		printf(" rrep-ack %d", ap->rrep_ack.ra_type);
+		ND_PRINT(" %u", length);
 		break;
 
 	default:
-		printf(" %d %d", ap->rreq.rreq_type, length);
+		ND_PRINT(" %u", length);
 	}
 }