X-Git-Url: https://git.tcpdump.org/tcpdump/blobdiff_plain/9d046ee0503d4c8cbfcb200c88986de876f6cae7..b51a0dafc7861eb31d21524ec067d7c529a664b8:/print-ntp.c diff --git a/print-ntp.c b/print-ntp.c index 57bbf54d..86e29e69 100644 --- a/print-ntp.c +++ b/print-ntp.c @@ -42,48 +42,18 @@ #include #endif +#define ND_LONGJMP_FROM_TCHECK #include "netdissect.h" #include "addrtoname.h" #include "extract.h" +#include "ntp.h" /* * Based on ntp.h from the U of MD implementation * This file is based on Version 2 of the NTP spec (RFC1119). */ -/* - * Definitions for the masses - */ -#define JAN_1970 INT64_T_CONSTANT(2208988800) /* 1970 - 1900 in seconds */ - -/* - * Structure definitions for NTP fixed point values - * - * 0 1 2 3 - * 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 - * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - * | Integer Part | - * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - * | Fraction Part | - * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - * - * 0 1 2 3 - * 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 - * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - * | Integer Part | Fraction Part | - * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ -*/ -struct l_fixedpt { - nd_uint32_t int_part; - nd_uint32_t fraction; -}; - -struct s_fixedpt { - nd_uint16_t int_part; - nd_uint16_t fraction; -}; - /* rfc2030 * 1 2 3 * 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 @@ -186,7 +156,6 @@ struct ntp_time_data { #define INFO_REPLY 63 /* **** THIS implementation dependent **** */ static void p_sfix(netdissect_options *ndo, const struct s_fixedpt *); -static void p_ntp_time(netdissect_options *, const struct l_fixedpt *); static void p_ntp_delta(netdissect_options *, const struct l_fixedpt *, const struct l_fixedpt *); static void p_poll(netdissect_options *, const int); @@ -268,39 +237,33 @@ ntp_time_print(netdissect_options *ndo, if (length < NTP_TIMEMSG_MINLEN) goto invalid; - ND_TCHECK_1(bp->stratum); stratum = GET_U_1(bp->stratum); ND_PRINT(", Stratum %u (%s)", stratum, tok2str(ntp_stratum_values, (stratum >=2 && stratum<=15) ? "secondary reference" : "reserved", stratum)); - ND_TCHECK_1(bp->ppoll); ND_PRINT(", poll %d", GET_S_1(bp->ppoll)); p_poll(ndo, GET_S_1(bp->ppoll)); - ND_TCHECK_1(bp->precision); ND_PRINT(", precision %d", GET_S_1(bp->precision)); - ND_TCHECK_SIZE(&bp->root_delay); ND_PRINT("\n\tRoot Delay: "); p_sfix(ndo, &bp->root_delay); - ND_TCHECK_SIZE(&bp->root_dispersion); ND_PRINT(", Root dispersion: "); p_sfix(ndo, &bp->root_dispersion); - ND_TCHECK_4(bp->refid); ND_PRINT(", Reference-ID: "); /* Interpretation depends on stratum */ switch (stratum) { case UNSPECIFIED: ND_PRINT("(unspec)"); + ND_TCHECK_4(bp->refid); break; case PRIM_REF: - if (nd_printn(ndo, (const u_char *)&(bp->refid), 4, ndo->ndo_snapend)) - goto trunc; + nd_printjn(ndo, (const u_char *)&(bp->refid), 4); break; case INFO_QUERY: @@ -320,19 +283,15 @@ ntp_time_print(netdissect_options *ndo, break; } - ND_TCHECK_SIZE(&bp->ref_timestamp); ND_PRINT("\n\t Reference Timestamp: "); p_ntp_time(ndo, &(bp->ref_timestamp)); - ND_TCHECK_SIZE(&bp->org_timestamp); ND_PRINT("\n\t Originator Timestamp: "); p_ntp_time(ndo, &(bp->org_timestamp)); - ND_TCHECK_SIZE(&bp->rec_timestamp); ND_PRINT("\n\t Receive Timestamp: "); p_ntp_time(ndo, &(bp->rec_timestamp)); - ND_TCHECK_SIZE(&bp->xmt_timestamp); ND_PRINT("\n\t Transmit Timestamp: "); p_ntp_time(ndo, &(bp->xmt_timestamp)); @@ -344,21 +303,16 @@ ntp_time_print(netdissect_options *ndo, /* FIXME: this code is not aware of any extension fields */ if (length == NTP_TIMEMSG_MINLEN + 4) { /* Optional: key-id (crypto-NAK) */ - ND_TCHECK_4(bp->key_id); ND_PRINT("\n\tKey id: %u", GET_BE_U_4(bp->key_id)); } else if (length == NTP_TIMEMSG_MINLEN + 4 + 16) { /* Optional: key-id + 128-bit digest */ - ND_TCHECK_4(bp->key_id); ND_PRINT("\n\tKey id: %u", GET_BE_U_4(bp->key_id)); - ND_TCHECK_LEN(bp->message_digest, 16); ND_PRINT("\n\tAuthentication: %08x%08x%08x%08x", GET_BE_U_4(bp->message_digest), GET_BE_U_4(bp->message_digest + 4), GET_BE_U_4(bp->message_digest + 8), GET_BE_U_4(bp->message_digest + 12)); } else if (length == NTP_TIMEMSG_MINLEN + 4 + 20) { /* Optional: key-id + 160-bit digest */ - ND_TCHECK_4(bp->key_id); ND_PRINT("\n\tKey id: %u", GET_BE_U_4(bp->key_id)); - ND_TCHECK_LEN(bp->message_digest, 20); ND_PRINT("\n\tAuthentication: %08x%08x%08x%08x%08x", GET_BE_U_4(bp->message_digest), GET_BE_U_4(bp->message_digest + 4), @@ -373,10 +327,6 @@ ntp_time_print(netdissect_options *ndo, invalid: nd_print_invalid(ndo); ND_TCHECK_LEN(bp, length); - return; - -trunc: - nd_print_trunc(ndo); } /* @@ -392,7 +342,6 @@ ntp_control_print(netdissect_options *ndo, if (length < NTP_CTRLMSG_MINLEN) goto invalid; - ND_TCHECK_1(cd->control); control = GET_U_1(cd->control); R = (control & 0x80) != 0; E = (control & 0x40) != 0; @@ -402,23 +351,18 @@ ntp_control_print(netdissect_options *ndo, R ? "Response" : "Request", E ? "Error" : "OK", M ? "More" : "Last", opcode); - ND_TCHECK_2(cd->sequence); sequence = GET_BE_U_2(cd->sequence); ND_PRINT("\tSequence=%hu", sequence); - ND_TCHECK_2(cd->status); status = GET_BE_U_2(cd->status); ND_PRINT(", Status=%#hx", status); - ND_TCHECK_2(cd->assoc); assoc = GET_BE_U_2(cd->assoc); ND_PRINT(", Assoc.=%hu", assoc); - ND_TCHECK_2(cd->offset); offset = GET_BE_U_2(cd->offset); ND_PRINT(", Offset=%hu", offset); - ND_TCHECK_2(cd->count); count = GET_BE_U_2(cd->count); ND_PRINT(", Count=%hu", count); @@ -433,10 +377,6 @@ ntp_control_print(netdissect_options *ndo, invalid: nd_print_invalid(ndo); ND_TCHECK_LEN(cd, length); - return; - -trunc: - nd_print_trunc(ndo); } union ntpdata { @@ -456,7 +396,6 @@ ntp_print(netdissect_options *ndo, uint8_t status; ndo->ndo_protocol = "ntp"; - ND_TCHECK_1(bp->td.status); status = GET_U_1(bp->td.status); version = (status & VERSIONMASK) >> VERSIONSHIFT; @@ -497,10 +436,6 @@ ntp_print(netdissect_options *ndo, default: break; /* XXX: not implemented! */ } - return; - -trunc: - nd_print_trunc(ndo); } static void @@ -518,62 +453,6 @@ p_sfix(netdissect_options *ndo, ND_PRINT("%d.%06d", i, f); } -#define FMAXINT (4294967296.0) /* floating point rep. of MAXINT */ - -static void -p_ntp_time(netdissect_options *ndo, - const struct l_fixedpt *lfp) -{ - uint32_t i; - uint32_t uf; - uint32_t f; - double ff; - - i = GET_BE_U_4(lfp->int_part); - uf = GET_BE_U_4(lfp->fraction); - ff = uf; - if (ff < 0.0) /* some compilers are buggy */ - ff += FMAXINT; - ff = ff / FMAXINT; /* shift radix point by 32 bits */ - f = (uint32_t)(ff * 1000000000.0); /* treat fraction as parts per billion */ - ND_PRINT("%u.%09u", i, f); - -#ifdef HAVE_STRFTIME - /* - * print the UTC time in human-readable format. - */ - if (i) { - int64_t seconds_64bit = (int64_t)i - JAN_1970; - time_t seconds; - struct tm *tm; - char time_buf[128]; - - seconds = (time_t)seconds_64bit; - if (seconds != seconds_64bit) { - /* - * It doesn't fit into a time_t, so we can't hand it - * to gmtime. - */ - ND_PRINT(" (unrepresentable)"); - } else { - tm = gmtime(&seconds); - if (tm == NULL) { - /* - * gmtime() can't handle it. - * (Yes, that might happen with some version of - * Microsoft's C library.) - */ - ND_PRINT(" (unrepresentable)"); - } else { - /* use ISO 8601 (RFC3339) format */ - strftime(time_buf, sizeof (time_buf), "%Y-%m-%dT%H:%M:%SZ", tm); - ND_PRINT(" (%s)", time_buf); - } - } - } -#endif -} - /* Prints time difference between *lfp and *olfp */ static void p_ntp_delta(netdissect_options *ndo,