X-Git-Url: https://git.tcpdump.org/tcpdump/blobdiff_plain/51e180c4fb05a88ad6687a23cc983955cd9ea431..c39d40a767a1ae36171e5bcbf6f157ff3e80fb6c:/print-vrrp.c diff --git a/print-vrrp.c b/print-vrrp.c index 49f42480..ee97974e 100644 --- a/print-vrrp.c +++ b/print-vrrp.c @@ -120,7 +120,6 @@ vrrp_print(netdissect_options *ndo, if (version < 2 || version > 3 || type != VRRP_TYPE_ADVERTISEMENT) return; ND_PRINT(", vrid %u, prio %u", GET_U_1(bp + 1), GET_U_1(bp + 2)); - ND_TCHECK_1(bp + 5); if (version == 2) { auth_type = GET_U_1(bp + 4); @@ -166,16 +165,13 @@ vrrp_print(netdissect_options *ndo, bp += 4; } if (version == 2 && auth_type == VRRP_AUTH_SIMPLE) { /* simple text password */ - ND_TCHECK_1(bp + 7); ND_PRINT(" auth \""); - if (nd_printn(ndo, bp, 8, ndo->ndo_snapend)) { - ND_PRINT("\""); - goto trunc; - } + /* + * RFC 2338 Section 5.3.10: "If the configured authentication string + * is shorter than 8 bytes, the remaining space MUST be zero-filled. + */ + nd_printjnp(ndo, bp, 8); ND_PRINT("\""); } } - return; -trunc: - nd_print_trunc(ndo); }