X-Git-Url: https://git.tcpdump.org/tcpdump/blobdiff_plain/4405f138044178bf9756cbb8712d086aaaafcaed..a9d6fee301938c5a1d2033bf8b8f09db19efca5b:/print-ppi.c

diff --git a/print-ppi.c b/print-ppi.c
index 06678b0f..b9f76579 100644
--- a/print-ppi.c
+++ b/print-ppi.c
@@ -1,7 +1,7 @@
 /*
  * Oracle
  */
-#define NETDISSECT_REWORKED
+
 #ifdef HAVE_CONFIG_H
 #include "config.h"
 #endif
@@ -45,31 +45,36 @@ ppi_header_print(netdissect_options *ndo, const u_char *bp, u_int length)
 	ND_PRINT((ndo, ", length %u: ", length));
 }
 
-static void
+static u_int
 ppi_print(netdissect_options *ndo,
                const struct pcap_pkthdr *h, const u_char *p)
 {
 	if_printer printer;
-	ppi_header_t *hdr;
+	const ppi_header_t *hdr;
 	u_int caplen = h->caplen;
 	u_int length = h->len;
 	uint16_t len;
 	uint32_t dlt;
+	uint32_t hdrlen;
 
 	if (caplen < sizeof(ppi_header_t)) {
 		ND_PRINT((ndo, "[|ppi]"));
-		return;
+		return (caplen);
 	}
 
-	hdr = (ppi_header_t *)p;
+	hdr = (const ppi_header_t *)p;
 	len = EXTRACT_LE_16BITS(&hdr->ppi_len);
-	if (len < sizeof(ppi_header_t)) {
+	if (caplen < len) {
+		/*
+		 * If we don't have the entire PPI header, don't
+		 * bother.
+		 */
 		ND_PRINT((ndo, "[|ppi]"));
-		return;
+		return (caplen);
 	}
-	if (caplen < len) {
+	if (len < sizeof(ppi_header_t)) {
 		ND_PRINT((ndo, "[|ppi]"));
-		return;
+		return (len);
 	}
 	dlt = EXTRACT_LE_32BITS(&hdr->ppi_dlt);
 
@@ -81,14 +86,16 @@ ppi_print(netdissect_options *ndo,
 	p += len;
 
 	if ((printer = lookup_printer(dlt)) != NULL) {
-		printer(ndo, h, p);
+		hdrlen = printer(ndo, h, p);
 	} else {
 		if (!ndo->ndo_eflag)
-			ppi_header_print(ndo, (u_char *)hdr, length + len);
+			ppi_header_print(ndo, (const u_char *)hdr, length + len);
 
 		if (!ndo->ndo_suppress_default_print)
 			ND_DEFAULTPRINT(p, caplen);
+		hdrlen = 0;
 	}
+	return (len + hdrlen);
 }
 
 /*
@@ -101,9 +108,7 @@ u_int
 ppi_if_print(netdissect_options *ndo,
                const struct pcap_pkthdr *h, const u_char *p)
 {
-	ppi_print(ndo, h, p);
-
-	return (sizeof(ppi_header_t));
+	return (ppi_print(ndo, h, p));
 }
 
 /*