X-Git-Url: https://git.tcpdump.org/tcpdump/blobdiff_plain/436ced3bd83f6b3a5b4a206538c56189837add59..3a7639e545c0543bcec19c4321dd3ba397fbe6fa:/print-openflow.c diff --git a/print-openflow.c b/print-openflow.c index 07f15de6..687b16d6 100644 --- a/print-openflow.c +++ b/print-openflow.c @@ -30,6 +30,8 @@ * POSSIBILITY OF SUCH DAMAGE. */ +/* \summary: version-independent OpenFlow printer */ + #ifdef HAVE_CONFIG_H #include "config.h" #endif @@ -83,20 +85,20 @@ of_header_body_print(netdissect_options *ndo, const u_char *cp, const u_char *ep if (ep < cp + OF_HEADER_LEN) goto invalid; /* version */ - ND_TCHECK2(*cp, 1); - version = *cp; + ND_TCHECK_1(cp); + version = EXTRACT_U_1(cp); cp += 1; /* type */ - ND_TCHECK2(*cp, 1); - type = *cp; + ND_TCHECK_1(cp); + type = EXTRACT_U_1(cp); cp += 1; /* length */ - ND_TCHECK2(*cp, 2); - length = EXTRACT_16BITS(cp); + ND_TCHECK_2(cp); + length = EXTRACT_BE_U_2(cp); cp += 2; /* xid */ - ND_TCHECK2(*cp, 4); - xid = EXTRACT_32BITS(cp); + ND_TCHECK_4(cp); + xid = EXTRACT_BE_U_4(cp); cp += 4; /* Message length includes the header length and a message always includes * the basic header. A message length underrun fails decoding of the rest of