X-Git-Url: https://git.tcpdump.org/tcpdump/blobdiff_plain/32e24ead3b2a171e5f5eff50d7231c2514eda9b4..refs/heads/coverity_scan:/print-loopback.c

diff --git a/print-loopback.c b/print-loopback.c
index ea7d7280..e545eb07 100644
--- a/print-loopback.c
+++ b/print-loopback.c
@@ -29,15 +29,15 @@
 
 /*
  * originally defined as the Ethernet Configuration Testing Protocol.
- * specification: http://www.mit.edu/people/jhawk/ctp.pdf
+ * specification:
+ * https://web.archive.org/web/20060919181108/http://www.mit.edu/people/jhawk/ctp.pdf
  */
 
-#ifdef HAVE_CONFIG_H
 #include <config.h>
-#endif
 
 #include "netdissect-stdinc.h"
 
+#define ND_LONGJMP_FROM_TCHECK
 #include "netdissect.h"
 #include "extract.h"
 #include "addrtoname.h"
@@ -53,60 +53,57 @@ static const struct tok fcode_str[] = {
 };
 
 static void
-loopback_message_print(netdissect_options *ndo, const u_char *cp, const u_int len)
+loopback_message_print(netdissect_options *ndo,
+                       const u_char *cp, u_int len)
 {
-	const u_char *ep = ndo->ndo_snapend;
 	uint16_t function;
 
 	if (len < 2)
 		goto invalid;
 	/* function */
-	ND_TCHECK_2(cp);
-	function = EXTRACT_LE_U_2(cp);
+	function = GET_LE_U_2(cp);
 	cp += 2;
+	len -= 2;
 	ND_PRINT(", %s", tok2str(fcode_str, " invalid (%u)", function));
 
 	switch (function) {
 		case LOOPBACK_REPLY:
-			if (len < 4)
+			if (len < 2)
 				goto invalid;
 			/* receipt number */
-			ND_TCHECK_2(cp);
-			ND_PRINT(", receipt number %u", EXTRACT_LE_U_2(cp));
+			ND_PRINT(", receipt number %u", GET_LE_U_2(cp));
 			cp += 2;
+			len -= 2;
 			/* data */
-			ND_PRINT(", data (%u octets)", len - 4);
-			ND_TCHECK_LEN(cp, len - 4);
+			ND_PRINT(", data (%u octets)", len);
+			ND_TCHECK_LEN(cp, len);
 			break;
 		case LOOPBACK_FWDDATA:
-			if (len < 8)
+			if (len < MAC48_LEN)
 				goto invalid;
 			/* forwarding address */
-			ND_TCHECK_LEN(cp, MAC_ADDR_LEN);
-			ND_PRINT(", forwarding address %s", etheraddr_string(ndo, cp));
-			cp += MAC_ADDR_LEN;
+			ND_PRINT(", forwarding address %s", GET_MAC48_STRING(cp));
+			cp += MAC48_LEN;
+			len -= MAC48_LEN;
 			/* data */
-			ND_PRINT(", data (%u octets)", len - 8);
-			ND_TCHECK_LEN(cp, len - 8);
+			ND_PRINT(", data (%u octets)", len);
+			ND_TCHECK_LEN(cp, len);
 			break;
 		default:
-			ND_TCHECK_LEN(cp, len - 2);
+			ND_TCHECK_LEN(cp, len);
 			break;
 	}
 	return;
 
 invalid:
 	nd_print_invalid(ndo);
-	ND_TCHECK_LEN(cp, ep - cp);
-	return;
-trunc:
-	nd_print_trunc(ndo);
+	ND_TCHECK_LEN(cp, len);
 }
 
 void
-loopback_print(netdissect_options *ndo, const u_char *cp, const u_int len)
+loopback_print(netdissect_options *ndo,
+               const u_char *cp, u_int len)
 {
-	const u_char *ep = ndo->ndo_snapend;
 	uint16_t skipCount;
 
 	ndo->ndo_protocol = "loopback";
@@ -114,22 +111,24 @@ loopback_print(netdissect_options *ndo, const u_char *cp, const u_int len)
 	if (len < 2)
 		goto invalid;
 	/* skipCount */
-	ND_TCHECK_2(cp);
-	skipCount = EXTRACT_LE_U_2(cp);
+	skipCount = GET_LE_U_2(cp);
 	cp += 2;
+	len -= 2;
 	ND_PRINT(", skipCount %u", skipCount);
 	if (skipCount % 8)
 		ND_PRINT(" (bogus)");
-	if (skipCount > len - 2)
+	if (skipCount > len)
 		goto invalid;
-	loopback_message_print(ndo, cp + skipCount, len - 2 - skipCount);
+	/* the octets to skip */
+	ND_TCHECK_LEN(cp, skipCount);
+	cp += skipCount;
+	len -= skipCount;
+	/* the first message to decode */
+	loopback_message_print(ndo, cp, len);
 	return;
 
 invalid:
 	nd_print_invalid(ndo);
-	ND_TCHECK_LEN(cp, ep - cp);
-	return;
-trunc:
-	nd_print_trunc(ndo);
+	ND_TCHECK_LEN(cp, len);
 }