Eliminate a GCC warning about a "char" array subscript - and, by doing

[tcpdump] / print-ether.c

diff --git a/print-ether.c b/print-ether.c
index d75a64d291e83354ab5d53e21b1a80badb739137..2826c7bbd252f0377fd892b4123017f5192a5965 100644 (file)
--- a/print-ether.c
+++ b/print-ether.c
@@ -1,5 +1,5 @@
 /*
 /*

- * Copyright (c) 1988, 1989, 1990, 1991, 1992, 1993, 1994, 1995, 1996, 1997
+ * Copyright (c) 1988, 1989, 1990, 1991, 1992, 1993, 1994, 1995, 1996, 1997, 2000

  *     The Regents of the University of California.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  *     The Regents of the University of California.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without


@@ -20,21 +20,14 @@
  */
 #ifndef lint
 static const char rcsid[] =
  */
 #ifndef lint
 static const char rcsid[] =

-    "@(#) $Header: /tcpdump/master/tcpdump/print-ether.c,v 1.57 2000-10-07 05:46:21 itojun Exp $ (LBL)";
+    "@(#) $Header: /tcpdump/master/tcpdump/print-ether.c,v 1.76 2002-12-19 09:39:12 guy Exp $ (LBL)";

 #endif
 
 #ifdef HAVE_CONFIG_H
 #include "config.h"
 #endif
 
 #endif
 
 #ifdef HAVE_CONFIG_H
 #include "config.h"
 #endif
 

-#include <sys/param.h>
-#include <sys/time.h>
-#include <sys/socket.h>
-
-struct mbuf;
-struct rtentry;
-
-#include <netinet/in.h>
+#include <tcpdump-stdinc.h>

 
 #include <stdio.h>
 #include <pcap.h>
 
 #include <stdio.h>
 #include <pcap.h>


@@ -45,11 +38,10 @@ struct rtentry;
 
 #include "ether.h"
 
 
 #include "ether.h"
 

-const u_char *packetp;

 const u_char *snapend;
 
 static inline void
 const u_char *snapend;
 
 static inline void

-ether_print(register const u_char *bp, u_int length)
+ether_hdr_print(register const u_char *bp, u_int length)

 {
        register const struct ether_header *ep;
 
 {
        register const struct ether_header *ep;
 


@@ -67,44 +59,25 @@ ether_print(register const u_char *bp, u_int length)
                             length);
 }
 
                             length);
 }
 

-static u_short extracted_ethertype;
-
-/*
- * This is the top level routine of the printer.  'p' is the points
- * to the ether header of the packet, 'h->tv' is the timestamp,
- * 'h->length' is the length of the packet off the wire, and 'h->caplen'
- * is the number of bytes actually captured.
- */

 void
 void

-ether_if_print(u_char *user, const struct pcap_pkthdr *h, const u_char *p)
+ether_print(const u_char *p, u_int length, u_int caplen)

 {
 {

-       u_int caplen = h->caplen;
-       u_int length = h->len;

        struct ether_header *ep;
        u_short ether_type;
        struct ether_header *ep;
        u_short ether_type;

+       u_short extracted_ethertype;

 
 

-       ts_print(&h->ts);
-
-       if (caplen < sizeof(struct ether_header)) {
+       if (caplen < ETHER_HDRLEN) {

                printf("[|ether]");
                printf("[|ether]");

-               goto out;
+               return;

        }
 
        if (eflag)
        }
 
        if (eflag)

-               ether_print(p, length);
+               ether_hdr_print(p, length);

 
 

-       /*
-        * Some printers want to get back at the ethernet addresses,
-        * and/or check that they're not walking off the end of the packet.
-        * Rather than pass them all the way down, we set these globals.
-        */
-       packetp = p;
-       snapend = p + caplen;
-
-       length -= sizeof(struct ether_header);
-       caplen -= sizeof(struct ether_header);
+       length -= ETHER_HDRLEN;
+       caplen -= ETHER_HDRLEN;

        ep = (struct ether_header *)p;
        ep = (struct ether_header *)p;

-       p += sizeof(struct ether_header);
+       p += ETHER_HDRLEN;

 
        ether_type = ntohs(ep->ether_type);
 
 
        ether_type = ntohs(ep->ether_type);
 


@@ -114,10 +87,11 @@ ether_if_print(u_char *user, const struct pcap_pkthdr *h, const u_char *p)
        extracted_ethertype = 0;
        if (ether_type <= ETHERMTU) {
                /* Try to print the LLC-layer header & higher layers */
        extracted_ethertype = 0;
        if (ether_type <= ETHERMTU) {
                /* Try to print the LLC-layer header & higher layers */

-               if (llc_print(p, length, caplen, ESRC(ep), EDST(ep)) == 0) {
+               if (llc_print(p, length, caplen, ESRC(ep), EDST(ep),
+                   &extracted_ethertype) == 0) {

                        /* ether_type not known, print raw packet */
                        if (!eflag)
                        /* ether_type not known, print raw packet */
                        if (!eflag)

-                               ether_print((u_char *)ep, length);
+                               ether_hdr_print((u_char *)ep, length + ETHER_HDRLEN);

                        if (extracted_ethertype) {
                                printf("(LLC %s) ",
                               etherproto_string(htons(extracted_ethertype)));
                        if (extracted_ethertype) {
                                printf("(LLC %s) ",
                               etherproto_string(htons(extracted_ethertype)));


@@ -125,17 +99,28 @@ ether_if_print(u_char *user, const struct pcap_pkthdr *h, const u_char *p)
                        if (!xflag && !qflag)
                                default_print(p, caplen);
                }
                        if (!xflag && !qflag)
                                default_print(p, caplen);
                }

-       } else if (ether_encap_print(ether_type, p, length, caplen) == 0) {
+       } else if (ether_encap_print(ether_type, p, length, caplen,
+           &extracted_ethertype) == 0) {

                /* ether_type not known, print raw packet */
                if (!eflag)
                /* ether_type not known, print raw packet */
                if (!eflag)

-                       ether_print((u_char *)ep, length + sizeof(*ep));
+                       ether_hdr_print((u_char *)ep, length + ETHER_HDRLEN);

                if (!xflag && !qflag)
                        default_print(p, caplen);
        }
                if (!xflag && !qflag)
                        default_print(p, caplen);
        }

-       if (xflag)
-               default_print(p, caplen);
- out:
-       putchar('\n');
+}
+
+/*
+ * This is the top level routine of the printer.  'p' points
+ * to the ether header of the packet, 'h->ts' is the timestamp,
+ * 'h->length' is the length of the packet off the wire, and 'h->caplen'
+ * is the number of bytes actually captured.
+ */
+u_int
+ether_if_print(const struct pcap_pkthdr *h, const u_char *p)
+{
+       ether_print(p, h->len, h->caplen);
+
+       return (ETHER_HDRLEN);

 }
 
 /*
 }
 
 /*


@@ -144,16 +129,18 @@ ether_if_print(u_char *user, const struct pcap_pkthdr *h, const u_char *p)
  *
  * Returns non-zero if it can do so, zero if the ethertype is unknown.
  *
  *
  * Returns non-zero if it can do so, zero if the ethertype is unknown.
  *

- * Stuffs the ether type into a global for the benefit of lower layers
- * that might want to know what it is.
+ * The Ethernet type code is passed through a pointer; if it was
+ * ETHERTYPE_8021Q, it gets updated to be the Ethernet type of
+ * the 802.1Q payload, for the benefit of lower layers that might
+ * want to know what it is.

  */
 
 int
 ether_encap_print(u_short ethertype, const u_char *p,
  */
 
 int
 ether_encap_print(u_short ethertype, const u_char *p,

-    u_int length, u_int caplen)
+    u_int length, u_int caplen, u_short *extracted_ethertype)

 {
  recurse:
 {
  recurse:

-       extracted_ethertype = ethertype;
+       *extracted_ethertype = ethertype;

 
        switch (ethertype) {
 
 
        switch (ethertype) {
 


@@ -187,11 +174,12 @@ ether_encap_print(u_short ethertype, const u_char *p,
                return (1);
 
        case ETHERTYPE_IPX:
                return (1);
 
        case ETHERTYPE_IPX:

+               printf("(NOV-ETHII) ");

                ipx_print(p, length);
                return (1);
 
        case ETHERTYPE_8021Q:
                ipx_print(p, length);
                return (1);
 
        case ETHERTYPE_8021Q:

-               printf("802.1Q vlan#%d P%d%s",
+               printf("802.1Q vlan#%d P%d%s ",

                       ntohs(*(u_int16_t *)p) & 0xfff,
                       ntohs(*(u_int16_t *)p) >> 13,
                       (ntohs(*(u_int16_t *)p) & 0x1000) ? " CFI" : "");
                       ntohs(*(u_int16_t *)p) & 0xfff,
                       ntohs(*(u_int16_t *)p) >> 13,
                       (ntohs(*(u_int16_t *)p) & 0x1000) ? " CFI" : "");


@@ -202,15 +190,16 @@ ether_encap_print(u_short ethertype, const u_char *p,
                if (ethertype > ETHERMTU)
                        goto recurse;
 
                if (ethertype > ETHERMTU)
                        goto recurse;
 

-               extracted_ethertype = 0;
+               *extracted_ethertype = 0;

 
 

-               if (llc_print(p, length, caplen, p - 18, p - 12) == 0) {
+               if (llc_print(p, length, caplen, p - 18, p - 12,
+                   extracted_ethertype) == 0) {

                        /* ether_type not known, print raw packet */
                        if (!eflag)
                        /* ether_type not known, print raw packet */
                        if (!eflag)

-                               ether_print(p - 18, length + 4);
-                       if (extracted_ethertype) {
+                               ether_hdr_print(p - 18, length + 4);
+                       if (*extracted_ethertype) {

                                printf("(LLC %s) ",
                                printf("(LLC %s) ",

-                              etherproto_string(htons(extracted_ethertype)));
+                              etherproto_string(htons(*extracted_ethertype)));

                        }
                        if (!xflag && !qflag)
                                default_print(p - 18, caplen + 4);
                        }
                        if (!xflag && !qflag)
                                default_print(p - 18, caplen + 4);


@@ -220,8 +209,25 @@ ether_encap_print(u_short ethertype, const u_char *p,
        case ETHERTYPE_PPPOED:
        case ETHERTYPE_PPPOES:
                pppoe_print(p, length);
        case ETHERTYPE_PPPOED:
        case ETHERTYPE_PPPOES:
                pppoe_print(p, length);

-               return (1);
- 
+               return (1);
+
+       case ETHERTYPE_PPP:
+               printf("ppp");
+               if (length) {
+                       printf(": ");
+                       ppp_print(p, length);
+               }
+               return (1);
+
+        case ETHERTYPE_LOOPBACK:
+                printf("loopback");
+                return (1);
+
+       case ETHERTYPE_MPLS:
+       case ETHERTYPE_MPLS_MULTI:
+               mpls_print(p, length);
+               return (1);
+

        case ETHERTYPE_LAT:
        case ETHERTYPE_SCA:
        case ETHERTYPE_MOPRC:
        case ETHERTYPE_LAT:
        case ETHERTYPE_SCA:
        case ETHERTYPE_MOPRC: