Handle very large -f files by rejecting them.

[tcpdump] / print-chdlc.c

diff --git a/print-chdlc.c b/print-chdlc.c
index aab55a5e4de6be41bf4491845b151ff9a8558232..24acfbd2e86c94ed85983d01181740831fa1f1e1 100644 (file)
--- a/print-chdlc.c
+++ b/print-chdlc.c
@@ -19,13 +19,15 @@
  * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE.
  */
 
+/* \summary: Cisco HDLC printer */
+
 #ifdef HAVE_CONFIG_H
 #include "config.h"
 #endif
 
-#include <tcpdump-stdinc.h>
+#include <netdissect-stdinc.h>
 
-#include "interface.h"
+#include "netdissect.h"
 #include "addrtoname.h"
 #include "ethertype.h"
 #include "extract.h"
@@ -44,20 +46,18 @@ static const struct tok chdlc_cast_values[] = {
 u_int
 chdlc_if_print(netdissect_options *ndo, const struct pcap_pkthdr *h, register const u_char *p)
 {
-       register u_int length = h->len;
-       register u_int caplen = h->caplen;
-
-       if (caplen < CHDLC_HDRLEN) {
-               ND_PRINT((ndo, "[|chdlc]"));
-               return (caplen);
-       }
-        return (chdlc_print(ndo, p,length));
+       return chdlc_print(ndo, p, h->len);
 }
 
 u_int
-chdlc_print(netdissect_options *ndo, register const u_char *p, u_int length) {
+chdlc_print(netdissect_options *ndo, register const u_char *p, u_int length)
+{
        u_int proto;
+       const u_char *bp = p;
 
+       if (length < CHDLC_HDRLEN)
+               goto trunc;
+       ND_TCHECK2(*p, CHDLC_HDRLEN);
        proto = EXTRACT_16BITS(&p[2]);
        if (ndo->ndo_eflag) {
                 ND_PRINT((ndo, "%s, ethertype %s (0x%04x), length %u: ",
@@ -74,11 +74,9 @@ chdlc_print(netdissect_options *ndo, register const u_char *p, u_int length) {
        case ETHERTYPE_IP:
                ip_print(ndo, p, length);
                break;
-#ifdef INET6
        case ETHERTYPE_IPV6:
                ip6_print(ndo, p, length);
                break;
-#endif
        case CHDLC_TYPE_SLARP:
                chdlc_slarp_print(ndo, p, length);
                break;
@@ -93,12 +91,15 @@ chdlc_print(netdissect_options *ndo, register const u_char *p, u_int length) {
                break;
         case ETHERTYPE_ISO:
                 /* is the fudge byte set ? lets verify by spotting ISO headers */
+                if (length < 2)
+                    goto trunc;
+                ND_TCHECK_16BITS(p);
                 if (*(p+1) == 0x81 ||
                     *(p+1) == 0x82 ||
                     *(p+1) == 0x83)
-                    isoclns_print(p+1, length-1, length-1);
+                    isoclns_print(ndo, p + 1, length - 1);
                 else
-                    isoclns_print(p, length, length);
+                    isoclns_print(ndo, p, length);
                 break;
        default:
                 if (!ndo->ndo_eflag)
@@ -107,25 +108,29 @@ chdlc_print(netdissect_options *ndo, register const u_char *p, u_int length) {
        }
 
        return (CHDLC_HDRLEN);
+
+trunc:
+       ND_PRINT((ndo, "[|chdlc]"));
+       return ndo->ndo_snapend - bp;
 }
 
 /*
  * The fixed-length portion of a SLARP packet.
  */
 struct cisco_slarp {
-       u_int8_t code[4];
+       uint8_t code[4];
 #define SLARP_REQUEST  0
 #define SLARP_REPLY    1
 #define SLARP_KEEPALIVE        2
        union {
                struct {
-                       u_int8_t addr[4];
-                       u_int8_t mask[4];
+                       uint8_t addr[4];
+                       uint8_t mask[4];
                } addr;
                struct {
-                       u_int8_t myseq[4];
-                       u_int8_t yourseq[4];
-                       u_int8_t rel[2];
+                       uint8_t myseq[4];
+                       uint8_t yourseq[4];
+                       uint8_t rel[2];
                } keep;
        } un;
 };
@@ -160,8 +165,8 @@ chdlc_slarp_print(netdissect_options *ndo, const u_char *cp, u_int length)
                break;
        case SLARP_REPLY:
                ND_PRINT((ndo, "reply %s/%s",
-                       ipaddr_string(&slarp->un.addr.addr),
-                       ipaddr_string(&slarp->un.addr.mask)));
+                       ipaddr_string(ndo, &slarp->un.addr.addr),
+                       ipaddr_string(ndo, &slarp->un.addr.mask)));
                break;
        case SLARP_KEEPALIVE:
                ND_PRINT((ndo, "keepalive: mineseen=0x%08x, yourseen=0x%08x, reliability=0x%04x",
@@ -171,8 +176,7 @@ chdlc_slarp_print(netdissect_options *ndo, const u_char *cp, u_int length)
 
                 if (length >= SLARP_MAX_LEN) { /* uptime-stamp is optional */
                         cp += SLARP_MIN_LEN;
-                        if (!ND_TTEST2(*cp, 4))
-                                goto trunc;
+                        ND_TCHECK2(*cp, 4);
                         sec = EXTRACT_32BITS(cp) / 1000;
                         min = sec / 60; sec -= min * 60;
                         hrs = min / 60; min -= hrs * 60;