__RCSID("$NetBSD: print-tcp.c,v 1.8 2007/07/24 11:53:48 drochner Exp $");
#endif
-#ifdef HAVE_CONFIG_H
#include <config.h>
-#endif
#include "netdissect-stdinc.h"
#include <stdlib.h>
#include <string.h>
+#define ND_LONGJMP_FROM_TCHECK
#include "netdissect.h"
#include "addrtoname.h"
#include "extract.h"
+#include "diag-control.h"
+
#include "tcp.h"
#include "ip.h"
static void print_tcp_rst_data(netdissect_options *, const u_char *sp, u_int length);
static void print_tcp_fastopen_option(netdissect_options *ndo, const u_char *cp,
- u_int datalen, int exp);
+ u_int datalen);
#define MAX_RST_DATA_LEN 30
struct tha {
- struct in_addr src;
- struct in_addr dst;
+ nd_ipv4 src;
+ nd_ipv4 dst;
u_int port;
};
};
struct tha6 {
- struct in6_addr src;
- struct in6_addr dst;
+ nd_ipv6 src;
+ nd_ipv6 dst;
u_int port;
};
#define TSEQ_HASHSIZE 919
-/* These tcp optinos do not have the size octet */
+/* These tcp options do not have the size octet */
#define ZEROLENOPT(o) ((o) == TCPOPT_EOL || (o) == TCPOPT_NOP)
static struct tcp_seq_hash tcp_seq_hash4[TSEQ_HASHSIZE];
static struct tcp_seq_hash6 tcp_seq_hash6[TSEQ_HASHSIZE];
-static const struct tok tcp_flag_values[] = {
+const struct tok tcp_flag_values[] = {
{ TH_FIN, "F" },
{ TH_SYN, "S" },
{ TH_RST, "R" },
{ TH_URG, "U" },
{ TH_ECNECHO, "E" },
{ TH_CWR, "W" },
+ { TH_AE, "e" },
{ 0, NULL }
};
{ TCPOPT_TIMESTAMP, "TS" },
{ TCPOPT_CC, "cc" },
{ TCPOPT_CCNEW, "ccnew" },
- { TCPOPT_CCECHO, "" },
+ { TCPOPT_CCECHO, "ccecho" },
{ TCPOPT_SIGNATURE, "md5" },
{ TCPOPT_SCPS, "scps" },
{ TCPOPT_UTO, "uto" },
{ 0, NULL }
};
-static int
+static uint16_t
tcp_cksum(netdissect_options *ndo,
const struct ip *ip,
const struct tcphdr *tp,
u_int len)
{
- return nextproto4_cksum(ndo, ip, (const uint8_t *)tp, len, len,
- IPPROTO_TCP);
+ return nextproto4_cksum(ndo, ip, (const uint8_t *)tp, len, len,
+ IPPROTO_TCP);
}
-static int
+static uint16_t
tcp6_cksum(netdissect_options *ndo,
const struct ip6_hdr *ip6,
const struct tcphdr *tp,
u_int len)
{
- return nextproto6_cksum(ndo, ip6, (const uint8_t *)tp, len, len,
- IPPROTO_TCP);
+ return nextproto6_cksum(ndo, ip6, (const uint8_t *)tp, len, len,
+ IPPROTO_TCP);
}
void
{
const struct tcphdr *tp;
const struct ip *ip;
- u_char flags;
+ uint16_t flags;
u_int hlen;
char ch;
uint16_t sport, dport, win, urp;
uint16_t magic;
int rev;
const struct ip6_hdr *ip6;
+ u_int header_len; /* Header length in bytes */
- ndo->ndo_protocol = "tcp";
+ ndo->ndo_protocol = "tcp";
tp = (const struct tcphdr *)bp;
ip = (const struct ip *)bp2;
if (IP_V(ip) == 6)
ip6 = NULL;
ch = '\0';
if (!ND_TTEST_2(tp->th_dport)) {
- if (ip6) {
+ if (ip6) {
+ ND_PRINT("%s > %s:",
+ GET_IP6ADDR_STRING(ip6->ip6_src),
+ GET_IP6ADDR_STRING(ip6->ip6_dst));
+ } else {
ND_PRINT("%s > %s:",
- ip6addr_string(ndo, ip6->ip6_src),
- ip6addr_string(ndo, ip6->ip6_dst));
- } else {
- ND_PRINT("%s > %s:",
- ipaddr_string(ndo, ip->ip_src),
- ipaddr_string(ndo, ip->ip_dst));
+ GET_IPADDR_STRING(ip->ip_src),
+ GET_IPADDR_STRING(ip->ip_dst));
}
- nd_print_trunc(ndo);
- return;
+ nd_trunc_longjmp(ndo);
}
- sport = EXTRACT_BE_U_2(tp->th_sport);
- dport = EXTRACT_BE_U_2(tp->th_dport);
+ sport = GET_BE_U_2(tp->th_sport);
+ dport = GET_BE_U_2(tp->th_dport);
if (ip6) {
- if (EXTRACT_U_1(ip6->ip6_nxt) == IPPROTO_TCP) {
+ if (GET_U_1(ip6->ip6_nxt) == IPPROTO_TCP) {
ND_PRINT("%s.%s > %s.%s: ",
- ip6addr_string(ndo, ip6->ip6_src),
- tcpport_string(ndo, sport),
- ip6addr_string(ndo, ip6->ip6_dst),
- tcpport_string(ndo, dport));
+ GET_IP6ADDR_STRING(ip6->ip6_src),
+ tcpport_string(ndo, sport),
+ GET_IP6ADDR_STRING(ip6->ip6_dst),
+ tcpport_string(ndo, dport));
} else {
ND_PRINT("%s > %s: ",
- tcpport_string(ndo, sport), tcpport_string(ndo, dport));
+ tcpport_string(ndo, sport), tcpport_string(ndo, dport));
}
} else {
- if (EXTRACT_U_1(ip->ip_p) == IPPROTO_TCP) {
+ if (GET_U_1(ip->ip_p) == IPPROTO_TCP) {
ND_PRINT("%s.%s > %s.%s: ",
- ipaddr_string(ndo, ip->ip_src),
- tcpport_string(ndo, sport),
- ipaddr_string(ndo, ip->ip_dst),
- tcpport_string(ndo, dport));
+ GET_IPADDR_STRING(ip->ip_src),
+ tcpport_string(ndo, sport),
+ GET_IPADDR_STRING(ip->ip_dst),
+ tcpport_string(ndo, dport));
} else {
ND_PRINT("%s > %s: ",
- tcpport_string(ndo, sport), tcpport_string(ndo, dport));
+ tcpport_string(ndo, sport), tcpport_string(ndo, dport));
}
}
- ND_TCHECK_SIZE(tp);
-
hlen = TH_OFF(tp) * 4;
if (hlen < sizeof(*tp)) {
- ND_PRINT(" tcp %u [bad hdr length %u - too short, < %lu]",
- length - hlen, hlen, (unsigned long)sizeof(*tp));
- return;
+ ND_PRINT(" tcp %u [bad hdr length %u - too short, < %zu]",
+ length - hlen, hlen, sizeof(*tp));
+ goto invalid;
}
- seq = EXTRACT_BE_U_4(tp->th_seq);
- ack = EXTRACT_BE_U_4(tp->th_ack);
- win = EXTRACT_BE_U_2(tp->th_win);
- urp = EXTRACT_BE_U_2(tp->th_urp);
+ seq = GET_BE_U_4(tp->th_seq);
+ ack = GET_BE_U_4(tp->th_ack);
+ win = GET_BE_U_2(tp->th_win);
+ urp = GET_BE_U_2(tp->th_urp);
if (ndo->ndo_qflag) {
ND_PRINT("tcp %u", length - hlen);
if (hlen > length) {
ND_PRINT(" [bad hdr length %u - too long, > %u]",
- hlen, length);
+ hlen, length);
+ goto invalid;
}
return;
}
- flags = EXTRACT_U_1(tp->th_flags);
+ flags = tcp_get_flags(tp);
ND_PRINT("Flags [%s]", bittok2str_nosep(tcp_flag_values, "none", flags));
if (!ndo->ndo_Sflag && (flags & TH_ACK)) {
if (!th->nxt || (flags & TH_SYN)) {
/* didn't find it or new conversation */
- /* calloc() return used by the 'tcp_seq_hash6'
- hash table: do not free() */
+ /* calloc() return used by the 'tcp_seq_hash6'
+ hash table: do not free() */
if (th->nxt == NULL) {
th->nxt = (struct tcp_seq_hash6 *)
calloc(1, sizeof(*th));
if (th->nxt == NULL)
(*ndo->ndo_error)(ndo,
- S_ERR_ND_MEM_ALLOC,
- "tcp_print: calloc");
+ S_ERR_ND_MEM_ALLOC,
+ "%s: calloc", __func__);
}
th->addr = tha;
if (rev)
if (!th->nxt || (flags & TH_SYN)) {
/* didn't find it or new conversation */
- /* calloc() return used by the 'tcp_seq_hash4'
- hash table: do not free() */
+ /* calloc() return used by the 'tcp_seq_hash4'
+ hash table: do not free() */
if (th->nxt == NULL) {
th->nxt = (struct tcp_seq_hash *)
calloc(1, sizeof(*th));
if (th->nxt == NULL)
(*ndo->ndo_error)(ndo,
- S_ERR_ND_MEM_ALLOC,
- "tcp_print: calloc");
+ S_ERR_ND_MEM_ALLOC,
+ "%s: calloc", __func__);
}
th->addr = tha;
if (rev)
}
if (hlen > length) {
ND_PRINT(" [bad hdr length %u - too long, > %u]",
- hlen, length);
- return;
+ hlen, length);
+ goto invalid;
}
if (ndo->ndo_vflag && !ndo->ndo_Kflag && !fragmented) {
if (IP_V(ip) == 4) {
if (ND_TTEST_LEN(tp->th_sport, length)) {
sum = tcp_cksum(ndo, ip, tp, length);
- tcp_sum = EXTRACT_BE_U_2(tp->th_sum);
+ tcp_sum = GET_BE_U_2(tp->th_sum);
ND_PRINT(", cksum 0x%04x", tcp_sum);
if (sum != 0)
else
ND_PRINT(" (correct)");
}
- } else if (IP_V(ip) == 6 && ip6->ip6_plen) {
+ } else if (IP_V(ip) == 6) {
if (ND_TTEST_LEN(tp->th_sport, length)) {
sum = tcp6_cksum(ndo, ip6, tp, length);
- tcp_sum = EXTRACT_BE_U_2(tp->th_sum);
+ tcp_sum = GET_BE_U_2(tp->th_sum);
ND_PRINT(", cksum 0x%04x", tcp_sum);
if (sum != 0)
}
}
- if (flags & TH_ACK) {
+ if (flags & TH_ACK)
ND_PRINT(", ack %u", ack);
- }
+ else
+ if (ndo->ndo_vflag > 1 && ack != 0)
+ ND_PRINT(", [ack %u != 0 while ACK flag not set]", ack);
ND_PRINT(", win %u", win);
if (flags & TH_URG)
ND_PRINT(", urg %u", urp);
+ else
+ if (ndo->ndo_vflag > 1 && urp != 0)
+ ND_PRINT(", [urg %u != 0 while URG flag not set]", urp);
/*
* Handle any options.
*/
hlen -= sizeof(*tp);
cp = (const u_char *)tp + sizeof(*tp);
ND_PRINT(", options [");
- while (hlen > 0) {
+ while (hlen != 0) {
if (ch != '\0')
ND_PRINT("%c", ch);
- ND_TCHECK_1(cp);
- opt = EXTRACT_U_1(cp);
+ opt = GET_U_1(cp);
cp++;
if (ZEROLENOPT(opt))
len = 1;
else {
- ND_TCHECK_1(cp);
- len = EXTRACT_U_1(cp);
+ len = GET_U_1(cp);
cp++; /* total including type, len */
if (len < 2 || len > hlen)
goto bad;
datalen = 0;
/* Bail if "l" bytes of data are not left or were not captured */
-#define LENCHECK(l) { if ((l) > hlen) goto bad; ND_TCHECK_LEN(cp, l); }
+#define LENCHECK(l) { if ((l) > hlen) goto bad; }
ND_PRINT("%s", tok2str(tcp_option_values, "unknown-%u", opt));
case TCPOPT_MAXSEG:
datalen = 2;
LENCHECK(datalen);
- ND_PRINT(" %u", EXTRACT_BE_U_2(cp));
+ ND_PRINT(" %u", GET_BE_U_2(cp));
break;
case TCPOPT_WSCALE:
datalen = 1;
LENCHECK(datalen);
- ND_PRINT(" %u", EXTRACT_U_1(cp));
+ ND_PRINT(" %u", GET_U_1(cp));
break;
case TCPOPT_SACK:
ND_PRINT(" %u ", datalen / 8);
for (i = 0; i < datalen; i += 8) {
LENCHECK(i + 4);
- s = EXTRACT_BE_U_4(cp + i);
+ s = GET_BE_U_4(cp + i);
LENCHECK(i + 8);
- e = EXTRACT_BE_U_4(cp + i + 4);
+ e = GET_BE_U_4(cp + i + 4);
if (rev) {
s -= thseq;
e -= thseq;
*/
datalen = 4;
LENCHECK(datalen);
- ND_PRINT(" %u", EXTRACT_BE_U_4(cp));
+ ND_PRINT(" %u", GET_BE_U_4(cp));
break;
case TCPOPT_TIMESTAMP:
datalen = 8;
LENCHECK(datalen);
ND_PRINT(" val %u ecr %u",
- EXTRACT_BE_U_4(cp),
- EXTRACT_BE_U_4(cp + 4));
+ GET_BE_U_4(cp),
+ GET_BE_U_4(cp + 4));
break;
case TCPOPT_SIGNATURE:
datalen = TCP_SIGLEN;
LENCHECK(datalen);
+ ND_TCHECK_LEN(cp, datalen);
ND_PRINT(" ");
#ifdef HAVE_LIBCRYPTO
switch (tcp_verify_signature(ndo, ip, tp,
break;
case SIGNATURE_INVALID:
- ND_PRINT("invalid");
+ nd_print_invalid(ndo);
break;
case CANT_CHECK_SIGNATURE:
ND_PRINT("can't check - ");
for (i = 0; i < TCP_SIGLEN; ++i)
- ND_PRINT("%02x", EXTRACT_U_1(cp + i));
+ ND_PRINT("%02x",
+ GET_U_1(cp + i));
break;
}
#else
for (i = 0; i < TCP_SIGLEN; ++i)
- ND_PRINT("%02x", EXTRACT_U_1(cp + i));
+ ND_PRINT("%02x", GET_U_1(cp + i));
#endif
break;
case TCPOPT_SCPS:
datalen = 2;
LENCHECK(datalen);
- ND_PRINT(" cap %02x id %u", EXTRACT_U_1(cp), EXTRACT_U_1(cp + 1));
+ ND_PRINT(" cap %02x id %u", GET_U_1(cp),
+ GET_U_1(cp + 1));
break;
case TCPOPT_TCPAO:
* at this point.)
*/
if (datalen < 2) {
- ND_PRINT(" invalid");
+ nd_print_invalid(ndo);
} else {
LENCHECK(1);
- ND_PRINT(" keyid %u", EXTRACT_U_1(cp));
+ ND_PRINT(" keyid %u", GET_U_1(cp));
LENCHECK(2);
- ND_PRINT(" rnextkeyid %u", EXTRACT_U_1(cp + 1));
+ ND_PRINT(" rnextkeyid %u",
+ GET_U_1(cp + 1));
if (datalen > 2) {
ND_PRINT(" mac 0x");
for (i = 2; i < datalen; i++) {
LENCHECK(i + 1);
- ND_PRINT("%02x", EXTRACT_U_1(cp + i));
+ ND_PRINT("%02x",
+ GET_U_1(cp + i));
}
}
}
case TCPOPT_UTO:
datalen = 2;
LENCHECK(datalen);
- utoval = EXTRACT_BE_U_2(cp);
+ utoval = GET_BE_U_2(cp);
ND_PRINT(" 0x%x", utoval);
if (utoval & 0x0001)
utoval = (utoval >> 1) * 60;
break;
case TCPOPT_MPTCP:
+ {
+ const u_char *snapend_save;
+ int ret;
+
datalen = len - 2;
LENCHECK(datalen);
- if (!mptcp_print(ndo, cp-2, len, flags))
+ /* FIXME: Proof-read mptcp_print() and if it
+ * always covers all bytes when it returns 1,
+ * only do ND_TCHECK_LEN() if it returned 0.
+ */
+ ND_TCHECK_LEN(cp, datalen);
+ /* Update the snapend to the end of the option
+ * before calling mptcp_print(). Some options
+ * (MPTCP or others) may be present after a
+ * MPTCP option. This prevents that, in
+ * mptcp_print(), the remaining length < the
+ * remaining caplen.
+ */
+ snapend_save = ndo->ndo_snapend;
+ ndo->ndo_snapend = ND_MIN(cp - 2 + len,
+ ndo->ndo_snapend);
+ ret = mptcp_print(ndo, cp - 2, len, flags);
+ ndo->ndo_snapend = snapend_save;
+ if (!ret)
goto bad;
break;
+ }
case TCPOPT_FASTOPEN:
datalen = len - 2;
LENCHECK(datalen);
+ ND_TCHECK_LEN(cp, datalen);
ND_PRINT(" ");
- print_tcp_fastopen_option(ndo, cp, datalen, FALSE);
+ print_tcp_fastopen_option(ndo, cp, datalen);
break;
case TCPOPT_EXPERIMENT2:
datalen = len - 2;
LENCHECK(datalen);
+ ND_TCHECK_LEN(cp, datalen);
if (datalen < 2)
goto bad;
/* RFC6994 */
- magic = EXTRACT_BE_U_2(cp);
+ magic = GET_BE_U_2(cp);
ND_PRINT("-");
switch(magic) {
case 0xf989: /* TCP Fast Open RFC 7413 */
- print_tcp_fastopen_option(ndo, cp + 2, datalen - 2, TRUE);
+ ND_PRINT("tfo");
+ print_tcp_fastopen_option(ndo, cp + 2, datalen - 2);
break;
default:
ND_PRINT(" 0x");
for (i = 0; i < datalen; ++i) {
LENCHECK(i + 1);
- ND_PRINT("%02x", EXTRACT_U_1(cp + i));
+ ND_PRINT("%02x", GET_U_1(cp + i));
}
break;
}
hlen -= datalen;
/* Check specification against observed length */
- ++datalen; /* option octet */
+ ++datalen; /* option octet */
if (!ZEROLENOPT(opt))
- ++datalen; /* size octet */
+ ++datalen; /* size octet */
if (datalen != len)
ND_PRINT("[len %u]", len);
ch = ',';
*/
ND_PRINT(", length %u", length);
- if (length <= 0)
+ if (length == 0)
return;
/*
* Decode payload if necessary.
*/
- bp += TH_OFF(tp) * 4;
- if ((flags & TH_RST) && ndo->ndo_vflag) {
- print_tcp_rst_data(ndo, bp, length);
+ header_len = TH_OFF(tp) * 4;
+ /*
+ * Do a bounds check before decoding the payload.
+ * At least the header data is required.
+ */
+ if (!ND_TTEST_LEN(bp, header_len)) {
+ ND_PRINT(" [remaining caplen(%u) < header length(%u)]",
+ ND_BYTES_AVAILABLE_AFTER(bp), header_len);
+ nd_trunc_longjmp(ndo);
+ }
+ bp += header_len;
+ if (flags & TH_RST) {
+ if (ndo->ndo_vflag)
+ print_tcp_rst_data(ndo, bp, length);
+ else
+ ND_TCHECK_LEN(bp, length);
return;
}
case PT_RESP:
resp_print(ndo, bp, length);
break;
+ case PT_DOMAIN:
+ /* over_tcp: TRUE, is_mdns: FALSE */
+ domain_print(ndo, bp, length, TRUE, FALSE);
+ break;
}
return;
}
- if (IS_SRC_OR_DST_PORT(TELNET_PORT)) {
+ if (IS_SRC_OR_DST_PORT(FTP_PORT)) {
+ ND_PRINT(": ");
+ ftp_print(ndo, bp, length);
+ } else if (IS_SRC_OR_DST_PORT(SSH_PORT)) {
+ ssh_print(ndo, bp, length);
+ } else if (IS_SRC_OR_DST_PORT(TELNET_PORT)) {
telnet_print(ndo, bp, length);
} else if (IS_SRC_OR_DST_PORT(SMTP_PORT)) {
ND_PRINT(": ");
smtp_print(ndo, bp, length);
} else if (IS_SRC_OR_DST_PORT(WHOIS_PORT)) {
ND_PRINT(": ");
- txtproto_print(ndo, bp, length, "whois", NULL, 0); /* RFC 3912 */
- } else if (IS_SRC_OR_DST_PORT(BGP_PORT))
+ whois_print(ndo, bp, length);
+ } else if (IS_SRC_OR_DST_PORT(NAMESERVER_PORT)) {
+ /* over_tcp: TRUE, is_mdns: FALSE */
+ domain_print(ndo, bp, length, TRUE, FALSE);
+ } else if (IS_SRC_OR_DST_PORT(HTTP_PORT)) {
+ ND_PRINT(": ");
+ http_print(ndo, bp, length);
+#ifdef ENABLE_SMB
+ } else if (IS_SRC_OR_DST_PORT(NETBIOS_SSN_PORT)) {
+ nbt_tcp_print(ndo, bp, length);
+#endif
+ } else if (IS_SRC_OR_DST_PORT(BGP_PORT)) {
bgp_print(ndo, bp, length);
- else if (IS_SRC_OR_DST_PORT(PPTP_PORT))
+ } else if (IS_SRC_OR_DST_PORT(RPKI_RTR_PORT)) {
+ rpki_rtr_print(ndo, bp, length);
+#ifdef ENABLE_SMB
+ } else if (IS_SRC_OR_DST_PORT(SMB_PORT)) {
+ smb_tcp_print(ndo, bp, length);
+#endif
+ } else if (IS_SRC_OR_DST_PORT(RTSP_PORT)) {
+ ND_PRINT(": ");
+ rtsp_print(ndo, bp, length);
+ } else if (IS_SRC_OR_DST_PORT(MSDP_PORT)) {
+ msdp_print(ndo, bp, length);
+ } else if (IS_SRC_OR_DST_PORT(LDP_PORT)) {
+ ldp_print(ndo, bp, length);
+ } else if (IS_SRC_OR_DST_PORT(PPTP_PORT))
pptp_print(ndo, bp);
else if (IS_SRC_OR_DST_PORT(REDIS_PORT))
resp_print(ndo, bp, length);
-#ifdef ENABLE_SMB
- else if (IS_SRC_OR_DST_PORT(NETBIOS_SSN_PORT))
- nbt_tcp_print(ndo, bp, length);
- else if (IS_SRC_OR_DST_PORT(SMB_PORT))
- smb_tcp_print(ndo, bp, length);
-#endif
else if (IS_SRC_OR_DST_PORT(BEEP_PORT))
beep_print(ndo, bp, length);
- else if (IS_SRC_OR_DST_PORT(OPENFLOW_PORT_OLD) || IS_SRC_OR_DST_PORT(OPENFLOW_PORT_IANA))
+ else if (IS_SRC_OR_DST_PORT(OPENFLOW_PORT_OLD) || IS_SRC_OR_DST_PORT(OPENFLOW_PORT_IANA)) {
openflow_print(ndo, bp, length);
- else if (IS_SRC_OR_DST_PORT(FTP_PORT)) {
- ND_PRINT(": ");
- ftp_print(ndo, bp, length);
- } else if (IS_SRC_OR_DST_PORT(HTTP_PORT) || IS_SRC_OR_DST_PORT(HTTP_PORT_ALT)) {
+ } else if (IS_SRC_OR_DST_PORT(HTTP_PORT_ALT)) {
ND_PRINT(": ");
http_print(ndo, bp, length);
- } else if (IS_SRC_OR_DST_PORT(RTSP_PORT) || IS_SRC_OR_DST_PORT(RTSP_PORT_ALT)) {
+ } else if (IS_SRC_OR_DST_PORT(RTSP_PORT_ALT)) {
ND_PRINT(": ");
rtsp_print(ndo, bp, length);
- } else if (length > 2 &&
- (IS_SRC_OR_DST_PORT(NAMESERVER_PORT))) {
- /*
- * TCP DNS query has 2byte length at the head.
- * XXX packet could be unaligned, it can go strange
- */
- domain_print(ndo, bp + 2, length - 2, 0);
- } else if (IS_SRC_OR_DST_PORT(MSDP_PORT)) {
- msdp_print(ndo, bp, length);
- } else if (IS_SRC_OR_DST_PORT(RPKI_RTR_PORT)) {
- rpki_rtr_print(ndo, bp, length);
- }
- else if (length > 0 && (IS_SRC_OR_DST_PORT(LDP_PORT))) {
- ldp_print(ndo, bp, length);
- }
- else if ((IS_SRC_OR_DST_PORT(NFS_PORT)) &&
- length >= 4 && ND_TTEST_4(bp)) {
+ } else if ((IS_SRC_OR_DST_PORT(NFS_PORT)) &&
+ length >= 4) {
/*
* If data present, header length valid, and NFS port used,
* assume NFS.
const struct sunrpc_msg *rp;
enum sunrpc_msg_type direction;
- fraglen = EXTRACT_BE_U_4(bp) & 0x7FFFFFFF;
+ fraglen = GET_BE_U_4(bp) & 0x7FFFFFFF;
if (fraglen > (length) - 4)
fraglen = (length) - 4;
rp = (const struct sunrpc_msg *)(bp + 4);
if (ND_TTEST_4(rp->rm_direction)) {
- direction = (enum sunrpc_msg_type) EXTRACT_BE_U_4(rp->rm_direction);
+ direction = (enum sunrpc_msg_type) GET_BE_U_4(rp->rm_direction);
if (dport == NFS_PORT && direction == SUNRPC_CALL) {
ND_PRINT(": NFS request xid %u ",
- EXTRACT_BE_U_4(rp->rm_xid));
+ GET_BE_U_4(rp->rm_xid));
nfsreq_noaddr_print(ndo, (const u_char *)rp, fraglen, (const u_char *)ip);
return;
}
if (sport == NFS_PORT && direction == SUNRPC_REPLY) {
ND_PRINT(": NFS reply xid %u ",
- EXTRACT_BE_U_4(rp->rm_xid));
+ GET_BE_U_4(rp->rm_xid));
nfsreply_noaddr_print(ndo, (const u_char *)rp, fraglen, (const u_char *)ip);
return;
}
}
return;
- bad:
+bad:
ND_PRINT("[bad opt]");
if (ch != '\0')
ND_PRINT("]");
return;
- trunc:
- nd_print_trunc(ndo);
- if (ch != '\0')
- ND_PRINT(">");
+invalid:
+ nd_print_invalid(ndo);
}
/*
print_tcp_rst_data(netdissect_options *ndo,
const u_char *sp, u_int length)
{
- int c;
-
- ND_PRINT(ND_TTEST_LEN(sp, length) ? " [RST" : " [!RST");
- if (length > MAX_RST_DATA_LEN) {
- length = MAX_RST_DATA_LEN; /* can use -X for longer */
+ ND_PRINT(" [RST");
+ if (length > MAX_RST_DATA_LEN) /* can use -X for longer */
ND_PRINT("+"); /* indicate we truncate */
- }
ND_PRINT(" ");
- while (length-- && sp < ndo->ndo_snapend) {
- c = EXTRACT_U_1(sp);
- sp++;
- fn_print_char(ndo, c);
- }
+ nd_printjn(ndo, sp, ND_MIN(length, MAX_RST_DATA_LEN));
ND_PRINT("]");
+ ND_TCHECK_LEN(sp, length);
}
static void
print_tcp_fastopen_option(netdissect_options *ndo, const u_char *cp,
- u_int datalen, int exp)
+ u_int datalen)
{
u_int i;
- if (exp)
- ND_PRINT("tfo");
-
if (datalen == 0) {
/* Fast Open Cookie Request */
ND_PRINT(" cookiereq");
} else {
/* Fast Open Cookie */
if (datalen % 2 != 0 || datalen < 4 || datalen > 16) {
- ND_PRINT(" invalid");
+ nd_print_invalid(ndo);
} else {
ND_PRINT(" cookie ");
for (i = 0; i < datalen; ++i)
- ND_PRINT("%02x", EXTRACT_U_1(cp + i));
+ ND_PRINT("%02x", GET_U_1(cp + i));
}
}
}
#ifdef HAVE_LIBCRYPTO
-USES_APPLE_DEPRECATED_API
+DIAG_OFF_DEPRECATION
static int
tcp_verify_signature(netdissect_options *ndo,
const struct ip *ip, const struct tcphdr *tp,
uint32_t len32;
uint8_t nxt;
- if (data + length > ndo->ndo_snapend) {
- ND_PRINT("snaplen too short, ");
- return (CANT_CHECK_SIGNATURE);
- }
+ if (!ND_TTEST_LEN(data, length)) {
+ ND_PRINT("snaplen too short, ");
+ return (CANT_CHECK_SIGNATURE);
+ }
tp1 = *tp;
if (ndo->ndo_sigsecret == NULL) {
- ND_PRINT("shared secret not supplied with -M, ");
+ ND_PRINT("shared secret not supplied with -M, ");
return (CANT_CHECK_SIGNATURE);
}
MD5_Update(&ctx, (const char *)&ip->ip_dst, sizeof(ip->ip_dst));
MD5_Update(&ctx, (const char *)&zero_proto, sizeof(zero_proto));
MD5_Update(&ctx, (const char *)&ip->ip_p, sizeof(ip->ip_p));
- tlen = EXTRACT_BE_U_2(ip->ip_len) - IP_HL(ip) * 4;
+ tlen = GET_BE_U_2(ip->ip_len) - IP_HL(ip) * 4;
tlen = htons(tlen);
MD5_Update(&ctx, (const char *)&tlen, sizeof(tlen));
} else if (IP_V(ip) == 6) {
ip6 = (const struct ip6_hdr *)ip;
MD5_Update(&ctx, (const char *)&ip6->ip6_src, sizeof(ip6->ip6_src));
MD5_Update(&ctx, (const char *)&ip6->ip6_dst, sizeof(ip6->ip6_dst));
- len32 = htonl(EXTRACT_BE_U_2(ip6->ip6_plen));
+ len32 = htonl(GET_BE_U_2(ip6->ip6_plen));
MD5_Update(&ctx, (const char *)&len32, sizeof(len32));
nxt = 0;
MD5_Update(&ctx, (const char *)&nxt, sizeof(nxt));
nxt = IPPROTO_TCP;
MD5_Update(&ctx, (const char *)&nxt, sizeof(nxt));
} else {
- ND_PRINT("IP version not 4 or 6, ");
+ ND_PRINT("IP version not 4 or 6, ");
return (CANT_CHECK_SIGNATURE);
}
else
return (SIGNATURE_INVALID);
}
-USES_APPLE_RST
+DIAG_ON_DEPRECATION
#endif /* HAVE_LIBCRYPTO */
projects / tcpdump / blobdiff