]> The Tcpdump Group git mirrors - tcpdump/blobdiff - print-pim.c
Handle very large -f files by rejecting them.
[tcpdump] / print-pim.c
index 2eb795aa276d48067e0bde96e9f6fcd30932f83e..9c8ca547faba1912fb24c41b44f01a53f0a684d2 100644 (file)
  * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE.
  */
 
-#ifndef lint
-static const char rcsid[] =
-    "@(#) $Header: /tcpdump/master/tcpdump/print-pim.c,v 1.9 1999-10-30 05:11:19 itojun Exp $ (LBL)";
+/* \summary: Protocol Independent Multicast (PIM) printer */
+
+#ifdef HAVE_CONFIG_H
+#include "config.h"
 #endif
 
-#include <sys/param.h>
-#include <sys/time.h>
-#include <sys/socket.h>
+#include <netdissect-stdinc.h>
+
+#include "netdissect.h"
+#include "addrtoname.h"
+#include "extract.h"
+
+#include "ip.h"
+#include "ip6.h"
+#include "ipproto.h"
+
+#define PIMV1_TYPE_QUERY           0
+#define PIMV1_TYPE_REGISTER        1
+#define PIMV1_TYPE_REGISTER_STOP   2
+#define PIMV1_TYPE_JOIN_PRUNE      3
+#define PIMV1_TYPE_RP_REACHABILITY 4
+#define PIMV1_TYPE_ASSERT          5
+#define PIMV1_TYPE_GRAFT           6
+#define PIMV1_TYPE_GRAFT_ACK       7
+
+static const struct tok pimv1_type_str[] = {
+       { PIMV1_TYPE_QUERY,           "Query"         },
+       { PIMV1_TYPE_REGISTER,        "Register"      },
+       { PIMV1_TYPE_REGISTER_STOP,   "Register-Stop" },
+       { PIMV1_TYPE_JOIN_PRUNE,      "Join/Prune"    },
+       { PIMV1_TYPE_RP_REACHABILITY, "RP-reachable"  },
+       { PIMV1_TYPE_ASSERT,          "Assert"        },
+       { PIMV1_TYPE_GRAFT,           "Graft"         },
+       { PIMV1_TYPE_GRAFT_ACK,       "Graft-ACK"     },
+       { 0, NULL }
+};
+
+#define PIMV2_TYPE_HELLO         0
+#define PIMV2_TYPE_REGISTER      1
+#define PIMV2_TYPE_REGISTER_STOP 2
+#define PIMV2_TYPE_JOIN_PRUNE    3
+#define PIMV2_TYPE_BOOTSTRAP     4
+#define PIMV2_TYPE_ASSERT        5
+#define PIMV2_TYPE_GRAFT         6
+#define PIMV2_TYPE_GRAFT_ACK     7
+#define PIMV2_TYPE_CANDIDATE_RP  8
+#define PIMV2_TYPE_PRUNE_REFRESH 9
+#define PIMV2_TYPE_DF_ELECTION   10
+#define PIMV2_TYPE_ECMP_REDIRECT 11
 
-#include <netinet/in.h>
-#include <netinet/in_systm.h>
-#include <netinet/ip.h>
-#include <netinet/ip_var.h>
-#include <netinet/udp.h>
-#include <netinet/udp_var.h>
-#include <netinet/tcp.h>
+static const struct tok pimv2_type_values[] = {
+    { PIMV2_TYPE_HELLO,         "Hello" },
+    { PIMV2_TYPE_REGISTER,      "Register" },
+    { PIMV2_TYPE_REGISTER_STOP, "Register Stop" },
+    { PIMV2_TYPE_JOIN_PRUNE,    "Join / Prune" },
+    { PIMV2_TYPE_BOOTSTRAP,     "Bootstrap" },
+    { PIMV2_TYPE_ASSERT,        "Assert" },
+    { PIMV2_TYPE_GRAFT,         "Graft" },
+    { PIMV2_TYPE_GRAFT_ACK,     "Graft Acknowledgement" },
+    { PIMV2_TYPE_CANDIDATE_RP,  "Candidate RP Advertisement" },
+    { PIMV2_TYPE_PRUNE_REFRESH, "Prune Refresh" },
+    { PIMV2_TYPE_DF_ELECTION,   "DF Election" },
+    { PIMV2_TYPE_ECMP_REDIRECT, "ECMP Redirect" },
+    { 0, NULL}
+};
+
+#define PIMV2_HELLO_OPTION_HOLDTIME             1
+#define PIMV2_HELLO_OPTION_LANPRUNEDELAY        2
+#define PIMV2_HELLO_OPTION_DR_PRIORITY_OLD     18
+#define PIMV2_HELLO_OPTION_DR_PRIORITY         19
+#define PIMV2_HELLO_OPTION_GENID               20
+#define PIMV2_HELLO_OPTION_REFRESH_CAP         21
+#define PIMV2_HELLO_OPTION_BIDIR_CAP           22
+#define PIMV2_HELLO_OPTION_ADDRESS_LIST        24
+#define PIMV2_HELLO_OPTION_ADDRESS_LIST_OLD 65001
+
+static const struct tok pimv2_hello_option_values[] = {
+    { PIMV2_HELLO_OPTION_HOLDTIME,         "Hold Time" },
+    { PIMV2_HELLO_OPTION_LANPRUNEDELAY,    "LAN Prune Delay" },
+    { PIMV2_HELLO_OPTION_DR_PRIORITY_OLD,  "DR Priority (Old)" },
+    { PIMV2_HELLO_OPTION_DR_PRIORITY,      "DR Priority" },
+    { PIMV2_HELLO_OPTION_GENID,            "Generation ID" },
+    { PIMV2_HELLO_OPTION_REFRESH_CAP,      "State Refresh Capability" },
+    { PIMV2_HELLO_OPTION_BIDIR_CAP,        "Bi-Directional Capability" },
+    { PIMV2_HELLO_OPTION_ADDRESS_LIST,     "Address List" },
+    { PIMV2_HELLO_OPTION_ADDRESS_LIST_OLD, "Address List (Old)" },
+    { 0, NULL}
+};
+
+#define PIMV2_REGISTER_FLAG_LEN      4
+#define PIMV2_REGISTER_FLAG_BORDER 0x80000000
+#define PIMV2_REGISTER_FLAG_NULL   0x40000000
+
+static const struct tok pimv2_register_flag_values[] = {
+    { PIMV2_REGISTER_FLAG_BORDER, "Border" },
+    { PIMV2_REGISTER_FLAG_NULL, "Null" },
+    { 0, NULL}
+};
 
 /*
  * XXX: We consider a case where IPv6 is not ready yet for portability,
  * but PIM dependent defintions should be independent of IPv6...
  */
-#ifdef INET6
-#include <netinet6/pim6.h>
-#else
+
 struct pim {
-#if defined(BYTE_ORDER) && (BYTE_ORDER == LITTLE_ENDIAN)
-       u_char  pim_type:4, /* the PIM message type, currently they are:
-                           * Hello, Register, Register-Stop, Join/Prune,
-                           * Bootstrap, Assert, Graft (PIM-DM only),
-                           * Graft-Ack (PIM-DM only), C-RP-Adv
-                           */
-               pim_ver:4;  /* PIM version number; 2 for PIMv2 */
-#else
-       u_char  pim_ver:4,      /* PIM version */
-               pim_type:4;     /* PIM type    */
-#endif
+       uint8_t pim_typever;
+                       /* upper 4bit: PIM version number; 2 for PIMv2 */
+                       /* lower 4bit: the PIM message type, currently they are:
+                        * Hello, Register, Register-Stop, Join/Prune,
+                        * Bootstrap, Assert, Graft (PIM-DM only),
+                        * Graft-Ack (PIM-DM only), C-RP-Adv
+                        */
+#define PIM_VER(x)     (((x) & 0xf0) >> 4)
+#define PIM_TYPE(x)    ((x) & 0x0f)
        u_char  pim_rsv;        /* Reserved */
        u_short pim_cksum;      /* IP style check sum */
 };
-#endif 
 
+static void pimv2_print(netdissect_options *, register const u_char *bp, register u_int len, const u_char *);
 
-#include <stdio.h>
-#include <stdlib.h>
-#include <unistd.h>
+static void
+pimv1_join_prune_print(netdissect_options *ndo,
+                       register const u_char *bp, register u_int len)
+{
+       int ngroups, njoin, nprune;
+       int njp;
 
-#include "interface.h"
-#include "addrtoname.h"
+       /* If it's a single group and a single source, use 1-line output. */
+       if (ND_TTEST2(bp[0], 30) && bp[11] == 1 &&
+           ((njoin = EXTRACT_16BITS(&bp[20])) + EXTRACT_16BITS(&bp[22])) == 1) {
+               int hold;
 
-static void pimv2_print(register const u_char *bp, register u_int len);
+               ND_PRINT((ndo, " RPF %s ", ipaddr_string(ndo, bp)));
+               hold = EXTRACT_16BITS(&bp[6]);
+               if (hold != 180) {
+                       ND_PRINT((ndo, "Hold "));
+                       unsigned_relts_print(ndo, hold);
+               }
+               ND_PRINT((ndo, "%s (%s/%d, %s", njoin ? "Join" : "Prune",
+               ipaddr_string(ndo, &bp[26]), bp[25] & 0x3f,
+               ipaddr_string(ndo, &bp[12])));
+               if (EXTRACT_32BITS(&bp[16]) != 0xffffffff)
+                       ND_PRINT((ndo, "/%s", ipaddr_string(ndo, &bp[16])));
+               ND_PRINT((ndo, ") %s%s %s",
+                   (bp[24] & 0x01) ? "Sparse" : "Dense",
+                   (bp[25] & 0x80) ? " WC" : "",
+                   (bp[25] & 0x40) ? "RP" : "SPT"));
+               return;
+       }
+
+       if (len < sizeof(struct in_addr))
+               goto trunc;
+       ND_TCHECK2(bp[0], sizeof(struct in_addr));
+       if (ndo->ndo_vflag > 1)
+               ND_PRINT((ndo, "\n"));
+       ND_PRINT((ndo, " Upstream Nbr: %s", ipaddr_string(ndo, bp)));
+       bp += 4;
+       len -= 4;
+       if (len < 4)
+               goto trunc;
+       ND_TCHECK2(bp[2], 2);
+       if (ndo->ndo_vflag > 1)
+               ND_PRINT((ndo, "\n"));
+       ND_PRINT((ndo, " Hold time: "));
+       unsigned_relts_print(ndo, EXTRACT_16BITS(&bp[2]));
+       if (ndo->ndo_vflag < 2)
+               return;
+       bp += 4;
+       len -= 4;
+
+       if (len < 4)
+               goto trunc;
+       ND_TCHECK2(bp[0], 4);
+       ngroups = bp[3];
+       bp += 4;
+       len -= 4;
+       while (ngroups--) {
+               /*
+                * XXX - does the address have length "addrlen" and the
+                * mask length "maddrlen"?
+                */
+               if (len < 4)
+                       goto trunc;
+               ND_TCHECK2(bp[0], sizeof(struct in_addr));
+               ND_PRINT((ndo, "\n\tGroup: %s", ipaddr_string(ndo, bp)));
+               bp += 4;
+               len -= 4;
+               if (len < 4)
+                       goto trunc;
+               ND_TCHECK2(bp[0], sizeof(struct in_addr));
+               if (EXTRACT_32BITS(&bp[0]) != 0xffffffff)
+                       ND_PRINT((ndo, "/%s", ipaddr_string(ndo, &bp[0])));
+               bp += 4;
+               len -= 4;
+               if (len < 4)
+                       goto trunc;
+               ND_TCHECK2(bp[0], 4);
+               njoin = EXTRACT_16BITS(&bp[0]);
+               nprune = EXTRACT_16BITS(&bp[2]);
+               ND_PRINT((ndo, " joined: %d pruned: %d", njoin, nprune));
+               bp += 4;
+               len -= 4;
+               for (njp = 0; njp < (njoin + nprune); njp++) {
+                       const char *type;
+
+                       if (njp < njoin)
+                               type = "Join ";
+                       else
+                               type = "Prune";
+                       if (len < 6)
+                               goto trunc;
+                       ND_TCHECK2(bp[0], 6);
+                       ND_PRINT((ndo, "\n\t%s %s%s%s%s/%d", type,
+                           (bp[0] & 0x01) ? "Sparse " : "Dense ",
+                           (bp[1] & 0x80) ? "WC " : "",
+                           (bp[1] & 0x40) ? "RP " : "SPT ",
+                           ipaddr_string(ndo, &bp[2]),
+                           bp[1] & 0x3f));
+                       bp += 6;
+                       len -= 6;
+               }
+       }
+       return;
+trunc:
+       ND_PRINT((ndo, "[|pim]"));
+       return;
+}
 
 void
-igmp_pim_print(register const u_char *bp, register u_int len)
+pimv1_print(netdissect_options *ndo,
+            register const u_char *bp, register u_int len)
 {
-    register const u_char *ep;
-    register u_char type;
+       register u_char type;
+
+       ND_TCHECK(bp[1]);
+       type = bp[1];
+
+       ND_PRINT((ndo, " %s", tok2str(pimv1_type_str, "[type %u]", type)));
+       switch (type) {
+       case PIMV1_TYPE_QUERY:
+               if (ND_TTEST(bp[8])) {
+                       switch (bp[8] >> 4) {
+                       case 0:
+                               ND_PRINT((ndo, " Dense-mode"));
+                               break;
+                       case 1:
+                               ND_PRINT((ndo, " Sparse-mode"));
+                               break;
+                       case 2:
+                               ND_PRINT((ndo, " Sparse-Dense-mode"));
+                               break;
+                       default:
+                               ND_PRINT((ndo, " mode-%d", bp[8] >> 4));
+                               break;
+                       }
+               }
+               if (ndo->ndo_vflag) {
+                       ND_TCHECK2(bp[10],2);
+                       ND_PRINT((ndo, " (Hold-time "));
+                       unsigned_relts_print(ndo, EXTRACT_16BITS(&bp[10]));
+                       ND_PRINT((ndo, ")"));
+               }
+               break;
 
-    ep = (const u_char *)snapend;
-    if (bp >= ep)
+       case PIMV1_TYPE_REGISTER:
+               ND_TCHECK2(bp[8], 20);                  /* ip header */
+               ND_PRINT((ndo, " for %s > %s", ipaddr_string(ndo, &bp[20]),
+                   ipaddr_string(ndo, &bp[24])));
+               break;
+       case PIMV1_TYPE_REGISTER_STOP:
+               ND_TCHECK2(bp[12], sizeof(struct in_addr));
+               ND_PRINT((ndo, " for %s > %s", ipaddr_string(ndo, &bp[8]),
+                   ipaddr_string(ndo, &bp[12])));
+               break;
+       case PIMV1_TYPE_RP_REACHABILITY:
+               if (ndo->ndo_vflag) {
+                       ND_TCHECK2(bp[22], 2);
+                       ND_PRINT((ndo, " group %s", ipaddr_string(ndo, &bp[8])));
+                       if (EXTRACT_32BITS(&bp[12]) != 0xffffffff)
+                               ND_PRINT((ndo, "/%s", ipaddr_string(ndo, &bp[12])));
+                       ND_PRINT((ndo, " RP %s hold ", ipaddr_string(ndo, &bp[16])));
+                       unsigned_relts_print(ndo, EXTRACT_16BITS(&bp[22]));
+               }
+               break;
+       case PIMV1_TYPE_ASSERT:
+               ND_TCHECK2(bp[16], sizeof(struct in_addr));
+               ND_PRINT((ndo, " for %s > %s", ipaddr_string(ndo, &bp[16]),
+                   ipaddr_string(ndo, &bp[8])));
+               if (EXTRACT_32BITS(&bp[12]) != 0xffffffff)
+                       ND_PRINT((ndo, "/%s", ipaddr_string(ndo, &bp[12])));
+               ND_TCHECK2(bp[24], 4);
+               ND_PRINT((ndo, " %s pref %d metric %d",
+                   (bp[20] & 0x80) ? "RP-tree" : "SPT",
+               EXTRACT_32BITS(&bp[20]) & 0x7fffffff,
+               EXTRACT_32BITS(&bp[24])));
+               break;
+       case PIMV1_TYPE_JOIN_PRUNE:
+       case PIMV1_TYPE_GRAFT:
+       case PIMV1_TYPE_GRAFT_ACK:
+               if (ndo->ndo_vflag) {
+                       if (len < 8)
+                               goto trunc;
+                       pimv1_join_prune_print(ndo, &bp[8], len - 8);
+               }
+               break;
+       }
+       ND_TCHECK(bp[4]);
+       if ((bp[4] >> 4) != 1)
+               ND_PRINT((ndo, " [v%d]", bp[4] >> 4));
        return;
 
-    type = bp[1];
+trunc:
+       ND_PRINT((ndo, "[|pim]"));
+       return;
+}
 
-    switch (type) {
-    case 0:
-       (void)printf(" Query");
-       break;
+/*
+ * auto-RP is a cisco protocol, documented at
+ * ftp://ftpeng.cisco.com/ipmulticast/specs/pim-autorp-spec01.txt
+ *
+ * This implements version 1+, dated Sept 9, 1998.
+ */
+void
+cisco_autorp_print(netdissect_options *ndo,
+                   register const u_char *bp, register u_int len)
+{
+       int type;
+       int numrps;
+       int hold;
 
-    case 1:
-       (void)printf(" Register");
-       break;
+       if (len < 8)
+               goto trunc;
+       ND_TCHECK(bp[0]);
+       ND_PRINT((ndo, " auto-rp "));
+       type = bp[0];
+       switch (type) {
+       case 0x11:
+               ND_PRINT((ndo, "candidate-advert"));
+               break;
+       case 0x12:
+               ND_PRINT((ndo, "mapping"));
+               break;
+       default:
+               ND_PRINT((ndo, "type-0x%02x", type));
+               break;
+       }
 
-    case 2:
-       (void)printf(" Register-Stop");
-       break;
+       ND_TCHECK(bp[1]);
+       numrps = bp[1];
 
-    case 3:
-       (void)printf(" Join/Prune");
-       break;
+       ND_TCHECK2(bp[2], 2);
+       ND_PRINT((ndo, " Hold "));
+       hold = EXTRACT_16BITS(&bp[2]);
+       if (hold)
+               unsigned_relts_print(ndo, EXTRACT_16BITS(&bp[2]));
+       else
+               ND_PRINT((ndo, "FOREVER"));
 
-    case 4:
-       (void)printf(" RP-reachable");
-       break;
+       /* Next 4 bytes are reserved. */
 
-    case 5:
-       (void)printf(" Assert");
-       break;
+       bp += 8; len -= 8;
 
-    case 6:
-       (void)printf(" Graft");
-       break;
+       /*XXX skip unless -v? */
 
-    case 7:
-       (void)printf(" Graft-ACK");
-       break;
+       /*
+        * Rest of packet:
+        * numrps entries of the form:
+        * 32 bits: RP
+        * 6 bits: reserved
+        * 2 bits: PIM version supported, bit 0 is "supports v1", 1 is "v2".
+        * 8 bits: # of entries for this RP
+        * each entry: 7 bits: reserved, 1 bit: negative,
+        *             8 bits: mask 32 bits: source
+        * lather, rinse, repeat.
+        */
+       while (numrps--) {
+               int nentries;
+               char s;
 
-    case 8:
-       (void)printf(" Mode");
-       break;
+               if (len < 4)
+                       goto trunc;
+               ND_TCHECK2(bp[0], 4);
+               ND_PRINT((ndo, " RP %s", ipaddr_string(ndo, bp)));
+               bp += 4;
+               len -= 4;
+               if (len < 1)
+                       goto trunc;
+               ND_TCHECK(bp[0]);
+               switch (bp[0] & 0x3) {
+               case 0: ND_PRINT((ndo, " PIMv?"));
+                       break;
+               case 1: ND_PRINT((ndo, " PIMv1"));
+                       break;
+               case 2: ND_PRINT((ndo, " PIMv2"));
+                       break;
+               case 3: ND_PRINT((ndo, " PIMv1+2"));
+                       break;
+               }
+               if (bp[0] & 0xfc)
+                       ND_PRINT((ndo, " [rsvd=0x%02x]", bp[0] & 0xfc));
+               bp += 1;
+               len -= 1;
+               if (len < 1)
+                       goto trunc;
+               ND_TCHECK(bp[0]);
+               nentries = bp[0];
+               bp += 1;
+               len -= 1;
+               s = ' ';
+               for (; nentries; nentries--) {
+                       if (len < 6)
+                               goto trunc;
+                       ND_TCHECK2(bp[0], 6);
+                       ND_PRINT((ndo, "%c%s%s/%d", s, bp[0] & 1 ? "!" : "",
+                                 ipaddr_string(ndo, &bp[2]), bp[1]));
+                       if (bp[0] & 0x02) {
+                               ND_PRINT((ndo, " bidir"));
+                       }
+                       if (bp[0] & 0xfc) {
+                               ND_PRINT((ndo, "[rsvd=0x%02x]", bp[0] & 0xfc));
+                       }
+                       s = ',';
+                       bp += 6; len -= 6;
+               }
+       }
+       return;
 
-    default:
-       (void)printf(" [type %d]", type);
-       break;
-    }
+trunc:
+       ND_PRINT((ndo, "[|autorp]"));
+       return;
 }
 
 void
-pim_print(register const u_char *bp, register u_int len)
+pim_print(netdissect_options *ndo,
+          register const u_char *bp, register u_int len, const u_char *bp2)
 {
-       register const u_char *ep;
-       register struct pim *pim = (struct pim *)bp;
+       register const struct pim *pim = (const struct pim *)bp;
 
-       ep = (const u_char *)snapend;
-       if (bp >= ep)
-               return;
 #ifdef notyet                  /* currently we see only version and type */
-       TCHECK(pim->pim_rsv);
+       ND_TCHECK(pim->pim_rsv);
 #endif
 
-       switch(pim->pim_ver) {
-        case 2:                /* avoid hardcoding? */
-               (void)printf("v2");
-               pimv2_print(bp, len);
+       ND_TCHECK(pim->pim_typever);
+       switch (PIM_VER(pim->pim_typever)) {
+       case 2:
+               if (!ndo->ndo_vflag) {
+                       ND_PRINT((ndo, "PIMv%u, %s, length %u",
+                                 PIM_VER(pim->pim_typever),
+                                 tok2str(pimv2_type_values,"Unknown Type",PIM_TYPE(pim->pim_typever)),
+                                 len));
+                       return;
+               } else {
+                       ND_PRINT((ndo, "PIMv%u, length %u\n\t%s",
+                                 PIM_VER(pim->pim_typever),
+                                 len,
+                                 tok2str(pimv2_type_values,"Unknown Type",PIM_TYPE(pim->pim_typever))));
+                       pimv2_print(ndo, bp, len, bp2);
+               }
                break;
-        default:
-               (void)printf("v%d", pim->pim_ver);
+       default:
+               ND_PRINT((ndo, "PIMv%u, length %u",
+                         PIM_VER(pim->pim_typever),
+                         len));
                break;
        }
        return;
+
+trunc:
+       ND_PRINT((ndo, "[|pim]"));
+       return;
 }
 
+/*
+ * PIMv2 uses encoded address representations.
+ *
+ * The last PIM-SM I-D before RFC2117 was published specified the
+ * following representation for unicast addresses.  However, RFC2117
+ * specified no encoding for unicast addresses with the unicast
+ * address length specified in the header.  Therefore, we have to
+ * guess which encoding is being used (Cisco's PIMv2 implementation
+ * uses the non-RFC encoding).  RFC2117 turns a previously "Reserved"
+ * field into a 'unicast-address-length-in-bytes' field.  We guess
+ * that it's the draft encoding if this reserved field is zero.
+ *
+ * RFC2362 goes back to the encoded format, and calls the addr length
+ * field "reserved" again.
+ *
+ * The first byte is the address family, from:
+ *
+ *    0    Reserved
+ *    1    IP (IP version 4)
+ *    2    IP6 (IP version 6)
+ *    3    NSAP
+ *    4    HDLC (8-bit multidrop)
+ *    5    BBN 1822
+ *    6    802 (includes all 802 media plus Ethernet "canonical format")
+ *    7    E.163
+ *    8    E.164 (SMDS, Frame Relay, ATM)
+ *    9    F.69 (Telex)
+ *   10    X.121 (X.25, Frame Relay)
+ *   11    IPX
+ *   12    Appletalk
+ *   13    Decnet IV
+ *   14    Banyan Vines
+ *   15    E.164 with NSAP format subaddress
+ *
+ * In addition, the second byte is an "Encoding".  0 is the default
+ * encoding for the address family, and no other encodings are currently
+ * specified.
+ *
+ */
+
 enum pimv2_addrtype {
        pimv2_unicast, pimv2_group, pimv2_source
 };
-#if 0
-static char *addrtypestr[] = {
-       "unicast", "group", "source"
-};
-#endif
 
+/*  0                   1                   2                   3
+ *  0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
+ * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
+ * | Addr Family   | Encoding Type |     Unicast Address           |
+ * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+++++++
+ *  0                   1                   2                   3
+ *  0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
+ * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
+ * | Addr Family   | Encoding Type |   Reserved    |  Mask Len     |
+ * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
+ * |                Group multicast Address                        |
+ * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
+ *  0                   1                   2                   3
+ *  0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
+ * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
+ * | Addr Family   | Encoding Type | Rsrvd   |S|W|R|  Mask Len     |
+ * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
+ * |                        Source Address                         |
+ * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
+ */
 static int
-pimv2_addr_print(const u_char *bp, enum pimv2_addrtype at, int silent)
+pimv2_addr_print(netdissect_options *ndo,
+                 const u_char *bp, u_int len, enum pimv2_addrtype at,
+                 u_int addr_len, int silent)
 {
-       const u_char *ep;
        int af;
-       char *afstr;
-       int len;
-
-       ep = (const u_char *)snapend;
-       if (bp >= ep)
-               return -1;
+       int hdrlen;
 
-       switch (bp[0]) {
-        case 1:
-               af = AF_INET;
-               afstr = "IPv4";
-               break;
-#ifdef INET6
-        case 2:
-               af = AF_INET6;
-               afstr = "IPv6";
-               break;
-#endif
-        default:
-               return -1;
+       if (addr_len == 0) {
+               if (len < 2)
+                       goto trunc;
+               ND_TCHECK(bp[1]);
+               switch (bp[0]) {
+               case 1:
+                       af = AF_INET;
+                       addr_len = (u_int)sizeof(struct in_addr);
+                       break;
+               case 2:
+                       af = AF_INET6;
+                       addr_len = (u_int)sizeof(struct in6_addr);
+                       break;
+               default:
+                       return -1;
+               }
+               if (bp[1] != 0)
+                       return -1;
+               hdrlen = 2;
+       } else {
+               switch (addr_len) {
+               case sizeof(struct in_addr):
+                       af = AF_INET;
+                       break;
+               case sizeof(struct in6_addr):
+                       af = AF_INET6;
+                       break;
+               default:
+                       return -1;
+                       break;
+               }
+               hdrlen = 0;
        }
 
-       if (bp[1] != 0)
-               return -1;
-
+       bp += hdrlen;
+       len -= hdrlen;
        switch (at) {
-        case pimv2_unicast:
+       case pimv2_unicast:
+               if (len < addr_len)
+                       goto trunc;
+               ND_TCHECK2(bp[0], addr_len);
                if (af == AF_INET) {
-                       len = 4;
-                       if (bp + 2 + len > ep)
-                               return -1;
                        if (!silent)
-                               (void)printf("%s", ipaddr_string(bp + 2));
+                               ND_PRINT((ndo, "%s", ipaddr_string(ndo, bp)));
                }
-#ifdef INET6
                else if (af == AF_INET6) {
-                       len = 16;
-                       if (bp + 2 + len > ep)
-                               return -1;
                        if (!silent)
-                               (void)printf("%s", ip6addr_string(bp + 2));
+                               ND_PRINT((ndo, "%s", ip6addr_string(ndo, bp)));
                }
-#endif
-               return 2 + len;
-        case pimv2_group:
+               return hdrlen + addr_len;
+       case pimv2_group:
+       case pimv2_source:
+               if (len < addr_len + 2)
+                       goto trunc;
+               ND_TCHECK2(bp[0], addr_len + 2);
                if (af == AF_INET) {
-                       len = 4;
-                       if (bp + 4 + len > ep)
-                               return -1;
-                       if (!silent)
-                               (void)printf("%s/%u", ipaddr_string(bp + 4), bp[3]);
-               }
-#ifdef INET6
-               else if (af == AF_INET6) {
-                       len = 16;
-                       if (bp + 4 + len > ep)
-                               return -1;
-                       if (!silent)
-                               (void)printf("%s/%u", ip6addr_string(bp + 4), bp[3]);
-               }
-#endif
-               return 4 + len;
-        case pimv2_source:
-               if (af == AF_INET) {
-                       len = 4;
-                       if (bp + 4 + len > ep)
-                               return -1;
-                       if (!silent)
-                               (void)printf("%s/%u", ipaddr_string(bp + 4), bp[3]);
+                       if (!silent) {
+                               ND_PRINT((ndo, "%s", ipaddr_string(ndo, bp + 2)));
+                               if (bp[1] != 32)
+                                       ND_PRINT((ndo, "/%u", bp[1]));
+                       }
                }
-#ifdef INET6
                else if (af == AF_INET6) {
-                       len = 16;
-                       if (bp + 4 + len > ep)
-                               return -1;
-                       if (!silent)
-                               (void)printf("%s/%u", ip6addr_string(bp + 4), bp[3]);
+                       if (!silent) {
+                               ND_PRINT((ndo, "%s", ip6addr_string(ndo, bp + 2)));
+                               if (bp[1] != 128)
+                                       ND_PRINT((ndo, "/%u", bp[1]));
+                       }
                }
-#endif
-               if (vflag && bp[2] && !silent) {
-                       (void)printf("(%s%s%s)",
-                               bp[2] & 0x04 ? "S" : "",
-                               bp[2] & 0x02 ? "W" : "",
-                               bp[2] & 0x01 ? "R" : "");
+               if (bp[0] && !silent) {
+                       if (at == pimv2_group) {
+                               ND_PRINT((ndo, "(0x%02x)", bp[0]));
+                       } else {
+                               ND_PRINT((ndo, "(%s%s%s",
+                                       bp[0] & 0x04 ? "S" : "",
+                                       bp[0] & 0x02 ? "W" : "",
+                                       bp[0] & 0x01 ? "R" : ""));
+                               if (bp[0] & 0xf8) {
+                                       ND_PRINT((ndo, "+0x%02x", bp[0] & 0xf8));
+                               }
+                               ND_PRINT((ndo, ")"));
+                       }
                }
-               return 4 + len;
+               return hdrlen + 2 + addr_len;
        default:
                return -1;
        }
+trunc:
+       return -1;
+}
+
+enum checksum_status {
+       CORRECT,
+       INCORRECT,
+       UNVERIFIED
+};
+
+static enum checksum_status
+pimv2_check_checksum(netdissect_options *ndo, const u_char *bp,
+                    const u_char *bp2, u_int len)
+{
+       const struct ip *ip;
+       u_int cksum;
+
+       if (!ND_TTEST2(bp[0], len)) {
+               /* We don't have all the data. */
+               return (UNVERIFIED);
+       }
+       ip = (const struct ip *)bp2;
+       if (IP_V(ip) == 4) {
+               struct cksum_vec vec[1];
+
+               vec[0].ptr = bp;
+               vec[0].len = len;
+               cksum = in_cksum(vec, 1);
+               return (cksum ? INCORRECT : CORRECT);
+       } else if (IP_V(ip) == 6) {
+               const struct ip6_hdr *ip6;
+
+               ip6 = (const struct ip6_hdr *)bp2;
+               cksum = nextproto6_cksum(ndo, ip6, bp, len, len, IPPROTO_PIM);
+               return (cksum ? INCORRECT : CORRECT);
+       } else {
+               return (UNVERIFIED);
+       }
 }
 
 static void
-pimv2_print(register const u_char *bp, register u_int len)
+pimv2_print(netdissect_options *ndo,
+            register const u_char *bp, register u_int len, const u_char *bp2)
 {
-       register const u_char *ep;
-       register struct pim *pim = (struct pim *)bp;
+       register const struct pim *pim = (const struct pim *)bp;
        int advance;
+       enum checksum_status cksum_status;
+       int pimv2_addr_len;
 
-       ep = (const u_char *)snapend;
-       if (bp >= ep)
-               return;
-#ifdef notyet                  /* currently we see only version and type */
-       TCHECK(pim->pim_rsv);
-#endif
+       if (len < 2)
+               goto trunc;
+       ND_TCHECK(pim->pim_rsv);
+       pimv2_addr_len = pim->pim_rsv;
+       if (pimv2_addr_len != 0)
+               ND_PRINT((ndo, ", RFC2117-encoding"));
+
+       if (len < 4)
+               goto trunc;
+       ND_TCHECK(pim->pim_cksum);
+       ND_PRINT((ndo, ", cksum 0x%04x ", EXTRACT_16BITS(&pim->pim_cksum)));
+       if (EXTRACT_16BITS(&pim->pim_cksum) == 0) {
+               ND_PRINT((ndo, "(unverified)"));
+       } else {
+               if (PIM_TYPE(pim->pim_typever) == PIMV2_TYPE_REGISTER) {
+                       /*
+                        * The checksum only covers the packet header,
+                        * not the encapsulated packet.
+                        */
+                       cksum_status = pimv2_check_checksum(ndo, bp, bp2, 8);
+                       if (cksum_status == INCORRECT) {
+                               /*
+                                * To quote RFC 4601, "For interoperability
+                                * reasons, a message carrying a checksum
+                                * calculated over the entire PIM Register
+                                * message should also be accepted."
+                                */
+                               cksum_status = pimv2_check_checksum(ndo, bp, bp2, len);
+                       }
+               } else {
+                       /*
+                        * The checksum covers the entire packet.
+                        */
+                       cksum_status = pimv2_check_checksum(ndo, bp, bp2, len);
+               }
+               switch (cksum_status) {
+
+               case CORRECT:
+                       ND_PRINT((ndo, "(correct)"));
+                       break;
 
-       switch (pim->pim_type) {
-        case 0:
+               case INCORRECT:
+                       ND_PRINT((ndo, "(incorrect)"));
+                       break;
+
+               case UNVERIFIED:
+                       ND_PRINT((ndo, "(unverified)"));
+                       break;
+               }
+       }
+       bp += 4;
+       len -= 4;
+
+       switch (PIM_TYPE(pim->pim_typever)) {
+       case PIMV2_TYPE_HELLO:
            {
-               u_int16_t otype, olen;
-               (void)printf(" Hello");
-               bp += 4;
-               while (bp < ep) {
-                       otype = ntohs(*(u_int16_t *)(bp + 0));
-                       olen = ntohs(*(u_int16_t *)(bp + 2));
-                       if (otype == 1 && olen == 2 && bp + 4 + olen <= ep) {
-                               u_int16_t value;
-                               (void)printf(" holdtime=");
-                               value = ntohs(*(u_int16_t *)(bp + 4));
-                               if (value == 0xffff)
-                                       (void)printf("infty");
-                               else
-                                       (void)printf("%u", value);
-                               bp += 4 + olen;
-                       } else
+               uint16_t otype, olen;
+               while (len > 0) {
+                       if (len < 4)
+                               goto trunc;
+                       ND_TCHECK2(bp[0], 4);
+                       otype = EXTRACT_16BITS(&bp[0]);
+                       olen = EXTRACT_16BITS(&bp[2]);
+                       ND_PRINT((ndo, "\n\t  %s Option (%u), length %u, Value: ",
+                                 tok2str(pimv2_hello_option_values, "Unknown", otype),
+                                 otype,
+                                 olen));
+                       bp += 4;
+                       len -= 4;
+
+                       if (len < olen)
+                               goto trunc;
+                       ND_TCHECK2(bp[0], olen);
+                       switch (otype) {
+                       case PIMV2_HELLO_OPTION_HOLDTIME:
+                               if (olen != 2) {
+                                       ND_PRINT((ndo, "ERROR: Option Length != 2 Bytes (%u)", olen));
+                               } else {
+                                       unsigned_relts_print(ndo, EXTRACT_16BITS(bp));
+                               }
+                               break;
+
+                       case PIMV2_HELLO_OPTION_LANPRUNEDELAY:
+                               if (olen != 4) {
+                                       ND_PRINT((ndo, "ERROR: Option Length != 4 Bytes (%u)", olen));
+                               } else {
+                                       char t_bit;
+                                       uint16_t lan_delay, override_interval;
+                                       lan_delay = EXTRACT_16BITS(bp);
+                                       override_interval = EXTRACT_16BITS(bp+2);
+                                       t_bit = (lan_delay & 0x8000)? 1 : 0;
+                                       lan_delay &= ~0x8000;
+                                       ND_PRINT((ndo, "\n\t    T-bit=%d, LAN delay %dms, Override interval %dms",
+                                       t_bit, lan_delay, override_interval));
+                               }
+                               break;
+
+                       case PIMV2_HELLO_OPTION_DR_PRIORITY_OLD:
+                       case PIMV2_HELLO_OPTION_DR_PRIORITY:
+                               switch (olen) {
+                               case 0:
+                                       ND_PRINT((ndo, "Bi-Directional Capability (Old)"));
+                                       break;
+                               case 4:
+                                       ND_PRINT((ndo, "%u", EXTRACT_32BITS(bp)));
+                                       break;
+                               default:
+                                       ND_PRINT((ndo, "ERROR: Option Length != 4 Bytes (%u)", olen));
+                                       break;
+                               }
+                               break;
+
+                       case PIMV2_HELLO_OPTION_GENID:
+                               if (olen != 4) {
+                                       ND_PRINT((ndo, "ERROR: Option Length != 4 Bytes (%u)", olen));
+                               } else {
+                                       ND_PRINT((ndo, "0x%08x", EXTRACT_32BITS(bp)));
+                               }
+                               break;
+
+                       case PIMV2_HELLO_OPTION_REFRESH_CAP:
+                               if (olen != 4) {
+                                       ND_PRINT((ndo, "ERROR: Option Length != 4 Bytes (%u)", olen));
+                               } else {
+                                       ND_PRINT((ndo, "v%d", *bp));
+                                       if (*(bp+1) != 0) {
+                                               ND_PRINT((ndo, ", interval "));
+                                               unsigned_relts_print(ndo, *(bp+1));
+                                       }
+                                       if (EXTRACT_16BITS(bp+2) != 0) {
+                                               ND_PRINT((ndo, " ?0x%04x?", EXTRACT_16BITS(bp+2)));
+                                       }
+                               }
                                break;
+
+                       case  PIMV2_HELLO_OPTION_BIDIR_CAP:
+                               break;
+
+                       case PIMV2_HELLO_OPTION_ADDRESS_LIST_OLD:
+                       case PIMV2_HELLO_OPTION_ADDRESS_LIST:
+                               if (ndo->ndo_vflag > 1) {
+                                       const u_char *ptr = bp;
+                                       u_int plen = len;
+                                       while (ptr < (bp+olen)) {
+                                               ND_PRINT((ndo, "\n\t    "));
+                                               advance = pimv2_addr_print(ndo, ptr, plen, pimv2_unicast, pimv2_addr_len, 0);
+                                               if (advance < 0)
+                                                       goto trunc;
+                                               ptr += advance;
+                                               plen -= advance;
+                                       }
+                               }
+                               break;
+                       default:
+                               if (ndo->ndo_vflag <= 1)
+                                       print_unknown_data(ndo, bp, "\n\t    ", olen);
+                               break;
+                       }
+                       /* do we want to see an additionally hexdump ? */
+                       if (ndo->ndo_vflag> 1)
+                               print_unknown_data(ndo, bp, "\n\t    ", olen);
+                       bp += olen;
+                       len -= olen;
                }
                break;
            }
 
-        case 1:
-        {
-               struct ip *ip;
+       case PIMV2_TYPE_REGISTER:
+       {
+               const struct ip *ip;
 
-               (void)printf(" Register");
-               if (vflag && bp + 8 <= ep) {
-                       (void)printf(" %s%s", bp[4] & 0x80 ? "B" : "",
-                               bp[4] & 0x40 ? "N" : "");
-               }
-               bp += 8; len -= 8;
+               if (len < 4)
+                       goto trunc;
+               ND_TCHECK2(*bp, PIMV2_REGISTER_FLAG_LEN);
 
+               ND_PRINT((ndo, ", Flags [ %s ]\n\t",
+                         tok2str(pimv2_register_flag_values,
+                         "none",
+                         EXTRACT_32BITS(bp))));
+
+               bp += 4; len -= 4;
                /* encapsulated multicast packet */
-               if (bp >= ep)
+               if (len == 0)
+                       goto trunc;
+               ip = (const struct ip *)bp;
+               ND_TCHECK(ip->ip_vhl);
+               switch (IP_V(ip)) {
+                case 0: /* Null header */
+                       ND_TCHECK(ip->ip_dst);
+                       ND_PRINT((ndo, "IP-Null-header %s > %s",
+                                 ipaddr_string(ndo, &ip->ip_src),
+                                 ipaddr_string(ndo, &ip->ip_dst)));
                        break;
-               ip = (struct ip *)bp;
-               switch(ip->ip_v) {
-                case 4:        /* IPv4 */
-                       printf(" ");
-                       ip_print(bp, len);
+
+               case 4: /* IPv4 */
+                       ip_print(ndo, bp, len);
                        break;
-#ifdef INET6
-                case 6:        /* IPv6 */
-                       printf(" ");
-                       ip6_print(bp, len);
+
+               case 6: /* IPv6 */
+                       ip6_print(ndo, bp, len);
                        break;
-#endif
-                default:
-                       (void)printf(" IP ver %d", ip->ip_v);
+
+               default:
+                       ND_PRINT((ndo, "IP ver %d", IP_V(ip)));
                        break;
                }
                break;
-        }
+       }
 
-        case 2:
-               (void)printf(" Register-Stop");
-               bp += 4; len -= 4;
-               if (bp >= ep)
-                       break;
-               (void)printf(" group=");
-               if ((advance = pimv2_addr_print(bp, pimv2_group, 0)) < 0) {
-                       (void)printf("...");
-                       break;
-               }
+       case PIMV2_TYPE_REGISTER_STOP:
+               ND_PRINT((ndo, " group="));
+               if ((advance = pimv2_addr_print(ndo, bp, len, pimv2_group, pimv2_addr_len, 0)) < 0)
+                       goto trunc;
                bp += advance; len -= advance;
-               if (bp >= ep)
-                       break;
-               (void)printf(" source=");
-               if ((advance = pimv2_addr_print(bp, pimv2_unicast, 0)) < 0) {
-                       (void)printf("...");
-                       break;
-               }
+               ND_PRINT((ndo, " source="));
+               if ((advance = pimv2_addr_print(ndo, bp, len, pimv2_unicast, pimv2_addr_len, 0)) < 0)
+                       goto trunc;
                bp += advance; len -= advance;
                break;
 
-        case 3:
-        case 6:
-        case 7:
+       case PIMV2_TYPE_JOIN_PRUNE:
+       case PIMV2_TYPE_GRAFT:
+       case PIMV2_TYPE_GRAFT_ACK:
+
+
+        /*
+         * 0                   1                   2                   3
+         *   0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
+         *  +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
+         *  |PIM Ver| Type  | Addr length   |           Checksum            |
+         *  +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
+         *  |             Unicast-Upstream Neighbor Address                 |
+         *  +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
+         *  |  Reserved     | Num groups    |          Holdtime             |
+         *  +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
+         *  |            Encoded-Multicast Group Address-1                  |
+         *  +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
+         *  |   Number of Joined  Sources   |   Number of Pruned Sources    |
+         *  +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
+         *  |               Encoded-Joined Source Address-1                 |
+         *  +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
+         *  |                             .                                 |
+         *  |                             .                                 |
+         *  +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
+         *  |               Encoded-Joined Source Address-n                 |
+         *  +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
+         *  |               Encoded-Pruned Source Address-1                 |
+         *  +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
+         *  |                             .                                 |
+         *  |                             .                                 |
+         *  +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
+         *  |               Encoded-Pruned Source Address-n                 |
+         *  +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
+         *  |                           .                                   |
+         *  |                           .                                   |
+         *  +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
+         *  |                Encoded-Multicast Group Address-n              |
+         *  +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
+         */
+
            {
-               u_int8_t ngroup;
-               u_int16_t holdtime;
-               u_int16_t njoin;
-               u_int16_t nprune;
+               uint8_t ngroup;
+               uint16_t holdtime;
+               uint16_t njoin;
+               uint16_t nprune;
                int i, j;
 
-               switch (pim->pim_type) {
-                case 3:
-                       (void)printf(" Join/Prune");
-                       break;
-                case 6:
-                       (void)printf(" Graft");
-                       break;
-                case 7:
-                       (void)printf(" Graft-ACK");
-                       break;
-               }
-               bp += 4; len -= 4;
-               if (pim->pim_type != 7) {       /*not for Graft-ACK*/
-                       if (bp >= ep)
-                               break;
-                       (void)printf(" upstream-neighbor=");
-                       if ((advance = pimv2_addr_print(bp, pimv2_unicast, 0)) < 0) {
-                               (void)printf("...");
-                               break;
-                       }
+               if (PIM_TYPE(pim->pim_typever) != 7) {  /*not for Graft-ACK*/
+                       ND_PRINT((ndo, ", upstream-neighbor: "));
+                       if ((advance = pimv2_addr_print(ndo, bp, len, pimv2_unicast, pimv2_addr_len, 0)) < 0)
+                               goto trunc;
                        bp += advance; len -= advance;
                }
-               if (bp + 4 > ep)
-                       break;
+               if (len < 4)
+                       goto trunc;
+               ND_TCHECK2(*bp, 4);
                ngroup = bp[1];
-               holdtime = ntohs(*(u_int16_t *)(bp + 2));
-               (void)printf(" groups=%u", ngroup);
-               if (pim->pim_type != 7) {       /*not for Graft-ACK*/
-                       (void)printf(" holdtime=");
+               holdtime = EXTRACT_16BITS(&bp[2]);
+               ND_PRINT((ndo, "\n\t  %u group(s)", ngroup));
+               if (PIM_TYPE(pim->pim_typever) != 7) {  /*not for Graft-ACK*/
+                       ND_PRINT((ndo, ", holdtime: "));
                        if (holdtime == 0xffff)
-                               (void)printf("infty");
+                               ND_PRINT((ndo, "infinite"));
                        else
-                               (void)printf("%u", holdtime);
+                               unsigned_relts_print(ndo, holdtime);
                }
                bp += 4; len -= 4;
                for (i = 0; i < ngroup; i++) {
-                       if (bp >= ep)
-                               goto jp_done;
-                       (void)printf(" (group%d: ", i);
-                       if ((advance = pimv2_addr_print(bp, pimv2_group, 0)) < 0) {
-                               (void)printf("...)");
-                               goto jp_done;
-                       }
+                       ND_PRINT((ndo, "\n\t    group #%u: ", i+1));
+                       if ((advance = pimv2_addr_print(ndo, bp, len, pimv2_group, pimv2_addr_len, 0)) < 0)
+                               goto trunc;
                        bp += advance; len -= advance;
-                       if (bp + 4 > ep) {
-                               (void)printf("...)");
-                               goto jp_done;
-                       }
-                       njoin = ntohs(*(u_int16_t *)(bp + 0));
-                       nprune = ntohs(*(u_int16_t *)(bp + 2));
-                       (void)printf(" join=%u", njoin);
+                       if (len < 4)
+                               goto trunc;
+                       ND_TCHECK2(*bp, 4);
+                       njoin = EXTRACT_16BITS(&bp[0]);
+                       nprune = EXTRACT_16BITS(&bp[2]);
+                       ND_PRINT((ndo, ", joined sources: %u, pruned sources: %u", njoin, nprune));
                        bp += 4; len -= 4;
                        for (j = 0; j < njoin; j++) {
-                               (void)printf(" ");
-                               if ((advance = pimv2_addr_print(bp, pimv2_source, 0)) < 0) {
-                                       (void)printf("...)");
-                                       goto jp_done;
-                               }
+                               ND_PRINT((ndo, "\n\t      joined source #%u: ", j+1));
+                               if ((advance = pimv2_addr_print(ndo, bp, len, pimv2_source, pimv2_addr_len, 0)) < 0)
+                                       goto trunc;
                                bp += advance; len -= advance;
                        }
-                       (void)printf(" prune=%u", nprune);
                        for (j = 0; j < nprune; j++) {
-                               (void)printf(" ");
-                               if ((advance = pimv2_addr_print(bp, pimv2_source, 0)) < 0) {
-                                       (void)printf("...)");
-                                       goto jp_done;
-                               }
+                               ND_PRINT((ndo, "\n\t      pruned source #%u: ", j+1));
+                               if ((advance = pimv2_addr_print(ndo, bp, len, pimv2_source, pimv2_addr_len, 0)) < 0)
+                                       goto trunc;
                                bp += advance; len -= advance;
                        }
-                       (void)printf(")");
                }
-       jp_done:
                break;
            }
 
-        case 4:
-        {
+       case PIMV2_TYPE_BOOTSTRAP:
+       {
                int i, j, frpcnt;
 
-               (void)printf(" Bootstrap");
-               bp += 4;
-
                /* Fragment Tag, Hash Mask len, and BSR-priority */
-               if (bp + sizeof(u_int16_t) >= ep) break;
-               (void)printf(" tag=%x", ntohs(*(u_int16_t *)bp));
-               bp += sizeof(u_int16_t);
-               if (bp >= ep) break;
-               (void)printf(" hashmlen=%d", bp[0]);
-               if (bp + 1 >= ep) break;
-               (void)printf(" BSRprio=%d", bp[1]);
+               if (len < 2)
+                       goto trunc;
+               ND_TCHECK_16BITS(bp);
+               ND_PRINT((ndo, " tag=%x", EXTRACT_16BITS(bp)));
                bp += 2;
+               len -= 2;
+               if (len < 1)
+                       goto trunc;
+               ND_TCHECK(bp[0]);
+               ND_PRINT((ndo, " hashmlen=%d", bp[0]));
+               if (len < 2)
+                       goto trunc;
+               ND_TCHECK(bp[2]);
+               ND_PRINT((ndo, " BSRprio=%d", bp[1]));
+               bp += 2;
+               len -= 2;
 
                /* Encoded-Unicast-BSR-Address */
-               if (bp >= ep) break;
-               (void)printf(" BSR=");
-               if ((advance = pimv2_addr_print(bp, pimv2_unicast, 0)) < 0) {
-                       (void)printf("...");
-                       break;
-               }
+               ND_PRINT((ndo, " BSR="));
+               if ((advance = pimv2_addr_print(ndo, bp, len, pimv2_unicast, pimv2_addr_len, 0)) < 0)
+                       goto trunc;
                bp += advance;
+               len -= advance;
 
-               for (i = 0; bp < ep; i++) {
+               for (i = 0; len > 0; i++) {
                        /* Encoded-Group Address */
-                       (void)printf(" (group%d: ", i);
-                       if ((advance = pimv2_addr_print(bp, pimv2_group, 0))
-                           < 0) {
-                               (void)printf("...)");
-                               goto bs_done;
-                       }
+                       ND_PRINT((ndo, " (group%d: ", i));
+                       if ((advance = pimv2_addr_print(ndo, bp, len, pimv2_group, pimv2_addr_len, 0)) < 0)
+                               goto trunc;
                        bp += advance;
+                       len -= advance;
 
                        /* RP-Count, Frag RP-Cnt, and rsvd */
-                       if (bp >= ep) {
-                               (void)printf("...)");
-                               goto bs_done;
-                       }
-                       (void)printf(" RPcnt=%d", frpcnt = bp[0]);
-                       if (bp + 1 >= ep) {
-                               (void)printf("...)");
-                               goto bs_done;
-                       }
-                       (void)printf(" FRPcnt=%d", bp[1]);
+                       if (len < 1)
+                               goto trunc;
+                       ND_TCHECK(bp[0]);
+                       ND_PRINT((ndo, " RPcnt=%d", bp[0]));
+                       if (len < 2)
+                               goto trunc;
+                       ND_TCHECK(bp[1]);
+                       ND_PRINT((ndo, " FRPcnt=%d", frpcnt = bp[1]));
+                       if (len < 4)
+                               goto trunc;
                        bp += 4;
+                       len -= 4;
 
-                       for (j = 0; j < frpcnt && bp < ep; j++) {
+                       for (j = 0; j < frpcnt && len > 0; j++) {
                                /* each RP info */
-                               (void)printf(" RP%d=", j);
-                               if ((advance = pimv2_addr_print(bp,
+                               ND_PRINT((ndo, " RP%d=", j));
+                               if ((advance = pimv2_addr_print(ndo, bp, len,
                                                                pimv2_unicast,
-                                                               0)) < 0) {
-                                       (void)printf("...)");
-                                       goto bs_done;
-                               }
+                                                               pimv2_addr_len,
+                                                               0)) < 0)
+                                       goto trunc;
                                bp += advance;
+                               len -= advance;
 
-                               if (bp + 2 >= ep) {
-                                       (void)printf("...)");
-                                       goto bs_done;
-                               }
-                               (void)printf(",holdtime=%d",
-                                            ntohs(*(u_int16_t *)bp));
-                               if (bp + 3 >= ep) {
-                                       (void)printf("...)");
-                                       goto bs_done;
-                               }
-                               (void)printf(",prio=%d", bp[3]);
+                               if (len < 2)
+                                       goto trunc;
+                               ND_TCHECK_16BITS(bp);
+                               ND_PRINT((ndo, ",holdtime="));
+                               unsigned_relts_print(ndo, EXTRACT_16BITS(bp));
+                               if (len < 3)
+                                       goto trunc;
+                               ND_TCHECK(bp[2]);
+                               ND_PRINT((ndo, ",prio=%d", bp[2]));
+                               if (len < 4)
+                                       goto trunc;
                                bp += 4;
+                               len -= 4;
                        }
-                       (void)printf(")");
+                       ND_PRINT((ndo, ")"));
                }
-          bs_done:
                break;
-        }
-        case 5:
-               (void)printf(" Assert");
-               bp += 4; len -= 4;
-               if (bp >= ep)
-                       break;
-               (void)printf(" group=");
-               if ((advance = pimv2_addr_print(bp, pimv2_group, 0)) < 0) {
-                       (void)printf("...");
-                       break;
-               }
+       }
+       case PIMV2_TYPE_ASSERT:
+               ND_PRINT((ndo, " group="));
+               if ((advance = pimv2_addr_print(ndo, bp, len, pimv2_group, pimv2_addr_len, 0)) < 0)
+                       goto trunc;
                bp += advance; len -= advance;
-               if (bp >= ep)
-                       break;
-               (void)printf(" src=");
-               if ((advance = pimv2_addr_print(bp, pimv2_unicast, 0)) < 0) {
-                       (void)printf("...");
-                       break;
-               }
+               ND_PRINT((ndo, " src="));
+               if ((advance = pimv2_addr_print(ndo, bp, len, pimv2_unicast, pimv2_addr_len, 0)) < 0)
+                       goto trunc;
                bp += advance; len -= advance;
-               if (bp + 8 > ep)
-                       break;
-               if (ntohl(*(u_int32_t *)bp) & 0x80000000)
-                       (void)printf(" RPT");
-               (void)printf(" pref=%u", ntohl(*(u_int32_t *)bp & 0x7fffffff));
-               (void)printf(" metric=%u", ntohl(*(u_int32_t *)(bp + 4)));
+               if (len < 8)
+                       goto trunc;
+               ND_TCHECK2(*bp, 8);
+               if (bp[0] & 0x80)
+                       ND_PRINT((ndo, " RPT"));
+               ND_PRINT((ndo, " pref=%u", EXTRACT_32BITS(&bp[0]) & 0x7fffffff));
+               ND_PRINT((ndo, " metric=%u", EXTRACT_32BITS(&bp[4])));
                break;
 
-        case 8:
-        {
+       case PIMV2_TYPE_CANDIDATE_RP:
+       {
                int i, pfxcnt;
 
-               (void)printf(" Candidate-RP-Advertisement");
-               bp += 4;
-
                /* Prefix-Cnt, Priority, and Holdtime */
-               if (bp >= ep) break;
-               (void)printf(" prefix-cnt=%d", bp[0]);
+               if (len < 1)
+                       goto trunc;
+               ND_TCHECK(bp[0]);
+               ND_PRINT((ndo, " prefix-cnt=%d", bp[0]));
                pfxcnt = bp[0];
-               if (bp + 1 >= ep) break;
-               (void)printf(" prio=%d", bp[1]);
-               if (bp + 3 >= ep) break;
-               (void)printf(" holdtime=%d", ntohs(*(u_int16_t *)(bp + 2)));
+               if (len < 2)
+                       goto trunc;
+               ND_TCHECK(bp[1]);
+               ND_PRINT((ndo, " prio=%d", bp[1]));
+               if (len < 4)
+                       goto trunc;
+               ND_TCHECK_16BITS(&bp[2]);
+               ND_PRINT((ndo, " holdtime="));
+               unsigned_relts_print(ndo, EXTRACT_16BITS(&bp[2]));
                bp += 4;
+               len -= 4;
 
                /* Encoded-Unicast-RP-Address */
-               if (bp >= ep) break;
-               (void)printf(" RP=");
-               if ((advance = pimv2_addr_print(bp, pimv2_unicast, 0)) < 0) {
-                       (void)printf("...");
-                       break;
-               }
+               ND_PRINT((ndo, " RP="));
+               if ((advance = pimv2_addr_print(ndo, bp, len, pimv2_unicast, pimv2_addr_len, 0)) < 0)
+                       goto trunc;
                bp += advance;
+               len -= advance;
 
                /* Encoded-Group Addresses */
-               for (i = 0; i < pfxcnt && bp < ep; i++) {
-                       (void)printf(" Group%d=", i);
-                       if ((advance = pimv2_addr_print(bp, pimv2_group, 0))
-                           < 0) {
-                               (void)printf("...");
-                               break;
-                       }
+               for (i = 0; i < pfxcnt && len > 0; i++) {
+                       ND_PRINT((ndo, " Group%d=", i));
+                       if ((advance = pimv2_addr_print(ndo, bp, len, pimv2_group, pimv2_addr_len, 0)) < 0)
+                               goto trunc;
                        bp += advance;
+                       len -= advance;
                }
                break;
-        }
+       }
+
+       case PIMV2_TYPE_PRUNE_REFRESH:
+               ND_PRINT((ndo, " src="));
+               if ((advance = pimv2_addr_print(ndo, bp, len, pimv2_unicast, pimv2_addr_len, 0)) < 0)
+                       goto trunc;
+               bp += advance;
+               len -= advance;
+               ND_PRINT((ndo, " grp="));
+               if ((advance = pimv2_addr_print(ndo, bp, len, pimv2_group, pimv2_addr_len, 0)) < 0)
+                       goto trunc;
+               bp += advance;
+               len -= advance;
+               ND_PRINT((ndo, " forwarder="));
+               if ((advance = pimv2_addr_print(ndo, bp, len, pimv2_unicast, pimv2_addr_len, 0)) < 0)
+                       goto trunc;
+               bp += advance;
+               len -= advance;
+               if (len < 2)
+                       goto trunc;
+               ND_TCHECK_16BITS(bp);
+               ND_PRINT((ndo, " TUNR "));
+               unsigned_relts_print(ndo, EXTRACT_16BITS(bp));
+               break;
+
 
         default:
-               (void)printf(" [type %d]", pim->pim_type);
+               ND_PRINT((ndo, " [type %d]", PIM_TYPE(pim->pim_typever)));
                break;
        }
 
        return;
+
+trunc:
+       ND_PRINT((ndo, "[|pim]"));
 }
+
+/*
+ * Local Variables:
+ * c-style: whitesmith
+ * c-basic-offset: 8
+ * End:
+ */