remove redundant ND_TCHECK, let GET_ routines handle checks

[tcpdump] / funcattrs.h

diff --git a/funcattrs.h b/funcattrs.h
index cb0678eaa8a2be72680962b3b2121ceac56d92b8..f37e07e213bb4f1dbc1d08fdb8ac6cb266ae127a 100644 (file)
--- a/funcattrs.h
+++ b/funcattrs.h
@@ -35,6 +35,8 @@
 #ifndef lib_funcattrs_h
 #define lib_funcattrs_h
 
 #ifndef lib_funcattrs_h
 #define lib_funcattrs_h
 

+#include "compiler-tests.h"
+

 /*
  * Attributes to apply to functions and their arguments, using various
  * compiler-specific extensions.
 /*
  * Attributes to apply to functions and their arguments, using various
  * compiler-specific extensions.


@@ -43,7 +45,7 @@
 /*
  * This was introduced by Clang:
  *
 /*
  * This was introduced by Clang:
  *

- *     http://clang.llvm.org/docs/LanguageExtensions.html#has-attribute
+ *     https://clang.llvm.org/docs/LanguageExtensions.html#has-attribute

  *
  * in some version (which version?); it has been picked up by GCC 5.0.
  */
  *
  * in some version (which version?); it has been picked up by GCC 5.0.
  */


@@ -65,10 +67,10 @@
  * declaration, as the MSVC version has to go before the declaration.)
  */
 #if __has_attribute(noreturn) \
  * declaration, as the MSVC version has to go before the declaration.)
  */
 #if __has_attribute(noreturn) \

-    || (defined(__GNUC__) && ((__GNUC__ * 100 + __GNUC_MINOR__) >= 205)) \
-    || (defined(__SUNPRO_C) && (__SUNPRO_C >= 0x590)) \
-    || (defined(__xlC__) && __xlC__ >= 0x0A01) \
-    || (defined(__HP_aCC) && __HP_aCC >= 61000)
+    || ND_IS_AT_LEAST_GNUC_VERSION(2,5) \
+    || ND_IS_AT_LEAST_SUNC_VERSION(5,9) \
+    || ND_IS_AT_LEAST_XL_C_VERSION(10,1) \
+    || ND_IS_AT_LEAST_HP_C_VERSION(6,10)

   /*
    * Compiler with support for __attribute((noreturn)), or GCC 2.5 and
    * later, or Solaris Studio 12 (Sun C 5.9) and later, or IBM XL C 10.1
   /*
    * Compiler with support for __attribute((noreturn)), or GCC 2.5 and
    * later, or Solaris Studio 12 (Sun C 5.9) and later, or IBM XL C 10.1


@@ -109,9 +111,9 @@
  * string".
  */
 #if __has_attribute(__format__) \
  * string".
  */
 #if __has_attribute(__format__) \

-    || (defined(__GNUC__) && ((__GNUC__ * 100 + __GNUC_MINOR__) >= 203)) \
-    || (defined(__xlC__) && __xlC__ >= 0x0A01) \
-    || (defined(__HP_aCC) && __HP_aCC >= 61000)
+    || ND_IS_AT_LEAST_GNUC_VERSION(2,3) \
+    || ND_IS_AT_LEAST_XL_C_VERSION(10,1) \
+    || ND_IS_AT_LEAST_HP_C_VERSION(6,10)

   /*
    * Compiler with support for it, or GCC 2.3 and later, or IBM XL C 10.1
    * and later (do any earlier versions of XL C support this?),
   /*
    * Compiler with support for it, or GCC 2.3 and later, or IBM XL C 10.1
    * and later (do any earlier versions of XL C support this?),


@@ -136,13 +138,9 @@
 /*
  * For flagging arguments as format strings in MSVC.
  */
 /*
  * For flagging arguments as format strings in MSVC.
  */

-#if _MSC_VER >= 1400
+#ifdef _MSC_VER

  #include <sal.h>
  #include <sal.h>

- #if _MSC_VER > 1400
-  #define FORMAT_STRING(p) _Printf_format_string_ p
- #else
-  #define FORMAT_STRING(p) __format_string p
- #endif
+ #define FORMAT_STRING(p) _Printf_format_string_ p

 #else
  #define FORMAT_STRING(p) p
 #endif
 #else
  #define FORMAT_STRING(p) p
 #endif