Process VLAN frames and Alteon jumbo frames in the Ethernet printer.

[tcpdump] / print-olsr.c

diff --git a/print-olsr.c b/print-olsr.c
index 54709b76e238a151e41453d68767148c74722ea7..ba0ed2bede8a14569e98de85aab86a113264a3d7 100644 (file)
--- a/print-olsr.c
+++ b/print-olsr.c
@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 1998-2007 The TCPDUMP project
 /*
  * Copyright (c) 1998-2007 The TCPDUMP project

+ * Copyright (c) 2009  Florian Forster

  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that: (1) source code
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that: (1) source code


@@ -15,6 +16,7 @@
  * Optimized Link State Protocl (OLSR) as per rfc3626
  *
  * Original code by Hannes Gredler <[email protected]>
  * Optimized Link State Protocl (OLSR) as per rfc3626
  *
  * Original code by Hannes Gredler <[email protected]>

+ * IPv6 additions by Florian Forster <octo at verplant.org>

  */
 
 #ifdef HAVE_CONFIG_H
  */
 
 #ifdef HAVE_CONFIG_H


@@ -28,7 +30,7 @@
 
 #include "interface.h"
 #include "addrtoname.h"
 
 #include "interface.h"
 #include "addrtoname.h"

-#include "extract.h"           
+#include "extract.h"

 #include "ip.h"
 
 /*
 #include "ip.h"
 
 /*


@@ -88,7 +90,7 @@ static struct tok olsr_msg_values[] = {
     { 0, NULL}
 };
 
     { 0, NULL}
 };
 

-struct olsr_msg {
+struct olsr_msg4 {

     u_int8_t msg_type;
     u_int8_t vtime;
     u_int8_t msg_len[2];
     u_int8_t msg_type;
     u_int8_t vtime;
     u_int8_t msg_len[2];


@@ -98,6 +100,16 @@ struct olsr_msg {
     u_int8_t msg_seq[2];
 };
 
     u_int8_t msg_seq[2];
 };
 

+struct olsr_msg6 {
+    u_int8_t msg_type;
+    u_int8_t vtime;
+    u_int8_t msg_len[2];
+    u_int8_t originator[16];
+    u_int8_t ttl;
+    u_int8_t hopcount;
+    u_int8_t msg_seq[2];
+};
+

 struct olsr_hello {
     u_int8_t res[2];
     u_int8_t htime;
 struct olsr_hello {
     u_int8_t res[2];
     u_int8_t htime;


@@ -115,11 +127,16 @@ struct olsr_tc {
     u_int8_t res[2];
 };
 
     u_int8_t res[2];
 };
 

-struct olsr_hna {
+struct olsr_hna4 {

     u_int8_t network[4];
     u_int8_t mask[4];
 };
 
     u_int8_t network[4];
     u_int8_t mask[4];
 };
 

+struct olsr_hna6 {
+    u_int8_t network[16];
+    u_int8_t mask[16];
+};
+

 
 #define OLSR_EXTRACT_LINK_TYPE(link_code) (link_code & 0x3)
 #define OLSR_EXTRACT_NEIGHBOR_TYPE(link_code) (link_code >> 2)
 
 #define OLSR_EXTRACT_LINK_TYPE(link_code) (link_code & 0x3)
 #define OLSR_EXTRACT_NEIGHBOR_TYPE(link_code) (link_code >> 2)


@@ -139,13 +156,20 @@ static struct tok olsr_neighbor_type_values[] = {
     { 0, NULL}
 };
 
     { 0, NULL}
 };
 

-struct olsr_lq_neighbor {
+struct olsr_lq_neighbor4 {

     u_int8_t neighbor[4];
     u_int8_t link_quality;
     u_int8_t neighbor_link_quality;
     u_int8_t res[2];
 };
 
     u_int8_t neighbor[4];
     u_int8_t link_quality;
     u_int8_t neighbor_link_quality;
     u_int8_t res[2];
 };
 

+struct olsr_lq_neighbor6 {
+    u_int8_t neighbor[16];
+    u_int8_t link_quality;
+    u_int8_t neighbor_link_quality;
+    u_int8_t res[2];
+};
+

 /*
  * macro to convert the 8-bit mantissa/exponent to a double float
  * taken from olsr.org.
 /*
  * macro to convert the 8-bit mantissa/exponent to a double float
  * taken from olsr.org.


@@ -158,13 +182,13 @@ struct olsr_lq_neighbor {
  * print a neighbor list with LQ extensions.
  */
 static void
  * print a neighbor list with LQ extensions.
  */
 static void

-olsr_print_lq_neighbor (const u_char *msg_data, u_int hello_len)
+olsr_print_lq_neighbor4 (const u_char *msg_data, u_int hello_len)

 {
 {

-    struct olsr_lq_neighbor *lq_neighbor;
+    struct olsr_lq_neighbor4 *lq_neighbor;

 
 

-    while (hello_len >= sizeof(struct olsr_lq_neighbor)) {
+    while (hello_len >= sizeof(struct olsr_lq_neighbor4)) {

 
 

-        lq_neighbor = (struct olsr_lq_neighbor *)msg_data;
+        lq_neighbor = (struct olsr_lq_neighbor4 *)msg_data;

 
         printf("\n\t      neighbor %s, link-quality %.2lf%%"
                ", neighbor-link-quality %.2lf%%",
 
         printf("\n\t      neighbor %s, link-quality %.2lf%%"
                ", neighbor-link-quality %.2lf%%",


@@ -172,11 +196,33 @@ olsr_print_lq_neighbor (const u_char *msg_data, u_int hello_len)
                ((double)lq_neighbor->link_quality/2.55),
                ((double)lq_neighbor->neighbor_link_quality/2.55));
 
                ((double)lq_neighbor->link_quality/2.55),
                ((double)lq_neighbor->neighbor_link_quality/2.55));
 

-        msg_data += sizeof(struct olsr_lq_neighbor);
-        hello_len -= sizeof(struct olsr_lq_neighbor);
+        msg_data += sizeof(struct olsr_lq_neighbor4);
+        hello_len -= sizeof(struct olsr_lq_neighbor4);

     }
 }
 
     }
 }
 

+#if INET6
+static void
+olsr_print_lq_neighbor6 (const u_char *msg_data, u_int hello_len)
+{
+    struct olsr_lq_neighbor6 *lq_neighbor;
+
+    while (hello_len >= sizeof(struct olsr_lq_neighbor6)) {
+
+        lq_neighbor = (struct olsr_lq_neighbor6 *)msg_data;
+
+        printf("\n\t      neighbor %s, link-quality %.2lf%%"
+               ", neighbor-link-quality %.2lf%%",
+               ip6addr_string(lq_neighbor->neighbor),
+               ((double)lq_neighbor->link_quality/2.55),
+               ((double)lq_neighbor->neighbor_link_quality/2.55));
+
+        msg_data += sizeof(struct olsr_lq_neighbor6);
+        hello_len -= sizeof(struct olsr_lq_neighbor6);
+    }
+}
+#endif /* INET6 */
+

 /*
  * print a neighbor list.
  */
 /*
  * print a neighbor list.
  */


@@ -202,39 +248,41 @@ olsr_print_neighbor (const u_char *msg_data, u_int hello_len)
 
 
 void
 
 
 void

-olsr_print (const u_char *pptr, u_int length)
+olsr_print (const u_char *pptr, u_int length, int is_ipv6)

 {
     union {
         const struct olsr_common *common;
 {
     union {
         const struct olsr_common *common;

-        const struct olsr_msg *msg;
+        const struct olsr_msg4 *msg4;
+        const struct olsr_msg6 *msg6;

         const struct olsr_hello *hello;
         const struct olsr_hello_link *hello_link;
         const struct olsr_hello *hello;
         const struct olsr_hello_link *hello_link;

-        const struct olsr_lq_neighbor *lq_neighbor;

         const struct olsr_tc *tc;
         const struct olsr_tc *tc;

-        const struct olsr_hna *hna;
+        const struct olsr_hna4 *hna;

     } ptr;
 
     } ptr;
 

-    u_int msg_type, msg_len, msg_tlen, hello_len, prefix;
-    u_int16_t name_entries, name_entry_type, name_entry_len;
+    u_int msg_type, msg_len, msg_tlen, hello_len;
+    u_int16_t name_entry_type, name_entry_len;
+    u_int name_entry_padding;

     u_int8_t link_type, neighbor_type;
     const u_char *tptr, *msg_data;
 
     u_int8_t link_type, neighbor_type;
     const u_char *tptr, *msg_data;
 

-    tptr = pptr; 
+    tptr = pptr;

 
     if (length < sizeof(struct olsr_common)) {
         goto trunc;
     }
 
     if (!TTEST2(*tptr, sizeof(struct olsr_common))) {
 
     if (length < sizeof(struct olsr_common)) {
         goto trunc;
     }
 
     if (!TTEST2(*tptr, sizeof(struct olsr_common))) {

-       goto trunc;
+        goto trunc;

     }
 
     ptr.common = (struct olsr_common *)tptr;
     length = MIN(length, EXTRACT_16BITS(ptr.common->packet_len));
 
     }
 
     ptr.common = (struct olsr_common *)tptr;
     length = MIN(length, EXTRACT_16BITS(ptr.common->packet_len));
 

-    printf("OLSR, seq 0x%04x, length %u",
-           EXTRACT_16BITS(ptr.common->packet_seq),
-           length);
+    printf("OLSRv%i, seq 0x%04x, length %u",
+            (is_ipv6 == 0) ? 4 : 6,
+            EXTRACT_16BITS(ptr.common->packet_seq),
+            length);

 
     tptr += sizeof(struct olsr_common);
 
 
     tptr += sizeof(struct olsr_common);
 


@@ -242,41 +290,81 @@ olsr_print (const u_char *pptr, u_int length)
      * In non-verbose mode, just print version.
      */
     if (vflag < 1) {
      * In non-verbose mode, just print version.
      */
     if (vflag < 1) {

-       return;
+        return;

     }
 
     while (tptr < (pptr+length)) {
     }
 
     while (tptr < (pptr+length)) {

-
-        if (!TTEST2(*tptr, sizeof(struct olsr_msg)))   
+        union
+        {
+            struct olsr_msg4 *v4;
+            struct olsr_msg6 *v6;
+        } msgptr;
+        int msg_len_valid = 0;
+
+        if (!TTEST2(*tptr, sizeof(struct olsr_msg4)))

             goto trunc;
 
             goto trunc;
 

-        ptr.msg = (struct olsr_msg *)tptr;
-
-        msg_type = ptr.msg->msg_type;
-        msg_len = EXTRACT_16BITS(ptr.msg->msg_len);
+#if INET6
+        if (is_ipv6)
+        {
+            msgptr.v6 = (struct olsr_msg6 *) tptr;
+            msg_type = msgptr.v6->msg_type;
+            msg_len = EXTRACT_16BITS(msgptr.v6->msg_len);
+            if ((msg_len >= sizeof (struct olsr_msg6))
+                    && (msg_len <= length))
+                msg_len_valid = 1;
+
+            /* infinite loop check */
+            if (msg_type == 0 || msg_len == 0) {
+                return;
+            }

 
 

-        /* infinite loop check */
-        if (msg_type == 0 || msg_len == 0) {
-            return;
+            printf("\n\t%s Message (%#04x), originator %s, ttl %u, hop %u"
+                    "\n\t  vtime %.3lfs, msg-seq 0x%04x, length %u%s",
+                    tok2str(olsr_msg_values, "Unknown", msg_type),
+                    msg_type, ip6addr_string(msgptr.v6->originator),
+                    msgptr.v6->ttl,
+                    msgptr.v6->hopcount,
+                    ME_TO_DOUBLE(msgptr.v6->vtime),
+                    EXTRACT_16BITS(msgptr.v6->msg_seq),
+                    msg_len, (msg_len_valid == 0) ? " (invalid)" : "");
+
+            msg_tlen = msg_len - sizeof(struct olsr_msg6);
+            msg_data = tptr + sizeof(struct olsr_msg6);

         }
         }

+        else /* (!is_ipv6) */
+#endif /* INET6 */
+        {
+            msgptr.v4 = (struct olsr_msg4 *) tptr;
+            msg_type = msgptr.v4->msg_type;
+            msg_len = EXTRACT_16BITS(msgptr.v4->msg_len);
+            if ((msg_len >= sizeof (struct olsr_msg4))
+                    && (msg_len <= length))
+                msg_len_valid = 1;
+
+            /* infinite loop check */
+            if (msg_type == 0 || msg_len == 0) {
+                return;
+            }

 
 

-        printf("\n\t%s Message (%u), originator %s, ttl %u, hop %u"
-               "\n\t  vtime %.3lfs, msg-seq 0x%04x, length %u",
-               tok2str(olsr_msg_values, "Unknown", msg_type),
-               msg_type, ipaddr_string(ptr.msg->originator),
-               ptr.msg->ttl,
-               ptr.msg->hopcount,
-               ME_TO_DOUBLE(ptr.msg->vtime),
-               EXTRACT_16BITS(ptr.msg->msg_seq),
-               msg_len);
-
-        msg_tlen = msg_len - sizeof(struct olsr_msg);
-        msg_data = tptr + sizeof(struct olsr_msg);
+            printf("\n\t%s Message (%#04x), originator %s, ttl %u, hop %u"
+                    "\n\t  vtime %.3lfs, msg-seq 0x%04x, length %u%s",
+                    tok2str(olsr_msg_values, "Unknown", msg_type),
+                    msg_type, ipaddr_string(msgptr.v4->originator),
+                    msgptr.v4->ttl,
+                    msgptr.v4->hopcount,
+                    ME_TO_DOUBLE(msgptr.v4->vtime),
+                    EXTRACT_16BITS(msgptr.v4->msg_seq),
+                    msg_len, (msg_len_valid == 0) ? " (invalid)" : "");
+
+            msg_tlen = msg_len - sizeof(struct olsr_msg4);
+            msg_data = tptr + sizeof(struct olsr_msg4);
+        }

 
         switch (msg_type) {
         case OLSR_HELLO_MSG:
         case OLSR_HELLO_LQ_MSG:
 
         switch (msg_type) {
         case OLSR_HELLO_MSG:
         case OLSR_HELLO_LQ_MSG:

-            if (!TTEST2(*msg_data, sizeof(struct olsr_hello))) 
+            if (!TTEST2(*msg_data, sizeof(struct olsr_hello)))

                 goto trunc;
 
             ptr.hello = (struct olsr_hello *)msg_data;
                 goto trunc;
 
             ptr.hello = (struct olsr_hello *)msg_data;


@@ -286,11 +374,12 @@ olsr_print (const u_char *pptr, u_int length)
             msg_tlen -= sizeof(struct olsr_hello);
 
             while (msg_tlen >= sizeof(struct olsr_hello_link)) {
             msg_tlen -= sizeof(struct olsr_hello);
 
             while (msg_tlen >= sizeof(struct olsr_hello_link)) {

+                int hello_len_valid = 0;

 
                 /*
                  * link-type.
                  */
 
                 /*
                  * link-type.
                  */

-                if (!TTEST2(*msg_data, sizeof(struct olsr_hello_link)))        
+                if (!TTEST2(*msg_data, sizeof(struct olsr_hello_link)))

                     goto trunc;
 
                 ptr.hello_link = (struct olsr_hello_link *)msg_data;
                     goto trunc;
 
                 ptr.hello_link = (struct olsr_hello_link *)msg_data;


@@ -299,10 +388,18 @@ olsr_print (const u_char *pptr, u_int length)
                 link_type = OLSR_EXTRACT_LINK_TYPE(ptr.hello_link->link_code);
                 neighbor_type = OLSR_EXTRACT_NEIGHBOR_TYPE(ptr.hello_link->link_code);
 
                 link_type = OLSR_EXTRACT_LINK_TYPE(ptr.hello_link->link_code);
                 neighbor_type = OLSR_EXTRACT_NEIGHBOR_TYPE(ptr.hello_link->link_code);
 

-                printf("\n\t    link-type %s, neighbor-type %s, len %u",
+                if ((hello_len <= msg_tlen)
+                        && (hello_len >= sizeof(struct olsr_hello_link)))
+                    hello_len_valid = 1;
+
+                printf("\n\t    link-type %s, neighbor-type %s, len %u%s",

                        tok2str(olsr_link_type_values, "Unknown", link_type),
                        tok2str(olsr_neighbor_type_values, "Unknown", neighbor_type),
                        tok2str(olsr_link_type_values, "Unknown", link_type),
                        tok2str(olsr_neighbor_type_values, "Unknown", neighbor_type),

-                       hello_len);
+                       hello_len,
+                       (hello_len_valid == 0) ? " (invalid)" : "");
+
+                if (hello_len_valid == 0)
+                    break;

 
                 msg_data += sizeof(struct olsr_hello_link);
                 msg_tlen -= sizeof(struct olsr_hello_link);
 
                 msg_data += sizeof(struct olsr_hello_link);
                 msg_tlen -= sizeof(struct olsr_hello_link);


@@ -311,7 +408,12 @@ olsr_print (const u_char *pptr, u_int length)
                 if (msg_type == OLSR_HELLO_MSG) {
                     olsr_print_neighbor(msg_data, hello_len);
                 } else {
                 if (msg_type == OLSR_HELLO_MSG) {
                     olsr_print_neighbor(msg_data, hello_len);
                 } else {

-                    olsr_print_lq_neighbor(msg_data, hello_len);
+#if INET6
+                    if (is_ipv6)
+                        olsr_print_lq_neighbor6(msg_data, hello_len);
+                    else
+#endif
+                        olsr_print_lq_neighbor4(msg_data, hello_len);

                 }
 
                 msg_data += hello_len;
                 }
 
                 msg_data += hello_len;


@@ -321,7 +423,7 @@ olsr_print (const u_char *pptr, u_int length)
 
         case OLSR_TC_MSG:
         case OLSR_TC_LQ_MSG:
 
         case OLSR_TC_MSG:
         case OLSR_TC_LQ_MSG:

-            if (!TTEST2(*msg_data, sizeof(struct olsr_tc)))    
+            if (!TTEST2(*msg_data, sizeof(struct olsr_tc)))

                 goto trunc;
 
             ptr.tc = (struct olsr_tc *)msg_data;
                 goto trunc;
 
             ptr.tc = (struct olsr_tc *)msg_data;


@@ -333,74 +435,170 @@ olsr_print (const u_char *pptr, u_int length)
             if (msg_type == OLSR_TC_MSG) {
                 olsr_print_neighbor(msg_data, msg_tlen);
             } else {
             if (msg_type == OLSR_TC_MSG) {
                 olsr_print_neighbor(msg_data, msg_tlen);
             } else {

-                olsr_print_lq_neighbor(msg_data, msg_tlen);
+#if INET6
+                if (is_ipv6)
+                    olsr_print_lq_neighbor6(msg_data, msg_tlen);
+                else
+#endif
+                    olsr_print_lq_neighbor4(msg_data, msg_tlen);

             }
             break;
 
         case OLSR_MID_MSG:
             }
             break;
 
         case OLSR_MID_MSG:

-            if (!TTEST2(*msg_data, sizeof(struct in_addr)))    
-                goto trunc;
+        {
+            size_t addr_size = sizeof(struct in_addr);
+
+#if INET6
+            if (is_ipv6)
+                addr_size = sizeof(struct in6_addr);
+#endif
+
+            while (msg_tlen >= addr_size) {
+                if (!TTEST2(*msg_data, addr_size))
+                    goto trunc;

 
 

-            while (msg_tlen >= sizeof(struct in_addr)) {
-                printf("\n\t  interface address %s", ipaddr_string(msg_data));
-                msg_data += sizeof(struct in_addr);
-                msg_tlen -= sizeof(struct in_addr);
+                printf("\n\t  interface address %s",
+#if INET6
+                        is_ipv6 ? ip6addr_string(msg_data) :
+#endif
+                        ipaddr_string(msg_data));
+                msg_data += addr_size;
+                msg_tlen -= addr_size;

             }
             break;
             }
             break;

+        }

 
         case OLSR_HNA_MSG:
 
         case OLSR_HNA_MSG:

-            prefix = 1;
-            printf("\n\t  advertised networks\n\t    ");
-            while (msg_tlen >= sizeof(struct olsr_hna)) {
-                if (!TTEST2(*msg_data, sizeof(struct olsr_hna)))       
-                    goto trunc;
+            printf("\n\t  Advertised networks (total %u)",
+                    (unsigned int) (msg_tlen / sizeof(struct olsr_hna6)));
+#if INET6
+            if (is_ipv6)
+            {
+                int i = 0;
+                while (msg_tlen >= sizeof(struct olsr_hna6)) {
+                    struct olsr_hna6 *hna6;
+
+                    if (!TTEST2(*msg_data, sizeof(struct olsr_hna6)))
+                        goto trunc;
+
+                    hna6 = (struct olsr_hna6 *)msg_data;
+
+                    printf("\n\t    #%i: %s/%u",
+                            i, ip6addr_string(hna6->network),
+                            mask62plen (hna6->mask));
+
+                    msg_data += sizeof(struct olsr_hna6);
+                    msg_tlen -= sizeof(struct olsr_hna6);
+                }
+            }
+            else
+#endif
+            {
+                int col = 0;
+                while (msg_tlen >= sizeof(struct olsr_hna4)) {
+                    if (!TTEST2(*msg_data, sizeof(struct olsr_hna4)))
+                        goto trunc;

 
 

-                ptr.hna = (struct olsr_hna *)msg_data;
+                    ptr.hna = (struct olsr_hna4 *)msg_data;

 
 

-                /* print 4 prefixes per line */
+                    /* print 4 prefixes per line */
+                    if (col == 0)
+                        printf ("\n\t    ");
+                    else
+                        printf (", ");

 
 

-                printf("%s/%u%s",
-                       ipaddr_string(ptr.hna->network),
-                       mask2plen(EXTRACT_32BITS(ptr.hna->mask)),                       
-                       prefix % 4 == 0 ? "\n\t    " : " ");
+                    printf("%s/%u",
+                            ipaddr_string(ptr.hna->network),
+                            mask2plen(EXTRACT_32BITS(ptr.hna->mask)));

 
 

-                msg_data += sizeof(struct olsr_hna);
-                msg_tlen -= sizeof(struct olsr_hna);
-                prefix ++;
+                    msg_data += sizeof(struct olsr_hna4);
+                    msg_tlen -= sizeof(struct olsr_hna4);
+
+                    col = (col + 1) % 4;
+                }

             }
             break;
 
         case OLSR_NAMESERVICE_MSG:
             }
             break;
 
         case OLSR_NAMESERVICE_MSG:

-            name_entries = EXTRACT_16BITS(msg_data+2);
-            printf("\n\t  Version %u, Entries %u",
-                   EXTRACT_16BITS(msg_data), name_entries);
+        {
+            u_int name_entries = EXTRACT_16BITS(msg_data+2);
+            u_int addr_size = 4;
+            int name_entries_valid = 0;
+            u_int i;
+
+            if (is_ipv6)
+                addr_size = 16;
+
+            if ((name_entries > 0)
+                    && ((name_entries * (4 + addr_size)) <= msg_tlen))
+                name_entries_valid = 1;
+
+            if (msg_tlen < 4)
+                goto trunc;
+            if (!TTEST2(*msg_data, 4))
+                goto trunc;
+
+            printf("\n\t  Version %u, Entries %u%s",
+                   EXTRACT_16BITS(msg_data),
+                   name_entries, (name_entries_valid == 0) ? " (invalid)" : "");
+
+            if (name_entries_valid == 0)
+                break;
+

             msg_data += 4;
             msg_tlen -= 4;
 
             msg_data += 4;
             msg_tlen -= 4;
 

-            while (name_entries && msg_tlen) {
+            for (i = 0; i < name_entries; i++) {
+                int name_entry_len_valid = 0;
+
+                if (msg_tlen < 4)
+                    break;
+                if (!TTEST2(*msg_data, 4))
+                    goto trunc;

 
                 name_entry_type = EXTRACT_16BITS(msg_data);
                 name_entry_len = EXTRACT_16BITS(msg_data+2);
 
                 name_entry_type = EXTRACT_16BITS(msg_data);
                 name_entry_len = EXTRACT_16BITS(msg_data+2);

+

                 msg_data += 4;
                 msg_tlen -= 4;
 
                 msg_data += 4;
                 msg_tlen -= 4;
 

-                printf("\n\t    #%u Name Entry, length %u",
-                       name_entry_type,
-                       name_entry_len);
+                if ((name_entry_len > 0) && ((addr_size + name_entry_len) <= msg_tlen))
+                    name_entry_len_valid = 1;

 
 

-                printf(", originator %s", ipaddr_string(msg_data));
+                printf("\n\t    #%u: type %#06x, length %u%s",
+                        (unsigned int) i, name_entry_type,
+                        name_entry_len, (name_entry_len_valid == 0) ? " (invalid)" : "");

 
 

-                /* 32-bit alignement */
+                if (name_entry_len_valid == 0)
+                    break;
+
+                /* 32-bit alignment */
+                name_entry_padding = 0;

                 if (name_entry_len%4 != 0)
                 if (name_entry_len%4 != 0)

-                    name_entry_len+=4-(name_entry_len%4);
+                    name_entry_padding = 4-(name_entry_len%4);

 
 

+                if (msg_tlen < addr_size + name_entry_len + name_entry_padding)
+                    goto trunc;

 
 

-                msg_data += name_entry_len;
-                msg_tlen -= name_entry_len;
+                if (!TTEST2(*msg_data, addr_size + name_entry_len + name_entry_padding))
+                    goto trunc;

 
 

-                name_entries--;
-            }
+#if INET6
+                if (is_ipv6)
+                    printf(", address %s, name \"",
+                            ip6addr_string(msg_data));
+                else
+#endif
+                    printf(", address %s, name \"",
+                            ipaddr_string(msg_data));
+                fn_printn(msg_data + addr_size, name_entry_len, NULL);
+                printf("\"");
+
+                msg_data += addr_size + name_entry_len + name_entry_padding;
+                msg_tlen -= addr_size + name_entry_len + name_entry_padding;
+            } /* for (i = 0; i < name_entries; i++) */

             break;
             break;

+        } /* case OLSR_NAMESERVICE_MSG */

 
             /*
              * FIXME those are the defined messages that lack a decoder
 
             /*
              * FIXME those are the defined messages that lack a decoder


@@ -408,11 +606,11 @@ olsr_print (const u_char *pptr, u_int length)
              */
         case OLSR_POWERINFO_MSG:
         default:
              */
         case OLSR_POWERINFO_MSG:
         default:

-           print_unknown_data(msg_data, "\n\t    ", msg_tlen);
+            print_unknown_data(msg_data, "\n\t    ", msg_tlen);

             break;
             break;

-        }      
+        } /* switch (msg_type) */

         tptr += msg_len;
         tptr += msg_len;

-    }
+    } /* while (tptr < (pptr+length)) */

 
     return;
 
 
     return;