Use more the ND_TTEST_1() macro

[tcpdump] / print-vrrp.c

diff --git a/print-vrrp.c b/print-vrrp.c
index f29272ee525935ece4fe97b5eefb88ebd499bb94..b7e309d00a5fee79c0bb3920f2ff1435398ae12c 100644 (file)
--- a/print-vrrp.c
+++ b/print-vrrp.c
@@ -23,11 +23,13 @@
  * FOR A PARTICULAR PURPOSE.
  */
 
  * FOR A PARTICULAR PURPOSE.
  */
 

+/* \summary: Virtual Router Redundancy Protocol (VRRP) printer */
+

 #ifdef HAVE_CONFIG_H
 #include "config.h"
 #endif
 
 #ifdef HAVE_CONFIG_H
 #include "config.h"
 #endif
 

-#include <tcpdump-stdinc.h>
+#include <netdissect-stdinc.h>

 
 #include "netdissect.h"
 #include "extract.h"
 
 #include "netdissect.h"
 #include "extract.h"


@@ -102,55 +104,55 @@ static const struct tok auth2str[] = {
 
 void
 vrrp_print(netdissect_options *ndo,
 
 void
 vrrp_print(netdissect_options *ndo,

-           register const u_char *bp, register u_int len,
-           register const u_char *bp2, int ttl)
+           const u_char *bp, u_int len,
+           const u_char *bp2, int ttl)

 {
        int version, type, auth_type = VRRP_AUTH_NONE; /* keep compiler happy */
        const char *type_s;
 
 {
        int version, type, auth_type = VRRP_AUTH_NONE; /* keep compiler happy */
        const char *type_s;
 

-       ND_TCHECK(bp[0]);
-       version = (bp[0] & 0xf0) >> 4;
-       type = bp[0] & 0x0f;
+       ND_TCHECK_1(bp);
+       version = (EXTRACT_U_1(bp) & 0xf0) >> 4;
+       type = EXTRACT_U_1(bp) & 0x0f;

        type_s = tok2str(type2str, "unknown type (%u)", type);
        ND_PRINT((ndo, "VRRPv%u, %s", version, type_s));
        if (ttl != 255)
                ND_PRINT((ndo, ", (ttl %u)", ttl));
        if (version < 2 || version > 3 || type != VRRP_TYPE_ADVERTISEMENT)
                return;
        type_s = tok2str(type2str, "unknown type (%u)", type);
        ND_PRINT((ndo, "VRRPv%u, %s", version, type_s));
        if (ttl != 255)
                ND_PRINT((ndo, ", (ttl %u)", ttl));
        if (version < 2 || version > 3 || type != VRRP_TYPE_ADVERTISEMENT)
                return;

-       ND_TCHECK(bp[2]);
-       ND_PRINT((ndo, ", vrid %u, prio %u", bp[1], bp[2]));
-       ND_TCHECK(bp[5]);
+       ND_TCHECK_1(bp + 2);
+       ND_PRINT((ndo, ", vrid %u, prio %u", EXTRACT_U_1(bp + 1), EXTRACT_U_1(bp + 2)));
+       ND_TCHECK_1(bp + 5);

 
        if (version == 2) {
 
        if (version == 2) {

-               auth_type = bp[4];
+               auth_type = EXTRACT_U_1(bp + 4);

                ND_PRINT((ndo, ", authtype %s", tok2str(auth2str, NULL, auth_type)));
                ND_PRINT((ndo, ", authtype %s", tok2str(auth2str, NULL, auth_type)));

-               ND_PRINT((ndo, ", intvl %us, length %u", bp[5], len));
+               ND_PRINT((ndo, ", intvl %us, length %u", EXTRACT_U_1(bp + 5), len));

        } else { /* version == 3 */
        } else { /* version == 3 */

-               uint16_t intvl = (bp[4] & 0x0f) << 8 | bp[5];
+               uint16_t intvl = (EXTRACT_U_1(bp + 4) & 0x0f) << 8 | EXTRACT_U_1(bp + 5);

                ND_PRINT((ndo, ", intvl %ucs, length %u", intvl, len));
        }
 
        if (ndo->ndo_vflag) {
                ND_PRINT((ndo, ", intvl %ucs, length %u", intvl, len));
        }
 
        if (ndo->ndo_vflag) {

-               int naddrs = bp[3];
+               int naddrs = EXTRACT_U_1(bp + 3);

                int i;
                char c;
 
                int i;
                char c;
 

-               if (version == 2 && ND_TTEST2(bp[0], len)) {
+               if (version == 2 && ND_TTEST_LEN(bp, len)) {

                        struct cksum_vec vec[1];
 
                        vec[0].ptr = bp;
                        vec[0].len = len;
                        if (in_cksum(vec, 1))
                                ND_PRINT((ndo, ", (bad vrrp cksum %x)",
                        struct cksum_vec vec[1];
 
                        vec[0].ptr = bp;
                        vec[0].len = len;
                        if (in_cksum(vec, 1))
                                ND_PRINT((ndo, ", (bad vrrp cksum %x)",

-                                       EXTRACT_16BITS(&bp[6])));
+                                       EXTRACT_BE_U_2(bp + 6)));

                }
 
                }
 

-               if (version == 3 && ND_TTEST2(bp[0], len)) {
+               if (version == 3 && ND_TTEST_LEN(bp, len)) {

                        uint16_t cksum = nextproto4_cksum(ndo, (const struct ip *)bp2, bp,
                                len, len, IPPROTO_VRRP);
                        if (cksum)
                                ND_PRINT((ndo, ", (bad vrrp cksum %x)",
                        uint16_t cksum = nextproto4_cksum(ndo, (const struct ip *)bp2, bp,
                                len, len, IPPROTO_VRRP);
                        if (cksum)
                                ND_PRINT((ndo, ", (bad vrrp cksum %x)",

-                                       EXTRACT_16BITS(&bp[6])));
+                                       EXTRACT_BE_U_2(bp + 6)));

                }
 
                ND_PRINT((ndo, ", addrs"));
                }
 
                ND_PRINT((ndo, ", addrs"));


@@ -160,13 +162,13 @@ vrrp_print(netdissect_options *ndo,
                c = ' ';
                bp += 8;
                for (i = 0; i < naddrs; i++) {
                c = ' ';
                bp += 8;
                for (i = 0; i < naddrs; i++) {

-                       ND_TCHECK(bp[3]);
+                       ND_TCHECK_1(bp + 3);

                        ND_PRINT((ndo, "%c%s", c, ipaddr_string(ndo, bp)));
                        c = ',';
                        bp += 4;
                }
                if (version == 2 && auth_type == VRRP_AUTH_SIMPLE) { /* simple text password */
                        ND_PRINT((ndo, "%c%s", c, ipaddr_string(ndo, bp)));
                        c = ',';
                        bp += 4;
                }
                if (version == 2 && auth_type == VRRP_AUTH_SIMPLE) { /* simple text password */

-                       ND_TCHECK(bp[7]);
+                       ND_TCHECK_1(bp + 7);

                        ND_PRINT((ndo, " auth \""));
                        if (fn_printn(ndo, bp, 8, ndo->ndo_snapend)) {
                                ND_PRINT((ndo, "\""));
                        ND_PRINT((ndo, " auth \""));
                        if (fn_printn(ndo, bp, 8, ndo->ndo_snapend)) {
                                ND_PRINT((ndo, "\""));