BOOTP: try to fix 2 newly added compile warnings

[tcpdump] / print-ascii.c

diff --git a/print-ascii.c b/print-ascii.c
index c672ca8cdeb3e7af6fd1cfb57e5930da02d6555a..2f05c3873d210423c7e61d6b6b4ea92a00e7543c 100644 (file)
--- a/print-ascii.c
+++ b/print-ascii.c
@@ -40,14 +40,11 @@
 #include "config.h"
 #endif
 
 #include "config.h"
 #endif
 

-#ifndef lint
-static const char rcsid[] _U_ =
-     "@(#) $Header: /tcpdump/master/tcpdump/print-ascii.c,v 1.17 2005-07-06 20:53:32 guy Exp $";
-#endif

 #include <tcpdump-stdinc.h>
 #include <stdio.h>
 
 #include "netdissect.h"
 #include <tcpdump-stdinc.h>
 #include <stdio.h>
 
 #include "netdissect.h"

+#include "interface.h"

 
 #define ASCII_LINELENGTH 300
 #define HEXDUMP_BYTES_PER_LINE 16
 
 #define ASCII_LINELENGTH 300
 #define HEXDUMP_BYTES_PER_LINE 16


@@ -65,16 +62,30 @@ ascii_print(register const u_char *cp, register u_int length)
        while (length > 0) {
                s = *cp++;
                length--;
        while (length > 0) {
                s = *cp++;
                length--;

-               if (!isgraph(s) &&
-                   (s != '\t' && s != ' ' && s != '\n' && s != '\r'))
-                       putchar('.');
-               else
-                       putchar(s);
+               if (s == '\r') {
+                       /*
+                        * Don't print CRs at the end of the line; they
+                        * don't belong at the ends of lines on UN*X,
+                        * and the standard I/O library will give us one
+                        * on Windows so we don't need to print one
+                        * ourselves.
+                        *
+                        * In the middle of a line, just print a '.'.
+                        */
+                       if (length > 1 && *cp != '\n')
+                               putchar('.');
+               } else {
+                       if (!ND_ISGRAPH(s) &&
+                           (s != '\t' && s != ' ' && s != '\n'))
+                               putchar('.');
+                       else
+                               putchar(s);
+               }

        }
 }
 
 void
        }
 }
 
 void

-hex_and_ascii_print_with_offset(register const char *ident,
+hex_and_ascii_print_with_offset(netdissect_options *ndo, register const char *ident,

     register const u_char *cp, register u_int length, register u_int oset)
 {
        register u_int i;
     register const u_char *cp, register u_int length, register u_int oset)
 {
        register u_int i;


@@ -92,14 +103,14 @@ hex_and_ascii_print_with_offset(register const char *ident,
                (void)snprintf(hsp, sizeof(hexstuff) - (hsp - hexstuff),
                    " %02x%02x", s1, s2);
                hsp += HEXDUMP_HEXSTUFF_PER_SHORT;
                (void)snprintf(hsp, sizeof(hexstuff) - (hsp - hexstuff),
                    " %02x%02x", s1, s2);
                hsp += HEXDUMP_HEXSTUFF_PER_SHORT;

-               *(asp++) = (isgraph(s1) ? s1 : '.');
-               *(asp++) = (isgraph(s2) ? s2 : '.');
+               *(asp++) = (ND_ISGRAPH(s1) ? s1 : '.');
+               *(asp++) = (ND_ISGRAPH(s2) ? s2 : '.');

                i++;
                if (i >= HEXDUMP_SHORTS_PER_LINE) {
                        *hsp = *asp = '\0';
                i++;
                if (i >= HEXDUMP_SHORTS_PER_LINE) {
                        *hsp = *asp = '\0';

-                       (void)printf("%s0x%04x: %-*s  %s",
+                       ND_PRINT((ndo, "%s0x%04x: %-*s  %s",

                            ident, oset, HEXDUMP_HEXSTUFF_PER_LINE,
                            ident, oset, HEXDUMP_HEXSTUFF_PER_LINE,

-                           hexstuff, asciistuff);
+                           hexstuff, asciistuff));

                        i = 0; hsp = hexstuff; asp = asciistuff;
                        oset += HEXDUMP_BYTES_PER_LINE;
                }
                        i = 0; hsp = hexstuff; asp = asciistuff;
                        oset += HEXDUMP_BYTES_PER_LINE;
                }


@@ -109,22 +120,22 @@ hex_and_ascii_print_with_offset(register const char *ident,
                (void)snprintf(hsp, sizeof(hexstuff) - (hsp - hexstuff),
                    " %02x", s1);
                hsp += 3;
                (void)snprintf(hsp, sizeof(hexstuff) - (hsp - hexstuff),
                    " %02x", s1);
                hsp += 3;

-               *(asp++) = (isgraph(s1) ? s1 : '.');
+               *(asp++) = (ND_ISGRAPH(s1) ? s1 : '.');

                ++i;
        }
        if (i > 0) {
                *hsp = *asp = '\0';
                ++i;
        }
        if (i > 0) {
                *hsp = *asp = '\0';

-               (void)printf("%s0x%04x: %-*s  %s",
+               ND_PRINT((ndo, "%s0x%04x: %-*s  %s",

                     ident, oset, HEXDUMP_HEXSTUFF_PER_LINE,
                     ident, oset, HEXDUMP_HEXSTUFF_PER_LINE,

-                    hexstuff, asciistuff);
+                    hexstuff, asciistuff));

        }
 }
 
 void
        }
 }
 
 void

-hex_and_ascii_print(register const char *ident, register const u_char *cp,
-    register u_int length)
+hex_and_ascii_print(netdissect_options *ndo, register const char *ident,
+    register const u_char *cp, register u_int length)

 {
 {

-       hex_and_ascii_print_with_offset(ident, cp, length, 0);
+       hex_and_ascii_print_with_offset(ndo, ident, cp, length, 0);

 }
 
 /*
 }
 
 /*


@@ -142,16 +153,16 @@ hex_print_with_offset(netdissect_options *ndo,
        i = 0;
        while (--nshorts >= 0) {
                if ((i++ % 8) == 0) {
        i = 0;
        while (--nshorts >= 0) {
                if ((i++ % 8) == 0) {

-                  (void)ND_PRINT((ndo,"%s0x%04x: ", ident, oset));
-                  oset += HEXDUMP_BYTES_PER_LINE;
+                       ND_PRINT((ndo,"%s0x%04x: ", ident, oset));
+                       oset += HEXDUMP_BYTES_PER_LINE;

                }
                s = *cp++;
                }
                s = *cp++;

-               (void)ND_PRINT((ndo," %02x%02x", s, *cp++));
+               ND_PRINT((ndo," %02x%02x", s, *cp++));

        }
        if (length & 1) {
                if ((i % 8) == 0)
        }
        if (length & 1) {
                if ((i % 8) == 0)

-                  (void)ND_PRINT((ndo,"%s0x%04x: ", ident, oset));
-               (void)ND_PRINT((ndo," %02x", *cp));
+                       ND_PRINT((ndo,"%s0x%04x: ", ident, oset));
+               ND_PRINT((ndo," %02x", *cp));

        }
 }
 
        }
 }