travis: try removing the matrix: clause and putting back the Coverity stuff.

[tcpdump] / print-vrrp.c

diff --git a/print-vrrp.c b/print-vrrp.c
index 7920699765d1d7765c29d10a98953875551e6694..2739e37c6294222a3a453723981e136a9dd44329 100644 (file)
--- a/print-vrrp.c
+++ b/print-vrrp.c
@@ -23,16 +23,15 @@
  * FOR A PARTICULAR PURPOSE.
  */
 
  * FOR A PARTICULAR PURPOSE.
  */
 

+/* \summary: Virtual Router Redundancy Protocol (VRRP) printer */
+

 #ifdef HAVE_CONFIG_H
 #ifdef HAVE_CONFIG_H

-#include "config.h"
+#include <config.h>

 #endif
 
 #endif
 

-#include <tcpdump-stdinc.h>
-
-#include <stdio.h>
-#include <stdlib.h>
+#include "netdissect-stdinc.h"

 
 

-#include "interface.h"
+#include "netdissect.h"

 #include "extract.h"
 #include "addrtoname.h"
 
 #include "extract.h"
 #include "addrtoname.h"
 


@@ -104,80 +103,82 @@ static const struct tok auth2str[] = {
 };
 
 void
 };
 
 void

-vrrp_print(register const u_char *bp, register u_int len,
-    register const u_char *bp2, int ttl)
+vrrp_print(netdissect_options *ndo,
+           const u_char *bp, u_int len,
+           const u_char *bp2, int ttl)

 {
        int version, type, auth_type = VRRP_AUTH_NONE; /* keep compiler happy */
        const char *type_s;
 
 {
        int version, type, auth_type = VRRP_AUTH_NONE; /* keep compiler happy */
        const char *type_s;
 

-       TCHECK(bp[0]);
-       version = (bp[0] & 0xf0) >> 4;
-       type = bp[0] & 0x0f;
+       ndo->ndo_protocol = "vrrp";
+       ND_TCHECK_1(bp);
+       version = (GET_U_1(bp) & 0xf0) >> 4;
+       type = GET_U_1(bp) & 0x0f;

        type_s = tok2str(type2str, "unknown type (%u)", type);
        type_s = tok2str(type2str, "unknown type (%u)", type);

-       printf("VRRPv%u, %s", version, type_s);
+       ND_PRINT("VRRPv%u, %s", version, type_s);

        if (ttl != 255)
        if (ttl != 255)

-               printf(", (ttl %u)", ttl);
+               ND_PRINT(", (ttl %u)", ttl);

        if (version < 2 || version > 3 || type != VRRP_TYPE_ADVERTISEMENT)
                return;
        if (version < 2 || version > 3 || type != VRRP_TYPE_ADVERTISEMENT)
                return;

-       TCHECK(bp[2]);
-       printf(", vrid %u, prio %u", bp[1], bp[2]);
-       TCHECK(bp[5]);
+       ND_TCHECK_1(bp + 2);
+       ND_PRINT(", vrid %u, prio %u", GET_U_1(bp + 1), GET_U_1(bp + 2));
+       ND_TCHECK_1(bp + 5);

 
        if (version == 2) {
 
        if (version == 2) {

-               auth_type = bp[4];
-               printf(", authtype %s", tok2str(auth2str, NULL, auth_type));
-               printf(", intvl %us, length %u", bp[5], len);
+               auth_type = GET_U_1(bp + 4);
+               ND_PRINT(", authtype %s", tok2str(auth2str, NULL, auth_type));
+               ND_PRINT(", intvl %us, length %u", GET_U_1(bp + 5), len);

        } else { /* version == 3 */
        } else { /* version == 3 */

-               u_int16_t intvl = (bp[4] & 0x0f) << 8 | bp[5];
-               printf(", intvl %ucs, length %u", intvl, len);
+               uint16_t intvl = (GET_U_1(bp + 4) & 0x0f) << 8 | GET_U_1(bp + 5);
+               ND_PRINT(", intvl %ucs, length %u", intvl, len);

        }
 
        }
 

-       if (vflag) {
-               int naddrs = bp[3];
-               int i;
+       if (ndo->ndo_vflag) {
+               u_int naddrs = GET_U_1(bp + 3);
+               u_int i;

                char c;
 
                char c;
 

-               if (version == 2 && TTEST2(bp[0], len)) {
+               if (version == 2 && ND_TTEST_LEN(bp, len)) {

                        struct cksum_vec vec[1];
 
                        vec[0].ptr = bp;
                        vec[0].len = len;
                        if (in_cksum(vec, 1))
                        struct cksum_vec vec[1];
 
                        vec[0].ptr = bp;
                        vec[0].len = len;
                        if (in_cksum(vec, 1))

-                               printf(", (bad vrrp cksum %x)",
-                                       EXTRACT_16BITS(&bp[6]));
+                               ND_PRINT(", (bad vrrp cksum %x)",
+                                       GET_BE_U_2(bp + 6));

                }
 
                }
 

-               if (version == 3 && TTEST2(bp[0], len)) {
-                       u_int16_t cksum = nextproto4_cksum((struct ip *)bp2, bp,
+               if (version == 3 && ND_TTEST_LEN(bp, len)) {
+                       uint16_t cksum = nextproto4_cksum(ndo, (const struct ip *)bp2, bp,

                                len, len, IPPROTO_VRRP);
                        if (cksum)
                                len, len, IPPROTO_VRRP);
                        if (cksum)

-                               printf(", (bad vrrp cksum %x)",
-                                       EXTRACT_16BITS(&bp[6]));
+                               ND_PRINT(", (bad vrrp cksum %x)",
+                                       GET_BE_U_2(bp + 6));

                }
 
                }
 

-               printf(", addrs");
+               ND_PRINT(", addrs");

                if (naddrs > 1)
                if (naddrs > 1)

-                       printf("(%d)", naddrs);
-               printf(":");
+                       ND_PRINT("(%u)", naddrs);
+               ND_PRINT(":");

                c = ' ';
                bp += 8;
                for (i = 0; i < naddrs; i++) {
                c = ' ';
                bp += 8;
                for (i = 0; i < naddrs; i++) {

-                       TCHECK(bp[3]);
-                       printf("%c%s", c, ipaddr_string(bp));
+                       ND_TCHECK_1(bp + 3);
+                       ND_PRINT("%c%s", c, GET_IPADDR_STRING(bp));

                        c = ',';
                        bp += 4;
                }
                if (version == 2 && auth_type == VRRP_AUTH_SIMPLE) { /* simple text password */
                        c = ',';
                        bp += 4;
                }
                if (version == 2 && auth_type == VRRP_AUTH_SIMPLE) { /* simple text password */

-                       TCHECK(bp[7]);
-                       printf(" auth \"");
-                       if (fn_printn(bp, 8, snapend)) {
-                               printf("\"");
+                       ND_TCHECK_1(bp + 7);
+                       ND_PRINT(" auth \"");
+                       if (nd_printn(ndo, bp, 8, ndo->ndo_snapend)) {
+                               ND_PRINT("\"");

                                goto trunc;
                        }
                                goto trunc;
                        }

-                       printf("\"");
+                       ND_PRINT("\"");

                }
        }
        return;
 trunc:
                }
        }
        return;
 trunc:

-       printf("[|vrrp]");
+       nd_print_trunc(ndo);

 }
 }