Default to first interface from pcap_findalldevs()

[tcpdump] / print-vjc.c

diff --git a/print-vjc.c b/print-vjc.c
index a489776bc561d452a9b67adb3f75a11921716b18..0f37924c52591fede0a7c283573f08e330d6af73 100644 (file)
--- a/print-vjc.c
+++ b/print-vjc.c
@@ -23,12 +23,9 @@
 #include "config.h"
 #endif
 
-#include <tcpdump-stdinc.h>
-
-#include <stdio.h>
-
-#include "interface.h"
+#include <netdissect-stdinc.h>
 
+#include "netdissect.h"
 #include "slcompress.h"
 #include "ppp.h"
 
@@ -73,40 +70,47 @@
  * We therefore leave "proto" - which is the PPP protocol type - in place,
  * *not* marked as unused, for now, so that GCC warnings about the
  * unused argument remind us that we should fix this some day.
+ *
+ * XXX - also, it fetches the TCP checksum field in COMPRESSED_TCP
+ * packets directly, rather than with EXTRACT_16BITS(); RFC 1144 says
+ * it's "the unmodified TCP checksum", which would imply that it's
+ * big-endian, but perhaps, on the platform where this was developed,
+ * the packets were munged by the networking stack before being handed
+ * to the packet capture mechanism.
  */
 int
-vjc_print(register const char *bp, u_short proto _U_)
+vjc_print(netdissect_options *ndo, register const char *bp, u_short proto _U_)
 {
        int i;
 
        switch (bp[0] & 0xf0) {
        case TYPE_IP:
-               if (eflag)
-                       printf("(vjc type=IP) ");
+               if (ndo->ndo_eflag)
+                       ND_PRINT((ndo, "(vjc type=IP) "));
                return PPP_IP;
        case TYPE_UNCOMPRESSED_TCP:
-               if (eflag)
-                       printf("(vjc type=raw TCP) ");
+               if (ndo->ndo_eflag)
+                       ND_PRINT((ndo, "(vjc type=raw TCP) "));
                return PPP_IP;
        case TYPE_COMPRESSED_TCP:
-               if (eflag)
-                       printf("(vjc type=compressed TCP) ");
+               if (ndo->ndo_eflag)
+                       ND_PRINT((ndo, "(vjc type=compressed TCP) "));
                for (i = 0; i < 8; i++) {
                        if (bp[1] & (0x80 >> i))
-                               printf("%c", "?CI?SAWU"[i]);
+                               ND_PRINT((ndo, "%c", "?CI?SAWU"[i]));
                }
                if (bp[1])
-                       printf(" ");
-               printf("C=0x%02x ", bp[2]);
-               printf("sum=0x%04x ", *(u_short *)&bp[3]);
+                       ND_PRINT((ndo, " "));
+               ND_PRINT((ndo, "C=0x%02x ", bp[2]));
+               ND_PRINT((ndo, "sum=0x%04x ", *(const u_short *)&bp[3]));
                return -1;
        case TYPE_ERROR:
-               if (eflag)
-                       printf("(vjc type=error) ");
+               if (ndo->ndo_eflag)
+                       ND_PRINT((ndo, "(vjc type=error) "));
                return -1;
        default:
-               if (eflag)
-                       printf("(vjc type=0x%02x) ", bp[0] & 0xf0);
+               if (ndo->ndo_eflag)
+                       ND_PRINT((ndo, "(vjc type=0x%02x) ", bp[0] & 0xf0));
                return -1;
        }
 }