remove redundant ND_TCHECK, let GET_ routines handle checks

[tcpdump] / print-rt6.c

diff --git a/print-rt6.c b/print-rt6.c
index 269496aaecfc98ccfd107b626e4cf83be2a03a95..e7d9fbde8ca259ac3cefd6237f865cd957e60291 100644 (file)
--- a/print-rt6.c
+++ b/print-rt6.c
@@ -22,10 +22,10 @@
 /* \summary: IPv6 routing header printer */
 
 #ifdef HAVE_CONFIG_H
-#include "config.h"
+#include <config.h>
 #endif
 
-#include <netdissect-stdinc.h>
+#include "netdissect-stdinc.h"
 
 #include <string.h>
 
@@ -40,48 +40,67 @@ rt6_print(netdissect_options *ndo, const u_char *bp, const u_char *bp2 _U_)
 {
        const struct ip6_rthdr *dp;
        const struct ip6_rthdr0 *dp0;
-       const u_char *ep;
+       const struct ip6_srh *srh;
        u_int i, len, type;
-       const struct in6_addr *addr;
+       const u_char *p;
 
-       dp = (const struct ip6_rthdr *)bp;
-
-       /* 'ep' points to the end of available data. */
-       ep = ndo->ndo_snapend;
+       ndo->ndo_protocol = "rt6";
 
-       ND_TCHECK(dp->ip6r_segleft);
+       nd_print_protocol_caps(ndo);
+       dp = (const struct ip6_rthdr *)bp;
 
-       len = EXTRACT_U_1(dp->ip6r_len);
-       ND_PRINT((ndo, "srcrt (len=%u", len));  /*)*/
-       type = EXTRACT_U_1(dp->ip6r_type);
-       ND_PRINT((ndo, ", type=%u", type));
-       ND_PRINT((ndo, ", segleft=%u", EXTRACT_U_1(dp->ip6r_segleft)));
+       len = GET_U_1(dp->ip6r_len);
+       ND_PRINT(" (len=%u", len);      /*)*/
+       type = GET_U_1(dp->ip6r_type);
+       ND_PRINT(", type=%u", type);
+       if (type == IPV6_RTHDR_TYPE_0)
+               ND_PRINT(" [Deprecated]");
+       ND_PRINT(", segleft=%u", GET_U_1(dp->ip6r_segleft));
 
        switch (type) {
        case IPV6_RTHDR_TYPE_0:
        case IPV6_RTHDR_TYPE_2:                 /* Mobile IPv6 ID-20 */
                dp0 = (const struct ip6_rthdr0 *)dp;
 
-               ND_TCHECK(dp0->ip6r0_reserved);
-               if (EXTRACT_BE_U_4(dp0->ip6r0_reserved) || ndo->ndo_vflag) {
-                       ND_PRINT((ndo, ", rsv=0x%0x",
-                           EXTRACT_BE_U_4(dp0->ip6r0_reserved)));
+               if (GET_BE_U_4(dp0->ip6r0_reserved) || ndo->ndo_vflag) {
+                       ND_PRINT(", rsv=0x%0x",
+                           GET_BE_U_4(dp0->ip6r0_reserved));
                }
 
                if (len % 2 == 1)
                        goto trunc;
                len >>= 1;
-               addr = &dp0->ip6r0_addr[0];
+               p = (const u_char *) dp0->ip6r0_addr;
                for (i = 0; i < len; i++) {
-                       if ((const u_char *)(addr + 1) > ep)
-                               goto trunc;
+                       ND_PRINT(", [%u]%s", i, GET_IP6ADDR_STRING(p));
+                       p += 16;
+               }
+               /*(*/
+               ND_PRINT(") ");
+               return((GET_U_1(dp0->ip6r0_len) + 1) << 3);
+               break;
+       case IPV6_RTHDR_TYPE_4:
+               srh = (const struct ip6_srh *)dp;
+               ND_PRINT(", last-entry=%u", GET_U_1(srh->srh_last_ent));
 
-                       ND_PRINT((ndo, ", [%d]%s", i, ip6addr_string(ndo, addr)));
-                       addr++;
+               if (GET_U_1(srh->srh_flags) || ndo->ndo_vflag) {
+                       ND_PRINT(", flags=0x%0x",
+                               GET_U_1(srh->srh_flags));
+               }
+
+               ND_PRINT(", tag=%x", GET_BE_U_2(srh->srh_tag));
+
+               if (len % 2 == 1)
+                       goto trunc;
+               len >>= 1;
+               p  = (const u_char *) srh->srh_segments;
+               for (i = 0; i < len; i++) {
+                       ND_PRINT(", [%u]%s", i, GET_IP6ADDR_STRING(p));
+                       p += 16;
                }
                /*(*/
-               ND_PRINT((ndo, ") "));
-               return((EXTRACT_U_1(dp0->ip6r0_len) + 1) << 3);
+               ND_PRINT(") ");
+               return((GET_U_1(srh->srh_len) + 1) << 3);
                break;
        default:
                goto trunc;
@@ -89,6 +108,6 @@ rt6_print(netdissect_options *ndo, const u_char *bp, const u_char *bp2 _U_)
        }
 
  trunc:
-       ND_PRINT((ndo, "[|srcrt]"));
+       nd_print_trunc(ndo);
        return -1;
 }