]> The Tcpdump Group git mirrors - tcpdump/blobdiff - print-fr.c
The third argument to linkaddr_string is one of the LINKADDR_ enums.
[tcpdump] / print-fr.c
index 2e04cbdca156a5a331c2524796cd99838b182fd7..59d394171c6276b34279ca860f4d9f3305921feb 100644 (file)
  * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE.
  */
 
+/* \summary: Frame Relay printer */
+
 #ifdef HAVE_CONFIG_H
-#include "config.h"
+#include <config.h>
 #endif
 
-#include <tcpdump-stdinc.h>
+#include "netdissect-stdinc.h"
 
 #include <stdio.h>
 #include <string.h>
 
-#include "interface.h"
+#include "netdissect.h"
 #include "addrtoname.h"
 #include "ethertype.h"
 #include "llc.h"
@@ -96,62 +98,60 @@ static const struct tok frf_flag_values[] = {
  * 0 on invalid address, -1 on truncated packet
  * save the flags dep. on address length
  */
-static int parse_q922_addr(netdissect_options *ndo,
+static int parse_q922_header(netdissect_options *ndo,
                            const u_char *p, u_int *dlci,
-                           u_int *addr_len, uint8_t *flags, u_int length)
+                           u_int *addr_len, uint32_t *flags, u_int length)
 {
-       if (!ND_TTEST(p[0]) || length < 1)
+       if (!ND_TTEST_1(p) || length < 1)
                return -1;
-       if ((p[0] & FR_EA_BIT))
+       if ((GET_U_1(p) & FR_EA_BIT))
                return 0;
 
-       if (!ND_TTEST(p[1]) || length < 2)
+       if (!ND_TTEST_1(p + 1) || length < 2)
                return -1;
        *addr_len = 2;
-       *dlci = ((p[0] & 0xFC) << 2) | ((p[1] & 0xF0) >> 4);
+       *dlci = ((GET_U_1(p) & 0xFC) << 2) | ((GET_U_1(p + 1) & 0xF0) >> 4);
 
-        flags[0] = p[0] & 0x02; /* populate the first flag fields */
-        flags[1] = p[1] & 0x0c;
-        flags[2] = 0;           /* clear the rest of the flags */
-        flags[3] = 0;
+       *flags = ((GET_U_1(p) & 0x02) << 24) |  /* CR flag */
+                ((GET_U_1(p + 1) & 0x0e) << 16);       /* FECN,BECN,DE flags */
 
-       if (p[1] & FR_EA_BIT)
+       if (GET_U_1(p + 1) & FR_EA_BIT)
                return 1;       /* 2-byte Q.922 address */
 
        p += 2;
        length -= 2;
-       if (!ND_TTEST(p[0]) || length < 1)
+       if (!ND_TTEST_1(p) || length < 1)
                return -1;
        (*addr_len)++;          /* 3- or 4-byte Q.922 address */
-       if ((p[0] & FR_EA_BIT) == 0) {
-               *dlci = (*dlci << 7) | (p[0] >> 1);
+       if ((GET_U_1(p) & FR_EA_BIT) == 0) {
+               *dlci = (*dlci << 7) | (GET_U_1(p) >> 1);
                (*addr_len)++;  /* 4-byte Q.922 address */
                p++;
                length--;
        }
 
-       if (!ND_TTEST(p[0]) || length < 1)
+       if (!ND_TTEST_1(p) || length < 1)
                return -1;
-       if ((p[0] & FR_EA_BIT) == 0)
+       if ((GET_U_1(p) & FR_EA_BIT) == 0)
                return 0; /* more than 4 bytes of Q.922 address? */
 
-        flags[3] = p[0] & 0x02;
+       *flags = *flags | (GET_U_1(p) & 0x02);  /* SDLC flag */
 
-        *dlci = (*dlci << 6) | (p[0] >> 2);
+        *dlci = (*dlci << 6) | (GET_U_1(p) >> 2);
 
        return 1;
 }
 
-char *
+const char *
 q922_string(netdissect_options *ndo, const u_char *p, u_int length)
 {
 
     static u_int dlci, addr_len;
-    static uint8_t flags[4];
+    static uint32_t flags;
     static char buffer[sizeof("DLCI xxxxxxxxxx")];
     memset(buffer, 0, sizeof(buffer));
 
-    if (parse_q922_addr(ndo, p, &dlci, &addr_len, flags, length) == 1){
+    if (parse_q922_header(ndo, p, &dlci, &addr_len, &flags, length) == 1){
         snprintf(buffer, sizeof(buffer), "DLCI %u", dlci);
     }
 
@@ -186,54 +186,55 @@ q922_string(netdissect_options *ndo, const u_char *p, u_int length)
 */
 
 static void
-fr_hdr_print(netdissect_options *ndo,
-             int length, u_int addr_len, u_int dlci, uint8_t *flags, uint16_t nlpid)
+fr_hdr_print(netdissect_options *ndo, int length, u_int addr_len,
+            u_int dlci, uint32_t flags, uint16_t nlpid)
 {
     if (ndo->ndo_qflag) {
-        ND_PRINT((ndo, "Q.922, DLCI %u, length %u: ",
+        ND_PRINT("Q.922, DLCI %u, length %u: ",
                      dlci,
-                     length));
+                     length);
     } else {
         if (nlpid <= 0xff) /* if its smaller than 256 then its a NLPID */
-            ND_PRINT((ndo, "Q.922, hdr-len %u, DLCI %u, Flags [%s], NLPID %s (0x%02x), length %u: ",
+            ND_PRINT("Q.922, hdr-len %u, DLCI %u, Flags [%s], NLPID %s (0x%02x), length %u: ",
                          addr_len,
                          dlci,
-                         bittok2str(fr_header_flag_values, "none", EXTRACT_32BITS(flags)),
+                         bittok2str(fr_header_flag_values, "none", flags),
                          tok2str(nlpid_values,"unknown", nlpid),
                          nlpid,
-                         length));
+                         length);
         else /* must be an ethertype */
-            ND_PRINT((ndo, "Q.922, hdr-len %u, DLCI %u, Flags [%s], cisco-ethertype %s (0x%04x), length %u: ",
+            ND_PRINT("Q.922, hdr-len %u, DLCI %u, Flags [%s], cisco-ethertype %s (0x%04x), length %u: ",
                          addr_len,
                          dlci,
-                         bittok2str(fr_header_flag_values, "none", EXTRACT_32BITS(flags)),
+                         bittok2str(fr_header_flag_values, "none", flags),
                          tok2str(ethertype_values, "unknown", nlpid),
                          nlpid,
-                         length));
+                         length);
     }
 }
 
 u_int
 fr_if_print(netdissect_options *ndo,
-            const struct pcap_pkthdr *h, register const u_char *p)
+            const struct pcap_pkthdr *h, const u_char *p)
 {
-       register u_int length = h->len;
-       register u_int caplen = h->caplen;
+       u_int length = h->len;
+       u_int caplen = h->caplen;
 
-        ND_TCHECK2(*p, 4); /* minimum frame header length */
+       ndo->ndo_protocol = "fr_if";
+        ND_TCHECK_4(p); /* minimum frame header length */
 
         if ((length = fr_print(ndo, p, length)) == 0)
             return (0);
         else
             return length;
- trunc:
-        ND_PRINT((ndo, "[|fr]"));
+trunc:
+        nd_print_trunc(ndo);
         return caplen;
 }
 
 u_int
 fr_print(netdissect_options *ndo,
-         register const u_char *p, u_int length)
+         const u_char *p, u_int length)
 {
        int ret;
        uint16_t extracted_ethertype;
@@ -241,31 +242,32 @@ fr_print(netdissect_options *ndo,
        u_int addr_len;
        uint16_t nlpid;
        u_int hdr_len;
-       uint8_t flags[4];
+       uint32_t flags;
 
-       ret = parse_q922_addr(ndo, p, &dlci, &addr_len, flags, length);
+       ndo->ndo_protocol = "fr";
+       ret = parse_q922_header(ndo, p, &dlci, &addr_len, &flags, length);
        if (ret == -1)
                goto trunc;
        if (ret == 0) {
-               ND_PRINT((ndo, "Q.922, invalid address"));
+               ND_PRINT("Q.922, invalid address");
                return 0;
        }
 
-       ND_TCHECK(p[addr_len]);
+       ND_TCHECK_1(p + addr_len);
        if (length < addr_len + 1)
                goto trunc;
 
-       if (p[addr_len] != LLC_UI && dlci != 0) {
+       if (GET_U_1(p + addr_len) != LLC_UI && dlci != 0) {
                 /*
                  * Let's figure out if we have Cisco-style encapsulation,
                  * with an Ethernet type (Cisco HDLC type?) following the
                  * address.
                  */
-               if (!ND_TTEST2(p[addr_len], 2) || length < addr_len + 2) {
+               if (!ND_TTEST_2(p + addr_len) || length < addr_len + 2) {
                         /* no Ethertype */
-                        ND_PRINT((ndo, "UI %02x! ", p[addr_len]));
+                        ND_PRINT("UI %02x! ", GET_U_1(p + addr_len));
                 } else {
-                        extracted_ethertype = EXTRACT_16BITS(p+addr_len);
+                        extracted_ethertype = GET_BE_U_2(p + addr_len);
 
                         if (ndo->ndo_eflag)
                                 fr_hdr_print(ndo, length, addr_len, dlci,
@@ -274,25 +276,26 @@ fr_print(netdissect_options *ndo,
                         if (ethertype_print(ndo, extracted_ethertype,
                                             p+addr_len+ETHERTYPE_LEN,
                                             length-addr_len-ETHERTYPE_LEN,
-                                            length-addr_len-ETHERTYPE_LEN) == 0)
+                                            ND_BYTES_AVAILABLE_AFTER(p)-addr_len-ETHERTYPE_LEN,
+                                            NULL, NULL) == 0)
                                 /* ether_type not known, probably it wasn't one */
-                                ND_PRINT((ndo, "UI %02x! ", p[addr_len]));
+                                ND_PRINT("UI %02x! ", GET_U_1(p + addr_len));
                         else
                                 return addr_len + 2;
                 }
         }
 
-       ND_TCHECK(p[addr_len+1]);
+       ND_TCHECK_1(p + addr_len + 1);
        if (length < addr_len + 2)
                goto trunc;
 
-       if (p[addr_len + 1] == 0) {
+       if (GET_U_1(p + addr_len + 1) == 0) {
                /*
                 * Assume a pad byte after the control (UI) byte.
                 * A pad byte should only be used with 3-byte Q.922.
                 */
                if (addr_len != 3)
-                       ND_PRINT((ndo, "Pad! "));
+                       ND_PRINT("Pad! ");
                hdr_len = addr_len + 1 /* UI */ + 1 /* pad */ + 1 /* NLPID */;
        } else {
                /*
@@ -300,14 +303,14 @@ fr_print(netdissect_options *ndo,
                 * A pad byte should be used with 3-byte Q.922.
                 */
                if (addr_len == 3)
-                       ND_PRINT((ndo, "No pad! "));
+                       ND_PRINT("No pad! ");
                hdr_len = addr_len + 1 /* UI */ + 1 /* NLPID */;
        }
 
-        ND_TCHECK(p[hdr_len - 1]);
+        ND_TCHECK_1(p + hdr_len - 1);
        if (length < hdr_len)
                goto trunc;
-       nlpid = p[hdr_len - 1];
+       nlpid = GET_U_1(p + hdr_len - 1);
 
        if (ndo->ndo_eflag)
                fr_hdr_print(ndo, length, addr_len, dlci, flags, nlpid);
@@ -326,11 +329,11 @@ fr_print(netdissect_options *ndo,
        case NLPID_CLNP:
        case NLPID_ESIS:
        case NLPID_ISIS:
-               isoclns_print(ndo, p - 1, length + 1, length + 1); /* OSI printers need the NLPID field */
+               isoclns_print(ndo, p - 1, length + 1); /* OSI printers need the NLPID field */
                break;
 
        case NLPID_SNAP:
-               if (snap_print(ndo, p, length, length, NULL, NULL, 0) == 0) {
+               if (snap_print(ndo, p, length, ND_BYTES_AVAILABLE_AFTER(p), NULL, NULL, 0) == 0) {
                        /* ether_type not known, print raw packet */
                         if (!ndo->ndo_eflag)
                             fr_hdr_print(ndo, length + hdr_len, hdr_len,
@@ -362,27 +365,28 @@ fr_print(netdissect_options *ndo,
 
        return hdr_len;
 
- trunc:
-        ND_PRINT((ndo, "[|fr]"));
+trunc:
+        nd_print_trunc(ndo);
         return 0;
 
 }
 
 u_int
 mfr_if_print(netdissect_options *ndo,
-             const struct pcap_pkthdr *h, register const u_char *p)
+             const struct pcap_pkthdr *h, const u_char *p)
 {
-       register u_int length = h->len;
-       register u_int caplen = h->caplen;
+       u_int length = h->len;
+       u_int caplen = h->caplen;
 
-        ND_TCHECK2(*p, 2); /* minimum frame header length */
+       ndo->ndo_protocol = "mfr_if";
+        ND_TCHECK_2(p); /* minimum frame header length */
 
         if ((length = mfr_print(ndo, p, length)) == 0)
             return (0);
         else
             return length;
- trunc:
-        ND_PRINT((ndo, "[|mfr]"));
+trunc:
+        nd_print_trunc(ndo);
         return caplen;
 }
 
@@ -432,7 +436,7 @@ struct ie_tlv_header_t {
 
 u_int
 mfr_print(netdissect_options *ndo,
-          register const u_char *p, u_int length)
+          const u_char *p, u_int length)
 {
     u_int tlen,idx,hdr_len = 0;
     uint16_t sequence_num;
@@ -453,13 +457,20 @@ mfr_print(netdissect_options *ndo,
  *    +----+----+----+----+----+----+----+----+
  */
 
-    ND_TCHECK2(*p, 4); /* minimum frame header length */
+    ndo->ndo_protocol = "mfr";
+
+    if (length < 4) {  /* minimum frame header length */
+        ND_PRINT("[length %u < 4]", length);
+        nd_print_invalid(ndo);
+        return length;
+    }
+    ND_TCHECK_4(p);
 
-    if ((p[0] & MFR_BEC_MASK) == MFR_CTRL_FRAME && p[1] == 0) {
-        ND_PRINT((ndo, "FRF.16 Control, Flags [%s], %s, length %u",
-               bittok2str(frf_flag_values,"none",(p[0] & MFR_BEC_MASK)),
-               tok2str(mfr_ctrl_msg_values,"Unknown Message (0x%02x)",p[2]),
-               length));
+    if ((GET_U_1(p) & MFR_BEC_MASK) == MFR_CTRL_FRAME && GET_U_1(p + 1) == 0) {
+        ND_PRINT("FRF.16 Control, Flags [%s], %s, length %u",
+               bittok2str(frf_flag_values,"none",(GET_U_1(p) & MFR_BEC_MASK)),
+               tok2str(mfr_ctrl_msg_values,"Unknown Message (0x%02x)",GET_U_1(p + 2)),
+               length);
         tptr = p + 3;
         tlen = length -3;
         hdr_len = 3;
@@ -468,20 +479,20 @@ mfr_print(netdissect_options *ndo,
             return hdr_len;
 
         while (tlen>sizeof(struct ie_tlv_header_t)) {
-            ND_TCHECK2(*tptr, sizeof(struct ie_tlv_header_t));
-            ie_type=tptr[0];
-            ie_len=tptr[1];
+            ND_TCHECK_LEN(tptr, sizeof(struct ie_tlv_header_t));
+            ie_type=GET_U_1(tptr);
+            ie_len=GET_U_1(tptr + 1);
 
-            ND_PRINT((ndo, "\n\tIE %s (%u), length %u: ",
+            ND_PRINT("\n\tIE %s (%u), length %u: ",
                    tok2str(mfr_ctrl_ie_values,"Unknown",ie_type),
                    ie_type,
-                   ie_len));
+                   ie_len);
 
             /* infinite loop check */
             if (ie_type == 0 || ie_len <= sizeof(struct ie_tlv_header_t))
                 return hdr_len;
 
-            ND_TCHECK2(*tptr, ie_len);
+            ND_TCHECK_LEN(tptr, ie_len);
             tptr+=sizeof(struct ie_tlv_header_t);
             /* tlv len includes header */
             ie_len-=sizeof(struct ie_tlv_header_t);
@@ -490,14 +501,20 @@ mfr_print(netdissect_options *ndo,
             switch (ie_type) {
 
             case MFR_CTRL_IE_MAGIC_NUM:
-                ND_PRINT((ndo, "0x%08x", EXTRACT_32BITS(tptr)));
+                /* FRF.16.1 Section 3.4.3 Magic Number Information Element */
+                if (ie_len != 4) {
+                    ND_PRINT("[IE data length %d != 4]", ie_len);
+                    nd_print_invalid(ndo);
+                    break;
+                }
+                ND_PRINT("0x%08x", GET_BE_U_4(tptr));
                 break;
 
             case MFR_CTRL_IE_BUNDLE_ID: /* same message format */
             case MFR_CTRL_IE_LINK_ID:
                 for (idx = 0; idx < ie_len && idx < MFR_ID_STRING_MAXLEN; idx++) {
-                    if (*(tptr+idx) != 0) /* don't print null termination */
-                        safeputchar(ndo, *(tptr + idx));
+                    if (GET_U_1(tptr + idx) != 0) /* don't print null termination */
+                        fn_print_char(ndo, GET_U_1(tptr + idx));
                     else
                         break;
                 }
@@ -509,6 +526,7 @@ mfr_print(netdissect_options *ndo,
                     break;
                 }
                 /* fall through and hexdump if no unix timestamp */
+                ND_FALL_THROUGH;
 
                 /*
                  * FIXME those are the defined IEs that lack a decoder
@@ -538,38 +556,38 @@ mfr_print(netdissect_options *ndo,
  *
  *      7    6    5    4    3    2    1    0
  *    +----+----+----+----+----+----+----+----+
- *    | B  | E  | C=0|seq. (high 4 bits) | EA  |
+ *    | B  | E  | C=0|seq. (high 4 bits) | EA |
  *    +----+----+----+----+----+----+----+----+
  *    |        sequence  (low 8 bits)         |
  *    +----+----+----+----+----+----+----+----+
- *    |        DLCI (6 bits)        | CR | EA  |
+ *    |        DLCI (6 bits)        | CR | EA |
  *    +----+----+----+----+----+----+----+----+
  *    |   DLCI (4 bits)   |FECN|BECN| DE | EA |
  *    +----+----+----+----+----+----+----+----+
  */
 
-    sequence_num = (p[0]&0x1e)<<7 | p[1];
+    sequence_num = (GET_U_1(p)&0x1e)<<7 | GET_U_1(p + 1);
     /* whole packet or first fragment ? */
-    if ((p[0] & MFR_BEC_MASK) == MFR_FRAG_FRAME ||
-        (p[0] & MFR_BEC_MASK) == MFR_B_BIT) {
-        ND_PRINT((ndo, "FRF.16 Frag, seq %u, Flags [%s], ",
+    if ((GET_U_1(p) & MFR_BEC_MASK) == MFR_FRAG_FRAME ||
+        (GET_U_1(p) & MFR_BEC_MASK) == MFR_B_BIT) {
+        ND_PRINT("FRF.16 Frag, seq %u, Flags [%s], ",
                sequence_num,
-               bittok2str(frf_flag_values,"none",(p[0] & MFR_BEC_MASK))));
+               bittok2str(frf_flag_values,"none",(GET_U_1(p) & MFR_BEC_MASK)));
         hdr_len = 2;
         fr_print(ndo, p+hdr_len,length-hdr_len);
         return hdr_len;
     }
 
     /* must be a middle or the last fragment */
-    ND_PRINT((ndo, "FRF.16 Frag, seq %u, Flags [%s]",
+    ND_PRINT("FRF.16 Frag, seq %u, Flags [%s]",
            sequence_num,
-           bittok2str(frf_flag_values,"none",(p[0] & MFR_BEC_MASK))));
+           bittok2str(frf_flag_values,"none",(GET_U_1(p) & MFR_BEC_MASK)));
     print_unknown_data(ndo, p, "\n\t", length);
 
     return hdr_len;
 
- trunc:
-    ND_PRINT((ndo, "[|mfr]"));
+trunc:
+    nd_print_trunc(ndo);
     return length;
 }
 
@@ -596,14 +614,18 @@ frf15_print(netdissect_options *ndo,
 {
     uint16_t sequence_num, flags;
 
-    flags = p[0]&MFR_BEC_MASK;
-    sequence_num = (p[0]&0x1e)<<7 | p[1];
+    if (length < 2)
+        goto trunc;
+    ND_TCHECK_2(p);
 
-    ND_PRINT((ndo, "FRF.15, seq 0x%03x, Flags [%s],%s Fragmentation, length %u",
+    flags = GET_U_1(p)&MFR_BEC_MASK;
+    sequence_num = (GET_U_1(p)&0x1e)<<7 | GET_U_1(p + 1);
+
+    ND_PRINT("FRF.15, seq 0x%03x, Flags [%s],%s Fragmentation, length %u",
            sequence_num,
            bittok2str(frf_flag_values,"none",flags),
-           p[0]&FR_FRF15_FRAGTYPE ? "Interface" : "End-to-End",
-           length));
+           GET_U_1(p)&FR_FRF15_FRAGTYPE ? "Interface" : "End-to-End",
+           length);
 
 /* TODO:
  * depending on all permutations of the B, E and C bit
@@ -613,7 +635,10 @@ frf15_print(netdissect_options *ndo,
  * model is end-to-end or interface based wether we want to print
  * another Q.922 header
  */
+    return;
 
+trunc:
+    nd_print_trunc(ndo);
 }
 
 /*
@@ -681,7 +706,11 @@ static const struct tok fr_q933_msg_values[] = {
     { 0, NULL }
 };
 
-#define MSG_ANSI_LOCKING_SHIFT 0x95
+#define IE_IS_SINGLE_OCTET(iecode)     ((iecode) & 0x80)
+#define IE_IS_SHIFT(iecode)            (((iecode) & 0xF0) == 0x90)
+#define IE_SHIFT_IS_NON_LOCKING(iecode)        ((iecode) & 0x08)
+#define IE_SHIFT_IS_LOCKING(iecode)    (!(IE_SHIFT_IS_NON_LOCKING(iecode)))
+#define IE_SHIFT_CODESET(iecode)       ((iecode) & 0x07)
 
 #define FR_LMI_ANSI_REPORT_TYPE_IE     0x01
 #define FR_LMI_ANSI_LINK_VERIFY_IE_91  0x19 /* details? */
@@ -692,7 +721,7 @@ static const struct tok fr_q933_msg_values[] = {
 #define FR_LMI_CCITT_LINK_VERIFY_IE    0x53
 #define FR_LMI_CCITT_PVC_STATUS_IE     0x57
 
-static const struct tok fr_q933_ie_values_codeset5[] = {
+static const struct tok fr_q933_ie_values_codeset_0_5[] = {
     { FR_LMI_ANSI_REPORT_TYPE_IE, "ANSI Report Type" },
     { FR_LMI_ANSI_LINK_VERIFY_IE_91, "ANSI Link Verify" },
     { FR_LMI_ANSI_LINK_VERIFY_IE, "ANSI Link Verify" },
@@ -714,14 +743,14 @@ static const struct tok fr_lmi_report_type_ie_values[] = {
     { 0, NULL }
 };
 
-/* array of 16 codepages - currently we only support codepage 1,5 */
+/* array of 16 codesets - currently we only support codepage 0 and 5 */
 static const struct tok *fr_q933_ie_codesets[] = {
+    fr_q933_ie_values_codeset_0_5,
     NULL,
-    fr_q933_ie_values_codeset5,
     NULL,
     NULL,
     NULL,
-    fr_q933_ie_values_codeset5,
+    fr_q933_ie_values_codeset_0_5,
     NULL,
     NULL,
     NULL,
@@ -734,20 +763,20 @@ static const struct tok *fr_q933_ie_codesets[] = {
     NULL
 };
 
-static int fr_q933_print_ie_codeset5(netdissect_options *ndo,
-    const struct ie_tlv_header_t  *ie_p, const u_char *p);
+static int fr_q933_print_ie_codeset_0_5(netdissect_options *ndo, u_int iecode,
+    u_int ielength, const u_char *p);
 
-typedef int (*codeset_pr_func_t)(netdissect_options *,
-    const struct ie_tlv_header_t  *ie_p, const u_char *p);
+typedef int (*codeset_pr_func_t)(netdissect_options *, u_int iecode,
+    u_int ielength, const u_char *p);
 
-/* array of 16 codepages - currently we only support codepage 1,5 */
+/* array of 16 codesets - currently we only support codepage 0 and 5 */
 static const codeset_pr_func_t fr_q933_print_ie_codeset[] = {
+    fr_q933_print_ie_codeset_0_5,
     NULL,
-    fr_q933_print_ie_codeset5,
     NULL,
     NULL,
     NULL,
-    fr_q933_print_ie_codeset5,
+    fr_q933_print_ie_codeset_0_5,
     NULL,
     NULL,
     NULL,
@@ -760,121 +789,317 @@ static const codeset_pr_func_t fr_q933_print_ie_codeset[] = {
     NULL
 };
 
+/*
+ * ITU-T Q.933.
+ *
+ * p points to octet 2, the octet containing the length of the
+ * call reference value, so p[n] is octet n+2 ("octet X" is as
+ * used in Q.931/Q.933).
+ *
+ * XXX - actually used both for Q.931 and Q.933.
+ */
 void
 q933_print(netdissect_options *ndo,
            const u_char *p, u_int length)
 {
-       const u_char *ptemp = p;
-       const struct ie_tlv_header_t  *ie_p;
-        int olen;
-       int is_ansi = 0;
-        u_int codeset;
-        u_int ie_is_known = 0;
-
-       if (length < 9) {       /* shortest: Q.933a LINK VERIFY */
-               ND_PRINT((ndo, "[|q.933]"));
-               return;
-       }
-
-        codeset = p[2]&0x0f;   /* extract the codeset */
-
-       if (p[2] == MSG_ANSI_LOCKING_SHIFT) {
-               is_ansi = 1;
+       u_int olen;
+       u_int call_ref_length, i;
+       uint8_t call_ref[15];   /* maximum length - length field is 4 bits */
+       u_int msgtype;
+       u_int iecode;
+       u_int ielength;
+       u_int codeset = 0;
+       u_int is_ansi = 0;
+       u_int ie_is_known;
+       u_int non_locking_shift;
+       u_int unshift_codeset;
+
+       ndo->ndo_protocol = "q.933";
+       ND_PRINT("%s", ndo->ndo_eflag ? "" : "Q.933");
+
+       if (length == 0 || !ND_TTEST_1(p)) {
+               if (!ndo->ndo_eflag)
+                       ND_PRINT(", ");
+               ND_PRINT("length %u", length);
+               goto trunc;
        }
 
-        ND_PRINT((ndo, "%s", ndo->ndo_eflag ? "" : "Q.933, "));
-
-       /* printing out header part */
-       ND_PRINT((ndo, "%s, codeset %u", is_ansi ? "ANSI" : "CCITT", codeset));
-
-       if (p[0]) {
-               ND_PRINT((ndo, ", Call Ref: 0x%02x", p[0]));
-       }
-        if (ndo->ndo_vflag) {
-                ND_PRINT((ndo, ", %s (0x%02x), length %u",
-                      tok2str(fr_q933_msg_values,
-                              "unknown message", p[1]),
-                      p[1],
-                      length));
-        } else {
-                ND_PRINT((ndo, ", %s",
-                      tok2str(fr_q933_msg_values,
-                              "unknown message 0x%02x", p[1])));
+       /*
+        * Get the length of the call reference value.
+        */
+       olen = length; /* preserve the original length for display */
+       call_ref_length = GET_U_1(p) & 0x0f;
+       p++;
+       length--;
+
+       /*
+        * Get the call reference value.
+        */
+       for (i = 0; i < call_ref_length; i++) {
+               if (length == 0 || !ND_TTEST_1(p)) {
+                       if (!ndo->ndo_eflag)
+                               ND_PRINT(", ");
+                       ND_PRINT("length %u", olen);
+                       goto trunc;
+               }
+               call_ref[i] = GET_U_1(p);
+               p++;
+               length--;
        }
 
-        olen = length; /* preserve the original length for non verbose mode */
-
-       if (length < (u_int)(2 - is_ansi)) {
-               ND_PRINT((ndo, "[|q.933]"));
-               return;
+       /*
+        * Get the message type.
+        */
+       if (length == 0 || !ND_TTEST_1(p)) {
+               if (!ndo->ndo_eflag)
+                       ND_PRINT(", ");
+               ND_PRINT("length %u", olen);
+               goto trunc;
        }
-       length -= 2 + is_ansi;
-       ptemp += 2 + is_ansi;
-
-       /* Loop through the rest of IE */
-       while (length > sizeof(struct ie_tlv_header_t)) {
-               ie_p = (const struct ie_tlv_header_t  *)ptemp;
-               if (length < sizeof(struct ie_tlv_header_t) ||
-                   length < sizeof(struct ie_tlv_header_t) + ie_p->ie_len) {
-                    if (ndo->ndo_vflag) { /* not bark if there is just a trailer */
-                        ND_PRINT((ndo, "\n[|q.933]"));
-                    } else {
-                        ND_PRINT((ndo, ", length %u", olen));
-                   }
-                    return;
+       msgtype = GET_U_1(p);
+       p++;
+       length--;
+
+       /*
+        * Peek ahead to see if we start with a shift.
+        */
+       non_locking_shift = 0;
+       unshift_codeset = codeset;
+       if (length != 0) {
+               if (!ND_TTEST_1(p)) {
+                       if (!ndo->ndo_eflag)
+                               ND_PRINT(", ");
+                       ND_PRINT("length %u", olen);
+                       goto trunc;
                }
-
-                /* lets do the full IE parsing only in verbose mode
-                 * however some IEs (DLCI Status, Link Verify)
-                 * are also interestting in non-verbose mode */
-                if (ndo->ndo_vflag) {
-                    ND_PRINT((ndo, "\n\t%s IE (0x%02x), length %u: ",
-                           tok2str(fr_q933_ie_codesets[codeset],
-                                  "unknown", ie_p->ie_type),
-                           ie_p->ie_type,
-                           ie_p->ie_len));
+               iecode = GET_U_1(p);
+               if (IE_IS_SHIFT(iecode)) {
+                       /*
+                        * It's a shift.  Skip over it.
+                        */
+                       p++;
+                       length--;
+
+                       /*
+                        * Get the codeset.
+                        */
+                       codeset = IE_SHIFT_CODESET(iecode);
+
+                       /*
+                        * If it's a locking shift to codeset 5,
+                        * mark this as ANSI.  (XXX - 5 is actually
+                        * for national variants in general, not
+                        * the US variant in particular, but maybe
+                        * this is more American exceptionalism. :-))
+                        */
+                       if (IE_SHIFT_IS_LOCKING(iecode)) {
+                               /*
+                                * It's a locking shift.
+                                */
+                               if (codeset == 5) {
+                                       /*
+                                        * It's a locking shift to
+                                        * codeset 5, so this is
+                                        * T1.617 Annex D.
+                                        */
+                                       is_ansi = 1;
+                               }
+                       } else {
+                               /*
+                                * It's a non-locking shift.
+                                * Remember the current codeset, so we
+                                * can revert to it after the next IE.
+                                */
+                               non_locking_shift = 1;
+                               unshift_codeset = 0;
+                       }
                }
+       }
 
-                /* sanity check */
-                if (ie_p->ie_type == 0 || ie_p->ie_len == 0) {
-                    return;
+       /* printing out header part */
+       if (!ndo->ndo_eflag)
+               ND_PRINT(", ");
+       ND_PRINT("%s, codeset %u", is_ansi ? "ANSI" : "CCITT", codeset);
+
+       if (call_ref_length != 0) {
+               ND_TCHECK_1(p);
+               if (call_ref_length > 1 || GET_U_1(p) != 0) {
+                       /*
+                        * Not a dummy call reference.
+                        */
+                       ND_PRINT(", Call Ref: 0x");
+                       for (i = 0; i < call_ref_length; i++)
+                               ND_PRINT("%02x", call_ref[i]);
                }
+       }
+       if (ndo->ndo_vflag) {
+               ND_PRINT(", %s (0x%02x), length %u",
+                  tok2str(fr_q933_msg_values,
+                       "unknown message", msgtype),
+                  msgtype,
+                  olen);
+       } else {
+               ND_PRINT(", %s",
+                      tok2str(fr_q933_msg_values,
+                              "unknown message 0x%02x", msgtype));
+       }
 
-                if (fr_q933_print_ie_codeset[codeset] != NULL) {
-                    ie_is_known = fr_q933_print_ie_codeset[codeset](ndo, ie_p, ptemp);
+       /* Loop through the rest of the IEs */
+       while (length != 0) {
+               /*
+                * What's the state of any non-locking shifts?
+                */
+               if (non_locking_shift == 1) {
+                       /*
+                        * There's a non-locking shift in effect for
+                        * this IE.  Count it, so we reset the codeset
+                        * before the next IE.
+                        */
+                       non_locking_shift = 2;
+               } else if (non_locking_shift == 2) {
+                       /*
+                        * Unshift.
+                        */
+                       codeset = unshift_codeset;
+                       non_locking_shift = 0;
                }
 
-                if (ndo->ndo_vflag >= 1 && !ie_is_known) {
-                    print_unknown_data(ndo, ptemp+2, "\n\t", ie_p->ie_len);
+               /*
+                * Get the first octet of the IE.
+                */
+               if (!ND_TTEST_1(p)) {
+                       if (!ndo->ndo_vflag) {
+                               ND_PRINT(", length %u", olen);
+                       }
+                       goto trunc;
                }
+               iecode = GET_U_1(p);
+               p++;
+               length--;
 
-                /* do we want to see a hexdump of the IE ? */
-                if (ndo->ndo_vflag> 1 && ie_is_known) {
-                    print_unknown_data(ndo, ptemp+2, "\n\t  ", ie_p->ie_len);
+               /* Single-octet IE? */
+               if (IE_IS_SINGLE_OCTET(iecode)) {
+                       /*
+                        * Yes.  Is it a shift?
+                        */
+                       if (IE_IS_SHIFT(iecode)) {
+                               /*
+                                * Yes.  Is it locking?
+                                */
+                               if (IE_SHIFT_IS_LOCKING(iecode)) {
+                                       /*
+                                        * Yes.
+                                        */
+                                       non_locking_shift = 0;
+                               } else {
+                                       /*
+                                        * No.  Remember the current
+                                        * codeset, so we can revert
+                                        * to it after the next IE.
+                                        */
+                                       non_locking_shift = 1;
+                                       unshift_codeset = codeset;
+                               }
+
+                               /*
+                                * Get the codeset.
+                                */
+                               codeset = IE_SHIFT_CODESET(iecode);
+                       }
+               } else {
+                       /*
+                        * No.  Get the IE length.
+                        */
+                       if (length == 0 || !ND_TTEST_1(p)) {
+                               if (!ndo->ndo_vflag) {
+                                       ND_PRINT(", length %u", olen);
+                               }
+                               goto trunc;
+                       }
+                       ielength = GET_U_1(p);
+                       p++;
+                       length--;
+
+                       /* lets do the full IE parsing only in verbose mode
+                        * however some IEs (DLCI Status, Link Verify)
+                        * are also interesting in non-verbose mode */
+                       if (ndo->ndo_vflag) {
+                               ND_PRINT("\n\t%s IE (0x%02x), length %u: ",
+                                   tok2str(fr_q933_ie_codesets[codeset],
+                                       "unknown", iecode),
+                                   iecode,
+                                   ielength);
+                       }
+
+                       /* sanity checks */
+                       if (iecode == 0 || ielength == 0) {
+                               return;
+                       }
+                       if (length < ielength || !ND_TTEST_LEN(p, ielength)) {
+                               if (!ndo->ndo_vflag) {
+                                       ND_PRINT(", length %u", olen);
+                               }
+                               goto trunc;
+                       }
+
+                       ie_is_known = 0;
+                       if (fr_q933_print_ie_codeset[codeset] != NULL) {
+                               ie_is_known = fr_q933_print_ie_codeset[codeset](ndo, iecode, ielength, p);
+                       }
+
+                       if (ie_is_known) {
+                               /*
+                                * Known IE; do we want to see a hexdump
+                                * of it?
+                                */
+                               if (ndo->ndo_vflag > 1) {
+                                       /* Yes. */
+                                       print_unknown_data(ndo, p, "\n\t  ", ielength);
+                               }
+                       } else {
+                               /*
+                                * Unknown IE; if we're printing verbosely,
+                                * print its content in hex.
+                                */
+                               if (ndo->ndo_vflag >= 1) {
+                                       print_unknown_data(ndo, p, "\n\t", ielength);
+                               }
+                       }
+
+                       length -= ielength;
+                       p += ielength;
                }
-
-               length = length - ie_p->ie_len - 2;
-               ptemp = ptemp + ie_p->ie_len + 2;
        }
-        if (!ndo->ndo_vflag) {
-            ND_PRINT((ndo, ", length %u", olen));
+       if (!ndo->ndo_vflag) {
+           ND_PRINT(", length %u", olen);
        }
+       return;
+
+trunc:
+       nd_print_trunc(ndo);
 }
 
 static int
-fr_q933_print_ie_codeset5(netdissect_options *ndo,
-                          const struct ie_tlv_header_t  *ie_p, const u_char *p)
+fr_q933_print_ie_codeset_0_5(netdissect_options *ndo, u_int iecode,
+                          u_int ielength, const u_char *p)
 {
         u_int dlci;
 
-        switch (ie_p->ie_type) {
+        switch (iecode) {
 
         case FR_LMI_ANSI_REPORT_TYPE_IE: /* fall through */
         case FR_LMI_CCITT_REPORT_TYPE_IE:
+            if (ielength < 1) {
+                if (!ndo->ndo_vflag) {
+                    ND_PRINT(", ");
+               }
+                ND_PRINT("Invalid REPORT TYPE IE");
+                return 1;
+            }
             if (ndo->ndo_vflag) {
-                ND_PRINT((ndo, "%s (%u)",
-                       tok2str(fr_lmi_report_type_ie_values,"unknown",p[2]),
-                       p[2]));
+                ND_PRINT("%s (%u)",
+                       tok2str(fr_lmi_report_type_ie_values,"unknown",GET_U_1(p)),
+                       GET_U_1(p));
            }
             return 1;
 
@@ -882,47 +1107,48 @@ fr_q933_print_ie_codeset5(netdissect_options *ndo,
         case FR_LMI_CCITT_LINK_VERIFY_IE:
         case FR_LMI_ANSI_LINK_VERIFY_IE_91:
             if (!ndo->ndo_vflag) {
-                ND_PRINT((ndo, ", "));
+                ND_PRINT(", ");
            }
-            ND_PRINT((ndo, "TX Seq: %3d, RX Seq: %3d", p[2], p[3]));
+            if (ielength < 2) {
+                ND_PRINT("Invalid LINK VERIFY IE");
+                return 1;
+            }
+            ND_PRINT("TX Seq: %3d, RX Seq: %3d", GET_U_1(p), GET_U_1(p + 1));
             return 1;
 
         case FR_LMI_ANSI_PVC_STATUS_IE: /* fall through */
         case FR_LMI_CCITT_PVC_STATUS_IE:
             if (!ndo->ndo_vflag) {
-                ND_PRINT((ndo, ", "));
+                ND_PRINT(", ");
            }
             /* now parse the DLCI information element. */
-            if ((ie_p->ie_len < 3) ||
-                (p[2] & 0x80) ||
-                ((ie_p->ie_len == 3) && !(p[3] & 0x80)) ||
-                ((ie_p->ie_len == 4) && ((p[3] & 0x80) || !(p[4] & 0x80))) ||
-                ((ie_p->ie_len == 5) && ((p[3] & 0x80) || (p[4] & 0x80) ||
-                                   !(p[5] & 0x80))) ||
-                (ie_p->ie_len > 5) ||
-                !(p[ie_p->ie_len + 1] & 0x80)) {
-                ND_PRINT((ndo, "Invalid DLCI IE"));
+            if ((ielength < 3) ||
+                (GET_U_1(p) & 0x80) ||
+                ((ielength == 3) && !(GET_U_1(p + 1) & 0x80)) ||
+                ((ielength == 4) &&
+                  ((GET_U_1(p + 1) & 0x80) || !(GET_U_1(p + 2) & 0x80))) ||
+                ((ielength == 5) &&
+                  ((GET_U_1(p + 1) & 0x80) || (GET_U_1(p + 2) & 0x80) ||
+                   !(GET_U_1(p + 3) & 0x80))) ||
+                (ielength > 5) ||
+                !(GET_U_1(p + ielength - 1) & 0x80)) {
+                ND_PRINT("Invalid DLCI in PVC STATUS IE");
+                return 1;
            }
 
-            dlci = ((p[2] & 0x3F) << 4) | ((p[3] & 0x78) >> 3);
-            if (ie_p->ie_len == 4) {
-                dlci = (dlci << 6) | ((p[4] & 0x7E) >> 1);
+            dlci = ((GET_U_1(p) & 0x3F) << 4) | ((GET_U_1(p + 1) & 0x78) >> 3);
+            if (ielength == 4) {
+                dlci = (dlci << 6) | ((GET_U_1(p + 2) & 0x7E) >> 1);
            }
-            else if (ie_p->ie_len == 5) {
-                dlci = (dlci << 13) | (p[4] & 0x7F) | ((p[5] & 0x7E) >> 1);
+            else if (ielength == 5) {
+                dlci = (dlci << 13) | (GET_U_1(p + 2) & 0x7F) | ((GET_U_1(p + 3) & 0x7E) >> 1);
            }
 
-            ND_PRINT((ndo, "DLCI %u: status %s%s", dlci,
-                    p[ie_p->ie_len + 1] & 0x8 ? "New, " : "",
-                    p[ie_p->ie_len + 1] & 0x2 ? "Active" : "Inactive"));
+            ND_PRINT("DLCI %u: status %s%s", dlci,
+                    GET_U_1(p + ielength - 1) & 0x8 ? "New, " : "",
+                    GET_U_1(p + ielength - 1) & 0x2 ? "Active" : "Inactive");
             return 1;
        }
 
         return 0;
 }
-/*
- * Local Variables:
- * c-style: whitesmith
- * c-basic-offset: 8
- * End:
- */