CI: Add warning exemptions for Sun C (suncc-5.14) on Solaris 10

[tcpdump] / print-tftp.c

diff --git a/print-tftp.c b/print-tftp.c
index b6f9107e7c53c2348691ce71bb1883208915c36c..ec64a5c9dfa97b7c99ede676beafe926cb0c44aa 100644 (file)
--- a/print-tftp.c
+++ b/print-tftp.c
@@ -21,14 +21,10 @@
 
 /* \summary: Trivial File Transfer Protocol (TFTP) printer */
 
-#ifdef HAVE_CONFIG_H
 #include <config.h>
-#endif
 
 #include "netdissect-stdinc.h"
 
-#include <string.h>
-
 #include "netdissect.h"
 #include "extract.h"
 
@@ -104,7 +100,6 @@ tftp_print(netdissect_options *ndo,
        /* Print tftp request type */
        if (length < 2)
                goto trunc;
-       ND_TCHECK_2(bp);
        opcode = GET_BE_U_2(bp);
        cp = tok2str(op2str, "tftp-#%u", opcode);
        ND_PRINT(", %s", cp);
@@ -142,7 +137,6 @@ tftp_print(netdissect_options *ndo,
 
                /* Print options, if any */
                while (length != 0) {
-                       ND_TCHECK_1(bp);
                        if (GET_U_1(bp) != '\0')
                                ND_PRINT(" ");
                        ui = nd_printztn(ndo, bp, length, ndo->ndo_snapend);
@@ -156,7 +150,6 @@ tftp_print(netdissect_options *ndo,
        case OACK:
                /* Print options */
                while (length != 0) {
-                       ND_TCHECK_1(bp);
                        if (GET_U_1(bp) != '\0')
                                ND_PRINT(" ");
                        ui = nd_printztn(ndo, bp, length, ndo->ndo_snapend);
@@ -171,7 +164,6 @@ tftp_print(netdissect_options *ndo,
        case DATA:
                if (length < 2)
                        goto trunc;     /* no block number */
-               ND_TCHECK_2(bp);
                ND_PRINT(" block %u", GET_BE_U_2(bp));
                break;
 
@@ -179,7 +171,6 @@ tftp_print(netdissect_options *ndo,
                /* Print error code string */
                if (length < 2)
                        goto trunc;     /* no error code */
-               ND_TCHECK_2(bp);
                ND_PRINT(" %s", tok2str(err2str, "tftp-err-#%u \"",
                                       GET_BE_U_2(bp)));
                bp += 2;
@@ -202,5 +193,4 @@ tftp_print(netdissect_options *ndo,
        return;
 trunc:
        nd_print_trunc(ndo);
-       return;
 }