]> The Tcpdump Group git mirrors - tcpdump/blobdiff - print-bootp.c
Don't print timestamps to a buffer and then print the buffer.
[tcpdump] / print-bootp.c
index 5be109abfc73f499fe0a6b6ac42eb14bf6fe89b9..62b337cb411837251d07b90e702154c9f8f5cfa3 100644 (file)
 /* \summary: BOOTP and IPv4 DHCP printer */
 
 #ifdef HAVE_CONFIG_H
-#include "config.h"
+#include <config.h>
 #endif
 
-#include <netdissect-stdinc.h>
+#include "netdissect-stdinc.h"
 
 #include <string.h>
 
@@ -33,7 +33,6 @@
 #include "addrtoname.h"
 #include "extract.h"
 
-static const char tstr[] = " [|bootp]";
 
 /*
  * Bootstrap Protocol (BOOTP).  RFC951 and RFC1048.
@@ -64,15 +63,15 @@ struct bootp {
        nd_uint16_t     bp_secs;        /* seconds since boot began */
        nd_uint16_t     bp_flags;       /* flags - see bootp_flag_values[]
                                           in print-bootp.c */
-       struct in_addr  bp_ciaddr;      /* client IP address */
-       struct in_addr  bp_yiaddr;      /* 'your' IP address */
-       struct in_addr  bp_siaddr;      /* server IP address */
-       struct in_addr  bp_giaddr;      /* gateway IP address */
+       nd_ipv4         bp_ciaddr;      /* client IP address */
+       nd_ipv4         bp_yiaddr;      /* 'your' IP address */
+       nd_ipv4         bp_siaddr;      /* server IP address */
+       nd_ipv4         bp_giaddr;      /* gateway IP address */
        nd_byte         bp_chaddr[16];  /* client hardware address */
        nd_byte         bp_sname[64];   /* server host name */
        nd_byte         bp_file[128];   /* boot file name */
        nd_byte         bp_vend[64];    /* vendor-specific area */
-} UNALIGNED;
+};
 
 #define BOOTPREPLY     2
 #define BOOTPREQUEST   1
@@ -241,13 +240,13 @@ struct bootp {
 struct cmu_vend {
        nd_byte         v_magic[4];     /* magic number */
        nd_uint32_t     v_flags;        /* flags/opcodes, etc. */
-       struct in_addr  v_smask;        /* Subnet mask */
-       struct in_addr  v_dgate;        /* Default gateway */
-       struct in_addr  v_dns1, v_dns2; /* Domain name servers */
-       struct in_addr  v_ins1, v_ins2; /* IEN-116 name servers */
-       struct in_addr  v_ts1, v_ts2;   /* Time servers */
+       nd_ipv4         v_smask;        /* Subnet mask */
+       nd_ipv4         v_dgate;        /* Default gateway */
+       nd_ipv4         v_dns1, v_dns2; /* Domain name servers */
+       nd_ipv4         v_ins1, v_ins2; /* IEN-116 name servers */
+       nd_ipv4         v_ts1, v_ts2;   /* Time servers */
        nd_byte         v_unused[24];   /* currently unused */
-} UNALIGNED;
+};
 
 
 /* v_flags values */
@@ -288,6 +287,7 @@ bootp_print(netdissect_options *ndo,
        static const u_char vm_rfc1048[4] = VM_RFC1048;
        uint8_t bp_op, bp_htype, bp_hlen;
 
+       ndo->ndo_protocol = "bootp";
        bp = (const struct bootp *)cp;
        ND_TCHECK_1(bp->bp_op);
        bp_op = EXTRACT_U_1(bp->bp_op);
@@ -298,7 +298,7 @@ bootp_print(netdissect_options *ndo,
        bp_htype = EXTRACT_U_1(bp->bp_htype);
        bp_hlen = EXTRACT_U_1(bp->bp_hlen);
        if (bp_htype == 1 && bp_hlen == 6 && bp_op == BOOTPREQUEST) {
-               ND_TCHECK_LEN(bp->bp_chaddr, 6);
+               ND_TCHECK_6(bp->bp_chaddr);
                ND_PRINT(" from %s", etheraddr_string(ndo, bp->bp_chaddr));
        }
 
@@ -311,19 +311,19 @@ bootp_print(netdissect_options *ndo,
 
        /* The usual hardware address type is 1 (10Mb Ethernet) */
        if (bp_htype != 1)
-               ND_PRINT(", htype %d", bp_htype);
+               ND_PRINT(", htype %u", bp_htype);
 
        /* The usual length for 10Mb Ethernet address is 6 bytes */
        if (bp_htype != 1 || bp_hlen != 6)
-               ND_PRINT(", hlen %d", bp_hlen);
+               ND_PRINT(", hlen %u", bp_hlen);
 
        /* Only print interesting fields */
        if (EXTRACT_U_1(bp->bp_hops))
-               ND_PRINT(", hops %d", EXTRACT_U_1(bp->bp_hops));
+               ND_PRINT(", hops %u", EXTRACT_U_1(bp->bp_hops));
        if (EXTRACT_BE_U_4(bp->bp_xid))
                ND_PRINT(", xid 0x%x", EXTRACT_BE_U_4(bp->bp_xid));
        if (EXTRACT_BE_U_2(bp->bp_secs))
-               ND_PRINT(", secs %d", EXTRACT_BE_U_2(bp->bp_secs));
+               ND_PRINT(", secs %u", EXTRACT_BE_U_2(bp->bp_secs));
 
        ND_TCHECK_2(bp->bp_flags);
        ND_PRINT(", Flags [%s]",
@@ -332,38 +332,38 @@ bootp_print(netdissect_options *ndo,
                ND_PRINT(" (0x%04x)", EXTRACT_BE_U_2(bp->bp_flags));
 
        /* Client's ip address */
-       ND_TCHECK(bp->bp_ciaddr);
-       if (EXTRACT_IPV4_TO_HOST_ORDER(&bp->bp_ciaddr.s_addr))
-               ND_PRINT("\n\t  Client-IP %s", ipaddr_string(ndo, &bp->bp_ciaddr));
+       ND_TCHECK_4(bp->bp_ciaddr);
+       if (EXTRACT_IPV4_TO_NETWORK_ORDER(bp->bp_ciaddr))
+               ND_PRINT("\n\t  Client-IP %s", ipaddr_string(ndo, bp->bp_ciaddr));
 
        /* 'your' ip address (bootp client) */
-       ND_TCHECK(bp->bp_yiaddr);
-       if (EXTRACT_IPV4_TO_HOST_ORDER(&bp->bp_yiaddr.s_addr))
-               ND_PRINT("\n\t  Your-IP %s", ipaddr_string(ndo, &bp->bp_yiaddr));
+       ND_TCHECK_4(bp->bp_yiaddr);
+       if (EXTRACT_IPV4_TO_NETWORK_ORDER(bp->bp_yiaddr))
+               ND_PRINT("\n\t  Your-IP %s", ipaddr_string(ndo, bp->bp_yiaddr));
 
        /* Server's ip address */
-       ND_TCHECK(bp->bp_siaddr);
-       if (EXTRACT_IPV4_TO_HOST_ORDER(&bp->bp_siaddr.s_addr))
-               ND_PRINT("\n\t  Server-IP %s", ipaddr_string(ndo, &bp->bp_siaddr));
+       ND_TCHECK_4(bp->bp_siaddr);
+       if (EXTRACT_IPV4_TO_NETWORK_ORDER(bp->bp_siaddr))
+               ND_PRINT("\n\t  Server-IP %s", ipaddr_string(ndo, bp->bp_siaddr));
 
        /* Gateway's ip address */
-       ND_TCHECK(bp->bp_giaddr);
-       if (EXTRACT_IPV4_TO_HOST_ORDER(&bp->bp_giaddr.s_addr))
-               ND_PRINT("\n\t  Gateway-IP %s", ipaddr_string(ndo, &bp->bp_giaddr));
+       ND_TCHECK_4(bp->bp_giaddr);
+       if (EXTRACT_IPV4_TO_NETWORK_ORDER(bp->bp_giaddr))
+               ND_PRINT("\n\t  Gateway-IP %s", ipaddr_string(ndo, bp->bp_giaddr));
 
        /* Client's Ethernet address */
        if (bp_htype == 1 && bp_hlen == 6) {
-               ND_TCHECK_LEN(bp->bp_chaddr, 6);
+               ND_TCHECK_6(bp->bp_chaddr);
                ND_PRINT("\n\t  Client-Ethernet-Address %s", etheraddr_string(ndo, bp->bp_chaddr));
        }
 
        ND_TCHECK_1(bp->bp_sname);              /* check first char only */
        if (EXTRACT_U_1(bp->bp_sname)) {
                ND_PRINT("\n\t  sname \"");
-               if (fn_printztn(ndo, bp->bp_sname, (u_int)sizeof bp->bp_sname,
-                   ndo->ndo_snapend)) {
+               if (nd_printztn(ndo, bp->bp_sname, (u_int)sizeof(bp->bp_sname),
+                               ndo->ndo_snapend) == 0) {
                        ND_PRINT("\"");
-                       ND_PRINT("%s", tstr + 1);
+                       nd_print_trunc(ndo);
                        return;
                }
                ND_PRINT("\"");
@@ -371,17 +371,17 @@ bootp_print(netdissect_options *ndo,
        ND_TCHECK_1(bp->bp_file);               /* check first char only */
        if (EXTRACT_U_1(bp->bp_file)) {
                ND_PRINT("\n\t  file \"");
-               if (fn_printztn(ndo, bp->bp_file, (u_int)sizeof bp->bp_file,
-                   ndo->ndo_snapend)) {
+               if (nd_printztn(ndo, bp->bp_file, (u_int)sizeof(bp->bp_file),
+                               ndo->ndo_snapend) == 0) {
                        ND_PRINT("\"");
-                       ND_PRINT("%s", tstr + 1);
+                       nd_print_trunc(ndo);
                        return;
                }
                ND_PRINT("\"");
        }
 
        /* Decode the vendor buffer */
-       ND_TCHECK_LEN(bp->bp_vend, 4);
+       ND_TCHECK_4(bp->bp_vend);
        if (memcmp((const char *)bp->bp_vend, vm_rfc1048,
                    sizeof(uint32_t)) == 0)
                rfc1048_print(ndo, bp->bp_vend);
@@ -398,7 +398,7 @@ bootp_print(netdissect_options *ndo,
 
        return;
 trunc:
-       ND_PRINT("%s", tstr);
+       nd_print_trunc(ndo);
 }
 
 /*
@@ -603,9 +603,7 @@ rfc1048_print(netdissect_options *ndo,
        const char *cp;
        char c;
        int first, idx;
-       uint32_t ul;
-       uint16_t us;
-       uint8_t uc, subopt, suboptlen;
+       uint8_t subopt, suboptlen;
 
        ND_PRINT("\n\t  Vendor-rfc1048 Extensions");
 
@@ -656,24 +654,20 @@ rfc1048_print(netdissect_options *ndo,
                                ND_PRINT(", occurs %u", ntag);
                }
 
-               if (!ND_TTEST_LEN(bp, len)) {
-                       ND_PRINT("[|rfc1048 %u]", len);
-                       return;
-               }
+               ND_TCHECK_LEN(bp, len);
 
                if (tag == TAG_DHCP_MESSAGE && len == 1) {
-                       uc = EXTRACT_U_1(bp);
+                       ND_PRINT("%s", tok2str(dhcp_msg_values, "Unknown (%u)", EXTRACT_U_1(bp)));
                        bp++;
-                       ND_PRINT("%s", tok2str(dhcp_msg_values, "Unknown (%u)", uc));
                        continue;
                }
 
                if (tag == TAG_PARM_REQUEST) {
                        idx = 0;
-                       while (len-- > 0) {
-                               uc = EXTRACT_U_1(bp);
+                       while (len > 0) {
+                               cp = tok2str(tag2str, "?Option %u", EXTRACT_U_1(bp));
                                bp++;
-                               cp = tok2str(tag2str, "?Option %u", uc);
+                               len--;
                                if (idx % 4 == 0)
                                        ND_PRINT("\n\t      ");
                                else
@@ -687,10 +681,9 @@ rfc1048_print(netdissect_options *ndo,
                if (tag == TAG_EXTENDED_REQUEST) {
                        first = 1;
                        while (len > 1) {
-                               len -= 2;
-                               us = EXTRACT_BE_U_2(bp);
+                               cp = tok2str(xtag2str, "?xT%u", EXTRACT_BE_U_2(bp));
                                bp += 2;
-                               cp = tok2str(xtag2str, "?xT%u", us);
+                               len -= 2;
                                if (!first)
                                        ND_PRINT("+");
                                ND_PRINT("%s", cp + 1);
@@ -715,7 +708,7 @@ rfc1048_print(netdissect_options *ndo,
                case 'a':
                        /* ASCII strings */
                        ND_PRINT("\"");
-                       if (fn_printn(ndo, bp, len, ndo->ndo_snapend)) {
+                       if (nd_printn(ndo, bp, len, ndo->ndo_snapend)) {
                                ND_PRINT("\"");
                                goto trunc;
                        }
@@ -728,48 +721,44 @@ rfc1048_print(netdissect_options *ndo,
                case 'l':
                case 'L':
                        /* ip addresses/32-bit words */
-                       while (len >= sizeof(ul)) {
+                       while (len >= 4) {
                                if (!first)
                                        ND_PRINT(",");
-                               ul = EXTRACT_BE_U_4(bp);
-                               if (c == 'i') {
-                                       ul = htonl(ul);
-                                       ND_PRINT("%s", ipaddr_string(ndo, &ul));
-                               } else if (c == 'L')
-                                       ND_PRINT("%d", ul);
+                               if (c == 'i')
+                                       ND_PRINT("%s", ipaddr_string(ndo, bp));
+                               else if (c == 'L')
+                                       ND_PRINT("%d", EXTRACT_BE_S_4(bp));
                                else
-                                       ND_PRINT("%u", ul);
-                               bp += sizeof(ul);
-                               len -= sizeof(ul);
+                                       ND_PRINT("%u", EXTRACT_BE_U_4(bp));
+                               bp += 4;
+                               len -= 4;
                                first = 0;
                        }
                        break;
 
                case 'p':
                        /* IP address pairs */
-                       while (len >= 2*sizeof(ul)) {
+                       while (len >= 2*4) {
                                if (!first)
                                        ND_PRINT(",");
-                               memcpy((char *)&ul, (const char *)bp, sizeof(ul));
-                               ND_PRINT("(%s:", ipaddr_string(ndo, &ul));
-                               bp += sizeof(ul);
-                               memcpy((char *)&ul, (const char *)bp, sizeof(ul));
-                               ND_PRINT("%s)", ipaddr_string(ndo, &ul));
-                               bp += sizeof(ul);
-                               len -= 2*sizeof(ul);
+                               ND_PRINT("(%s:", ipaddr_string(ndo, bp));
+                               bp += 4;
+                               len -= 4;
+                               ND_PRINT("%s)", ipaddr_string(ndo, bp));
+                               bp += 4;
+                               len -= 4;
                                first = 0;
                        }
                        break;
 
                case 's':
                        /* shorts */
-                       while (len >= sizeof(us)) {
+                       while (len >= 2) {
                                if (!first)
                                        ND_PRINT(",");
-                               us = EXTRACT_BE_U_2(bp);
-                               ND_PRINT("%u", us);
-                               bp += sizeof(us);
-                               len -= sizeof(us);
+                               ND_PRINT("%u", EXTRACT_BE_U_2(bp));
+                               bp += 2;
+                               len -= 2;
                                first = 0;
                        }
                        break;
@@ -860,7 +849,7 @@ rfc1048_print(netdissect_options *ndo,
                                        ND_PRINT("%u/%u ", EXTRACT_U_1(bp), EXTRACT_U_1(bp + 1));
                                bp += 2;
                                ND_PRINT("\"");
-                               if (fn_printn(ndo, bp, len - 3, ndo->ndo_snapend)) {
+                               if (nd_printn(ndo, bp, len - 3, ndo->ndo_snapend)) {
                                        ND_PRINT("\"");
                                        goto trunc;
                                }
@@ -883,7 +872,7 @@ rfc1048_print(netdissect_options *ndo,
                                len--;
                                if (type == 0) {
                                        ND_PRINT("\"");
-                                       if (fn_printn(ndo, bp, len, ndo->ndo_snapend)) {
+                                       if (nd_printn(ndo, bp, len, ndo->ndo_snapend)) {
                                                ND_PRINT("\"");
                                                goto trunc;
                                        }
@@ -929,7 +918,7 @@ rfc1048_print(netdissect_options *ndo,
                                        case AGENT_SUBOPTION_CIRCUIT_ID: /* fall through */
                                        case AGENT_SUBOPTION_REMOTE_ID:
                                        case AGENT_SUBOPTION_SUBSCRIBER_ID:
-                                               if (fn_printn(ndo, bp, suboptlen, ndo->ndo_snapend))
+                                               if (nd_printn(ndo, bp, suboptlen, ndo->ndo_snapend))
                                                        goto trunc;
                                                break;
 
@@ -962,7 +951,7 @@ rfc1048_print(netdissect_options *ndo,
                                        len--;
                                        /* mask_width <= 32 */
                                        if (mask_width > 32) {
-                                               ND_PRINT("[ERROR: Mask width (%d) > 32]", mask_width);
+                                               ND_PRINT("[ERROR: Mask width (%u) > 32]", mask_width);
                                                bp += len;
                                                len = 0;
                                                break;
@@ -982,16 +971,15 @@ rfc1048_print(netdissect_options *ndo,
                                                for (i = 0; i < significant_octets ; i++) {
                                                        if (i > 0)
                                                                ND_PRINT(".");
-                                                       ND_PRINT("%d", EXTRACT_U_1(bp));
+                                                       ND_PRINT("%u", EXTRACT_U_1(bp));
                                                        bp++;
                                                }
                                                for (i = significant_octets ; i < 4 ; i++)
                                                        ND_PRINT(".0");
-                                               ND_PRINT("/%d", mask_width);
+                                               ND_PRINT("/%u", mask_width);
                                        }
-                                       memcpy((char *)&ul, (const char *)bp, sizeof(ul));
-                                       ND_PRINT(":%s)", ipaddr_string(ndo, &ul));
-                                       bp += sizeof(ul);
+                                       ND_PRINT(":%s)", ipaddr_string(ndo, bp));
+                                       bp += 4;
                                        len -= (significant_octets + 4);
                                        first = 0;
                                }
@@ -1028,12 +1016,12 @@ rfc1048_print(netdissect_options *ndo,
                                                break;
                                        }
                                        ND_PRINT("\"");
-                                       if (fn_printn(ndo, bp, suboptlen, ndo->ndo_snapend)) {
+                                       if (nd_printn(ndo, bp, suboptlen, ndo->ndo_snapend)) {
                                                ND_PRINT("\"");
                                                goto trunc;
                                        }
                                        ND_PRINT("\"");
-                                       ND_PRINT(", length %d", suboptlen);
+                                       ND_PRINT(", length %u", suboptlen);
                                        suboptnumber++;
                                        len -= suboptlen;
                                        bp += suboptlen;
@@ -1058,12 +1046,12 @@ rfc1048_print(netdissect_options *ndo,
        }
        return;
 trunc:
-       ND_PRINT("|[rfc1048]");
+       nd_print_trunc(ndo);
 }
 
-#define PRINTCMUADDR(m, s) { ND_TCHECK(cmu->m); \
-    if (cmu->m.s_addr != 0) \
-       ND_PRINT(" %s:%s", s, ipaddr_string(ndo, &cmu->m.s_addr)); }
+#define PRINTCMUADDR(m, s) { ND_TCHECK_4(&cmu->m); \
+    if (EXTRACT_IPV4_TO_NETWORK_ORDER(cmu->m) != 0) \
+       ND_PRINT(" %s:%s", s, ipaddr_string(ndo, cmu->m)); }
 
 static void
 cmu_print(netdissect_options *ndo,
@@ -1091,7 +1079,7 @@ cmu_print(netdissect_options *ndo,
        return;
 
 trunc:
-       ND_PRINT("%s", tstr);
+       nd_print_trunc(ndo);
 }
 
 #undef PRINTCMUADDR