More UNALIGNED_MEM{CPY,CMP} on IP addresses.

[tcpdump] / print-ip.c

diff --git a/print-ip.c b/print-ip.c
index c0c91888bdc3a6d30b3a81a150c6650b74fb8b40..22bd80054775e055fce7555b4f0d5f27c0c4cfc7 100644 (file)
--- a/print-ip.c
+++ b/print-ip.c
@@ -19,11 +19,6 @@
  * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE.
  */
 
-#ifndef lint
-static const char rcsid[] _U_ =
-    "@(#) $Header: /tcpdump/master/tcpdump/print-ip.c,v 1.159 2007-09-14 01:29:28 guy Exp $ (LBL)";
-#endif
-
 #ifdef HAVE_CONFIG_H
 #include "config.h"
 #endif
@@ -41,7 +36,9 @@ static const char rcsid[] _U_ =
 #include "ip.h"
 #include "ipproto.h"
 
-struct tok ip_option_values[] = {
+static const char tstr[] = "[|ip]";
+
+static const struct tok ip_option_values[] = {
     { IPOPT_EOL, "EOL" },
     { IPOPT_NOP, "NOP" },
     { IPOPT_TS, "timestamp" },
@@ -120,12 +117,12 @@ ip_finddst(const struct ip *ip)
                case IPOPT_LSRR:
                        if (len < 7)
                                break;
-                       memcpy(&retval, cp + len - 4, 4);
+                       UNALIGNED_MEMCPY(&retval, cp + len - 4, 4);
                        return retval;
                }
        }
 trunc:
-       memcpy(&retval, &ip->ip_dst.s_addr, sizeof(u_int32_t));
+       UNALIGNED_MEMCPY(&retval, &ip->ip_dst.s_addr, sizeof(u_int32_t));
        return retval;
 }
 
@@ -149,9 +146,9 @@ nextproto4_cksum(const struct ip *ip, const u_int8_t *data,
        ph.len = htons((u_int16_t)len);
        ph.mbz = 0;
        ph.proto = next_proto;
-       memcpy(&ph.src, &ip->ip_src.s_addr, sizeof(u_int32_t));
+       UNALIGNED_MEMCPY(&ph.src, &ip->ip_src.s_addr, sizeof(u_int32_t));
        if (IP_HL(ip) == 5)
-               memcpy(&ph.dst, &ip->ip_dst.s_addr, sizeof(u_int32_t));
+               UNALIGNED_MEMCPY(&ph.dst, &ip->ip_dst.s_addr, sizeof(u_int32_t));
        else
                ph.dst = ip_finddst(ip);
 
@@ -298,12 +295,12 @@ ip_optprint(register const u_char *cp, u_int length)
        return;
 
 trunc:
-       printf("[|ip]");
+       printf("%s", tstr);
 }
 
 #define IP_RES 0x8000
 
-static struct tok ip_frag_values[] = {
+static const struct tok ip_frag_values[] = {
         { IP_MF,        "+" },
         { IP_DF,        "DF" },
        { IP_RES,       "rsvd" }, /* The RFC3514 evil ;-) bit */
@@ -350,7 +347,7 @@ again:
                ipds->nh = enh & 0xff;
                goto again;
        }
-       
+
        case IPPROTO_IPCOMP:
        {
                int enh;
@@ -370,25 +367,25 @@ again:
        case IPPROTO_DCCP:
                dccp_print(ipds->cp, (const u_char *)ipds->ip, ipds->len);
                break;
-               
+
        case IPPROTO_TCP:
                /* pass on the MF bit plus the offset to detect fragments */
                tcp_print(ipds->cp, ipds->len, (const u_char *)ipds->ip,
                          ipds->off & (IP_MF|IP_OFFMASK));
                break;
-               
+
        case IPPROTO_UDP:
                /* pass on the MF bit plus the offset to detect fragments */
                udp_print(ipds->cp, ipds->len, (const u_char *)ipds->ip,
                          ipds->off & (IP_MF|IP_OFFMASK));
                break;
-               
+
        case IPPROTO_ICMP:
                /* pass on the MF bit plus the offset to detect fragments */
                icmp_print(ipds->cp, ipds->len, (const u_char *)ipds->ip,
                           ipds->off & (IP_MF|IP_OFFMASK));
                break;
-               
+
        case IPPROTO_PIGP:
                /*
                 * XXX - the current IANA protocol number assignments
@@ -405,11 +402,11 @@ again:
                 */
                igrp_print(ipds->cp, ipds->len, (const u_char *)ipds->ip);
                break;
-               
+
        case IPPROTO_EIGRP:
                eigrp_print(ipds->cp, ipds->len);
                break;
-               
+
        case IPPROTO_ND:
                ND_PRINT((ndo, " nd %d", ipds->len));
                break;
@@ -434,7 +431,7 @@ again:
                        return;
                }
                break;
-               
+
 #ifdef INET6
        case IPPROTO_IPV6:
                /* ip6-in-ip encapsulation */
@@ -482,7 +479,7 @@ again:
                break;
 
        default:
-               if ((proto = getprotobynumber(ipds->nh)) != NULL)
+               if (ndo->ndo_nflag==0 && (proto = getprotobynumber(ipds->nh)) != NULL)
                        ND_PRINT((ndo, " %s", proto->p_name));
                else
                        ND_PRINT((ndo, " ip-proto-%d", ipds->nh));
@@ -490,7 +487,7 @@ again:
                break;
        }
 }
-              
+
 void
 ip_print_inner(netdissect_options *ndo,
               const u_char *bp,
@@ -536,7 +533,7 @@ ip_print(netdissect_options *ndo,
            printf("IP ");
 
        if ((u_char *)(ipds->ip + 1) > ndo->ndo_snapend) {
-               printf("[|ip]");
+               printf("%s", tstr);
                return;
        }
        if (length < sizeof (struct ip)) {
@@ -597,7 +594,7 @@ ip_print(netdissect_options *ndo,
             }
 
             if (ipds->ip->ip_ttl >= 1)
-                (void)printf(", ttl %u", ipds->ip->ip_ttl);    
+                (void)printf(", ttl %u", ipds->ip->ip_ttl);
 
            /*
             * for the firewall guys, print id, offset.
@@ -665,21 +662,20 @@ ip_print(netdissect_options *ndo,
                    (void)printf(" %s", proto->p_name);
                else
                    (void)printf(" ip-proto-%d", ipds->ip->ip_p);
-           } 
+           }
        }
 }
 
 void
 ipN_print(register const u_char *bp, register u_int length)
 {
-       struct ip *ip, hdr;
+       struct ip hdr;
 
-       ip = (struct ip *)bp;
        if (length < 4) {
                (void)printf("truncated-ip %d", length);
                return;
        }
-       memcpy (&hdr, (char *)ip, 4);
+       memcpy (&hdr, bp, 4);
        switch (IP_V(&hdr)) {
        case 4:
                ip_print (gndo, bp, length);