]> The Tcpdump Group git mirrors - tcpdump/blobdiff - tcpdump.c
Improve a tcpdump error message, free device list before exiting.
[tcpdump] / tcpdump.c
index a7756be5624c0322d403c7b56403da6601509dc6..bddf963fa5e14a7fc0edc2a787a286e02e8bd50d 100644 (file)
--- a/tcpdump.c
+++ b/tcpdump.c
  * combined efforts of Van, Steve McCanne and Craig Leres of LBL.
  */
 
-#ifdef HAVE_CONFIG_H
 #include <config.h>
-#endif
-
-/*
- * Some older versions of Mac OS X ship pcap.h from libpcap 0.6 with a
- * libpcap based on 0.8.  That means it has pcap_findalldevs() but the
- * header doesn't define pcap_if_t, meaning that we can't actually *use*
- * pcap_findalldevs().
- */
-#ifdef HAVE_PCAP_FINDALLDEVS
-#ifndef HAVE_PCAP_IF_T
-#undef HAVE_PCAP_FINDALLDEVS
-#endif
-#endif
 
 #include "netdissect-stdinc.h"
 
@@ -63,9 +49,7 @@ The Regents of the University of California.  All rights reserved.\n";
 
 #include <sys/stat.h>
 
-#ifdef HAVE_FCNTL_H
 #include <fcntl.h>
-#endif
 
 #ifdef HAVE_LIBCRYPTO
 #include <openssl/crypto.h>
@@ -157,7 +141,6 @@ The Regents of the University of California.  All rights reserved.\n";
 #include "netdissect.h"
 #include "interface.h"
 #include "addrtoname.h"
-#include "machdep.h"
 #include "pcap-missing.h"
 #include "ascii_strcasecmp.h"
 
@@ -177,22 +160,18 @@ The Regents of the University of California.  All rights reserved.\n";
 #define SIGNAL_REQ_INFO SIGUSR1
 #endif
 
-#if defined(HAVE_PCAP_DUMP_FLUSH) && defined(SIGUSR2)
+#if defined(SIGUSR2)
 #define SIGNAL_FLUSH_PCAP SIGUSR2
 #endif
 
-#if defined(HAVE_PCAP_CREATE) || defined(_WIN32)
 static int Bflag;                      /* buffer size */
-#endif
 #ifdef HAVE_PCAP_DUMP_FTELL64
 static int64_t Cflag;                  /* rotate dump files after this many bytes */
 #else
 static long Cflag;                     /* rotate dump files after this many bytes */
 #endif
 static int Cflag_count;                        /* Keep track of which file number we're writing */
-#ifdef HAVE_PCAP_FINDALLDEVS
 static int Dflag;                      /* list available devices and exit */
-#endif
 #ifdef HAVE_PCAP_FINDALLDEVS_EX
 static char *remote_interfaces_source; /* list available devices from this source and exit */
 #endif
@@ -222,12 +201,8 @@ static int jflag = -1;                     /* packet time stamp source */
 #endif
 static int lflag;                      /* line-buffered output */
 static int pflag;                      /* don't go promiscuous */
-#ifdef HAVE_PCAP_SETDIRECTION
 static int Qflag = -1;                 /* restrict captured packet by send/receive direction */
-#endif
-#ifdef HAVE_PCAP_DUMP_FLUSH
 static int Uflag;                      /* "unbuffered" output of dump files */
-#endif
 static int Wflag;                      /* recycle output files after this number of files */
 static int WflagChars;
 static char *zflag = NULL;             /* compress each savefile using a specified command (like gzip or bzip2) */
@@ -271,7 +246,6 @@ static void flushpcap(int);
 static void info(int);
 static u_int packets_captured;
 
-#ifdef HAVE_PCAP_FINDALLDEVS
 static const struct tok status_flags[] = {
 #ifdef PCAP_IF_UP
        { PCAP_IF_UP,       "Up"       },
@@ -285,7 +259,6 @@ static const struct tok status_flags[] = {
 #endif
        { 0, NULL }
 };
-#endif
 
 static pcap_t *pd;
 static pcap_dumper_t *pdd = NULL;
@@ -483,13 +456,10 @@ show_dlts_and_exit(pcap_t *pc, const char *device)
                            dlts[i]);
                }
        }
-#ifdef HAVE_PCAP_FREE_DATALINKS
        pcap_free_datalinks(dlts);
-#endif
        exit_tcpdump(S_SUCCESS);
 }
 
-#ifdef HAVE_PCAP_FINDALLDEVS
 static void NORETURN
 show_devices_and_exit(void)
 {
@@ -552,7 +522,6 @@ show_devices_and_exit(void)
        pcap_freealldevs(devlist);
        exit_tcpdump(S_SUCCESS);
 }
-#endif /* HAVE_PCAP_FINDALLDEVS */
 
 #ifdef HAVE_PCAP_FINDALLDEVS_EX
 static void NORETURN
@@ -589,7 +558,7 @@ show_remote_devices_and_exit(void)
        pcap_freealldevs(devlist);
        exit_tcpdump(S_SUCCESS);
 }
-#endif /* HAVE_PCAP_FINDALLDEVS */
+#endif /* HAVE_PCAP_FINDALLDEVS_EX */
 
 /*
  * Short options.
@@ -625,55 +594,21 @@ show_remote_devices_and_exit(void)
  * Set up flags that might or might not be supported depending on the
  * version of libpcap we're using.
  */
-#if defined(HAVE_PCAP_CREATE) || defined(_WIN32)
-#define B_FLAG         "B:"
-#define B_FLAG_USAGE   " [ -B size ]"
-#else /* defined(HAVE_PCAP_CREATE) || defined(_WIN32) */
-#define B_FLAG
-#define B_FLAG_USAGE
-#endif /* defined(HAVE_PCAP_CREATE) || defined(_WIN32) */
-
-#ifdef HAVE_PCAP_FINDALLDEVS
-#define D_FLAG "D"
-#else
-#define D_FLAG
-#endif
-
-#ifdef HAVE_PCAP_CREATE
-#define I_FLAG         "I"
-#else /* HAVE_PCAP_CREATE */
-#define I_FLAG
-#endif /* HAVE_PCAP_CREATE */
-
 #ifdef HAVE_PCAP_SET_TSTAMP_TYPE
 #define j_FLAG         "j:"
 #define j_FLAG_USAGE   " [ -j tstamptype ]"
 #define J_FLAG         "J"
-#else /* PCAP_ERROR_TSTAMP_TYPE_NOTSUP */
+#else /* HAVE_PCAP_SET_TSTAMP_TYPE */
 #define j_FLAG
 #define j_FLAG_USAGE
 #define J_FLAG
-#endif /* PCAP_ERROR_TSTAMP_TYPE_NOTSUP */
+#endif /* HAVE_PCAP_SET_TSTAMP_TYPE */
 
 #ifdef USE_LIBSMI
 #define m_FLAG_USAGE "[ -m module ] ..."
 #endif
 
-#ifdef HAVE_PCAP_SETDIRECTION
-#define Q_FLAG "Q:"
-#define Q_FLAG_USAGE " [ -Q in|out|inout ]"
-#else
-#define Q_FLAG
-#define Q_FLAG_USAGE
-#endif
-
-#ifdef HAVE_PCAP_DUMP_FLUSH
-#define U_FLAG "U"
-#else
-#define U_FLAG
-#endif
-
-#define SHORTOPTS "aAb" B_FLAG "c:C:d" D_FLAG "eE:fF:G:hHi:" I_FLAG j_FLAG J_FLAG "KlLm:M:nNOpq" Q_FLAG "r:s:StT:u" U_FLAG "vV:w:W:xXy:Yz:Z:#"
+#define SHORTOPTS "aAbB:c:C:dDeE:fF:G:hHi:I" j_FLAG J_FLAG "KlLm:M:nNOpqQ:r:s:StT:uUvV:w:W:xXy:Yz:Z:#"
 
 /*
  * Long options.
@@ -705,20 +640,17 @@ show_remote_devices_and_exit(void)
 #define OPTION_FP_TYPE                 135
 #define OPTION_COUNT                   136
 #define OPTION_PRINT_SAMPLING          137
+#define OPTION_LENGTHS                 138
 
 static const struct option longopts[] = {
-#if defined(HAVE_PCAP_CREATE) || defined(_WIN32)
        { "buffer-size", required_argument, NULL, 'B' },
-#endif
        { "list-interfaces", no_argument, NULL, 'D' },
 #ifdef HAVE_PCAP_FINDALLDEVS_EX
        { "list-remote-interfaces", required_argument, NULL, OPTION_LIST_REMOTE_INTERFACES },
 #endif
        { "help", no_argument, NULL, 'h' },
        { "interface", required_argument, NULL, 'i' },
-#ifdef HAVE_PCAP_CREATE
        { "monitor-mode", no_argument, NULL, 'I' },
-#endif
 #ifdef HAVE_PCAP_SET_TSTAMP_TYPE
        { "time-stamp-type", required_argument, NULL, 'j' },
        { "list-time-stamp-types", no_argument, NULL, 'J' },
@@ -732,14 +664,10 @@ static const struct option longopts[] = {
        { "list-data-link-types", no_argument, NULL, 'L' },
        { "no-optimize", no_argument, NULL, 'O' },
        { "no-promiscuous-mode", no_argument, NULL, 'p' },
-#ifdef HAVE_PCAP_SETDIRECTION
        { "direction", required_argument, NULL, 'Q' },
-#endif
        { "snapshot-length", required_argument, NULL, 's' },
        { "absolute-tcp-sequence-numbers", no_argument, NULL, 'S' },
-#ifdef HAVE_PCAP_DUMP_FLUSH
        { "packet-buffered", no_argument, NULL, 'U' },
-#endif
        { "linktype", required_argument, NULL, 'y' },
 #ifdef HAVE_PCAP_SET_IMMEDIATE_MODE
        { "immediate-mode", no_argument, NULL, OPTION_IMMEDIATE_MODE },
@@ -753,12 +681,13 @@ static const struct option longopts[] = {
        { "number", no_argument, NULL, '#' },
        { "print", no_argument, NULL, OPTION_PRINT },
        { "print-sampling", required_argument, NULL, OPTION_PRINT_SAMPLING },
+       { "lengths", no_argument, NULL, OPTION_LENGTHS },
        { "version", no_argument, NULL, OPTION_VERSION },
        { NULL, 0, NULL, 0 }
 };
 
 #ifdef HAVE_PCAP_FINDALLDEVS_EX
-#define LIST_REMOTE_INTERFACES_USAGE "[ --list-remote-interfaces remote-source ]"
+#define LIST_REMOTE_INTERFACES_USAGE " [ --list-remote-interfaces remote-source ]"
 #else
 #define LIST_REMOTE_INTERFACES_USAGE
 #endif
@@ -997,7 +926,7 @@ tstamp_precision_to_string(int precision)
  * that requires that it be able to do an F_GETFL fcntl() to read
  * the O_ flags.
  *
- * Tcpdump uses ftell() to determine how much data has been written
+ * tcpdump uses ftell() to determine how much data has been written
  * to a file in order to, when used with -C, determine when it's time
  * to rotate capture files.  ftell() therefore needs to do an lseek()
  * to find out the file offset and must, thanks to the aforementioned
@@ -1126,7 +1055,6 @@ read_infile(char *fname)
        return (cp);
 }
 
-#ifdef HAVE_PCAP_FINDALLDEVS
 static long
 parse_interface_number(const char *device)
 {
@@ -1243,13 +1171,15 @@ _U_
        for (i = 0, dev = devlist; i < devnum-1 && dev != NULL;
            i++, dev = dev->next)
                ;
-       if (dev == NULL)
-               error("Invalid adapter index");
+       if (dev == NULL) {
+               pcap_freealldevs(devlist);
+               error("Invalid adapter index %ld: only %ld interfaces found",
+                   devnum, i);
+       }
        device = strdup(dev->name);
        pcap_freealldevs(devlist);
        return (device);
 }
-#endif
 
 #ifdef HAVE_PCAP_OPEN
 /*
@@ -1263,10 +1193,8 @@ static pcap_t *
 open_interface(const char *device, netdissect_options *ndo, char *ebuf)
 {
        pcap_t *pc;
-#ifdef HAVE_PCAP_CREATE
        int status;
        char *cp;
-#endif
 
 #ifdef HAVE_PCAP_OPEN
        /*
@@ -1312,7 +1240,6 @@ open_interface(const char *device, netdissect_options *ndo, char *ebuf)
        }
 #endif /* HAVE_PCAP_OPEN */
 
-#ifdef HAVE_PCAP_CREATE
        pc = pcap_create(device, ebuf);
        if (pc == NULL) {
                /*
@@ -1457,37 +1384,12 @@ open_interface(const char *device, netdissect_options *ndo, char *ebuf)
                        warning("%s: %s", device,
                            pcap_statustostr(status));
        }
-#ifdef HAVE_PCAP_SETDIRECTION
        if (Qflag != -1) {
                status = pcap_setdirection(pc, Qflag);
                if (status != 0)
                        error("%s: pcap_setdirection() failed: %s",
                              device,  pcap_geterr(pc));
        }
-#endif /* HAVE_PCAP_SETDIRECTION */
-#else /* HAVE_PCAP_CREATE */
-       *ebuf = '\0';
-       /*
-        * If no snapshot length was specified, or a length of 0 was
-        * specified, default to 256KB.
-        */
-       if (ndo->ndo_snaplen == 0)
-               ndo->ndo_snaplen = MAXIMUM_SNAPLEN;
-       pc = pcap_open_live(device, ndo->ndo_snaplen, !pflag, timeout, ebuf);
-       if (pc == NULL) {
-               /*
-                * If this failed with "No such device", that means
-                * the interface doesn't exist; return NULL, so that
-                * the caller can see whether the device name is
-                * actually an interface index.
-                */
-               if (strstr(ebuf, "No such device") != NULL)
-                       return (NULL);
-               error("%s", ebuf);
-       }
-       if (*ebuf)
-               warning("%s", ebuf);
-#endif /* HAVE_PCAP_CREATE */
 
        return (pc);
 }
@@ -1516,10 +1418,8 @@ main(int argc, char **argv)
 #endif
        char *ret = NULL;
        char *end;
-#ifdef HAVE_PCAP_FINDALLDEVS
        pcap_if_t *devlist;
        long devnum;
-#endif
        int status;
        FILE *VFile;
 #ifdef HAVE_CAPSICUM
@@ -1565,16 +1465,6 @@ main(int argc, char **argv)
                error("Attempting to initialize Winsock failed");
 #endif
 
-       /*
-        * On platforms where the CPU doesn't support unaligned loads,
-        * force unaligned accesses to abort with SIGBUS, rather than
-        * being fixed up (slowly) by the OS kernel; on those platforms,
-        * misaligned accesses are bugs, and we want tcpdump to crash so
-        * that the bugs are reported.
-        */
-       if (abort_on_misalignment(ebuf, sizeof(ebuf)) < 0)
-               error("%s", ebuf);
-
        /*
         * An explicit tzset() call is usually not needed as it happens
         * implicitly the first time we call localtime() or mktime(),
@@ -1598,13 +1488,11 @@ main(int argc, char **argv)
                        ++ndo->ndo_bflag;
                        break;
 
-#if defined(HAVE_PCAP_CREATE) || defined(_WIN32)
                case 'B':
                        Bflag = atoi(optarg)*1024;
                        if (Bflag <= 0)
                                error("invalid packet buffer size %s", optarg);
                        break;
-#endif /* defined(HAVE_PCAP_CREATE) || defined(_WIN32) */
 
                case 'c':
                        cnt = atoi(optarg);
@@ -1696,11 +1584,9 @@ main(int argc, char **argv)
                        ++dflag;
                        break;
 
-#ifdef HAVE_PCAP_FINDALLDEVS
                case 'D':
                        Dflag++;
                        break;
-#endif
 
 #ifdef HAVE_PCAP_FINDALLDEVS_EX
                case OPTION_LIST_REMOTE_INTERFACES:
@@ -1749,7 +1635,7 @@ main(int argc, char **argv)
                case 'h':
                        print_usage(stdout);
                        exit_tcpdump(S_SUCCESS);
-                       break;
+                       /* NOTREACHED */
 
                case 'H':
                        ++ndo->ndo_Hflag;
@@ -1759,11 +1645,9 @@ main(int argc, char **argv)
                        device = optarg;
                        break;
 
-#ifdef HAVE_PCAP_CREATE
                case 'I':
                        ++Iflag;
                        break;
-#endif /* HAVE_PCAP_CREATE */
 
 #ifdef HAVE_PCAP_SET_TSTAMP_TYPE
                case 'j':
@@ -1790,11 +1674,7 @@ main(int argc, char **argv)
                         */
                        setvbuf(stdout, NULL, _IONBF, 0);
 #else /* _WIN32 */
-#ifdef HAVE_SETLINEBUF
-                       setlinebuf(stdout);
-#else
                        setvbuf(stdout, NULL, _IOLBF, 0);
-#endif
 #endif /* _WIN32 */
                        lflag = 1;
                        break;
@@ -1843,7 +1723,6 @@ main(int argc, char **argv)
                        ++ndo->ndo_suppress_default_print;
                        break;
 
-#ifdef HAVE_PCAP_SETDIRECTION
                case 'Q':
                        if (ascii_strcasecmp(optarg, "in") == 0)
                                Qflag = PCAP_D_IN;
@@ -1854,7 +1733,6 @@ main(int argc, char **argv)
                        else
                                error("unknown capture direction '%s'", optarg);
                        break;
-#endif /* HAVE_PCAP_SETDIRECTION */
 
                case 'r':
                        RFileName = optarg;
@@ -1927,11 +1805,9 @@ main(int argc, char **argv)
                        ++ndo->ndo_uflag;
                        break;
 
-#ifdef HAVE_PCAP_DUMP_FLUSH
                case 'U':
                        ++Uflag;
                        break;
-#endif
 
                case 'v':
                        ++ndo->ndo_vflag;
@@ -1990,10 +1866,14 @@ main(int argc, char **argv)
                        ndo->ndo_packet_number = 1;
                        break;
 
+               case OPTION_LENGTHS:
+                       ndo->ndo_lengths = 1;
+                       break;
+
                case OPTION_VERSION:
                        print_version(stdout);
                        exit_tcpdump(S_SUCCESS);
-                       break;
+                       /* NOTREACHED */
 
 #ifdef HAVE_PCAP_SET_TSTAMP_PRECISION
                case OPTION_TSTAMP_PRECISION:
@@ -2052,10 +1932,8 @@ main(int argc, char **argv)
                        /* NOTREACHED */
                }
 
-#ifdef HAVE_PCAP_FINDALLDEVS
        if (Dflag)
                show_devices_and_exit();
-#endif
 #ifdef HAVE_PCAP_FINDALLDEVS_EX
        if (remote_interfaces_source != NULL)
                show_remote_devices_and_exit();
@@ -2073,7 +1951,7 @@ main(int argc, char **argv)
 
        default: /* Not supported */
                error("only -t, -tt, -ttt, -tttt and -ttttt are supported");
-               break;
+               /* NOTREACHED */
        }
 
        if (ndo->ndo_fflag != 0 && (VFileName != NULL || RFileName != NULL))
@@ -2179,7 +2057,7 @@ main(int argc, char **argv)
                                pcap_datalink_val_to_description(dlt));
                }
                fprintf(stderr, ", snapshot length %d\n", pcap_snapshot(pd));
-#ifdef DLT_LINUX_SLL2
+#if defined(DLT_LINUX_SLL2) && defined(__linux__)
                if (dlt == DLT_LINUX_SLL2)
                        fprintf(stderr, "Warning: interface names might be incorrect\n");
 #endif
@@ -2214,7 +2092,6 @@ main(int argc, char **argv)
                        /*
                         * No interface was specified.  Pick one.
                         */
-#ifdef HAVE_PCAP_FINDALLDEVS
                        /*
                         * Find the list of interfaces, and pick
                         * the first interface.
@@ -2225,15 +2102,6 @@ main(int argc, char **argv)
                                error("no interfaces available for capture");
                        device = strdup(devlist->name);
                        pcap_freealldevs(devlist);
-#else /* HAVE_PCAP_FINDALLDEVS */
-                       /*
-                        * Use whatever interface pcap_lookupdev()
-                        * chooses.
-                        */
-                       device = pcap_lookupdev(ebuf);
-                       if (device == NULL)
-                               error("%s", ebuf);
-#endif
                }
 
                /*
@@ -2248,7 +2116,6 @@ main(int argc, char **argv)
                         * a 1-based index in the list of
                         * interfaces.
                         */
-#ifdef HAVE_PCAP_FINDALLDEVS
                        devnum = parse_interface_number(device);
                        if (devnum == -1) {
                                /*
@@ -2270,13 +2137,6 @@ main(int argc, char **argv)
                        pd = open_interface(device, ndo, ebuf);
                        if (pd == NULL)
                                error("%s", ebuf);
-#else /* HAVE_PCAP_FINDALLDEVS */
-                       /*
-                        * We can't get a list of interfaces; just
-                        * fail.
-                        */
-                       error("%s", ebuf);
-#endif /* HAVE_PCAP_FINDALLDEVS */
                }
 
                /*
@@ -2287,35 +2147,17 @@ main(int argc, char **argv)
                if (setgid(getgid()) != 0 || setuid(getuid()) != 0)
                        fprintf(stderr, "Warning: setgid/setuid failed !\n");
 #endif /* _WIN32 */
-#if !defined(HAVE_PCAP_CREATE) && defined(_WIN32)
-               if(Bflag != 0)
-                       if(pcap_setbuff(pd, Bflag)==-1){
-                               error("%s", pcap_geterr(pd));
-                       }
-#endif /* !defined(HAVE_PCAP_CREATE) && defined(_WIN32) */
                if (Lflag)
                        show_dlts_and_exit(pd, device);
                if (yflag_dlt >= 0) {
-#ifdef HAVE_PCAP_SET_DATALINK
                        if (pcap_set_datalink(pd, yflag_dlt) < 0)
                                error("%s", pcap_geterr(pd));
-#else
-                       /*
-                        * We don't actually support changing the
-                        * data link type, so we only let them
-                        * set it to what it already is.
-                        */
-                       if (yflag_dlt != pcap_datalink(pd)) {
-                               error("%s is not one of the DLTs supported by this device\n",
-                                     yflag_dlt_name);
-                       }
-#endif
                        (void)fprintf(stderr, "%s: data link type %s\n",
                                      program_name,
                                      pcap_datalink_val_to_name(yflag_dlt));
                        (void)fflush(stderr);
                }
-#if defined(DLT_LINUX_SLL2) && defined(HAVE_PCAP_SET_DATALINK)
+#if defined(DLT_LINUX_SLL2)
                else {
                        /*
                         * Attempt to set default linktype to
@@ -2326,8 +2168,11 @@ main(int argc, char **argv)
                         * on; this may be a non-Linux "any" device
                         * that doesn't support DLT_LINUX_SLL2.
                         */
-                       if (strcmp(device, "any") == 0)
+                       if (strcmp(device, "any") == 0) {
+DIAG_OFF_WARN_UNUSED_RESULT
                                (void) pcap_set_datalink(pd, DLT_LINUX_SLL2);
+DIAG_ON_WARN_UNUSED_RESULT
+                       }
                }
 #endif
                i = pcap_snapshot(pd);
@@ -2381,7 +2226,21 @@ main(int argc, char **argv)
 #endif
        /* Cooperate with nohup(1) */
 #ifndef _WIN32
+       /*
+        * In illumos /usr/include/sys/iso/signal_iso.h causes Clang to
+        * generate a -Wstrict-prototypes warning here, see [1].  The
+        * __illumos__ macro is available since at least GCC 11 and Clang 13,
+        * see [2].
+        * 1: https://www.illumos.org/issues/16344
+        * 2: https://www.illumos.org/issues/13726
+        */
+#ifdef __illumos__
+       DIAG_OFF_STRICT_PROTOTYPES
+#endif /* __illumos__ */
        if ((oldhandler = setsignal(SIGHUP, cleanup)) != SIG_DFL)
+#ifdef __illumos__
+       DIAG_ON_STRICT_PROTOTYPES
+#endif /* __illumos__ */
                (void)setsignal(SIGHUP, oldhandler);
 #endif /* _WIN32 */
 
@@ -2394,7 +2253,7 @@ main(int argc, char **argv)
         * devices, and can't just give users that permission,
         * you'd make tcpdump set-UID or set-GID).
         *
-        * Tcpdump doesn't necessarily write only to one savefile;
+        * tcpdump doesn't necessarily write only to one savefile;
         * the general only way to allow a -Z instance to write to
         * savefiles as the user under whose UID it's run, rather
         * than as the user specified with -Z, would thus be to switch
@@ -2570,10 +2429,8 @@ DIAG_ON_ASSIGN_ENUM
                } else
                        dumpinfo.ndo = NULL;
 
-#ifdef HAVE_PCAP_DUMP_FLUSH
                if (Uflag)
                        pcap_dump_flush(pdd);
-#endif
        } else {
                dlt = pcap_datalink(pd);
                ndo->ndo_if_printer = get_if_printer(dlt);
@@ -2818,7 +2675,14 @@ static void
                )
                new.sa_flags = SA_RESTART;
        if (sigaction(sig, &new, &old) < 0)
+               /* The same workaround as for SIG_DFL above. */
+#ifdef __illumos__
+               DIAG_OFF_STRICT_PROTOTYPES
+#endif /* __illumos__ */
                return (SIG_ERR);
+#ifdef __illumos__
+               DIAG_ON_STRICT_PROTOTYPES
+#endif /* __illumos__ */
        return (old.sa_handler);
 #endif
 }
@@ -2843,7 +2707,6 @@ cleanup(int signo _U_)
        setitimer(ITIMER_REAL, &timer, NULL);
 #endif /* _WIN32 */
 
-#ifdef HAVE_PCAP_BREAKLOOP
        /*
         * We have "pcap_breakloop()"; use it, so that we do as little
         * as possible in the signal handler (it's probably not safe
@@ -2851,25 +2714,6 @@ cleanup(int signo _U_)
         * the ANSI C standard doesn't say it is).
         */
        pcap_breakloop(pd);
-#else
-       /*
-        * We don't have "pcap_breakloop()"; this isn't safe, but
-        * it's the best we can do.  Print the summary if we're
-        * not reading from a savefile - i.e., if we're doing a
-        * live capture - and exit.
-        */
-       if (pd != NULL && pcap_file(pd) == NULL) {
-               /*
-                * We got interrupted, so perhaps we didn't
-                * manage to finish a line we were printing.
-                * Print an extra newline, just in case.
-                */
-               putchar('\n');
-               (void)fflush(stdout);
-               info(1);
-       }
-       exit_tcpdump(S_SUCCESS);
-#endif
 }
 
 /*
@@ -2982,6 +2826,58 @@ compress_savefile(const char *filename)
 }
 #endif /* HAVE_FORK && HAVE_VFORK */
 
+static void
+close_old_dump_file(struct dump_info *dump_info)
+{
+       /*
+        * Close the current file and open a new one.
+        */
+       pcap_dump_close(dump_info->pdd);
+
+       /*
+        * Compress the file we just closed, if the user asked for it.
+        */
+       if (zflag != NULL)
+               compress_savefile(dump_info->CurrentFileName);
+}
+
+static void
+open_new_dump_file(struct dump_info *dump_info)
+{
+#ifdef HAVE_CAPSICUM
+       FILE *fp;
+       int fd;
+#endif
+
+#ifdef HAVE_LIBCAP_NG
+       capng_update(CAPNG_ADD, CAPNG_EFFECTIVE, CAP_DAC_OVERRIDE);
+       capng_apply(CAPNG_SELECT_BOTH);
+#endif /* HAVE_LIBCAP_NG */
+#ifdef HAVE_CAPSICUM
+       fd = openat(dump_info->dirfd, dump_info->CurrentFileName,
+           O_CREAT | O_WRONLY | O_TRUNC, 0644);
+       if (fd < 0) {
+               error("unable to open file %s", dump_info->CurrentFileName);
+       }
+       fp = fdopen(fd, "w");
+       if (fp == NULL) {
+               error("unable to fdopen file %s", dump_info->CurrentFileName);
+       }
+       dump_info->pdd = pcap_dump_fopen(dump_info->pd, fp);
+#else  /* !HAVE_CAPSICUM */
+       dump_info->pdd = pcap_dump_open(dump_info->pd, dump_info->CurrentFileName);
+#endif
+#ifdef HAVE_LIBCAP_NG
+       capng_update(CAPNG_DROP, CAPNG_EFFECTIVE, CAP_DAC_OVERRIDE);
+       capng_apply(CAPNG_SELECT_BOTH);
+#endif /* HAVE_LIBCAP_NG */
+       if (dump_info->pdd == NULL)
+               error("%s", pcap_geterr(pd));
+#ifdef HAVE_CAPSICUM
+       set_dumper_capsicum_rights(dump_info->pdd);
+#endif
+}
+
 static void
 dump_packet_and_trunc(u_char *user, const struct pcap_pkthdr *h, const u_char *sp)
 {
@@ -3014,25 +2910,12 @@ dump_packet_and_trunc(u_char *user, const struct pcap_pkthdr *h, const u_char *s
 
                /* If the time is greater than the specified window, rotate */
                if (t - Gflag_time >= Gflag) {
-#ifdef HAVE_CAPSICUM
-                       FILE *fp;
-                       int fd;
-#endif
-
                        /* Update the Gflag_time */
                        Gflag_time = t;
                        /* Update Gflag_count */
                        Gflag_count++;
-                       /*
-                        * Close the current file and open a new one.
-                        */
-                       pcap_dump_close(dump_info->pdd);
 
-                       /*
-                        * Compress the file we just closed, if the user asked for it
-                        */
-                       if (zflag != NULL)
-                               compress_savefile(dump_info->CurrentFileName);
+                       close_old_dump_file(dump_info);
 
                        /*
                         * Check to see if we've exceeded the Wflag (when
@@ -3069,36 +2952,7 @@ dump_packet_and_trunc(u_char *user, const struct pcap_pkthdr *h, const u_char *s
                        else
                                MakeFilename(dump_info->CurrentFileName, dump_info->WFileName, 0, 0);
 
-#ifdef HAVE_LIBCAP_NG
-                       capng_update(CAPNG_ADD, CAPNG_EFFECTIVE, CAP_DAC_OVERRIDE);
-                       capng_apply(CAPNG_SELECT_BOTH);
-#endif /* HAVE_LIBCAP_NG */
-#ifdef HAVE_CAPSICUM
-                       fd = openat(dump_info->dirfd,
-                           dump_info->CurrentFileName,
-                           O_CREAT | O_WRONLY | O_TRUNC, 0644);
-                       if (fd < 0) {
-                               error("unable to open file %s",
-                                   dump_info->CurrentFileName);
-                       }
-                       fp = fdopen(fd, "w");
-                       if (fp == NULL) {
-                               error("unable to fdopen file %s",
-                                   dump_info->CurrentFileName);
-                       }
-                       dump_info->pdd = pcap_dump_fopen(dump_info->pd, fp);
-#else  /* !HAVE_CAPSICUM */
-                       dump_info->pdd = pcap_dump_open(dump_info->pd, dump_info->CurrentFileName);
-#endif
-#ifdef HAVE_LIBCAP_NG
-                       capng_update(CAPNG_DROP, CAPNG_EFFECTIVE, CAP_DAC_OVERRIDE);
-                       capng_apply(CAPNG_SELECT_BOTH);
-#endif /* HAVE_LIBCAP_NG */
-                       if (dump_info->pdd == NULL)
-                               error("%s", pcap_geterr(pd));
-#ifdef HAVE_CAPSICUM
-                       set_dumper_capsicum_rights(dump_info->pdd);
-#endif
+                       open_new_dump_file(dump_info);
                }
        }
 
@@ -3123,22 +2977,7 @@ dump_packet_and_trunc(u_char *user, const struct pcap_pkthdr *h, const u_char *s
                if (size == -1)
                        error("ftell fails on output file");
                if (size > Cflag) {
-#ifdef HAVE_CAPSICUM
-                       FILE *fp;
-                       int fd;
-#endif
-
-                       /*
-                        * Close the current file and open a new one.
-                        */
-                       pcap_dump_close(dump_info->pdd);
-
-                       /*
-                        * Compress the file we just closed, if the user
-                        * asked for it.
-                        */
-                       if (zflag != NULL)
-                               compress_savefile(dump_info->CurrentFileName);
+                       close_old_dump_file(dump_info);
 
                        Cflag_count++;
                        if (Wflag > 0) {
@@ -3151,43 +2990,14 @@ dump_packet_and_trunc(u_char *user, const struct pcap_pkthdr *h, const u_char *s
                        if (dump_info->CurrentFileName == NULL)
                                error("%s: malloc", __func__);
                        MakeFilename(dump_info->CurrentFileName, dump_info->WFileName, Cflag_count, WflagChars);
-#ifdef HAVE_LIBCAP_NG
-                       capng_update(CAPNG_ADD, CAPNG_EFFECTIVE, CAP_DAC_OVERRIDE);
-                       capng_apply(CAPNG_SELECT_BOTH);
-#endif /* HAVE_LIBCAP_NG */
-#ifdef HAVE_CAPSICUM
-                       fd = openat(dump_info->dirfd, dump_info->CurrentFileName,
-                           O_CREAT | O_WRONLY | O_TRUNC, 0644);
-                       if (fd < 0) {
-                               error("unable to open file %s",
-                                   dump_info->CurrentFileName);
-                       }
-                       fp = fdopen(fd, "w");
-                       if (fp == NULL) {
-                               error("unable to fdopen file %s",
-                                   dump_info->CurrentFileName);
-                       }
-                       dump_info->pdd = pcap_dump_fopen(dump_info->pd, fp);
-#else  /* !HAVE_CAPSICUM */
-                       dump_info->pdd = pcap_dump_open(dump_info->pd, dump_info->CurrentFileName);
-#endif
-#ifdef HAVE_LIBCAP_NG
-                       capng_update(CAPNG_DROP, CAPNG_EFFECTIVE, CAP_DAC_OVERRIDE);
-                       capng_apply(CAPNG_SELECT_BOTH);
-#endif /* HAVE_LIBCAP_NG */
-                       if (dump_info->pdd == NULL)
-                               error("%s", pcap_geterr(pd));
-#ifdef HAVE_CAPSICUM
-                       set_dumper_capsicum_rights(dump_info->pdd);
-#endif
+
+                       open_new_dump_file(dump_info);
                }
        }
 
        pcap_dump((u_char *)dump_info->pdd, h, sp);
-#ifdef HAVE_PCAP_DUMP_FLUSH
        if (Uflag)
                pcap_dump_flush(dump_info->pdd);
-#endif
 
        if (dump_info->ndo != NULL)
                pretty_print_packet(dump_info->ndo, h, sp, packets_captured);
@@ -3209,10 +3019,8 @@ dump_packet(u_char *user, const struct pcap_pkthdr *h, const u_char *sp)
        dump_info = (struct dump_info *)user;
 
        pcap_dump((u_char *)dump_info->pdd, h, sp);
-#ifdef HAVE_PCAP_DUMP_FLUSH
        if (Uflag)
                pcap_dump_flush(dump_info->pdd);
-#endif
 
        if (dump_info->ndo != NULL)
                pretty_print_packet(dump_info->ndo, h, sp, packets_captured);
@@ -3289,21 +3097,10 @@ DIAG_OFF_DEPRECATION
 static void
 print_version(FILE *f)
 {
-#ifndef HAVE_PCAP_LIB_VERSION
-  #ifdef HAVE_PCAP_VERSION
-       extern char pcap_version[];
-  #else /* HAVE_PCAP_VERSION */
-       static char pcap_version[] = "unknown";
-  #endif /* HAVE_PCAP_VERSION */
-#endif /* HAVE_PCAP_LIB_VERSION */
        const char *smi_version_string;
 
        (void)fprintf(f, "%s version " PACKAGE_VERSION "\n", program_name);
-#ifdef HAVE_PCAP_LIB_VERSION
        (void)fprintf(f, "%s\n", pcap_lib_version());
-#else /* HAVE_PCAP_LIB_VERSION */
-       (void)fprintf(f, "libpcap version %s\n", pcap_version);
-#endif /* HAVE_PCAP_LIB_VERSION */
 
 #if defined(HAVE_LIBCRYPTO) && defined(SSLEAY_VERSION)
        (void)fprintf (f, "%s\n", SSLeay_version(SSLEAY_VERSION));
@@ -3322,6 +3119,8 @@ print_version(FILE *f)
        (void)fprintf (f, "Compiled with MemorySanitizer/Clang.\n");
 #  endif
 #endif /* __SANITIZE_ADDRESS__ or __has_feature */
+       (void)fprintf (f, "%zu-bit build, %zu-bit time_t\n",
+                      sizeof(void *) * 8, sizeof(time_t) * 8);
 }
 DIAG_ON_DEPRECATION
 
@@ -3330,15 +3129,13 @@ print_usage(FILE *f)
 {
        print_version(f);
        (void)fprintf(f,
-"Usage: %s [-Abd" D_FLAG "efhH" I_FLAG J_FLAG "KlLnNOpqStu" U_FLAG "vxX#]" B_FLAG_USAGE " [ -c count ] [--count]\n", program_name);
+"Usage: %s [-AbdDefhHI" J_FLAG "KlLnNOpqStuUvxX#] [ -B size ] [ -c count ] [--count]\n", program_name);
        (void)fprintf(f,
 "\t\t[ -C file_size ] [ -E algo:secret ] [ -F file ] [ -G seconds ]\n");
        (void)fprintf(f,
 "\t\t[ -i interface ]" IMMEDIATE_MODE_USAGE j_FLAG_USAGE "\n");
-#ifdef HAVE_PCAP_FINDALLDEVS_EX
        (void)fprintf(f,
-"\t\t" LIST_REMOTE_INTERFACES_USAGE "\n");
-#endif
+"\t\t[ --lengths ]" LIST_REMOTE_INTERFACES_USAGE "\n");
 #ifdef USE_LIBSMI
        (void)fprintf(f,
 "\t\t" m_FLAG_USAGE "\n");
@@ -3346,7 +3143,7 @@ print_usage(FILE *f)
        (void)fprintf(f,
 "\t\t[ -M secret ] [ --number ] [ --print ]\n");
        (void)fprintf(f,
-"\t\t[ --print-sampling nth ]" Q_FLAG_USAGE " [ -r file ]\n");
+"\t\t[ --print-sampling nth ] [ -Q in|out|inout ] [ -r file ]\n");
        (void)fprintf(f,
 "\t\t[ -s snaplen ] [ -T type ] [ --version ]\n");
        (void)fprintf(f,