]> The Tcpdump Group git mirrors - tcpdump/blobdiff - print-bootp.c
Clean up comments.
[tcpdump] / print-bootp.c
index f5a9a44e58390ca589047916acd7a679080bbfba..95d5d73b294a5def19c6c12d8c3a6509298fe3ab 100644 (file)
@@ -33,7 +33,6 @@
 #include "addrtoname.h"
 #include "extract.h"
 
-static const char tstr[] = " [|bootp]";
 
 /*
  * Bootstrap Protocol (BOOTP).  RFC951 and RFC1048.
@@ -64,15 +63,15 @@ struct bootp {
        nd_uint16_t     bp_secs;        /* seconds since boot began */
        nd_uint16_t     bp_flags;       /* flags - see bootp_flag_values[]
                                           in print-bootp.c */
-       struct in_addr  bp_ciaddr;      /* client IP address */
-       struct in_addr  bp_yiaddr;      /* 'your' IP address */
-       struct in_addr  bp_siaddr;      /* server IP address */
-       struct in_addr  bp_giaddr;      /* gateway IP address */
+       nd_ipv4         bp_ciaddr;      /* client IP address */
+       nd_ipv4         bp_yiaddr;      /* 'your' IP address */
+       nd_ipv4         bp_siaddr;      /* server IP address */
+       nd_ipv4         bp_giaddr;      /* gateway IP address */
        nd_byte         bp_chaddr[16];  /* client hardware address */
        nd_byte         bp_sname[64];   /* server host name */
        nd_byte         bp_file[128];   /* boot file name */
        nd_byte         bp_vend[64];    /* vendor-specific area */
-} ND_UNALIGNED;
+};
 
 #define BOOTPREPLY     2
 #define BOOTPREQUEST   1
@@ -241,13 +240,13 @@ struct bootp {
 struct cmu_vend {
        nd_byte         v_magic[4];     /* magic number */
        nd_uint32_t     v_flags;        /* flags/opcodes, etc. */
-       struct in_addr  v_smask;        /* Subnet mask */
-       struct in_addr  v_dgate;        /* Default gateway */
-       struct in_addr  v_dns1, v_dns2; /* Domain name servers */
-       struct in_addr  v_ins1, v_ins2; /* IEN-116 name servers */
-       struct in_addr  v_ts1, v_ts2;   /* Time servers */
+       nd_ipv4         v_smask;        /* Subnet mask */
+       nd_ipv4         v_dgate;        /* Default gateway */
+       nd_ipv4         v_dns1, v_dns2; /* Domain name servers */
+       nd_ipv4         v_ins1, v_ins2; /* IEN-116 name servers */
+       nd_ipv4         v_ts1, v_ts2;   /* Time servers */
        nd_byte         v_unused[24];   /* currently unused */
-} ND_UNALIGNED;
+};
 
 
 /* v_flags values */
@@ -288,17 +287,18 @@ bootp_print(netdissect_options *ndo,
        static const u_char vm_rfc1048[4] = VM_RFC1048;
        uint8_t bp_op, bp_htype, bp_hlen;
 
+       ndo->ndo_protocol = "bootp";
        bp = (const struct bootp *)cp;
        ND_TCHECK_1(bp->bp_op);
-       bp_op = EXTRACT_U_1(bp->bp_op);
+       bp_op = GET_U_1(bp->bp_op);
        ND_PRINT("BOOTP/DHCP, %s",
                  tok2str(bootp_op_values, "unknown (0x%02x)", bp_op));
 
        ND_TCHECK_1(bp->bp_hlen);
-       bp_htype = EXTRACT_U_1(bp->bp_htype);
-       bp_hlen = EXTRACT_U_1(bp->bp_hlen);
+       bp_htype = GET_U_1(bp->bp_htype);
+       bp_hlen = GET_U_1(bp->bp_hlen);
        if (bp_htype == 1 && bp_hlen == 6 && bp_op == BOOTPREQUEST) {
-               ND_TCHECK_LEN(bp->bp_chaddr, 6);
+               ND_TCHECK_6(bp->bp_chaddr);
                ND_PRINT(" from %s", etheraddr_string(ndo, bp->bp_chaddr));
        }
 
@@ -318,70 +318,70 @@ bootp_print(netdissect_options *ndo,
                ND_PRINT(", hlen %u", bp_hlen);
 
        /* Only print interesting fields */
-       if (EXTRACT_U_1(bp->bp_hops))
-               ND_PRINT(", hops %u", EXTRACT_U_1(bp->bp_hops));
-       if (EXTRACT_BE_U_4(bp->bp_xid))
-               ND_PRINT(", xid 0x%x", EXTRACT_BE_U_4(bp->bp_xid));
-       if (EXTRACT_BE_U_2(bp->bp_secs))
-               ND_PRINT(", secs %u", EXTRACT_BE_U_2(bp->bp_secs));
+       if (GET_U_1(bp->bp_hops))
+               ND_PRINT(", hops %u", GET_U_1(bp->bp_hops));
+       if (GET_BE_U_4(bp->bp_xid))
+               ND_PRINT(", xid 0x%x", GET_BE_U_4(bp->bp_xid));
+       if (GET_BE_U_2(bp->bp_secs))
+               ND_PRINT(", secs %u", GET_BE_U_2(bp->bp_secs));
 
        ND_TCHECK_2(bp->bp_flags);
        ND_PRINT(", Flags [%s]",
-                 bittok2str(bootp_flag_values, "none", EXTRACT_BE_U_2(bp->bp_flags)));
+                 bittok2str(bootp_flag_values, "none", GET_BE_U_2(bp->bp_flags)));
        if (ndo->ndo_vflag > 1)
-               ND_PRINT(" (0x%04x)", EXTRACT_BE_U_2(bp->bp_flags));
+               ND_PRINT(" (0x%04x)", GET_BE_U_2(bp->bp_flags));
 
        /* Client's ip address */
-       ND_TCHECK(bp->bp_ciaddr);
-       if (EXTRACT_IPV4_TO_HOST_ORDER(&bp->bp_ciaddr.s_addr))
-               ND_PRINT("\n\t  Client-IP %s", ipaddr_string(ndo, &bp->bp_ciaddr));
+       ND_TCHECK_4(bp->bp_ciaddr);
+       if (GET_IPV4_TO_NETWORK_ORDER(bp->bp_ciaddr))
+               ND_PRINT("\n\t  Client-IP %s", ipaddr_string(ndo, bp->bp_ciaddr));
 
        /* 'your' ip address (bootp client) */
-       ND_TCHECK(bp->bp_yiaddr);
-       if (EXTRACT_IPV4_TO_HOST_ORDER(&bp->bp_yiaddr.s_addr))
-               ND_PRINT("\n\t  Your-IP %s", ipaddr_string(ndo, &bp->bp_yiaddr));
+       ND_TCHECK_4(bp->bp_yiaddr);
+       if (GET_IPV4_TO_NETWORK_ORDER(bp->bp_yiaddr))
+               ND_PRINT("\n\t  Your-IP %s", ipaddr_string(ndo, bp->bp_yiaddr));
 
        /* Server's ip address */
-       ND_TCHECK(bp->bp_siaddr);
-       if (EXTRACT_IPV4_TO_HOST_ORDER(&bp->bp_siaddr.s_addr))
-               ND_PRINT("\n\t  Server-IP %s", ipaddr_string(ndo, &bp->bp_siaddr));
+       ND_TCHECK_4(bp->bp_siaddr);
+       if (GET_IPV4_TO_NETWORK_ORDER(bp->bp_siaddr))
+               ND_PRINT("\n\t  Server-IP %s", ipaddr_string(ndo, bp->bp_siaddr));
 
        /* Gateway's ip address */
-       ND_TCHECK(bp->bp_giaddr);
-       if (EXTRACT_IPV4_TO_HOST_ORDER(&bp->bp_giaddr.s_addr))
-               ND_PRINT("\n\t  Gateway-IP %s", ipaddr_string(ndo, &bp->bp_giaddr));
+       ND_TCHECK_4(bp->bp_giaddr);
+       if (GET_IPV4_TO_NETWORK_ORDER(bp->bp_giaddr))
+               ND_PRINT("\n\t  Gateway-IP %s", ipaddr_string(ndo, bp->bp_giaddr));
 
        /* Client's Ethernet address */
        if (bp_htype == 1 && bp_hlen == 6) {
-               ND_TCHECK_LEN(bp->bp_chaddr, 6);
+               ND_TCHECK_6(bp->bp_chaddr);
                ND_PRINT("\n\t  Client-Ethernet-Address %s", etheraddr_string(ndo, bp->bp_chaddr));
        }
 
        ND_TCHECK_1(bp->bp_sname);              /* check first char only */
-       if (EXTRACT_U_1(bp->bp_sname)) {
+       if (GET_U_1(bp->bp_sname)) {
                ND_PRINT("\n\t  sname \"");
-               if (fn_printztn(ndo, bp->bp_sname, (u_int)sizeof bp->bp_sname,
-                   ndo->ndo_snapend)) {
+               if (nd_printztn(ndo, bp->bp_sname, (u_int)sizeof(bp->bp_sname),
+                               ndo->ndo_snapend) == 0) {
                        ND_PRINT("\"");
-                       ND_PRINT("%s", tstr + 1);
+                       nd_print_trunc(ndo);
                        return;
                }
                ND_PRINT("\"");
        }
        ND_TCHECK_1(bp->bp_file);               /* check first char only */
-       if (EXTRACT_U_1(bp->bp_file)) {
+       if (GET_U_1(bp->bp_file)) {
                ND_PRINT("\n\t  file \"");
-               if (fn_printztn(ndo, bp->bp_file, (u_int)sizeof bp->bp_file,
-                   ndo->ndo_snapend)) {
+               if (nd_printztn(ndo, bp->bp_file, (u_int)sizeof(bp->bp_file),
+                               ndo->ndo_snapend) == 0) {
                        ND_PRINT("\"");
-                       ND_PRINT("%s", tstr + 1);
+                       nd_print_trunc(ndo);
                        return;
                }
                ND_PRINT("\"");
        }
 
        /* Decode the vendor buffer */
-       ND_TCHECK_LEN(bp->bp_vend, 4);
+       ND_TCHECK_4(bp->bp_vend);
        if (memcmp((const char *)bp->bp_vend, vm_rfc1048,
                    sizeof(uint32_t)) == 0)
                rfc1048_print(ndo, bp->bp_vend);
@@ -391,14 +391,14 @@ bootp_print(netdissect_options *ndo,
        else {
                uint32_t ul;
 
-               ul = EXTRACT_BE_U_4(bp->bp_vend);
+               ul = GET_BE_U_4(bp->bp_vend);
                if (ul != 0)
                        ND_PRINT("\n\t  Vendor-#0x%x", ul);
        }
 
        return;
 trunc:
-       ND_PRINT("%s", tstr);
+       nd_print_trunc(ndo);
 }
 
 /*
@@ -408,8 +408,8 @@ trunc:
  *     l - long (32 bits)
  *     L - unsigned long (32 bits)
  *     s - short (16 bits)
- *     b - period-seperated decimal bytes (variable length)
- *     x - colon-seperated hex bytes (variable length)
+ *     b - period-separated decimal bytes (variable length)
+ *     x - colon-separated hex bytes (variable length)
  *     a - ASCII string (variable length)
  *     B - on/off (8 bits)
  *     $ - special (explicit code to handle)
@@ -608,12 +608,12 @@ rfc1048_print(netdissect_options *ndo,
        ND_PRINT("\n\t  Vendor-rfc1048 Extensions");
 
        /* Step over magic cookie */
-       ND_PRINT("\n\t    Magic Cookie 0x%08x", EXTRACT_BE_U_4(bp));
+       ND_PRINT("\n\t    Magic Cookie 0x%08x", GET_BE_U_4(bp));
        bp += sizeof(int32_t);
 
        /* Loop while we there is a tag left in the buffer */
        while (ND_TTEST_1(bp)) {
-               tag = EXTRACT_U_1(bp);
+               tag = GET_U_1(bp);
                bp++;
                if (tag == TAG_PAD && ndo->ndo_vflag < 3)
                        continue;
@@ -621,7 +621,7 @@ rfc1048_print(netdissect_options *ndo,
                        return;
                if (tag == TAG_EXTENDED_OPTION) {
                        ND_TCHECK_2(bp + 1);
-                       tag = EXTRACT_BE_U_2(bp + 1);
+                       tag = GET_BE_U_2(bp + 1);
                        /* XXX we don't know yet if the IANA will
                         * preclude overlap of 1-byte and 2-byte spaces.
                         * If not, we need to offset tag after this step.
@@ -636,7 +636,7 @@ rfc1048_print(netdissect_options *ndo,
                else {
                        /* Get the length; check for truncation */
                        ND_TCHECK_1(bp);
-                       len = EXTRACT_U_1(bp);
+                       len = GET_U_1(bp);
                        bp++;
                }
 
@@ -646,7 +646,7 @@ rfc1048_print(netdissect_options *ndo,
                if (tag == TAG_PAD && ndo->ndo_vflag > 2) {
                        u_int ntag = 1;
                        while (ND_TTEST_1(bp) &&
-                              EXTRACT_U_1(bp) == TAG_PAD) {
+                              GET_U_1(bp) == TAG_PAD) {
                                bp++;
                                ntag++;
                        }
@@ -654,13 +654,11 @@ rfc1048_print(netdissect_options *ndo,
                                ND_PRINT(", occurs %u", ntag);
                }
 
-               if (!ND_TTEST_LEN(bp, len)) {
-                       ND_PRINT("[|rfc1048 %u]", len);
-                       return;
-               }
+               ND_TCHECK_LEN(bp, len);
 
                if (tag == TAG_DHCP_MESSAGE && len == 1) {
-                       ND_PRINT("%s", tok2str(dhcp_msg_values, "Unknown (%u)", EXTRACT_U_1(bp)));
+                       ND_PRINT("%s",
+                                tok2str(dhcp_msg_values, "Unknown (%u)", GET_U_1(bp)));
                        bp++;
                        continue;
                }
@@ -668,7 +666,8 @@ rfc1048_print(netdissect_options *ndo,
                if (tag == TAG_PARM_REQUEST) {
                        idx = 0;
                        while (len > 0) {
-                               cp = tok2str(tag2str, "?Option %u", EXTRACT_U_1(bp));
+                               cp = tok2str(tag2str, "?Option %u",
+                                            GET_U_1(bp));
                                bp++;
                                len--;
                                if (idx % 4 == 0)
@@ -684,7 +683,8 @@ rfc1048_print(netdissect_options *ndo,
                if (tag == TAG_EXTENDED_REQUEST) {
                        first = 1;
                        while (len > 1) {
-                               cp = tok2str(xtag2str, "?xT%u", EXTRACT_BE_U_2(bp));
+                               cp = tok2str(xtag2str, "?xT%u",
+                                            GET_BE_U_2(bp));
                                bp += 2;
                                len -= 2;
                                if (!first)
@@ -711,7 +711,7 @@ rfc1048_print(netdissect_options *ndo,
                case 'a':
                        /* ASCII strings */
                        ND_PRINT("\"");
-                       if (fn_printn(ndo, bp, len, ndo->ndo_snapend)) {
+                       if (nd_printn(ndo, bp, len, ndo->ndo_snapend)) {
                                ND_PRINT("\"");
                                goto trunc;
                        }
@@ -730,9 +730,9 @@ rfc1048_print(netdissect_options *ndo,
                                if (c == 'i')
                                        ND_PRINT("%s", ipaddr_string(ndo, bp));
                                else if (c == 'L')
-                                       ND_PRINT("%d", EXTRACT_BE_S_4(bp));
+                                       ND_PRINT("%d", GET_BE_S_4(bp));
                                else
-                                       ND_PRINT("%u", EXTRACT_BE_U_4(bp));
+                                       ND_PRINT("%u", GET_BE_U_4(bp));
                                bp += 4;
                                len -= 4;
                                first = 0;
@@ -759,7 +759,7 @@ rfc1048_print(netdissect_options *ndo,
                        while (len >= 2) {
                                if (!first)
                                        ND_PRINT(",");
-                               ND_PRINT("%u", EXTRACT_BE_U_2(bp));
+                               ND_PRINT("%u", GET_BE_U_2(bp));
                                bp += 2;
                                len -= 2;
                                first = 0;
@@ -772,7 +772,7 @@ rfc1048_print(netdissect_options *ndo,
                                uint8_t bool_value;
                                if (!first)
                                        ND_PRINT(",");
-                               bool_value = EXTRACT_U_1(bp);
+                               bool_value = GET_U_1(bp);
                                switch (bool_value) {
                                case 0:
                                        ND_PRINT("N");
@@ -798,7 +798,7 @@ rfc1048_print(netdissect_options *ndo,
                                uint8_t byte_value;
                                if (!first)
                                        ND_PRINT(c == 'x' ? ":" : ".");
-                               byte_value = EXTRACT_U_1(bp);
+                               byte_value = GET_U_1(bp);
                                if (c == 'x')
                                        ND_PRINT("%02x", byte_value);
                                else
@@ -819,7 +819,7 @@ rfc1048_print(netdissect_options *ndo,
                                        ND_PRINT("ERROR: length < 1 bytes");
                                        break;
                                }
-                               tag = EXTRACT_U_1(bp);
+                               tag = GET_U_1(bp);
                                ++bp;
                                --len;
                                ND_PRINT("%s", tok2str(nbo2str, NULL, tag));
@@ -831,7 +831,7 @@ rfc1048_print(netdissect_options *ndo,
                                        ND_PRINT("ERROR: length < 1 bytes");
                                        break;
                                }
-                               tag = EXTRACT_U_1(bp);
+                               tag = GET_U_1(bp);
                                ++bp;
                                --len;
                                ND_PRINT("%s", tok2str(oo2str, NULL, tag));
@@ -845,14 +845,16 @@ rfc1048_print(netdissect_options *ndo,
                                        len = 0;
                                        break;
                                }
-                               if (EXTRACT_U_1(bp))
-                                       ND_PRINT("[%s] ", client_fqdn_flags(EXTRACT_U_1(bp)));
+                               if (GET_U_1(bp))
+                                       ND_PRINT("[%s] ",
+                                                client_fqdn_flags(GET_U_1(bp)));
                                bp++;
-                               if (EXTRACT_U_1(bp) || EXTRACT_U_1(bp + 1))
-                                       ND_PRINT("%u/%u ", EXTRACT_U_1(bp), EXTRACT_U_1(bp + 1));
+                               if (GET_U_1(bp) || GET_U_1(bp + 1))
+                                       ND_PRINT("%u/%u ", GET_U_1(bp),
+                                                GET_U_1(bp + 1));
                                bp += 2;
                                ND_PRINT("\"");
-                               if (fn_printn(ndo, bp, len - 3, ndo->ndo_snapend)) {
+                               if (nd_printn(ndo, bp, len - 3, ndo->ndo_snapend)) {
                                        ND_PRINT("\"");
                                        goto trunc;
                                }
@@ -870,12 +872,12 @@ rfc1048_print(netdissect_options *ndo,
                                        ND_PRINT("ERROR: length < 1 bytes");
                                        break;
                                }
-                               type = EXTRACT_U_1(bp);
+                               type = GET_U_1(bp);
                                bp++;
                                len--;
                                if (type == 0) {
                                        ND_PRINT("\"");
-                                       if (fn_printn(ndo, bp, len, ndo->ndo_snapend)) {
+                                       if (nd_printn(ndo, bp, len, ndo->ndo_snapend)) {
                                                ND_PRINT("\"");
                                                goto trunc;
                                        }
@@ -888,7 +890,7 @@ rfc1048_print(netdissect_options *ndo,
                                        while (len > 0) {
                                                if (!first)
                                                        ND_PRINT(":");
-                                               ND_PRINT("%02x", EXTRACT_U_1(bp));
+                                               ND_PRINT("%02x", GET_U_1(bp));
                                                ++bp;
                                                --len;
                                                first = 0;
@@ -899,8 +901,8 @@ rfc1048_print(netdissect_options *ndo,
 
                        case TAG_AGENT_CIRCUIT:
                                while (len >= 2) {
-                                       subopt = EXTRACT_U_1(bp);
-                                       suboptlen = EXTRACT_U_1(bp + 1);
+                                       subopt = GET_U_1(bp);
+                                       suboptlen = GET_U_1(bp + 1);
                                        bp += 2;
                                        len -= 2;
                                        if (suboptlen > len) {
@@ -921,7 +923,7 @@ rfc1048_print(netdissect_options *ndo,
                                        case AGENT_SUBOPTION_CIRCUIT_ID: /* fall through */
                                        case AGENT_SUBOPTION_REMOTE_ID:
                                        case AGENT_SUBOPTION_SUBSCRIBER_ID:
-                                               if (fn_printn(ndo, bp, suboptlen, ndo->ndo_snapend))
+                                               if (nd_printn(ndo, bp, suboptlen, ndo->ndo_snapend))
                                                        goto trunc;
                                                break;
 
@@ -949,7 +951,7 @@ rfc1048_print(netdissect_options *ndo,
                                while (len > 0) {
                                        if (!first)
                                                ND_PRINT(",");
-                                       mask_width = EXTRACT_U_1(bp);
+                                       mask_width = GET_U_1(bp);
                                        bp++;
                                        len--;
                                        /* mask_width <= 32 */
@@ -974,7 +976,8 @@ rfc1048_print(netdissect_options *ndo,
                                                for (i = 0; i < significant_octets ; i++) {
                                                        if (i > 0)
                                                                ND_PRINT(".");
-                                                       ND_PRINT("%u", EXTRACT_U_1(bp));
+                                                       ND_PRINT("%u",
+                                                                GET_U_1(bp));
                                                        bp++;
                                                }
                                                for (i = significant_octets ; i < 4 ; i++)
@@ -1001,7 +1004,7 @@ rfc1048_print(netdissect_options *ndo,
                                        break;
                                }
                                while (len > 0) {
-                                       suboptlen = EXTRACT_U_1(bp);
+                                       suboptlen = GET_U_1(bp);
                                        bp++;
                                        len--;
                                        ND_PRINT("\n\t      ");
@@ -1019,7 +1022,7 @@ rfc1048_print(netdissect_options *ndo,
                                                break;
                                        }
                                        ND_PRINT("\"");
-                                       if (fn_printn(ndo, bp, suboptlen, ndo->ndo_snapend)) {
+                                       if (nd_printn(ndo, bp, suboptlen, ndo->ndo_snapend)) {
                                                ND_PRINT("\"");
                                                goto trunc;
                                        }
@@ -1049,12 +1052,12 @@ rfc1048_print(netdissect_options *ndo,
        }
        return;
 trunc:
-       ND_PRINT("|[rfc1048]");
+       nd_print_trunc(ndo);
 }
 
-#define PRINTCMUADDR(m, s) { ND_TCHECK(cmu->m); \
-    if (cmu->m.s_addr != 0) \
-       ND_PRINT(" %s:%s", s, ipaddr_string(ndo, &cmu->m.s_addr)); }
+#define PRINTCMUADDR(m, s) { ND_TCHECK_4(cmu->m); \
+    if (GET_IPV4_TO_NETWORK_ORDER(cmu->m) != 0) \
+       ND_PRINT(" %s:%s", s, ipaddr_string(ndo, cmu->m)); }
 
 static void
 cmu_print(netdissect_options *ndo,
@@ -1068,7 +1071,7 @@ cmu_print(netdissect_options *ndo,
 
        /* Only print if there are unknown bits */
        ND_TCHECK_4(cmu->v_flags);
-       v_flags = EXTRACT_U_1(cmu->v_flags);
+       v_flags = GET_U_1(cmu->v_flags);
        if ((v_flags & ~(VF_SMASK)) != 0)
                ND_PRINT(" F:0x%x", v_flags);
        PRINTCMUADDR(v_dgate, "DG");
@@ -1082,7 +1085,7 @@ cmu_print(netdissect_options *ndo,
        return;
 
 trunc:
-       ND_PRINT("%s", tstr);
+       nd_print_trunc(ndo);
 }
 
 #undef PRINTCMUADDR