CVE-2016-7931/Add bounds and length checks.

[tcpdump] / util-print.c

diff --git a/util-print.c b/util-print.c
index 6858ce3672012a6b5b4718f684aa4606dc6e6359..113f784660c8652d8da5bcddc8a347d617904a8a 100644 (file)
--- a/util-print.c
+++ b/util-print.c
@@ -783,7 +783,7 @@ txtproto_print(netdissect_options *ndo, const u_char *pptr, u_int len,
 
        /* Capitalize the protocol name */
        for (pnp = protoname; *pnp != '\0'; pnp++)
-               ND_PRINT((ndo, "%c", toupper(*pnp)));
+               ND_PRINT((ndo, "%c", toupper((u_char)*pnp)));
 
        if (is_reqresp) {
                /*