Pointers into packet data should usually be pointers to unsigned 1-byte

[tcpdump] / print-atalk.c

diff --git a/print-atalk.c b/print-atalk.c
index 8c92b63bb87d30b0374c236ba862dc574250656b..6ea136116788086c3d04f5824839177832c70d51 100644 (file)
--- a/print-atalk.c
+++ b/print-atalk.c
@@ -22,8 +22,8 @@
  */
 
 #ifndef lint
  */
 
 #ifndef lint

-static const char rcsid[] =
-    "@(#) $Header: /tcpdump/master/tcpdump/print-atalk.c,v 1.72 2002-08-01 08:53:00 risso Exp $ (LBL)";
+static const char rcsid[] _U_ =
+    "@(#) $Header: /tcpdump/master/tcpdump/print-atalk.c,v 1.81 2004-05-01 09:41:50 hannes Exp $ (LBL)";

 #endif
 
 #ifdef HAVE_CONFIG_H
 #endif
 
 #ifdef HAVE_CONFIG_H


@@ -35,7 +35,6 @@ static const char rcsid[] =
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>

-#include <netdb.h>             /* for MAXHOSTNAMELEN on some platforms */

 #include <pcap.h>
 
 #include "interface.h"
 #include <pcap.h>
 
 #include "interface.h"


@@ -82,31 +81,23 @@ static const char *ddpskt_string(int);
 /*
  * Print LLAP packets received on a physical LocalTalk interface.
  */
 /*
  * Print LLAP packets received on a physical LocalTalk interface.
  */

-void
-ltalk_if_print(u_char *user, const struct pcap_pkthdr *h, const u_char *p)
+u_int
+ltalk_if_print(const struct pcap_pkthdr *h, const u_char *p)

 {
 {

-       snapend = p + h->caplen;
-       ++infodelay;
-       ts_print(&h->ts);
-       llap_print(p, h->caplen);
-       if(xflag)
-               default_print(p, h->caplen);
-       putchar('\n');
-       --infodelay;
-       if (infoprint)
-               info(0);
+       return (llap_print(p, h->caplen));

 }
 
 /*
  * Print AppleTalk LLAP packets.
  */
 }
 
 /*
  * Print AppleTalk LLAP packets.
  */

-void
+u_int

 llap_print(register const u_char *bp, u_int length)
 {
        register const struct LAP *lp;
        register const struct atDDP *dp;
        register const struct atShortDDP *sdp;
        u_short snet;
 llap_print(register const u_char *bp, u_int length)
 {
        register const struct LAP *lp;
        register const struct atDDP *dp;
        register const struct atShortDDP *sdp;
        u_short snet;

+       u_int hdrlen;

 
        /*
         * Our packet is on a 4-byte boundary, as we're either called
 
        /*
         * Our packet is on a 4-byte boundary, as we're either called


@@ -119,12 +110,13 @@ llap_print(register const u_char *bp, u_int length)
        lp = (const struct LAP *)bp;
        bp += sizeof(*lp);
        length -= sizeof(*lp);
        lp = (const struct LAP *)bp;
        bp += sizeof(*lp);
        length -= sizeof(*lp);

+       hdrlen = sizeof(*lp);

        switch (lp->type) {
 
        case lapShortDDP:
                if (length < ddpSSize) {
                        (void)printf(" [|sddp %d]", length);
        switch (lp->type) {
 
        case lapShortDDP:
                if (length < ddpSSize) {
                        (void)printf(" [|sddp %d]", length);

-                       return;
+                       return (length);

                }
                sdp = (const struct atShortDDP *)bp;
                printf("%s.%s",
                }
                sdp = (const struct atShortDDP *)bp;
                printf("%s.%s",


@@ -133,13 +125,14 @@ llap_print(register const u_char *bp, u_int length)
                    ataddr_string(0, lp->dst), ddpskt_string(sdp->dstSkt));
                bp += ddpSSize;
                length -= ddpSSize;
                    ataddr_string(0, lp->dst), ddpskt_string(sdp->dstSkt));
                bp += ddpSSize;
                length -= ddpSSize;

+               hdrlen += ddpSSize;

                ddp_print(bp, length, sdp->type, 0, lp->src, sdp->srcSkt);
                break;
 
        case lapDDP:
                if (length < ddpSize) {
                        (void)printf(" [|ddp %d]", length);
                ddp_print(bp, length, sdp->type, 0, lp->src, sdp->srcSkt);
                break;
 
        case lapDDP:
                if (length < ddpSize) {
                        (void)printf(" [|ddp %d]", length);

-                       return;
+                       return (length);

                }
                dp = (const struct atDDP *)bp;
                snet = EXTRACT_16BITS(&dp->srcNet);
                }
                dp = (const struct atDDP *)bp;
                snet = EXTRACT_16BITS(&dp->srcNet);


@@ -150,6 +143,7 @@ llap_print(register const u_char *bp, u_int length)
                    ddpskt_string(dp->dstSkt));
                bp += ddpSize;
                length -= ddpSize;
                    ddpskt_string(dp->dstSkt));
                bp += ddpSize;
                length -= ddpSize;

+               hdrlen += ddpSize;

                ddp_print(bp, length, dp->type, snet, dp->srcNode, dp->srcSkt);
                break;
 
                ddp_print(bp, length, dp->type, snet, dp->srcNode, dp->srcSkt);
                break;
 


@@ -164,6 +158,7 @@ llap_print(register const u_char *bp, u_int length)
                    lp->src, lp->dst, lp->type, length);
                break;
        }
                    lp->src, lp->dst, lp->type, length);
                break;
        }

+       return (hdrlen);

 }
 
 /*
 }
 
 /*


@@ -177,6 +172,9 @@ atalk_print(register const u_char *bp, u_int length)
        register const struct atDDP *dp;
        u_short snet;
 
        register const struct atDDP *dp;
        u_short snet;
 

+        if(!eflag)
+            printf("AT ");
+

        if (length < ddpSize) {
                (void)printf(" [|ddp %d]", length);
                return;
        if (length < ddpSize) {
                (void)printf(" [|ddp %d]", length);
                return;


@@ -185,26 +183,11 @@ atalk_print(register const u_char *bp, u_int length)
        snet = EXTRACT_16BITS(&dp->srcNet);
        printf("%s.%s", ataddr_string(snet, dp->srcNode),
               ddpskt_string(dp->srcSkt));
        snet = EXTRACT_16BITS(&dp->srcNet);
        printf("%s.%s", ataddr_string(snet, dp->srcNode),
               ddpskt_string(dp->srcSkt));

-       printf(" > %s.%s:",
+       printf(" > %s.%s: ",

               ataddr_string(EXTRACT_16BITS(&dp->dstNet), dp->dstNode),
               ddpskt_string(dp->dstSkt));
        bp += ddpSize;
        length -= ddpSize;
               ataddr_string(EXTRACT_16BITS(&dp->dstNet), dp->dstNode),
               ddpskt_string(dp->dstSkt));
        bp += ddpSize;
        length -= ddpSize;

-#ifdef LBL_ALIGN
-       if ((long)bp & 3) {
-               static u_char *abuf = NULL;
-
-               if (abuf == NULL) {
-                       abuf = (u_char *)malloc(snaplen);
-                       if (abuf == NULL)
-                               error("atalk_print: malloc");
-               }
-               memcpy((char *)abuf, (char *)bp, min(length, snaplen));
-               snapend += abuf - (u_char *)bp;
-               packetp = abuf;
-               bp = abuf;
-       }
-#endif

        ddp_print(bp, length, dp->type, snet, dp->srcNode, dp->srcSkt);
 }
 
        ddp_print(bp, length, dp->type, snet, dp->srcNode, dp->srcSkt);
 }
 


@@ -218,9 +201,10 @@ aarp_print(register const u_char *bp, u_int length)
 
        printf("aarp ");
        ap = (const struct aarp *)bp;
 
        printf("aarp ");
        ap = (const struct aarp *)bp;

-       if (ntohs(ap->htype) == 1 && ntohs(ap->ptype) == ETHERTYPE_ATALK &&
+       if (EXTRACT_16BITS(&ap->htype) == 1 &&
+           EXTRACT_16BITS(&ap->ptype) == ETHERTYPE_ATALK &&

            ap->halen == 6 && ap->palen == 4 )
            ap->halen == 6 && ap->palen == 4 )

-               switch (ntohs(ap->op)) {
+               switch (EXTRACT_16BITS(&ap->op)) {

 
                case 1:                         /* request */
                        (void)printf("who-has %s tell %s",
 
                case 1:                         /* request */
                        (void)printf("who-has %s tell %s",


@@ -238,8 +222,8 @@ aarp_print(register const u_char *bp, u_int length)
                        return;
                }
        (void)printf("len %u op %u htype %u ptype %#x halen %u palen %u",
                        return;
                }
        (void)printf("len %u op %u htype %u ptype %#x halen %u palen %u",

-           length, ntohs(ap->op), ntohs(ap->htype), ntohs(ap->ptype),
-           ap->halen, ap->palen);
+           length, EXTRACT_16BITS(&ap->op), EXTRACT_16BITS(&ap->htype),
+           EXTRACT_16BITS(&ap->ptype), ap->halen, ap->palen);

 }
 
 /*
 }
 
 /*


@@ -260,6 +244,10 @@ ddp_print(register const u_char *bp, register u_int length, register int t,
                atp_print((const struct atATP *)bp, length);
                break;
 
                atp_print((const struct atATP *)bp, length);
                break;
 

+       case ddpEIGRP:
+               eigrp_print(bp, length);
+               break;
+

        default:
                (void)printf(" at-%s %d", tok2str(type2str, NULL, t), length);
                break;
        default:
                (void)printf(" at-%s %d", tok2str(type2str, NULL, t), length);
                break;