]> The Tcpdump Group git mirrors - tcpdump/blobdiff - print-rsvp.c
IPX: Add a length check
[tcpdump] / print-rsvp.c
index 421127ec1ab533dd6f0012eebbe3133fb38145fd..421f4ac8f39b8c9bcb0916f6b49d2b754993d1cc 100644 (file)
 /* specification: RFC 2205 */
 
 #ifdef HAVE_CONFIG_H
-#include "config.h"
+#include <config.h>
 #endif
 
-#include <netdissect-stdinc.h>
+#include "netdissect-stdinc.h"
 
 #include "netdissect.h"
 #include "extract.h"
@@ -33,7 +33,6 @@
 #include "af.h"
 #include "signature.h"
 
-static const char tstr[] = " [|rsvp]";
 
 /*
  * RFC 2205 common header
@@ -506,11 +505,11 @@ rsvp_intserv_print(netdissect_options *ndo,
     ND_TCHECK_2(tptr + 2);
     parameter_length = EXTRACT_BE_U_2(tptr + 2)<<2; /* convert wordcount to bytecount */
 
-    ND_PRINT((ndo, "\n\t      Parameter ID: %s (%u), length: %u, Flags: [0x%02x]",
+    ND_PRINT("\n\t      Parameter ID: %s (%u), length: %u, Flags: [0x%02x]",
            tok2str(rsvp_intserv_parameter_id_values,"unknown",parameter_id),
            parameter_id,
            parameter_length,
-           EXTRACT_U_1(tptr + 1)));
+           EXTRACT_U_1(tptr + 1));
 
     if (obj_tlen < parameter_length+4)
         return 0;
@@ -526,7 +525,7 @@ rsvp_intserv_print(netdissect_options *ndo,
         */
         if (parameter_length == 4) {
            ND_TCHECK_4(tptr + 4);
-            ND_PRINT((ndo, "\n\t\tIS hop count: %u", EXTRACT_BE_U_4(tptr + 4)));
+            ND_PRINT("\n\t\tIS hop count: %u", EXTRACT_BE_U_4(tptr + 4));
         }
         break;
 
@@ -541,7 +540,7 @@ rsvp_intserv_print(netdissect_options *ndo,
         if (parameter_length == 4) {
            ND_TCHECK_4(tptr + 4);
             bw.i = EXTRACT_BE_U_4(tptr + 4);
-            ND_PRINT((ndo, "\n\t\tPath b/w estimate: %.10g Mbps", bw.f / 125000));
+            ND_PRINT("\n\t\tPath b/w estimate: %.10g Mbps", bw.f / 125000);
         }
         break;
 
@@ -555,11 +554,11 @@ rsvp_intserv_print(netdissect_options *ndo,
         */
         if (parameter_length == 4) {
            ND_TCHECK_4(tptr + 4);
-            ND_PRINT((ndo, "\n\t\tMinimum path latency: "));
+            ND_PRINT("\n\t\tMinimum path latency: ");
             if (EXTRACT_BE_U_4(tptr + 4) == 0xffffffff)
-                ND_PRINT((ndo, "don't care"));
+                ND_PRINT("don't care");
             else
-                ND_PRINT((ndo, "%u", EXTRACT_BE_U_4(tptr + 4)));
+                ND_PRINT("%u", EXTRACT_BE_U_4(tptr + 4));
         }
         break;
 
@@ -574,7 +573,7 @@ rsvp_intserv_print(netdissect_options *ndo,
         */
         if (parameter_length == 4) {
            ND_TCHECK_4(tptr + 4);
-            ND_PRINT((ndo, "\n\t\tComposed MTU: %u bytes", EXTRACT_BE_U_4(tptr + 4)));
+            ND_PRINT("\n\t\tComposed MTU: %u bytes", EXTRACT_BE_U_4(tptr + 4));
         }
         break;
     case 127:
@@ -597,13 +596,13 @@ rsvp_intserv_print(netdissect_options *ndo,
         if (parameter_length == 20) {
            ND_TCHECK_LEN(tptr + 4, 20);
             bw.i = EXTRACT_BE_U_4(tptr + 4);
-            ND_PRINT((ndo, "\n\t\tToken Bucket Rate: %.10g Mbps", bw.f / 125000));
+            ND_PRINT("\n\t\tToken Bucket Rate: %.10g Mbps", bw.f / 125000);
             bw.i = EXTRACT_BE_U_4(tptr + 8);
-            ND_PRINT((ndo, "\n\t\tToken Bucket Size: %.10g bytes", bw.f));
+            ND_PRINT("\n\t\tToken Bucket Size: %.10g bytes", bw.f);
             bw.i = EXTRACT_BE_U_4(tptr + 12);
-            ND_PRINT((ndo, "\n\t\tPeak Data Rate: %.10g Mbps", bw.f / 125000));
-            ND_PRINT((ndo, "\n\t\tMinimum Policed Unit: %u bytes", EXTRACT_BE_U_4(tptr + 16)));
-            ND_PRINT((ndo, "\n\t\tMaximum Packet Size: %u bytes", EXTRACT_BE_U_4(tptr + 20)));
+            ND_PRINT("\n\t\tPeak Data Rate: %.10g Mbps", bw.f / 125000);
+            ND_PRINT("\n\t\tMinimum Policed Unit: %u bytes", EXTRACT_BE_U_4(tptr + 16));
+            ND_PRINT("\n\t\tMaximum Packet Size: %u bytes", EXTRACT_BE_U_4(tptr + 20));
         }
         break;
 
@@ -621,8 +620,8 @@ rsvp_intserv_print(netdissect_options *ndo,
         if (parameter_length == 8) {
            ND_TCHECK_8(tptr + 4);
             bw.i = EXTRACT_BE_U_4(tptr + 4);
-            ND_PRINT((ndo, "\n\t\tRate: %.10g Mbps", bw.f / 125000));
-            ND_PRINT((ndo, "\n\t\tSlack Term: %u", EXTRACT_BE_U_4(tptr + 8)));
+            ND_PRINT("\n\t\tRate: %.10g Mbps", bw.f / 125000);
+            ND_PRINT("\n\t\tSlack Term: %u", EXTRACT_BE_U_4(tptr + 8));
         }
         break;
 
@@ -632,7 +631,7 @@ rsvp_intserv_print(netdissect_options *ndo,
     case 136:
         if (parameter_length == 4) {
            ND_TCHECK_4(tptr + 4);
-            ND_PRINT((ndo, "\n\t\tValue: %u", EXTRACT_BE_U_4(tptr + 4)));
+            ND_PRINT("\n\t\tValue: %u", EXTRACT_BE_U_4(tptr + 4));
         }
         break;
 
@@ -643,7 +642,7 @@ rsvp_intserv_print(netdissect_options *ndo,
     return (parameter_length+4); /* header length 4 bytes */
 
 trunc:
-    ND_PRINT((ndo, "%s", tstr));
+    nd_print_trunc(ndo);
     return 0;
 }
 
@@ -693,17 +692,17 @@ rsvp_obj_print(netdissect_options *ndo,
         rsvp_obj_ctype=EXTRACT_U_1(rsvp_obj_header->ctype);
 
         if(rsvp_obj_len % 4) {
-            ND_PRINT((ndo, "%sERROR: object header size %u not a multiple of 4", indent, rsvp_obj_len));
+            ND_PRINT("%sERROR: object header size %u not a multiple of 4", indent, rsvp_obj_len);
             return -1;
         }
         if(rsvp_obj_len < sizeof(struct rsvp_object_header)) {
-            ND_PRINT((ndo, "%sERROR: object header too short %u < %lu", indent, rsvp_obj_len,
-                   (unsigned long)sizeof(struct rsvp_object_header)));
+            ND_PRINT("%sERROR: object header too short %u < %lu", indent, rsvp_obj_len,
+                   (unsigned long)sizeof(struct rsvp_object_header));
             return -1;
         }
 
         rsvp_obj_class_num = EXTRACT_U_1(rsvp_obj_header->class_num);
-        ND_PRINT((ndo, "%s%s Object (%u) Flags: [%s",
+        ND_PRINT("%s%s Object (%u) Flags: [%s",
                indent,
                tok2str(rsvp_obj_values,
                        "Unknown",
@@ -712,17 +711,17 @@ rsvp_obj_print(netdissect_options *ndo,
                (rsvp_obj_class_num & 0x80) ?
                    ((rsvp_obj_class_num & 0x40) ? "ignore and forward" :
                                          "ignore silently") :
-                   "reject"));
+                   "reject");
 
-        ND_PRINT((ndo, " if unknown], Class-Type: %s (%u), length: %u",
+        ND_PRINT(" if unknown], Class-Type: %s (%u), length: %u",
                tok2str(rsvp_ctype_values,
                        "Unknown",
                        (rsvp_obj_class_num<<8)+rsvp_obj_ctype),
                rsvp_obj_ctype,
-               rsvp_obj_len));
+               rsvp_obj_len);
 
         if(tlen < rsvp_obj_len) {
-            ND_PRINT((ndo, "%sERROR: object goes past end of objects TLV", indent));
+            ND_PRINT("%sERROR: object goes past end of objects TLV", indent);
             return -1;
         }
 
@@ -730,8 +729,7 @@ rsvp_obj_print(netdissect_options *ndo,
         obj_tlen=rsvp_obj_len-sizeof(struct rsvp_object_header);
 
         /* did we capture enough for fully decoding the object ? */
-        if (!ND_TTEST_LEN(tptr, rsvp_obj_len))
-            return -1;
+        ND_TCHECK_LEN(tptr, rsvp_obj_len);
         hexdump=FALSE;
 
         switch(rsvp_obj_class_num) {
@@ -740,28 +738,28 @@ rsvp_obj_print(netdissect_options *ndo,
             case RSVP_CTYPE_IPV4:
                 if (obj_tlen < 8)
                     return -1;
-                ND_PRINT((ndo, "%s  IPv4 DestAddress: %s, Protocol ID: 0x%02x",
+                ND_PRINT("%s  IPv4 DestAddress: %s, Protocol ID: 0x%02x",
                        indent,
                        ipaddr_string(ndo, obj_tptr),
-                       EXTRACT_U_1(obj_tptr + sizeof(struct in_addr))));
-                ND_PRINT((ndo, "%s  Flags: [0x%02x], DestPort %u",
+                       EXTRACT_U_1(obj_tptr + sizeof(nd_ipv4)));
+                ND_PRINT("%s  Flags: [0x%02x], DestPort %u",
                        indent,
                        EXTRACT_U_1((obj_tptr + 5)),
-                       EXTRACT_BE_U_2(obj_tptr + 6)));
+                       EXTRACT_BE_U_2(obj_tptr + 6));
                 obj_tlen-=8;
                 obj_tptr+=8;
                 break;
             case RSVP_CTYPE_IPV6:
                 if (obj_tlen < 20)
                     return -1;
-                ND_PRINT((ndo, "%s  IPv6 DestAddress: %s, Protocol ID: 0x%02x",
+                ND_PRINT("%s  IPv6 DestAddress: %s, Protocol ID: 0x%02x",
                        indent,
                        ip6addr_string(ndo, obj_tptr),
-                       EXTRACT_U_1(obj_tptr + sizeof(struct in6_addr))));
-                ND_PRINT((ndo, "%s  Flags: [0x%02x], DestPort %u",
+                       EXTRACT_U_1(obj_tptr + sizeof(nd_ipv6)));
+                ND_PRINT("%s  Flags: [0x%02x], DestPort %u",
                        indent,
-                       EXTRACT_U_1((obj_tptr + sizeof(struct in6_addr) + 1)),
-                       EXTRACT_BE_U_2(obj_tptr + sizeof(struct in6_addr) + 2)));
+                       EXTRACT_U_1((obj_tptr + sizeof(nd_ipv6) + 1)),
+                       EXTRACT_BE_U_2(obj_tptr + sizeof(nd_ipv6) + 2));
                 obj_tlen-=20;
                 obj_tptr+=20;
                 break;
@@ -769,11 +767,11 @@ rsvp_obj_print(netdissect_options *ndo,
             case RSVP_CTYPE_TUNNEL_IPV6:
                 if (obj_tlen < 36)
                     return -1;
-                ND_PRINT((ndo, "%s  IPv6 Tunnel EndPoint: %s, Tunnel ID: 0x%04x, Extended Tunnel ID: %s",
+                ND_PRINT("%s  IPv6 Tunnel EndPoint: %s, Tunnel ID: 0x%04x, Extended Tunnel ID: %s",
                        indent,
                        ip6addr_string(ndo, obj_tptr),
                        EXTRACT_BE_U_2(obj_tptr + 18),
-                       ip6addr_string(ndo, obj_tptr + 20)));
+                       ip6addr_string(ndo, obj_tptr + 20));
                 obj_tlen-=36;
                 obj_tptr+=36;
                 break;
@@ -781,22 +779,22 @@ rsvp_obj_print(netdissect_options *ndo,
             case RSVP_CTYPE_14: /* IPv6 p2mp LSP Tunnel */
                 if (obj_tlen < 26)
                     return -1;
-                ND_PRINT((ndo, "%s  IPv6 P2MP LSP ID: 0x%08x, Tunnel ID: 0x%04x, Extended Tunnel ID: %s",
+                ND_PRINT("%s  IPv6 P2MP LSP ID: 0x%08x, Tunnel ID: 0x%04x, Extended Tunnel ID: %s",
                        indent,
                        EXTRACT_BE_U_4(obj_tptr),
                        EXTRACT_BE_U_2(obj_tptr + 6),
-                       ip6addr_string(ndo, obj_tptr + 8)));
+                       ip6addr_string(ndo, obj_tptr + 8));
                 obj_tlen-=26;
                 obj_tptr+=26;
                 break;
             case RSVP_CTYPE_13: /* IPv4 p2mp LSP Tunnel */
                 if (obj_tlen < 12)
                     return -1;
-                ND_PRINT((ndo, "%s  IPv4 P2MP LSP ID: %s, Tunnel ID: 0x%04x, Extended Tunnel ID: %s",
+                ND_PRINT("%s  IPv4 P2MP LSP ID: %s, Tunnel ID: 0x%04x, Extended Tunnel ID: %s",
                        indent,
                        ipaddr_string(ndo, obj_tptr),
                        EXTRACT_BE_U_2(obj_tptr + 6),
-                       ipaddr_string(ndo, obj_tptr + 8)));
+                       ipaddr_string(ndo, obj_tptr + 8));
                 obj_tlen-=12;
                 obj_tptr+=12;
                 break;
@@ -804,11 +802,11 @@ rsvp_obj_print(netdissect_options *ndo,
             case RSVP_CTYPE_UNI_IPV4:
                 if (obj_tlen < 12)
                     return -1;
-                ND_PRINT((ndo, "%s  IPv4 Tunnel EndPoint: %s, Tunnel ID: 0x%04x, Extended Tunnel ID: %s",
+                ND_PRINT("%s  IPv4 Tunnel EndPoint: %s, Tunnel ID: 0x%04x, Extended Tunnel ID: %s",
                        indent,
                        ipaddr_string(ndo, obj_tptr),
                        EXTRACT_BE_U_2(obj_tptr + 6),
-                       ipaddr_string(ndo, obj_tptr + 8)));
+                       ipaddr_string(ndo, obj_tptr + 8));
                 obj_tlen-=12;
                 obj_tptr+=12;
                 break;
@@ -820,22 +818,22 @@ rsvp_obj_print(netdissect_options *ndo,
         case RSVP_OBJ_CONFIRM:
             switch(rsvp_obj_ctype) {
             case RSVP_CTYPE_IPV4:
-                if (obj_tlen < sizeof(struct in_addr))
+                if (obj_tlen < sizeof(nd_ipv4))
                     return -1;
-                ND_PRINT((ndo, "%s  IPv4 Receiver Address: %s",
+                ND_PRINT("%s  IPv4 Receiver Address: %s",
                        indent,
-                       ipaddr_string(ndo, obj_tptr)));
-                obj_tlen-=sizeof(struct in_addr);
-                obj_tptr+=sizeof(struct in_addr);
+                       ipaddr_string(ndo, obj_tptr));
+                obj_tlen-=sizeof(nd_ipv4);
+                obj_tptr+=sizeof(nd_ipv4);
                 break;
             case RSVP_CTYPE_IPV6:
-                if (obj_tlen < sizeof(struct in6_addr))
+                if (obj_tlen < sizeof(nd_ipv6))
                     return -1;
-                ND_PRINT((ndo, "%s  IPv6 Receiver Address: %s",
+                ND_PRINT("%s  IPv6 Receiver Address: %s",
                        indent,
-                       ip6addr_string(ndo, obj_tptr)));
-                obj_tlen-=sizeof(struct in6_addr);
-                obj_tptr+=sizeof(struct in6_addr);
+                       ip6addr_string(ndo, obj_tptr));
+                obj_tlen-=sizeof(nd_ipv6);
+                obj_tptr+=sizeof(nd_ipv6);
                 break;
             default:
                 hexdump=TRUE;
@@ -845,22 +843,22 @@ rsvp_obj_print(netdissect_options *ndo,
         case RSVP_OBJ_NOTIFY_REQ:
             switch(rsvp_obj_ctype) {
             case RSVP_CTYPE_IPV4:
-                if (obj_tlen < sizeof(struct in_addr))
+                if (obj_tlen < sizeof(nd_ipv4))
                     return -1;
-                ND_PRINT((ndo, "%s  IPv4 Notify Node Address: %s",
+                ND_PRINT("%s  IPv4 Notify Node Address: %s",
                        indent,
-                       ipaddr_string(ndo, obj_tptr)));
-                obj_tlen-=sizeof(struct in_addr);
-                obj_tptr+=sizeof(struct in_addr);
+                       ipaddr_string(ndo, obj_tptr));
+                obj_tlen-=sizeof(nd_ipv4);
+                obj_tptr+=sizeof(nd_ipv4);
                 break;
             case RSVP_CTYPE_IPV6:
-                if (obj_tlen < sizeof(struct in6_addr))
+                if (obj_tlen < sizeof(nd_ipv6))
                     return-1;
-                ND_PRINT((ndo, "%s  IPv6 Notify Node Address: %s",
+                ND_PRINT("%s  IPv6 Notify Node Address: %s",
                        indent,
-                       ip6addr_string(ndo, obj_tptr)));
-                obj_tlen-=sizeof(struct in6_addr);
-                obj_tptr+=sizeof(struct in6_addr);
+                       ip6addr_string(ndo, obj_tptr));
+                obj_tlen-=sizeof(nd_ipv6);
+                obj_tptr+=sizeof(nd_ipv6);
                 break;
             default:
                 hexdump=TRUE;
@@ -874,7 +872,7 @@ rsvp_obj_print(netdissect_options *ndo,
             switch(rsvp_obj_ctype) {
             case RSVP_CTYPE_1:
                 while(obj_tlen >= 4 ) {
-                    ND_PRINT((ndo, "%s  Label: %u", indent, EXTRACT_BE_U_4(obj_tptr)));
+                    ND_PRINT("%s  Label: %u", indent, EXTRACT_BE_U_4(obj_tptr));
                     obj_tlen-=4;
                     obj_tptr+=4;
                 }
@@ -882,21 +880,21 @@ rsvp_obj_print(netdissect_options *ndo,
             case RSVP_CTYPE_2:
                 if (obj_tlen < 4)
                     return-1;
-                ND_PRINT((ndo, "%s  Generalized Label: %u",
+                ND_PRINT("%s  Generalized Label: %u",
                        indent,
-                       EXTRACT_BE_U_4(obj_tptr)));
+                       EXTRACT_BE_U_4(obj_tptr));
                 obj_tlen-=4;
                 obj_tptr+=4;
                 break;
             case RSVP_CTYPE_3:
                 if (obj_tlen < 12)
                     return-1;
-                ND_PRINT((ndo, "%s  Waveband ID: %u%s  Start Label: %u, Stop Label: %u",
+                ND_PRINT("%s  Waveband ID: %u%s  Start Label: %u, Stop Label: %u",
                        indent,
                        EXTRACT_BE_U_4(obj_tptr),
                        indent,
                        EXTRACT_BE_U_4(obj_tptr + 4),
-                       EXTRACT_BE_U_4(obj_tptr + 8)));
+                       EXTRACT_BE_U_4(obj_tptr + 8));
                 obj_tlen-=12;
                 obj_tptr+=12;
                 break;
@@ -910,12 +908,12 @@ rsvp_obj_print(netdissect_options *ndo,
             case RSVP_CTYPE_1:
                 if (obj_tlen < 4)
                     return-1;
-                ND_PRINT((ndo, "%s  Reservation Style: %s, Flags: [0x%02x]",
+                ND_PRINT("%s  Reservation Style: %s, Flags: [0x%02x]",
                        indent,
                        tok2str(rsvp_resstyle_values,
                                "Unknown",
                                EXTRACT_BE_U_3(obj_tptr + 1)),
-                       EXTRACT_U_1(obj_tptr)));
+                       EXTRACT_U_1(obj_tptr));
                 obj_tlen-=4;
                 obj_tptr+=4;
                 break;
@@ -929,58 +927,58 @@ rsvp_obj_print(netdissect_options *ndo,
             case RSVP_CTYPE_IPV4:
                 if (obj_tlen < 8)
                     return-1;
-                ND_PRINT((ndo, "%s  Source Address: %s, Source Port: %u",
+                ND_PRINT("%s  Source Address: %s, Source Port: %u",
                        indent,
                        ipaddr_string(ndo, obj_tptr),
-                       EXTRACT_BE_U_2(obj_tptr + 6)));
+                       EXTRACT_BE_U_2(obj_tptr + 6));
                 obj_tlen-=8;
                 obj_tptr+=8;
                 break;
             case RSVP_CTYPE_IPV6:
                 if (obj_tlen < 20)
                     return-1;
-                ND_PRINT((ndo, "%s  Source Address: %s, Source Port: %u",
+                ND_PRINT("%s  Source Address: %s, Source Port: %u",
                        indent,
                        ip6addr_string(ndo, obj_tptr),
-                       EXTRACT_BE_U_2(obj_tptr + 18)));
+                       EXTRACT_BE_U_2(obj_tptr + 18));
                 obj_tlen-=20;
                 obj_tptr+=20;
                 break;
             case RSVP_CTYPE_13: /* IPv6 p2mp LSP tunnel */
                 if (obj_tlen < 40)
                     return-1;
-                ND_PRINT((ndo, "%s  IPv6 Tunnel Sender Address: %s, LSP ID: 0x%04x"
+                ND_PRINT("%s  IPv6 Tunnel Sender Address: %s, LSP ID: 0x%04x"
                        "%s  Sub-Group Originator ID: %s, Sub-Group ID: 0x%04x",
                        indent,
                        ip6addr_string(ndo, obj_tptr),
                        EXTRACT_BE_U_2(obj_tptr + 18),
                        indent,
                        ip6addr_string(ndo, obj_tptr+20),
-                       EXTRACT_BE_U_2(obj_tptr + 38)));
+                       EXTRACT_BE_U_2(obj_tptr + 38));
                 obj_tlen-=40;
                 obj_tptr+=40;
                 break;
             case RSVP_CTYPE_TUNNEL_IPV4:
                 if (obj_tlen < 8)
                     return-1;
-                ND_PRINT((ndo, "%s  IPv4 Tunnel Sender Address: %s, LSP-ID: 0x%04x",
+                ND_PRINT("%s  IPv4 Tunnel Sender Address: %s, LSP-ID: 0x%04x",
                        indent,
                        ipaddr_string(ndo, obj_tptr),
-                       EXTRACT_BE_U_2(obj_tptr + 6)));
+                       EXTRACT_BE_U_2(obj_tptr + 6));
                 obj_tlen-=8;
                 obj_tptr+=8;
                 break;
             case RSVP_CTYPE_12: /* IPv4 p2mp LSP tunnel */
                 if (obj_tlen < 16)
                     return-1;
-                ND_PRINT((ndo, "%s  IPv4 Tunnel Sender Address: %s, LSP ID: 0x%04x"
+                ND_PRINT("%s  IPv4 Tunnel Sender Address: %s, LSP ID: 0x%04x"
                        "%s  Sub-Group Originator ID: %s, Sub-Group ID: 0x%04x",
                        indent,
                        ipaddr_string(ndo, obj_tptr),
                        EXTRACT_BE_U_2(obj_tptr + 6),
                        indent,
                        ipaddr_string(ndo, obj_tptr+8),
-                       EXTRACT_BE_U_2(obj_tptr + 12)));
+                       EXTRACT_BE_U_2(obj_tptr + 12));
                 obj_tlen-=16;
                 obj_tptr+=16;
                 break;
@@ -993,11 +991,11 @@ rsvp_obj_print(netdissect_options *ndo,
             switch(rsvp_obj_ctype) {
             case RSVP_CTYPE_1:
                 while(obj_tlen >= 4 ) {
-                    ND_PRINT((ndo, "%s  L3 Protocol ID: %s",
+                    ND_PRINT("%s  L3 Protocol ID: %s",
                            indent,
                            tok2str(ethertype_values,
                                    "Unknown Protocol (0x%04x)",
-                                   EXTRACT_BE_U_2(obj_tptr + 2))));
+                                   EXTRACT_BE_U_2(obj_tptr + 2)));
                     obj_tlen-=4;
                     obj_tptr+=4;
                 }
@@ -1005,50 +1003,50 @@ rsvp_obj_print(netdissect_options *ndo,
             case RSVP_CTYPE_2:
                 if (obj_tlen < 12)
                     return-1;
-                ND_PRINT((ndo, "%s  L3 Protocol ID: %s",
+                ND_PRINT("%s  L3 Protocol ID: %s",
                        indent,
                        tok2str(ethertype_values,
                                "Unknown Protocol (0x%04x)",
-                               EXTRACT_BE_U_2(obj_tptr + 2))));
-                ND_PRINT((ndo, ",%s merge capability",((EXTRACT_U_1(obj_tptr + 4)) & 0x80) ? "no" : "" ));
-                ND_PRINT((ndo, "%s  Minimum VPI/VCI: %u/%u",
+                               EXTRACT_BE_U_2(obj_tptr + 2)));
+                ND_PRINT(",%s merge capability",((EXTRACT_U_1(obj_tptr + 4)) & 0x80) ? "no" : "" );
+                ND_PRINT("%s  Minimum VPI/VCI: %u/%u",
                        indent,
                        (EXTRACT_BE_U_2(obj_tptr + 4))&0xfff,
-                       (EXTRACT_BE_U_2(obj_tptr + 6)) & 0xfff));
-                ND_PRINT((ndo, "%s  Maximum VPI/VCI: %u/%u",
+                       (EXTRACT_BE_U_2(obj_tptr + 6)) & 0xfff);
+                ND_PRINT("%s  Maximum VPI/VCI: %u/%u",
                        indent,
                        (EXTRACT_BE_U_2(obj_tptr + 8))&0xfff,
-                       (EXTRACT_BE_U_2(obj_tptr + 10)) & 0xfff));
+                       (EXTRACT_BE_U_2(obj_tptr + 10)) & 0xfff);
                 obj_tlen-=12;
                 obj_tptr+=12;
                 break;
             case RSVP_CTYPE_3:
                 if (obj_tlen < 12)
                     return-1;
-                ND_PRINT((ndo, "%s  L3 Protocol ID: %s",
+                ND_PRINT("%s  L3 Protocol ID: %s",
                        indent,
                        tok2str(ethertype_values,
                                "Unknown Protocol (0x%04x)",
-                               EXTRACT_BE_U_2(obj_tptr + 2))));
-                ND_PRINT((ndo, "%s  Minimum/Maximum DLCI: %u/%u, %s%s bit DLCI",
+                               EXTRACT_BE_U_2(obj_tptr + 2)));
+                ND_PRINT("%s  Minimum/Maximum DLCI: %u/%u, %s%s bit DLCI",
                        indent,
                        (EXTRACT_BE_U_4(obj_tptr + 4))&0x7fffff,
                        (EXTRACT_BE_U_4(obj_tptr + 8))&0x7fffff,
                        (((EXTRACT_BE_U_2(obj_tptr + 4)>>7)&3) == 0 ) ? "10" : "",
-                       (((EXTRACT_BE_U_2(obj_tptr + 4) >> 7) & 3) == 2 ) ? "23" : ""));
+                       (((EXTRACT_BE_U_2(obj_tptr + 4) >> 7) & 3) == 2 ) ? "23" : "");
                 obj_tlen-=12;
                 obj_tptr+=12;
                 break;
             case RSVP_CTYPE_4:
                 if (obj_tlen < 4)
                     return-1;
-                ND_PRINT((ndo, "%s  LSP Encoding Type: %s (%u)",
+                ND_PRINT("%s  LSP Encoding Type: %s (%u)",
                        indent,
                        tok2str(gmpls_encoding_values,
                                "Unknown",
                                EXTRACT_U_1(obj_tptr)),
-                       EXTRACT_U_1(obj_tptr)));
-                ND_PRINT((ndo, "%s  Switching Type: %s (%u), Payload ID: %s (0x%04x)",
+                       EXTRACT_U_1(obj_tptr));
+                ND_PRINT("%s  Switching Type: %s (%u), Payload ID: %s (0x%04x)",
                        indent,
                        tok2str(gmpls_switch_cap_values,
                                "Unknown",
@@ -1057,7 +1055,7 @@ rsvp_obj_print(netdissect_options *ndo,
                        tok2str(gmpls_payload_values,
                                "Unknown",
                                EXTRACT_BE_U_2(obj_tptr + 2)),
-                       EXTRACT_BE_U_2(obj_tptr + 2)));
+                       EXTRACT_BE_U_2(obj_tptr + 2));
                 obj_tlen-=4;
                 obj_tptr+=4;
                 break;
@@ -1075,19 +1073,19 @@ rsvp_obj_print(netdissect_options *ndo,
 
                    ND_TCHECK_4(obj_tptr);
                    length = EXTRACT_U_1(obj_tptr + 1);
-                    ND_PRINT((ndo, "%s  Subobject Type: %s, length %u",
+                    ND_PRINT("%s  Subobject Type: %s, length %u",
                            indent,
                            tok2str(rsvp_obj_xro_values,
                                    "Unknown %u",
                                    RSVP_OBJ_XRO_MASK_SUBOBJ(EXTRACT_U_1(obj_tptr))),
-                           length));
+                           length);
                     if (obj_tlen < length) {
-                        ND_PRINT((ndo, "%s  ERROR: ERO subobject length > object length", indent));
+                        ND_PRINT("%s  ERROR: ERO subobject length > object length", indent);
                         break;
-                    };
+                    }
 
                     if (length == 0) { /* prevent infinite loops */
-                        ND_PRINT((ndo, "%s  ERROR: zero length ERO subtype", indent));
+                        ND_PRINT("%s  ERROR: zero length ERO subtype", indent);
                         break;
                     }
 
@@ -1096,31 +1094,31 @@ rsvp_obj_print(netdissect_options *ndo,
 
                     case RSVP_OBJ_XRO_IPV4:
                        if (length != 8) {
-                               ND_PRINT((ndo, " ERROR: length != 8"));
+                               ND_PRINT(" ERROR: length != 8");
                                goto invalid;
                        }
                        ND_TCHECK_8(obj_tptr);
                        prefix_length = EXTRACT_U_1(obj_tptr + 6);
                        if (prefix_length != 32) {
-                               ND_PRINT((ndo, " ERROR: Prefix length %u != 32",
-                                         prefix_length));
+                               ND_PRINT(" ERROR: Prefix length %u != 32",
+                                         prefix_length);
                                goto invalid;
                        }
-                        ND_PRINT((ndo, ", %s, %s/%u, Flags: [%s]",
+                        ND_PRINT(", %s, %s/%u, Flags: [%s]",
                                RSVP_OBJ_XRO_MASK_LOOSE(EXTRACT_U_1(obj_tptr)) ? "Loose" : "Strict",
                                ipaddr_string(ndo, obj_tptr+2),
                                EXTRACT_U_1((obj_tptr + 6)),
                                bittok2str(rsvp_obj_rro_flag_values,
                                    "none",
-                                   EXTRACT_U_1((obj_tptr + 7))))); /* rfc3209 says that this field is rsvd. */
+                                   EXTRACT_U_1((obj_tptr + 7)))); /* rfc3209 says that this field is rsvd. */
                     break;
                     case RSVP_OBJ_XRO_LABEL:
                        if (length != 8) {
-                               ND_PRINT((ndo, " ERROR: length != 8"));
+                               ND_PRINT(" ERROR: length != 8");
                                goto invalid;
                        }
                        ND_TCHECK_8(obj_tptr);
-                        ND_PRINT((ndo, ", Flags: [%s] (%#x), Class-Type: %s (%u), %u",
+                        ND_PRINT(", Flags: [%s] (%#x), Class-Type: %s (%u), %u",
                                bittok2str(rsvp_obj_rro_label_flag_values,
                                    "none",
                                    EXTRACT_U_1((obj_tptr + 2))),
@@ -1129,7 +1127,7 @@ rsvp_obj_print(netdissect_options *ndo,
                                        "Unknown",
                                        EXTRACT_U_1((obj_tptr + 3)) + (256 * RSVP_OBJ_RRO)),
                                EXTRACT_U_1((obj_tptr + 3)),
-                               EXTRACT_BE_U_4(obj_tptr + 4)));
+                               EXTRACT_BE_U_4(obj_tptr + 4));
                     }
                     obj_tlen-=length;
                     obj_tptr+=length;
@@ -1146,10 +1144,10 @@ rsvp_obj_print(netdissect_options *ndo,
             case RSVP_CTYPE_2:
                 if (obj_tlen < 8)
                     return-1;
-                ND_PRINT((ndo, "%s  Source Instance: 0x%08x, Destination Instance: 0x%08x",
+                ND_PRINT("%s  Source Instance: 0x%08x, Destination Instance: 0x%08x",
                        indent,
                        EXTRACT_BE_U_4(obj_tptr),
-                       EXTRACT_BE_U_4(obj_tptr + 4)));
+                       EXTRACT_BE_U_4(obj_tptr + 4));
                 obj_tlen-=8;
                 obj_tptr+=8;
                 break;
@@ -1163,10 +1161,10 @@ rsvp_obj_print(netdissect_options *ndo,
             case RSVP_CTYPE_1:
                 if (obj_tlen < 8)
                     return-1;
-                ND_PRINT((ndo, "%s  Restart  Time: %ums, Recovery Time: %ums",
+                ND_PRINT("%s  Restart  Time: %ums, Recovery Time: %ums",
                        indent,
                        EXTRACT_BE_U_4(obj_tptr),
-                       EXTRACT_BE_U_4(obj_tptr + 4)));
+                       EXTRACT_BE_U_4(obj_tptr + 4));
                 obj_tlen-=8;
                 obj_tptr+=8;
                 break;
@@ -1183,17 +1181,17 @@ rsvp_obj_print(netdissect_options *ndo,
                 namelen = EXTRACT_U_1(obj_tptr + 3);
                 if (obj_tlen < 4+namelen)
                     return-1;
-                ND_PRINT((ndo, "%s  Session Name: ", indent));
+                ND_PRINT("%s  Session Name: ", indent);
                 for (i = 0; i < namelen; i++)
-                    safeputchar(ndo, EXTRACT_U_1(obj_tptr + 4 + i));
-                ND_PRINT((ndo, "%s  Setup Priority: %u, Holding Priority: %u, Flags: [%s] (%#x)",
+                    fn_print_char(ndo, EXTRACT_U_1(obj_tptr + 4 + i));
+                ND_PRINT("%s  Setup Priority: %u, Holding Priority: %u, Flags: [%s] (%#x)",
                        indent,
                        EXTRACT_U_1(obj_tptr),
                        EXTRACT_U_1(obj_tptr + 1),
                        bittok2str(rsvp_session_attribute_flag_values,
                                   "none",
                                   EXTRACT_U_1((obj_tptr + 2))),
-                       EXTRACT_U_1(obj_tptr + 2)));
+                       EXTRACT_U_1(obj_tptr + 2));
                 obj_tlen-=4+namelen;
                 obj_tptr+=4+namelen;
                 break;
@@ -1229,12 +1227,12 @@ rsvp_obj_print(netdissect_options *ndo,
                     subobj_type = (EXTRACT_BE_U_2(obj_tptr + 2))>>8;
                     af = (EXTRACT_BE_U_2(obj_tptr + 2))&0x00FF;
 
-                    ND_PRINT((ndo, "%s  Subobject Type: %s (%u), AF: %s (%u), length: %u",
+                    ND_PRINT("%s  Subobject Type: %s (%u), AF: %s (%u), length: %u",
                            indent,
                            tok2str(rsvp_obj_generalized_uni_values, "Unknown", subobj_type),
                            subobj_type,
                            tok2str(af_values, "Unknown", af), af,
-                           subobj_len));
+                           subobj_len);
 
                     /* In addition to what is explained above, the same spec does not
                      * explicitly say that the same Length field includes the 4-octet
@@ -1274,14 +1272,14 @@ rsvp_obj_print(netdissect_options *ndo,
                         case AFNUM_INET:
                             if (subobj_len < 8)
                                 return -1;
-                            ND_PRINT((ndo, "%s    UNI IPv4 TNA address: %s",
-                                   indent, ipaddr_string(ndo, obj_tptr + 4)));
+                            ND_PRINT("%s    UNI IPv4 TNA address: %s",
+                                   indent, ipaddr_string(ndo, obj_tptr + 4));
                             break;
                         case AFNUM_INET6:
                             if (subobj_len < 20)
                                 return -1;
-                            ND_PRINT((ndo, "%s    UNI IPv6 TNA address: %s",
-                                   indent, ip6addr_string(ndo, obj_tptr + 4)));
+                            ND_PRINT("%s    UNI IPv6 TNA address: %s",
+                                   indent, ip6addr_string(ndo, obj_tptr + 4));
                             break;
                         case AFNUM_NSAP:
                             if (subobj_len) {
@@ -1304,12 +1302,12 @@ rsvp_obj_print(netdissect_options *ndo,
                             return -1;
                         }
 
-                        ND_PRINT((ndo, "%s    U-bit: %x, Label type: %u, Logical port id: %u, Label: %u",
+                        ND_PRINT("%s    U-bit: %x, Label type: %u, Logical port id: %u, Label: %u",
                                indent,
                                ((EXTRACT_BE_U_4(obj_tptr + 4))>>31),
                                ((EXTRACT_BE_U_4(obj_tptr + 4))&0xFF),
                                EXTRACT_BE_U_4(obj_tptr + 8),
-                               EXTRACT_BE_U_4(obj_tptr + 12)));
+                               EXTRACT_BE_U_4(obj_tptr + 12));
                         break;
 
                     case RSVP_GEN_UNI_SUBOBJ_SERVICE_LEVEL:
@@ -1317,8 +1315,8 @@ rsvp_obj_print(netdissect_options *ndo,
                             return -1;
                         }
 
-                        ND_PRINT((ndo, "%s    Service level: %u",
-                               indent, (EXTRACT_BE_U_4(obj_tptr + 4)) >> 24));
+                        ND_PRINT("%s    Service level: %u",
+                               indent, (EXTRACT_BE_U_4(obj_tptr + 4)) >> 24);
                         break;
 
                     default:
@@ -1329,11 +1327,6 @@ rsvp_obj_print(netdissect_options *ndo,
                     obj_tptr+=subobj_len;
                     obj_tlen+=subobj_len;
                }
-
-                if (total_subobj_len) {
-                    /* unless we have a TLV parser lets just hexdump */
-                    hexdump=TRUE;
-                }
                 break;
 
             default:
@@ -1347,10 +1340,10 @@ rsvp_obj_print(netdissect_options *ndo,
             case RSVP_CTYPE_IPV4:
                 if (obj_tlen < 8)
                     return-1;
-                ND_PRINT((ndo, "%s  Previous/Next Interface: %s, Logical Interface Handle: 0x%08x",
+                ND_PRINT("%s  Previous/Next Interface: %s, Logical Interface Handle: 0x%08x",
                        indent,
                        ipaddr_string(ndo, obj_tptr),
-                       EXTRACT_BE_U_4(obj_tptr + 4)));
+                       EXTRACT_BE_U_4(obj_tptr + 4));
                 obj_tlen-=8;
                 obj_tptr+=8;
                 if (obj_tlen)
@@ -1360,10 +1353,10 @@ rsvp_obj_print(netdissect_options *ndo,
             case RSVP_CTYPE_IPV6:
                 if (obj_tlen < 20)
                     return-1;
-                ND_PRINT((ndo, "%s  Previous/Next Interface: %s, Logical Interface Handle: 0x%08x",
+                ND_PRINT("%s  Previous/Next Interface: %s, Logical Interface Handle: 0x%08x",
                        indent,
                        ip6addr_string(ndo, obj_tptr),
-                       EXTRACT_BE_U_4(obj_tptr + 16)));
+                       EXTRACT_BE_U_4(obj_tptr + 16));
                 obj_tlen-=20;
                 obj_tptr+=20;
                 hexdump=TRUE; /* unless we have a TLV parser lets just hexdump */
@@ -1378,9 +1371,9 @@ rsvp_obj_print(netdissect_options *ndo,
             case RSVP_CTYPE_1:
                 if (obj_tlen < 4)
                     return-1;
-                ND_PRINT((ndo, "%s  Refresh Period: %ums",
+                ND_PRINT("%s  Refresh Period: %ums",
                        indent,
-                       EXTRACT_BE_U_4(obj_tptr)));
+                       EXTRACT_BE_U_4(obj_tptr));
                 obj_tlen-=4;
                 obj_tptr+=4;
                 break;
@@ -1397,21 +1390,21 @@ rsvp_obj_print(netdissect_options *ndo,
             case RSVP_CTYPE_2:
                 if (obj_tlen < 4)
                     return-1;
-                ND_PRINT((ndo, "%s  Msg-Version: %u, length: %u",
+                ND_PRINT("%s  Msg-Version: %u, length: %u",
                        indent,
                        (EXTRACT_U_1(obj_tptr) & 0xf0) >> 4,
-                       EXTRACT_BE_U_2(obj_tptr + 2) << 2));
+                       EXTRACT_BE_U_2(obj_tptr + 2) << 2);
                 obj_tptr+=4; /* get to the start of the service header */
                 obj_tlen-=4;
 
                 while (obj_tlen >= 4) {
                     intserv_serv_tlen=EXTRACT_BE_U_2(obj_tptr + 2)<<2;
-                    ND_PRINT((ndo, "%s  Service Type: %s (%u), break bit %sset, Service length: %u",
+                    ND_PRINT("%s  Service Type: %s (%u), break bit %sset, Service length: %u",
                            indent,
                            tok2str(rsvp_intserv_service_type_values,"unknown",EXTRACT_U_1((obj_tptr))),
                            EXTRACT_U_1(obj_tptr),
                            (EXTRACT_U_1(obj_tptr + 1)&0x80) ? "" : "not ",
-                           intserv_serv_tlen));
+                           intserv_serv_tlen);
 
                     obj_tptr+=4; /* get to the start of the parameter list */
                     obj_tlen-=4;
@@ -1436,78 +1429,78 @@ rsvp_obj_print(netdissect_options *ndo,
             case RSVP_CTYPE_IPV4:
                 if (obj_tlen < 8)
                     return-1;
-                ND_PRINT((ndo, "%s  Source Address: %s, Source Port: %u",
+                ND_PRINT("%s  Source Address: %s, Source Port: %u",
                        indent,
                        ipaddr_string(ndo, obj_tptr),
-                       EXTRACT_BE_U_2(obj_tptr + 6)));
+                       EXTRACT_BE_U_2(obj_tptr + 6));
                 obj_tlen-=8;
                 obj_tptr+=8;
                 break;
             case RSVP_CTYPE_IPV6:
                 if (obj_tlen < 20)
                     return-1;
-                ND_PRINT((ndo, "%s  Source Address: %s, Source Port: %u",
+                ND_PRINT("%s  Source Address: %s, Source Port: %u",
                        indent,
                        ip6addr_string(ndo, obj_tptr),
-                       EXTRACT_BE_U_2(obj_tptr + 18)));
+                       EXTRACT_BE_U_2(obj_tptr + 18));
                 obj_tlen-=20;
                 obj_tptr+=20;
                 break;
             case RSVP_CTYPE_3:
                 if (obj_tlen < 20)
                     return-1;
-                ND_PRINT((ndo, "%s  Source Address: %s, Flow Label: %u",
+                ND_PRINT("%s  Source Address: %s, Flow Label: %u",
                        indent,
                        ip6addr_string(ndo, obj_tptr),
-                       EXTRACT_BE_U_3(obj_tptr + 17)));
+                       EXTRACT_BE_U_3(obj_tptr + 17));
                 obj_tlen-=20;
                 obj_tptr+=20;
                 break;
             case RSVP_CTYPE_TUNNEL_IPV6:
                 if (obj_tlen < 20)
                     return-1;
-                ND_PRINT((ndo, "%s  Source Address: %s, LSP-ID: 0x%04x",
+                ND_PRINT("%s  Source Address: %s, LSP-ID: 0x%04x",
                        indent,
                        ipaddr_string(ndo, obj_tptr),
-                       EXTRACT_BE_U_2(obj_tptr + 18)));
+                       EXTRACT_BE_U_2(obj_tptr + 18));
                 obj_tlen-=20;
                 obj_tptr+=20;
                 break;
             case RSVP_CTYPE_13: /* IPv6 p2mp LSP tunnel */
                 if (obj_tlen < 40)
                     return-1;
-                ND_PRINT((ndo, "%s  IPv6 Tunnel Sender Address: %s, LSP ID: 0x%04x"
+                ND_PRINT("%s  IPv6 Tunnel Sender Address: %s, LSP ID: 0x%04x"
                        "%s  Sub-Group Originator ID: %s, Sub-Group ID: 0x%04x",
                        indent,
                        ip6addr_string(ndo, obj_tptr),
                        EXTRACT_BE_U_2(obj_tptr + 18),
                        indent,
                        ip6addr_string(ndo, obj_tptr+20),
-                       EXTRACT_BE_U_2(obj_tptr + 38)));
+                       EXTRACT_BE_U_2(obj_tptr + 38));
                 obj_tlen-=40;
                 obj_tptr+=40;
                 break;
             case RSVP_CTYPE_TUNNEL_IPV4:
                 if (obj_tlen < 8)
                     return-1;
-                ND_PRINT((ndo, "%s  Source Address: %s, LSP-ID: 0x%04x",
+                ND_PRINT("%s  Source Address: %s, LSP-ID: 0x%04x",
                        indent,
                        ipaddr_string(ndo, obj_tptr),
-                       EXTRACT_BE_U_2(obj_tptr + 6)));
+                       EXTRACT_BE_U_2(obj_tptr + 6));
                 obj_tlen-=8;
                 obj_tptr+=8;
                 break;
             case RSVP_CTYPE_12: /* IPv4 p2mp LSP tunnel */
                 if (obj_tlen < 16)
                     return-1;
-                ND_PRINT((ndo, "%s  IPv4 Tunnel Sender Address: %s, LSP ID: 0x%04x"
+                ND_PRINT("%s  IPv4 Tunnel Sender Address: %s, LSP ID: 0x%04x"
                        "%s  Sub-Group Originator ID: %s, Sub-Group ID: 0x%04x",
                        indent,
                        ipaddr_string(ndo, obj_tptr),
                        EXTRACT_BE_U_2(obj_tptr + 6),
                        indent,
                        ipaddr_string(ndo, obj_tptr+8),
-                       EXTRACT_BE_U_2(obj_tptr + 12)));
+                       EXTRACT_BE_U_2(obj_tptr + 12));
                 obj_tlen-=16;
                 obj_tptr+=16;
                 break;
@@ -1525,17 +1518,17 @@ rsvp_obj_print(netdissect_options *ndo,
                 if (obj_tlen < sizeof(struct rsvp_obj_frr_t))
                     return-1;
                 bw.i = EXTRACT_BE_U_4(obj_ptr.rsvp_obj_frr->bandwidth);
-                ND_PRINT((ndo, "%s  Setup Priority: %u, Holding Priority: %u, Hop-limit: %u, Bandwidth: %.10g Mbps",
+                ND_PRINT("%s  Setup Priority: %u, Holding Priority: %u, Hop-limit: %u, Bandwidth: %.10g Mbps",
                        indent,
                        obj_ptr.rsvp_obj_frr->setup_prio,
                        obj_ptr.rsvp_obj_frr->hold_prio,
                        obj_ptr.rsvp_obj_frr->hop_limit,
-                       bw.f * 8 / 1000000));
-                ND_PRINT((ndo, "%s  Include-any: 0x%08x, Exclude-any: 0x%08x, Include-all: 0x%08x",
+                       bw.f * 8 / 1000000);
+                ND_PRINT("%s  Include-any: 0x%08x, Exclude-any: 0x%08x, Include-all: 0x%08x",
                        indent,
                        EXTRACT_BE_U_4(obj_ptr.rsvp_obj_frr->include_any),
                        EXTRACT_BE_U_4(obj_ptr.rsvp_obj_frr->exclude_any),
-                       EXTRACT_BE_U_4(obj_ptr.rsvp_obj_frr->include_all)));
+                       EXTRACT_BE_U_4(obj_ptr.rsvp_obj_frr->include_all));
                 obj_tlen-=sizeof(struct rsvp_obj_frr_t);
                 obj_tptr+=sizeof(struct rsvp_obj_frr_t);
                 break;
@@ -1544,16 +1537,16 @@ rsvp_obj_print(netdissect_options *ndo,
                 if (obj_tlen < 16)
                     return-1;
                 bw.i = EXTRACT_BE_U_4(obj_ptr.rsvp_obj_frr->bandwidth);
-                ND_PRINT((ndo, "%s  Setup Priority: %u, Holding Priority: %u, Hop-limit: %u, Bandwidth: %.10g Mbps",
+                ND_PRINT("%s  Setup Priority: %u, Holding Priority: %u, Hop-limit: %u, Bandwidth: %.10g Mbps",
                        indent,
                        obj_ptr.rsvp_obj_frr->setup_prio,
                        obj_ptr.rsvp_obj_frr->hold_prio,
                        obj_ptr.rsvp_obj_frr->hop_limit,
-                       bw.f * 8 / 1000000));
-                ND_PRINT((ndo, "%s  Include Colors: 0x%08x, Exclude Colors: 0x%08x",
+                       bw.f * 8 / 1000000);
+                ND_PRINT("%s  Include Colors: 0x%08x, Exclude Colors: 0x%08x",
                        indent,
                        EXTRACT_BE_U_4(obj_ptr.rsvp_obj_frr->include_any),
-                       EXTRACT_BE_U_4(obj_ptr.rsvp_obj_frr->exclude_any)));
+                       EXTRACT_BE_U_4(obj_ptr.rsvp_obj_frr->exclude_any));
                 obj_tlen-=16;
                 obj_tptr+=16;
                 break;
@@ -1567,10 +1560,10 @@ rsvp_obj_print(netdissect_options *ndo,
             switch(rsvp_obj_ctype) {
             case RSVP_CTYPE_TUNNEL_IPV4:
                 while(obj_tlen >= 8) {
-                    ND_PRINT((ndo, "%s  PLR-ID: %s, Avoid-Node-ID: %s",
+                    ND_PRINT("%s  PLR-ID: %s, Avoid-Node-ID: %s",
                            indent,
                            ipaddr_string(ndo, obj_tptr),
-                           ipaddr_string(ndo, obj_tptr + 4)));
+                           ipaddr_string(ndo, obj_tptr + 4));
                     obj_tlen-=8;
                     obj_tptr+=8;
                 }
@@ -1584,9 +1577,9 @@ rsvp_obj_print(netdissect_options *ndo,
         case RSVP_OBJ_CLASSTYPE_OLD: /* fall through */
             switch(rsvp_obj_ctype) {
             case RSVP_CTYPE_1:
-                ND_PRINT((ndo, "%s  CT: %u",
+                ND_PRINT("%s  CT: %u",
                        indent,
-                       EXTRACT_BE_U_4(obj_tptr) & 0x7));
+                       EXTRACT_BE_U_4(obj_tptr) & 0x7);
                 obj_tlen-=4;
                 obj_tptr+=4;
                 break;
@@ -1603,27 +1596,27 @@ rsvp_obj_print(netdissect_options *ndo,
                     return-1;
                 error_code=EXTRACT_U_1(obj_tptr + 5);
                 error_value=EXTRACT_BE_U_2(obj_tptr + 6);
-                ND_PRINT((ndo, "%s  Error Node Address: %s, Flags: [0x%02x]%s  Error Code: %s (%u)",
+                ND_PRINT("%s  Error Node Address: %s, Flags: [0x%02x]%s  Error Code: %s (%u)",
                        indent,
                        ipaddr_string(ndo, obj_tptr),
                        EXTRACT_U_1(obj_tptr + 4),
                        indent,
                        tok2str(rsvp_obj_error_code_values,"unknown",error_code),
-                       error_code));
+                       error_code);
                 switch (error_code) {
                 case RSVP_OBJ_ERROR_SPEC_CODE_ROUTING:
-                    ND_PRINT((ndo, ", Error Value: %s (%u)",
+                    ND_PRINT(", Error Value: %s (%u)",
                            tok2str(rsvp_obj_error_code_routing_values,"unknown",error_value),
-                           error_value));
+                           error_value);
                     break;
                 case RSVP_OBJ_ERROR_SPEC_CODE_DIFFSERV_TE: /* fall through */
                 case RSVP_OBJ_ERROR_SPEC_CODE_DIFFSERV_TE_OLD:
-                    ND_PRINT((ndo, ", Error Value: %s (%u)",
+                    ND_PRINT(", Error Value: %s (%u)",
                            tok2str(rsvp_obj_error_code_diffserv_te_values,"unknown",error_value),
-                           error_value));
+                           error_value);
                     break;
                 default:
-                    ND_PRINT((ndo, ", Unknown Error Value (%u)", error_value));
+                    ND_PRINT(", Unknown Error Value (%u)", error_value);
                     break;
                 }
                 obj_tlen-=8;
@@ -1635,19 +1628,19 @@ rsvp_obj_print(netdissect_options *ndo,
                     return-1;
                 error_code=EXTRACT_U_1(obj_tptr + 17);
                 error_value=EXTRACT_BE_U_2(obj_tptr + 18);
-                ND_PRINT((ndo, "%s  Error Node Address: %s, Flags: [0x%02x]%s  Error Code: %s (%u)",
+                ND_PRINT("%s  Error Node Address: %s, Flags: [0x%02x]%s  Error Code: %s (%u)",
                        indent,
                        ip6addr_string(ndo, obj_tptr),
                        EXTRACT_U_1(obj_tptr + 16),
                        indent,
                        tok2str(rsvp_obj_error_code_values,"unknown",error_code),
-                       error_code));
+                       error_code);
 
                 switch (error_code) {
                 case RSVP_OBJ_ERROR_SPEC_CODE_ROUTING:
-                    ND_PRINT((ndo, ", Error Value: %s (%u)",
+                    ND_PRINT(", Error Value: %s (%u)",
                            tok2str(rsvp_obj_error_code_routing_values,"unknown",error_value),
-                          error_value));
+                          error_value);
                     break;
                 default:
                     break;
@@ -1666,19 +1659,19 @@ rsvp_obj_print(netdissect_options *ndo,
                 if (obj_tlen < 4)
                     return-1;
                 padbytes = EXTRACT_BE_U_2(obj_tptr + 2);
-                ND_PRINT((ndo, "%s  TLV count: %u, padding bytes: %u",
+                ND_PRINT("%s  TLV count: %u, padding bytes: %u",
                        indent,
                        EXTRACT_BE_U_2(obj_tptr),
-                       padbytes));
+                       padbytes);
                 obj_tlen-=4;
                 obj_tptr+=4;
                 /* loop through as long there is anything longer than the TLV header (2) */
                 while(obj_tlen >= 2 + padbytes) {
-                    ND_PRINT((ndo, "%s    %s TLV (0x%02x), length: %u", /* length includes header */
+                    ND_PRINT("%s    %s TLV (0x%02x), length: %u", /* length includes header */
                            indent,
                            tok2str(rsvp_obj_prop_tlv_values,"unknown",EXTRACT_U_1(obj_tptr)),
                            EXTRACT_U_1(obj_tptr),
-                           EXTRACT_U_1(obj_tptr + 1)));
+                           EXTRACT_U_1(obj_tptr + 1));
                     if (obj_tlen < EXTRACT_U_1(obj_tptr + 1))
                         return-1;
                     if (EXTRACT_U_1(obj_tptr + 1) < 2)
@@ -1702,18 +1695,18 @@ rsvp_obj_print(netdissect_options *ndo,
             case RSVP_CTYPE_2:
                 if (obj_tlen < 8)
                     return-1;
-                ND_PRINT((ndo, "%s  Flags [0x%02x], epoch: %u",
+                ND_PRINT("%s  Flags [0x%02x], epoch: %u",
                        indent,
                        EXTRACT_U_1(obj_tptr),
-                       EXTRACT_BE_U_3(obj_tptr + 1)));
+                       EXTRACT_BE_U_3(obj_tptr + 1));
                 obj_tlen-=4;
                 obj_tptr+=4;
                 /* loop through as long there are no messages left */
                 while(obj_tlen >= 4) {
-                    ND_PRINT((ndo, "%s    Message-ID 0x%08x (%u)",
+                    ND_PRINT("%s    Message-ID 0x%08x (%u)",
                            indent,
                            EXTRACT_BE_U_4(obj_tptr),
-                           EXTRACT_BE_U_4(obj_tptr)));
+                           EXTRACT_BE_U_4(obj_tptr));
                     obj_tlen-=4;
                     obj_tptr+=4;
                 }
@@ -1729,7 +1722,7 @@ rsvp_obj_print(netdissect_options *ndo,
                 if (obj_tlen < sizeof(struct rsvp_obj_integrity_t))
                     return-1;
                 obj_ptr.rsvp_obj_integrity = (const struct rsvp_obj_integrity_t *)obj_tptr;
-                ND_PRINT((ndo, "%s  Key-ID 0x%04x%08x, Sequence 0x%08x%08x, Flags [%s]",
+                ND_PRINT("%s  Key-ID 0x%04x%08x, Sequence 0x%08x%08x, Flags [%s]",
                        indent,
                        EXTRACT_BE_U_2(obj_ptr.rsvp_obj_integrity->key_id),
                        EXTRACT_BE_U_4(obj_ptr.rsvp_obj_integrity->key_id + 2),
@@ -1737,19 +1730,19 @@ rsvp_obj_print(netdissect_options *ndo,
                        EXTRACT_BE_U_4(obj_ptr.rsvp_obj_integrity->sequence + 4),
                        bittok2str(rsvp_obj_integrity_flag_values,
                                   "none",
-                                  obj_ptr.rsvp_obj_integrity->flags)));
-                ND_PRINT((ndo, "%s  MD5-sum 0x%08x%08x%08x%08x ",
+                                  obj_ptr.rsvp_obj_integrity->flags));
+                ND_PRINT("%s  MD5-sum 0x%08x%08x%08x%08x ",
                        indent,
                        EXTRACT_BE_U_4(obj_ptr.rsvp_obj_integrity->digest),
                        EXTRACT_BE_U_4(obj_ptr.rsvp_obj_integrity->digest + 4),
                        EXTRACT_BE_U_4(obj_ptr.rsvp_obj_integrity->digest + 8),
-                       EXTRACT_BE_U_4(obj_ptr.rsvp_obj_integrity->digest + 12)));
+                       EXTRACT_BE_U_4(obj_ptr.rsvp_obj_integrity->digest + 12));
 
                 sigcheck = signature_verify(ndo, pptr, plen,
                                             obj_ptr.rsvp_obj_integrity->digest,
                                             rsvp_clear_checksum,
                                             rsvp_com_header);
-                ND_PRINT((ndo, " (%s)", tok2str(signature_check_values, "Unknown", sigcheck)));
+                ND_PRINT(" (%s)", tok2str(signature_check_values, "Unknown", sigcheck));
 
                 obj_tlen+=sizeof(struct rsvp_obj_integrity_t);
                 obj_tptr+=sizeof(struct rsvp_obj_integrity_t);
@@ -1764,9 +1757,9 @@ rsvp_obj_print(netdissect_options *ndo,
             case RSVP_CTYPE_1:
                 if (obj_tlen < 4)
                     return-1;
-                ND_PRINT((ndo, "%s  Flags [%s]", indent,
+                ND_PRINT("%s  Flags [%s]", indent,
                        bittok2str(rsvp_obj_admin_status_flag_values, "none",
-                                  EXTRACT_BE_U_4(obj_tptr))));
+                                  EXTRACT_BE_U_4(obj_tptr)));
                 obj_tlen-=4;
                 obj_tptr+=4;
                 break;
@@ -1782,9 +1775,9 @@ rsvp_obj_print(netdissect_options *ndo,
                     return-1;
                 action = (EXTRACT_BE_U_2(obj_tptr)>>8);
 
-                ND_PRINT((ndo, "%s  Action: %s (%u), Label type: %u", indent,
+                ND_PRINT("%s  Action: %s (%u), Label type: %u", indent,
                        tok2str(rsvp_obj_label_set_action_values, "Unknown", action),
-                       action, ((EXTRACT_BE_U_4(obj_tptr) & 0x7F))));
+                       action, (EXTRACT_BE_U_4(obj_tptr) & 0x7F));
 
                 switch (action) {
                 case LABEL_SET_INCLUSIVE_RANGE:
@@ -1793,9 +1786,9 @@ rsvp_obj_print(netdissect_options *ndo,
                    /* only a couple of subchannels are expected */
                    if (obj_tlen < 12)
                        return -1;
-                   ND_PRINT((ndo, "%s  Start range: %u, End range: %u", indent,
+                   ND_PRINT("%s  Start range: %u, End range: %u", indent,
                            EXTRACT_BE_U_4(obj_tptr + 4),
-                           EXTRACT_BE_U_4(obj_tptr + 8)));
+                           EXTRACT_BE_U_4(obj_tptr + 8));
                    obj_tlen-=12;
                    obj_tptr+=12;
                     break;
@@ -1805,8 +1798,8 @@ rsvp_obj_print(netdissect_options *ndo,
                     obj_tptr+=4;
                     subchannel = 1;
                     while(obj_tlen >= 4 ) {
-                        ND_PRINT((ndo, "%s  Subchannel #%u: %u", indent, subchannel,
-                               EXTRACT_BE_U_4(obj_tptr)));
+                        ND_PRINT("%s  Subchannel #%u: %u", indent, subchannel,
+                               EXTRACT_BE_U_4(obj_tptr));
                         obj_tptr+=4;
                         obj_tlen-=4;
                         subchannel++;
@@ -1824,8 +1817,8 @@ rsvp_obj_print(netdissect_options *ndo,
             case RSVP_CTYPE_IPV4:
                 if (obj_tlen < 4)
                     return-1;
-                ND_PRINT((ndo, "%s  Sub-LSP destination address: %s",
-                       indent, ipaddr_string(ndo, obj_tptr)));
+                ND_PRINT("%s  Sub-LSP destination address: %s",
+                       indent, ipaddr_string(ndo, obj_tptr));
 
                 obj_tlen-=4;
                 obj_tptr+=4;
@@ -1833,8 +1826,8 @@ rsvp_obj_print(netdissect_options *ndo,
             case RSVP_CTYPE_IPV6:
                 if (obj_tlen < 16)
                     return-1;
-                ND_PRINT((ndo, "%s  Sub-LSP destination address: %s",
-                       indent, ip6addr_string(ndo, obj_tptr)));
+                ND_PRINT("%s  Sub-LSP destination address: %s",
+                       indent, ip6addr_string(ndo, obj_tptr));
 
                 obj_tlen-=16;
                 obj_tptr+=16;
@@ -1868,11 +1861,10 @@ rsvp_obj_print(netdissect_options *ndo,
     }
     return 0;
 invalid:
-    ND_PRINT((ndo, "%s", istr));
+    nd_print_invalid(ndo);
     return -1;
 trunc:
-    ND_PRINT((ndo, "\n\t\t"));
-    ND_PRINT((ndo, "%s", tstr));
+    nd_print_trunc(ndo);
     return -1;
 }
 
@@ -1885,18 +1877,19 @@ rsvp_print(netdissect_options *ndo,
     const u_char *tptr;
     u_short plen, tlen;
 
+    ndo->ndo_protocol = "rsvp";
     tptr=pptr;
 
     rsvp_com_header = (const struct rsvp_common_header *)pptr;
-    ND_TCHECK(*rsvp_com_header);
+    ND_TCHECK_SIZE(rsvp_com_header);
     version_flags = EXTRACT_U_1(rsvp_com_header->version_flags);
 
     /*
      * Sanity checking of the header.
      */
     if (RSVP_EXTRACT_VERSION(version_flags) != RSVP_VERSION) {
-       ND_PRINT((ndo, "ERROR: RSVP version %u packet not supported",
-               RSVP_EXTRACT_VERSION(version_flags)));
+       ND_PRINT("ERROR: RSVP version %u packet not supported",
+               RSVP_EXTRACT_VERSION(version_flags));
        return;
     }
 
@@ -1904,10 +1897,10 @@ rsvp_print(netdissect_options *ndo,
 
     /* in non-verbose mode just lets print the basic Message Type*/
     if (ndo->ndo_vflag < 1) {
-        ND_PRINT((ndo, "RSVPv%u %s Message, length: %u",
+        ND_PRINT("RSVPv%u %s Message, length: %u",
                RSVP_EXTRACT_VERSION(version_flags),
                tok2str(rsvp_msg_type_values, "unknown (%u)",msg_type),
-               len));
+               len);
         return;
     }
 
@@ -1915,18 +1908,18 @@ rsvp_print(netdissect_options *ndo,
 
     plen = tlen = EXTRACT_BE_U_2(rsvp_com_header->length);
 
-    ND_PRINT((ndo, "\n\tRSVPv%u %s Message (%u), Flags: [%s], length: %u, ttl: %u, checksum: 0x%04x",
+    ND_PRINT("\n\tRSVPv%u %s Message (%u), Flags: [%s], length: %u, ttl: %u, checksum: 0x%04x",
            RSVP_EXTRACT_VERSION(version_flags),
            tok2str(rsvp_msg_type_values, "unknown, type: %u",msg_type),
            msg_type,
            bittok2str(rsvp_header_flag_values,"none",RSVP_EXTRACT_FLAGS(version_flags)),
            tlen,
            EXTRACT_U_1(rsvp_com_header->ttl),
-           EXTRACT_BE_U_2(rsvp_com_header->checksum)));
+           EXTRACT_BE_U_2(rsvp_com_header->checksum));
 
     if (tlen < sizeof(struct rsvp_common_header)) {
-        ND_PRINT((ndo, "ERROR: common header too short %u < %lu", tlen,
-               (unsigned long)sizeof(struct rsvp_common_header)));
+        ND_PRINT("ERROR: common header too short %u < %lu", tlen,
+               (unsigned long)sizeof(struct rsvp_common_header));
         return;
     }
 
@@ -1948,39 +1941,39 @@ rsvp_print(netdissect_options *ndo,
             subtptr=subpptr;
 
             rsvp_com_header = (const struct rsvp_common_header *)subpptr;
-            ND_TCHECK(*rsvp_com_header);
+            ND_TCHECK_SIZE(rsvp_com_header);
             version_flags = EXTRACT_U_1(rsvp_com_header->version_flags);
 
             /*
              * Sanity checking of the header.
              */
             if (RSVP_EXTRACT_VERSION(version_flags) != RSVP_VERSION) {
-                ND_PRINT((ndo, "ERROR: RSVP version %u packet not supported",
-                       RSVP_EXTRACT_VERSION(version_flags)));
+                ND_PRINT("ERROR: RSVP version %u packet not supported",
+                       RSVP_EXTRACT_VERSION(version_flags));
                 return;
             }
 
             subplen = subtlen = EXTRACT_BE_U_2(rsvp_com_header->length);
 
             msg_type = EXTRACT_U_1(rsvp_com_header->msg_type);
-            ND_PRINT((ndo, "\n\t  RSVPv%u %s Message (%u), Flags: [%s], length: %u, ttl: %u, checksum: 0x%04x",
+            ND_PRINT("\n\t  RSVPv%u %s Message (%u), Flags: [%s], length: %u, ttl: %u, checksum: 0x%04x",
                    RSVP_EXTRACT_VERSION(version_flags),
                    tok2str(rsvp_msg_type_values, "unknown, type: %u",msg_type),
                    msg_type,
                    bittok2str(rsvp_header_flag_values,"none",RSVP_EXTRACT_FLAGS(version_flags)),
                    subtlen,
                    EXTRACT_U_1(rsvp_com_header->ttl),
-                   EXTRACT_BE_U_2(rsvp_com_header->checksum)));
+                   EXTRACT_BE_U_2(rsvp_com_header->checksum));
 
             if (subtlen < sizeof(struct rsvp_common_header)) {
-                ND_PRINT((ndo, "ERROR: common header too short %u < %lu", subtlen,
-                       (unsigned long)sizeof(struct rsvp_common_header)));
+                ND_PRINT("ERROR: common header too short %u < %lu", subtlen,
+                       (unsigned long)sizeof(struct rsvp_common_header));
                 return;
             }
 
             if (tlen < subtlen) {
-                ND_PRINT((ndo, "ERROR: common header too large %u > %u", subtlen,
-                       tlen));
+                ND_PRINT("ERROR: common header too large %u > %u", subtlen,
+                       tlen);
                 return;
             }
 
@@ -2024,6 +2017,5 @@ rsvp_print(netdissect_options *ndo,
 
     return;
 trunc:
-    ND_PRINT((ndo, "\n\t\t"));
-    ND_PRINT((ndo, "%s", tstr));
+    nd_print_trunc(ndo);
 }