Fix a bunch of de-constifications.

[tcpdump] / print-vjc.c

diff --git a/print-vjc.c b/print-vjc.c
index 24f8a122c09b92a2b4cf82f5fae8f75037d3bc95..65aa8e6abb8f757812ccbc91592d28179c00346e 100644 (file)
--- a/print-vjc.c
+++ b/print-vjc.c
@@ -19,7 +19,6 @@
  * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE.
  */
 
-#define NETDISSECT_REWORKED
 #ifdef HAVE_CONFIG_H
 #include "config.h"
 #endif
@@ -71,6 +70,13 @@
  * We therefore leave "proto" - which is the PPP protocol type - in place,
  * *not* marked as unused, for now, so that GCC warnings about the
  * unused argument remind us that we should fix this some day.
+ *
+ * XXX - also, it fetches the TCP checksum field in COMPRESSED_TCP
+ * packets directly, rather than with EXTRACT_16BITS(); RFC 1144 says
+ * it's "the unmodified TCP checksum", which would imply that it's
+ * big-endian, but perhaps, on the platform where this was developed,
+ * the packets were munged by the networking stack before being handed
+ * to the packet capture mechanism.
  */
 int
 vjc_print(netdissect_options *ndo, register const char *bp, u_short proto _U_)
@@ -96,7 +102,7 @@ vjc_print(netdissect_options *ndo, register const char *bp, u_short proto _U_)
                if (bp[1])
                        ND_PRINT((ndo, " "));
                ND_PRINT((ndo, "C=0x%02x ", bp[2]));
-               ND_PRINT((ndo, "sum=0x%04x ", *(u_short *)&bp[3]));
+               ND_PRINT((ndo, "sum=0x%04x ", *(const u_short *)&bp[3]));
                return -1;
        case TYPE_ERROR:
                if (ndo->ndo_eflag)