]> The Tcpdump Group git mirrors - tcpdump/blobdiff - print-domain.c
projects / tcpdump / blobdiff
summary | shortlog | log | commit | commitdiff | tree
raw | inline | side by side
Use more the EXTRACT_U_1() macro (40/n)
[tcpdump] / print-domain.c
diff --git a/print-domain.c b/print-domain.c
index 64924af909f3cbaa32af7c7ac74997dc3f2e31fd..e150116d84eb8583e346fe08a1757c5dd6e490bf 100644 (file)
--- a/print-domain.c
+++ b/print-domain.c
@@ -19,367 +19,310 @@
  * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE.
  */
 
  * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE.
  */
 
-#ifndef lint
-static const char rcsid[] =
-    "@(#) $Header: /tcpdump/master/tcpdump/print-domain.c,v 1.64 2001-01-02 23:24:51 guy Exp $ (LBL)";
-#endif
+/* \summary: Domain Name System (DNS) printer */
 
 #ifdef HAVE_CONFIG_H
 #include "config.h"
 #endif
 
 
 #ifdef HAVE_CONFIG_H
 #include "config.h"
 #endif
 
-#include <sys/param.h>
-#include <sys/time.h>
-
-#include <netinet/in.h>
+#include <netdissect-stdinc.h>
 
 
-#ifdef NOERROR
-#undef NOERROR                                 /* Solaris sucks */
-#endif
-#ifdef NOERROR
-#undef T_UNSPEC                                        /* SINIX does too */
-#endif
 #include "nameser.h"
 
 #include "nameser.h"
 
-#include <stdio.h>
 #include <string.h>
 
 #include <string.h>
 
-#include "interface.h"
+#include "netdissect.h"
 #include "addrtoname.h"
 #include "addrtoname.h"
-#include "extract.h"                    /* must come after interface.h */
-
-/* Compatibility */
-#ifndef T_TXT
-#define T_TXT          16              /* text strings */
-#endif
-#ifndef T_RP
-#define T_RP           17              /* responsible person */
-#endif
-#ifndef T_AFSDB
-#define T_AFSDB                18              /* AFS cell database */
-#endif
-#ifndef T_X25
-#define T_X25          19              /* X_25 calling address */
-#endif
-#ifndef T_ISDN
-#define T_ISDN         20              /* ISDN calling address */
-#endif
-#ifndef T_RT
-#define T_RT           21              /* router */
-#endif
-#ifndef T_NSAP
-#define T_NSAP         22              /* NSAP address */
-#endif
-#ifndef T_NSAP_PTR
-#define T_NSAP_PTR     23              /* reverse NSAP lookup (deprecated) */
-#endif
-#ifndef T_SIG
-#define T_SIG          24              /* security signature */
-#endif
-#ifndef T_KEY
-#define T_KEY          25              /* security key */
-#endif
-#ifndef T_PX
-#define T_PX           26              /* X.400 mail mapping */
-#endif
-#ifndef T_GPOS
-#define T_GPOS         27              /* geographical position (withdrawn) */
-#endif
-#ifndef T_AAAA
-#define T_AAAA         28              /* IP6 Address */
-#endif
-#ifndef T_LOC
-#define T_LOC          29              /* Location Information */
-#endif
-#ifndef T_NXT
-#define T_NXT          30              /* Next Valid Name in Zone */
-#endif
-#ifndef T_EID
-#define T_EID          31              /* Endpoint identifier */
-#endif
-#ifndef T_NIMLOC
-#define T_NIMLOC       32              /* Nimrod locator */
-#endif
-#ifndef T_SRV
-#define T_SRV          33              /* Server selection */
-#endif
-#ifndef T_ATMA
-#define T_ATMA         34              /* ATM Address */
-#endif
-#ifndef T_NAPTR
-#define T_NAPTR                35              /* Naming Authority PoinTeR */
-#endif
-#ifndef T_A6
-#define T_A6           38              /* IP6 address */
-#endif
-#ifndef T_DNAME
-#define T_DNAME                39              /* non-terminal redirection */
-#endif
-
-#ifndef T_OPT
-#define T_OPT          41              /* EDNS0 option (meta-RR) */
-#endif
-
-#ifndef T_UNSPEC
-#define T_UNSPEC       103             /* Unspecified format (binary data) */
-#endif
-#ifndef T_UNSPECA
-#define T_UNSPECA      104             /* "unspecified ascii". Ugly MIT hack */
-#endif
+#include "addrtostr.h"
+#include "extract.h"
 
 
-#ifndef C_CHAOS
-#define C_CHAOS                3               /* for chaos net (MIT) */
-#endif
-#ifndef C_HS
-#define C_HS           4               /* for Hesiod name server (MIT) (XXX) */
-#endif
-
-static char *ns_ops[] = {
-       "", " inv_q", " stat", " op3", " notify", " op5", " op6", " op7",
-       " op8", " updataA", " updateD", " updateDA",
+static const char *ns_ops[] = {
+       "", " inv_q", " stat", " op3", " notify", " update", " op6", " op7",
+       " op8", " updateA", " updateD", " updateDA",
        " updateM", " updateMA", " zoneInit", " zoneRef",
 };
 
        " updateM", " updateMA", " zoneInit", " zoneRef",
 };
 
-static char *ns_resp[] = {
+static const char *ns_resp[] = {
        "", " FormErr", " ServFail", " NXDomain",
        "", " FormErr", " ServFail", " NXDomain",
-       " NotImp", " Refused", " Resp6", " Resp7",
-       " Resp8", " Resp9", " Resp10", " Resp11",
+       " NotImp", " Refused", " YXDomain", " YXRRSet",
+       " NXRRSet", " NotAuth", " NotZone", " Resp11",
        " Resp12", " Resp13", " Resp14", " NoChange",
 };
 
 /* skip over a domain name */
 static const u_char *
        " Resp12", " Resp13", " Resp14", " NoChange",
 };
 
 /* skip over a domain name */
 static const u_char *
-ns_nskip(register const u_char *cp, register const u_char *bp)
+ns_nskip(netdissect_options *ndo,
+         register const u_char *cp)
 {
        register u_char i;
 
 {
        register u_char i;
 
-       if (((i = *cp++) & INDIR_MASK) == INDIR_MASK)
-               return (cp + 1);
-       if (cp >= snapend)
-               return(NULL);
-       while (i && cp < snapend) {
+       if (!ND_TTEST_1(cp))
+               return (NULL);
+       i = EXTRACT_U_1(cp);
+       cp++;
+       while (i) {
+               if ((i & INDIR_MASK) == INDIR_MASK)
+                       return (cp + 1);
                if ((i & INDIR_MASK) == EDNS0_MASK) {
                        int bitlen, bytelen;
 
                        if ((i & ~INDIR_MASK) != EDNS0_ELT_BITLABEL)
                                return(NULL); /* unknown ELT */
                if ((i & INDIR_MASK) == EDNS0_MASK) {
                        int bitlen, bytelen;
 
                        if ((i & ~INDIR_MASK) != EDNS0_ELT_BITLABEL)
                                return(NULL); /* unknown ELT */
-                       if ((bitlen = *cp++) == 0)
+                       if (!ND_TTEST_1(cp))
+                               return (NULL);
+                       if ((bitlen = EXTRACT_U_1(cp)) == 0)
                                bitlen = 256;
                                bitlen = 256;
+                       cp++;
                        bytelen = (bitlen + 7) / 8;
                        cp += bytelen;
                } else
                        cp += i;
                        bytelen = (bitlen + 7) / 8;
                        cp += bytelen;
                } else
                        cp += i;
-               if (cp >= snapend)
-                       return(NULL);
-               i = *cp++;
+               if (!ND_TTEST_1(cp))
+                       return (NULL);
+               i = EXTRACT_U_1(cp);
+               cp++;
        }
        return (cp);
 }
 
 /* print a <domain-name> */
 static const u_char *
        }
        return (cp);
 }
 
 /* print a <domain-name> */
 static const u_char *
-blabel_print(const u_char *cp)
+blabel_print(netdissect_options *ndo,
+             const u_char *cp)
 {
        int bitlen, slen, b;
 {
        int bitlen, slen, b;
-       int truncated = 0;
        const u_char *bitp, *lim;
        char tc;
 
        const u_char *bitp, *lim;
        char tc;
 
-       if (cp >= snapend)
+       if (!ND_TTEST_1(cp))
                return(NULL);
                return(NULL);
-       if ((bitlen = *cp) == 0)
+       if ((bitlen = EXTRACT_U_1(cp)) == 0)
                bitlen = 256;
        slen = (bitlen + 3) / 4;
                bitlen = 256;
        slen = (bitlen + 3) / 4;
-       if ((lim = cp + 1 + slen) > snapend) {
-               truncated = 1;
-               lim = snapend;
-       }
+       lim = cp + 1 + slen;
 
        /* print the bit string as a hex string */
 
        /* print the bit string as a hex string */
-       printf("\\[x");
-       for (bitp = cp + 1, b = bitlen; bitp < lim && b > 7; b -= 8, bitp++)
-               printf("%02x", *bitp);
-       if (bitp == lim)
-               printf("...");
-       else if (b > 4) {
-               tc = *bitp++;
-               printf("%02x", tc & (0xff << (8 - b)));
+       ND_PRINT((ndo, "\\[x"));
+       for (bitp = cp + 1, b = bitlen; bitp < lim && b > 7; b -= 8, bitp++) {
+               ND_TCHECK(*bitp);
+               ND_PRINT((ndo, "%02x", EXTRACT_U_1(bitp)));
+       }
+       if (b > 4) {
+               ND_TCHECK(*bitp);
+               tc = EXTRACT_U_1(bitp);
+               bitp++;
+               ND_PRINT((ndo, "%02x", tc & (0xff << (8 - b))));
        } else if (b > 0) {
        } else if (b > 0) {
-               tc = *bitp++;
-               printf("%1x", ((tc >> 4) & 0x0f) & (0x0f << (4 - b)));
+               ND_TCHECK(*bitp);
+               tc = EXTRACT_U_1(bitp);
+               bitp++;
+               ND_PRINT((ndo, "%1x", ((tc >> 4) & 0x0f) & (0x0f << (4 - b))));
        }
        }
-       printf("/%d]", bitlen);
-
-       return(truncated ? NULL : lim);
+       ND_PRINT((ndo, "/%d]", bitlen));
+       return lim;
+trunc:
+       ND_PRINT((ndo, ".../%d]", bitlen));
+       return NULL;
 }
 
 static int
 }
 
 static int
-labellen(const u_char *cp)
+labellen(netdissect_options *ndo,
+         const u_char *cp)
 {
        register u_int i;
 
 {
        register u_int i;
 
-       if (cp >= snapend)
+       if (!ND_TTEST_1(cp))
                return(-1);
                return(-1);
-       i = *cp;
+       i = EXTRACT_U_1(cp);
        if ((i & INDIR_MASK) == EDNS0_MASK) {
                int bitlen, elt;
        if ((i & INDIR_MASK) == EDNS0_MASK) {
                int bitlen, elt;
-
-               if ((elt = (i & ~INDIR_MASK)) != EDNS0_ELT_BITLABEL)
+               if ((elt = (i & ~INDIR_MASK)) != EDNS0_ELT_BITLABEL) {
+                       ND_PRINT((ndo, "<ELT %d>", elt));
                        return(-1);
                        return(-1);
-               if (cp + 1 >= snapend)
+               }
+               if (!ND_TTEST_1(cp + 1))
                        return(-1);
                        return(-1);
-               if ((bitlen = *(cp + 1)) == 0)
+               if ((bitlen = EXTRACT_U_1(cp + 1)) == 0)
                        bitlen = 256;
                return(((bitlen + 7) / 8) + 1);
        } else
                return(i);
 }
 
                        bitlen = 256;
                return(((bitlen + 7) / 8) + 1);
        } else
                return(i);
 }
 
-static const u_char *
-ns_nprint(register const u_char *cp, register const u_char *bp)
+const u_char *
+ns_nprint(netdissect_options *ndo,
+          register const u_char *cp, register const u_char *bp)
 {
        register u_int i, l;
        register const u_char *rp = NULL;
        register int compress = 0;
 {
        register u_int i, l;
        register const u_char *rp = NULL;
        register int compress = 0;
-       int chars_processed;
        int elt;
        int elt;
-       int data_size = snapend - bp;
+       u_int offset, max_offset;
 
 
-       if ((l = labellen(cp)) < 0)
+       if ((l = labellen(ndo, cp)) == (u_int)-1)
                return(NULL);
                return(NULL);
-       if (cp >= snapend)
+       if (!ND_TTEST_1(cp))
                return(NULL);
                return(NULL);
-       chars_processed = 1;
-       if (((i = *cp++) & INDIR_MASK) != INDIR_MASK) {
+       max_offset = (u_int)(cp - bp);
+       i = EXTRACT_U_1(cp);
+       cp++;
+       if ((i & INDIR_MASK) != INDIR_MASK) {
                compress = 0;
                rp = cp + l;
        }
 
        if (i != 0)
                compress = 0;
                rp = cp + l;
        }
 
        if (i != 0)
-               while (i && cp < snapend) {
+               while (i && cp < ndo->ndo_snapend) {
                        if ((i & INDIR_MASK) == INDIR_MASK) {
                                if (!compress) {
                                        rp = cp + 1;
                                        compress = 1;
                                }
                        if ((i & INDIR_MASK) == INDIR_MASK) {
                                if (!compress) {
                                        rp = cp + 1;
                                        compress = 1;
                                }
-                               cp = bp + (((i << 8) | *cp) & 0x3fff);
-                               if (cp >= snapend)
-                                       return(NULL);
-                               if ((l = labellen(cp)) < 0)
+                               if (!ND_TTEST_1(cp))
                                        return(NULL);
                                        return(NULL);
-                               i = *cp++;
-                               chars_processed++;
-
+                               offset = (((i << 8) | EXTRACT_U_1(cp)) & 0x3fff);
                                /*
                                /*
-                                * If we've looked at every character in
-                                * the message, this pointer will make
-                                * us look at some character again,
-                                * which means we're looping.
+                                * This must move backwards in the packet.
+                                * No RFC explicitly says that, but BIND's
+                                * name decompression code requires it,
+                                * as a way of preventing infinite loops
+                                * and other bad behavior, and it's probably
+                                * what was intended (compress by pointing
+                                * to domain name suffixes already seen in
+                                * the packet).
                                 */
                                 */
-                               if (chars_processed >= data_size) {
-                                       printf("<LOOP>");
-                                       return (NULL);
+                               if (offset >= max_offset) {
+                                       ND_PRINT((ndo, "<BAD PTR>"));
+                                       return(NULL);
                                }
                                }
+                               max_offset = offset;
+                               cp = bp + offset;
+                               if ((l = labellen(ndo, cp)) == (u_int)-1)
+                                       return(NULL);
+                               if (!ND_TTEST_1(cp))
+                                       return(NULL);
+                               i = EXTRACT_U_1(cp);
+                               cp++;
                                continue;
                        }
                        if ((i & INDIR_MASK) == EDNS0_MASK) {
                                elt = (i & ~INDIR_MASK);
                                switch(elt) {
                                case EDNS0_ELT_BITLABEL:
                                continue;
                        }
                        if ((i & INDIR_MASK) == EDNS0_MASK) {
                                elt = (i & ~INDIR_MASK);
                                switch(elt) {
                                case EDNS0_ELT_BITLABEL:
-                                       blabel_print(cp);
+                                       if (blabel_print(ndo, cp) == NULL)
+                                               return (NULL);
                                        break;
                                default:
                                        /* unknown ELT */
                                        break;
                                default:
                                        /* unknown ELT */
-                                       printf("<ELT %d>", elt);
+                                       ND_PRINT((ndo, "<ELT %d>", elt));
                                        return(NULL);
                                }
                        } else {
                                        return(NULL);
                                }
                        } else {
-                               if (fn_printn(cp, l, snapend))
-                                       break;
+                               if (fn_printn(ndo, cp, l, ndo->ndo_snapend))
+                                       return(NULL);
                        }
 
                        cp += l;
                        }
 
                        cp += l;
-                       chars_processed += l;
-                       putchar('.');
-                       if (cp >= snapend || (l = labellen(cp)) < 0)
+                       ND_PRINT((ndo, "."));
+                       if ((l = labellen(ndo, cp)) == (u_int)-1)
                                return(NULL);
                                return(NULL);
-                       i = *cp++;
-                       chars_processed++;
+                       if (!ND_TTEST_1(cp))
+                               return(NULL);
+                       i = EXTRACT_U_1(cp);
+                       cp++;
                        if (!compress)
                                rp += l + 1;
                }
        else
                        if (!compress)
                                rp += l + 1;
                }
        else
-               putchar('.');
+               ND_PRINT((ndo, "."));
        return (rp);
 }
 
 /* print a <character-string> */
 static const u_char *
        return (rp);
 }
 
 /* print a <character-string> */
 static const u_char *
-ns_cprint(register const u_char *cp, register const u_char *bp)
+ns_cprint(netdissect_options *ndo,
+          register const u_char *cp)
 {
        register u_int i;
 
 {
        register u_int i;
 
-       if (cp >= snapend)
-               return NULL;
-       i = *cp++;
-       (void)fn_printn(cp, i, snapend);
+       if (!ND_TTEST_1(cp))
+               return (NULL);
+       i = EXTRACT_U_1(cp);
+       cp++;
+       if (fn_printn(ndo, cp, i, ndo->ndo_snapend))
+               return (NULL);
        return (cp + i);
 }
 
        return (cp + i);
 }
 
-static struct tok type2str[] = {
-       { T_A,          "A" },
-       { T_NS,         "NS" },
-       { T_MD,         "MD" },
-       { T_MF,         "MF" },
-       { T_CNAME,      "CNAME" },
-       { T_SOA,        "SOA" },
-       { T_MB,         "MB" },
-       { T_MG,         "MG" },
-       { T_MR,         "MR" },
-       { T_NULL,       "NULL" },
-       { T_WKS,        "WKS" },
-       { T_PTR,        "PTR" },
-       { T_HINFO,      "HINFO" },
-       { T_MINFO,      "MINFO" },
-       { T_MX,         "MX" },
-       { T_TXT,        "TXT" },
-       { T_RP,         "RP" },
-       { T_AFSDB,      "AFSDB" },
-       { T_X25,        "X25" },
-       { T_ISDN,       "ISDN" },
-       { T_RT,         "RT" },
-       { T_NSAP,       "NSAP" },
+/* http://www.iana.org/assignments/dns-parameters */
+const struct tok ns_type2str[] = {
+       { T_A,          "A" },                  /* RFC 1035 */
+       { T_NS,         "NS" },                 /* RFC 1035 */
+       { T_MD,         "MD" },                 /* RFC 1035 */
+       { T_MF,         "MF" },                 /* RFC 1035 */
+       { T_CNAME,      "CNAME" },              /* RFC 1035 */
+       { T_SOA,        "SOA" },                /* RFC 1035 */
+       { T_MB,         "MB" },                 /* RFC 1035 */
+       { T_MG,         "MG" },                 /* RFC 1035 */
+       { T_MR,         "MR" },                 /* RFC 1035 */
+       { T_NULL,       "NULL" },               /* RFC 1035 */
+       { T_WKS,        "WKS" },                /* RFC 1035 */
+       { T_PTR,        "PTR" },                /* RFC 1035 */
+       { T_HINFO,      "HINFO" },              /* RFC 1035 */
+       { T_MINFO,      "MINFO" },              /* RFC 1035 */
+       { T_MX,         "MX" },                 /* RFC 1035 */
+       { T_TXT,        "TXT" },                /* RFC 1035 */
+       { T_RP,         "RP" },                 /* RFC 1183 */
+       { T_AFSDB,      "AFSDB" },              /* RFC 1183 */
+       { T_X25,        "X25" },                /* RFC 1183 */
+       { T_ISDN,       "ISDN" },               /* RFC 1183 */
+       { T_RT,         "RT" },                 /* RFC 1183 */
+       { T_NSAP,       "NSAP" },               /* RFC 1706 */
        { T_NSAP_PTR,   "NSAP_PTR" },
        { T_NSAP_PTR,   "NSAP_PTR" },
-       { T_SIG,        "SIG" },
-       { T_KEY,        "KEY" },
-       { T_PX,         "PX" },
-       { T_GPOS,       "GPOS" },
-       { T_AAAA,       "AAAA" },
-       { T_LOC,        "LOC " },
-       { T_NXT,        "NXT " },
-       { T_EID,        "EID " },
-       { T_NIMLOC,     "NIMLOC " },
-       { T_SRV,        "SRV " },
-       { T_ATMA,       "ATMA " },
-       { T_NAPTR,      "NAPTR " },
-       { T_A6,         "A6 " },
-       { T_DNAME,      "DNAME " },
-       { T_OPT,        "OPT " },
+       { T_SIG,        "SIG" },                /* RFC 2535 */
+       { T_KEY,        "KEY" },                /* RFC 2535 */
+       { T_PX,         "PX" },                 /* RFC 2163 */
+       { T_GPOS,       "GPOS" },               /* RFC 1712 */
+       { T_AAAA,       "AAAA" },               /* RFC 1886 */
+       { T_LOC,        "LOC" },                /* RFC 1876 */
+       { T_NXT,        "NXT" },                /* RFC 2535 */
+       { T_EID,        "EID" },                /* Nimrod */
+       { T_NIMLOC,     "NIMLOC" },             /* Nimrod */
+       { T_SRV,        "SRV" },                /* RFC 2782 */
+       { T_ATMA,       "ATMA" },               /* ATM Forum */
+       { T_NAPTR,      "NAPTR" },              /* RFC 2168, RFC 2915 */
+       { T_KX,         "KX" },                 /* RFC 2230 */
+       { T_CERT,       "CERT" },               /* RFC 2538 */
+       { T_A6,         "A6" },                 /* RFC 2874 */
+       { T_DNAME,      "DNAME" },              /* RFC 2672 */
+       { T_SINK,       "SINK" },
+       { T_OPT,        "OPT" },                /* RFC 2671 */
+       { T_APL,        "APL" },                /* RFC 3123 */
+       { T_DS,         "DS" },                 /* RFC 4034 */
+       { T_SSHFP,      "SSHFP" },              /* RFC 4255 */
+       { T_IPSECKEY,   "IPSECKEY" },           /* RFC 4025 */
+       { T_RRSIG,      "RRSIG" },              /* RFC 4034 */
+       { T_NSEC,       "NSEC" },               /* RFC 4034 */
+       { T_DNSKEY,     "DNSKEY" },             /* RFC 4034 */
+       { T_SPF,        "SPF" },                /* RFC-schlitt-spf-classic-02.txt */
        { T_UINFO,      "UINFO" },
        { T_UID,        "UID" },
        { T_GID,        "GID" },
        { T_UNSPEC,     "UNSPEC" },
        { T_UNSPECA,    "UNSPECA" },
        { T_UINFO,      "UINFO" },
        { T_UID,        "UID" },
        { T_GID,        "GID" },
        { T_UNSPEC,     "UNSPEC" },
        { T_UNSPECA,    "UNSPECA" },
-       { T_AXFR,       "AXFR" },
-       { T_MAILB,      "MAILB" },
-       { T_MAILA,      "MAILA" },
+       { T_TKEY,       "TKEY" },               /* RFC 2930 */
+       { T_TSIG,       "TSIG" },               /* RFC 2845 */
+       { T_IXFR,       "IXFR" },               /* RFC 1995 */
+       { T_AXFR,       "AXFR" },               /* RFC 1035 */
+       { T_MAILB,      "MAILB" },              /* RFC 1035 */
+       { T_MAILA,      "MAILA" },              /* RFC 1035 */
        { T_ANY,        "ANY" },
        { 0,            NULL }
 };
 
        { T_ANY,        "ANY" },
        { 0,            NULL }
 };
 
-static struct tok class2str[] = {
+const struct tok ns_class2str[] = {
        { C_IN,         "IN" },         /* Not used */
        { C_IN,         "IN" },         /* Not used */
-       { C_CHAOS,      "CHAOS)" },
+       { C_CHAOS,      "CHAOS" },
        { C_HS,         "HS" },
        { C_ANY,        "ANY" },
        { 0,            NULL }
        { C_HS,         "HS" },
        { C_ANY,        "ANY" },
        { 0,            NULL }
@@ -387,73 +330,106 @@ static struct tok class2str[] = {
 
 /* print a query */
 static const u_char *
 
 /* print a query */
 static const u_char *
-ns_qprint(register const u_char *cp, register const u_char *bp)
+ns_qprint(netdissect_options *ndo,
+          register const u_char *cp, register const u_char *bp, int is_mdns)
 {
        register const u_char *np = cp;
 {
        register const u_char *np = cp;
-       register u_int i;
+       register u_int i, class;
 
 
-       cp = ns_nskip(cp, bp);
+       cp = ns_nskip(ndo, cp);
 
 
-       if (cp + 4 > snapend || cp == NULL)
+       if (cp == NULL || !ND_TTEST_4(cp))
                return(NULL);
 
                return(NULL);
 
-       /* print the qtype and qclass (if it's not IN) */
-       i = *cp++ << 8;
-       i |= *cp++;
-       printf(" %s", tok2str(type2str, "Type%d", i));
-       i = *cp++ << 8;
-       i |= *cp++;
-       if (i != C_IN)
-               printf(" %s", tok2str(class2str, "(Class %d)", i));
-
-       fputs("? ", stdout);
-       cp = ns_nprint(np, bp);
+       /* print the qtype */
+       i = EXTRACT_BE_U_2(cp);
+       cp += 2;
+       ND_PRINT((ndo, " %s", tok2str(ns_type2str, "Type%d", i)));
+       /* print the qclass (if it's not IN) */
+       i = EXTRACT_BE_U_2(cp);
+       cp += 2;
+       if (is_mdns)
+               class = (i & ~C_QU);
+       else
+               class = i;
+       if (class != C_IN)
+               ND_PRINT((ndo, " %s", tok2str(ns_class2str, "(Class %d)", class)));
+       if (is_mdns) {
+               ND_PRINT((ndo, i & C_QU ? " (QU)" : " (QM)"));
+       }
+
+       ND_PRINT((ndo, "? "));
+       cp = ns_nprint(ndo, np, bp);
        return(cp ? cp + 4 : NULL);
 }
 
 /* print a reply */
 static const u_char *
        return(cp ? cp + 4 : NULL);
 }
 
 /* print a reply */
 static const u_char *
-ns_rprint(register const u_char *cp, register const u_char *bp)
+ns_rprint(netdissect_options *ndo,
+          register const u_char *cp, register const u_char *bp, int is_mdns)
 {
 {
-       register u_int class;
+       register u_int i, class, opt_flags = 0;
        register u_short typ, len;
        register const u_char *rp;
 
        register u_short typ, len;
        register const u_char *rp;
 
-       if (vflag) {
-               putchar(' ');
-               if ((cp = ns_nprint(cp, bp)) == NULL)
+       if (ndo->ndo_vflag) {
+               ND_PRINT((ndo, " "));
+               if ((cp = ns_nprint(ndo, cp, bp)) == NULL)
                        return NULL;
        } else
                        return NULL;
        } else
-               cp = ns_nskip(cp, bp);
-
-       if (cp + 10 > snapend || cp == NULL)
-               return (snapend);
-
-       /* print the type/qtype and class (if it's not IN) */
-       typ = *cp++ << 8;
-       typ |= *cp++;
-       class = *cp++ << 8;
-       class |= *cp++;
+               cp = ns_nskip(ndo, cp);
+
+       if (cp == NULL || !ND_TTEST2(*cp, 10))
+               return (ndo->ndo_snapend);
+
+       /* print the type/qtype */
+       typ = EXTRACT_BE_U_2(cp);
+       cp += 2;
+       /* print the class (if it's not IN and the type isn't OPT) */
+       i = EXTRACT_BE_U_2(cp);
+       cp += 2;
+       if (is_mdns)
+               class = (i & ~C_CACHE_FLUSH);
+       else
+               class = i;
        if (class != C_IN && typ != T_OPT)
        if (class != C_IN && typ != T_OPT)
-               printf(" %s", tok2str(class2str, "(Class %d)", class));
+               ND_PRINT((ndo, " %s", tok2str(ns_class2str, "(Class %d)", class)));
+       if (is_mdns) {
+               if (i & C_CACHE_FLUSH)
+                       ND_PRINT((ndo, " (Cache flush)"));
+       }
 
 
-       /* ignore ttl */
-       cp += 4;
+       if (typ == T_OPT) {
+               /* get opt flags */
+               cp += 2;
+               opt_flags = EXTRACT_BE_U_2(cp);
+               /* ignore rest of ttl field */
+               cp += 2;
+       } else if (ndo->ndo_vflag > 2) {
+               /* print ttl */
+               ND_PRINT((ndo, " ["));
+               unsigned_relts_print(ndo, EXTRACT_BE_U_4(cp));
+               ND_PRINT((ndo, "]"));
+               cp += 4;
+       } else {
+               /* ignore ttl */
+               cp += 4;
+       }
 
 
-       len = *cp++ << 8;
-       len |= *cp++;
+       len = EXTRACT_BE_U_2(cp);
+       cp += 2;
 
        rp = cp + len;
 
 
        rp = cp + len;
 
-       printf(" %s", tok2str(type2str, "Type%d", typ));
-       if (rp > snapend)
+       ND_PRINT((ndo, " %s", tok2str(ns_type2str, "Type%d", typ)));
+       if (rp > ndo->ndo_snapend)
                return(NULL);
 
        switch (typ) {
        case T_A:
                return(NULL);
 
        switch (typ) {
        case T_A:
-               if (cp + sizeof(struct in_addr) > snapend)
+               if (!ND_TTEST2(*cp, sizeof(struct in_addr)))
                        return(NULL);
                        return(NULL);
-               printf(" %s", ipaddr_string(cp));
+               ND_PRINT((ndo, " %s", intoa(htonl(EXTRACT_BE_U_4(cp)))));
                break;
 
        case T_NS:
                break;
 
        case T_NS:
@@ -462,245 +438,322 @@ ns_rprint(register const u_char *cp, register const u_char *bp)
 #ifdef T_DNAME
        case T_DNAME:
 #endif
 #ifdef T_DNAME
        case T_DNAME:
 #endif
-               putchar(' ');
-               if (ns_nprint(cp, bp) == NULL)
+               ND_PRINT((ndo, " "));
+               if (ns_nprint(ndo, cp, bp) == NULL)
                        return(NULL);
                break;
 
        case T_SOA:
                        return(NULL);
                break;
 
        case T_SOA:
-               if (!vflag)
+               if (!ndo->ndo_vflag)
                        break;
                        break;
-               putchar(' ');
-               if ((cp = ns_nprint(cp, bp)) == NULL)
+               ND_PRINT((ndo, " "));
+               if ((cp = ns_nprint(ndo, cp, bp)) == NULL)
                        return(NULL);
                        return(NULL);
-               putchar(' ');
-               if ((cp = ns_nprint(cp, bp)) == NULL)
+               ND_PRINT((ndo, " "));
+               if ((cp = ns_nprint(ndo, cp, bp)) == NULL)
                        return(NULL);
                        return(NULL);
-               if (cp + 5 * 4 > snapend)
+               if (!ND_TTEST2(*cp, 5 * 4))
                        return(NULL);
                        return(NULL);
-               printf(" %u", EXTRACT_32BITS(cp));
+               ND_PRINT((ndo, " %u", EXTRACT_BE_U_4(cp)));
                cp += 4;
                cp += 4;
-               printf(" %u", EXTRACT_32BITS(cp));
+               ND_PRINT((ndo, " %u", EXTRACT_BE_U_4(cp)));
                cp += 4;
                cp += 4;
-               printf(" %u", EXTRACT_32BITS(cp));
+               ND_PRINT((ndo, " %u", EXTRACT_BE_U_4(cp)));
                cp += 4;
                cp += 4;
-               printf(" %u", EXTRACT_32BITS(cp));
+               ND_PRINT((ndo, " %u", EXTRACT_BE_U_4(cp)));
                cp += 4;
                cp += 4;
-               printf(" %u", EXTRACT_32BITS(cp));
+               ND_PRINT((ndo, " %u", EXTRACT_BE_U_4(cp)));
                cp += 4;
                break;
        case T_MX:
                cp += 4;
                break;
        case T_MX:
-               putchar(' ');
-               if (cp + 2 > snapend)
+               ND_PRINT((ndo, " "));
+               if (!ND_TTEST_2(cp))
                        return(NULL);
                        return(NULL);
-               if (ns_nprint(cp + 2, bp) == NULL)
+               if (ns_nprint(ndo, cp + 2, bp) == NULL)
                        return(NULL);
                        return(NULL);
-               printf(" %d", EXTRACT_16BITS(cp));
+               ND_PRINT((ndo, " %d", EXTRACT_BE_U_2(cp)));
                break;
 
        case T_TXT:
                break;
 
        case T_TXT:
-               putchar(' ');
-               (void)ns_cprint(cp, bp);
+               while (cp < rp) {
+                       ND_PRINT((ndo, " \""));
+                       cp = ns_cprint(ndo, cp);
+                       if (cp == NULL)
+                               return(NULL);
+                       ND_PRINT((ndo, "\""));
+               }
+               break;
+
+       case T_SRV:
+               ND_PRINT((ndo, " "));
+               if (!ND_TTEST_6(cp))
+                       return(NULL);
+               if (ns_nprint(ndo, cp + 6, bp) == NULL)
+                       return(NULL);
+               ND_PRINT((ndo, ":%d %d %d", EXTRACT_BE_U_2(cp + 4),
+                         EXTRACT_BE_U_2(cp), EXTRACT_BE_U_2(cp + 2)));
                break;
 
                break;
 
-#ifdef INET6
        case T_AAAA:
        case T_AAAA:
-               if (cp + sizeof(struct in6_addr) > snapend)
+           {
+               char ntop_buf[INET6_ADDRSTRLEN];
+
+               if (!ND_TTEST2(*cp, sizeof(struct in6_addr)))
                        return(NULL);
                        return(NULL);
-               printf(" %s", ip6addr_string(cp));
+               ND_PRINT((ndo, " %s",
+                   addrtostr6(cp, ntop_buf, sizeof(ntop_buf))));
+
                break;
                break;
+           }
 
        case T_A6:
            {
                struct in6_addr a;
                int pbit, pbyte;
 
        case T_A6:
            {
                struct in6_addr a;
                int pbit, pbyte;
+               char ntop_buf[INET6_ADDRSTRLEN];
 
 
-               pbit = *cp;
+               if (!ND_TTEST_1(cp))
+                       return(NULL);
+               pbit = EXTRACT_U_1(cp);
                pbyte = (pbit & ~7) / 8;
                if (pbit > 128) {
                pbyte = (pbit & ~7) / 8;
                if (pbit > 128) {
-                       printf(" %u(bad plen)", pbit);
+                       ND_PRINT((ndo, " %u(bad plen)", pbit));
                        break;
                } else if (pbit < 128) {
                        break;
                } else if (pbit < 128) {
+                       if (!ND_TTEST2(*(cp + 1), sizeof(a) - pbyte))
+                               return(NULL);
                        memset(&a, 0, sizeof(a));
                        memcpy(&a.s6_addr[pbyte], cp + 1, sizeof(a) - pbyte);
                        memset(&a, 0, sizeof(a));
                        memcpy(&a.s6_addr[pbyte], cp + 1, sizeof(a) - pbyte);
-                       printf(" %u %s", pbit, ip6addr_string(&a));
+                       ND_PRINT((ndo, " %u %s", pbit,
+                           addrtostr6(&a, ntop_buf, sizeof(ntop_buf))));
                }
                if (pbit > 0) {
                }
                if (pbit > 0) {
-                       putchar(' ');
-                       if (ns_nprint(cp + 1 + sizeof(a) - pbyte, bp) == NULL)
+                       ND_PRINT((ndo, " "));
+                       if (ns_nprint(ndo, cp + 1 + sizeof(a) - pbyte, bp) == NULL)
                                return(NULL);
                }
                break;
            }
                                return(NULL);
                }
                break;
            }
-#endif /*INET6*/
 
        case T_OPT:
 
        case T_OPT:
-               printf(" UDPsize=%u", class);
+               ND_PRINT((ndo, " UDPsize=%u", class));
+               if (opt_flags & 0x8000)
+                       ND_PRINT((ndo, " DO"));
                break;
 
        case T_UNSPECA:         /* One long string */
                break;
 
        case T_UNSPECA:         /* One long string */
-               if (cp + len > snapend)
+               if (!ND_TTEST2(*cp, len))
+                       return(NULL);
+               if (fn_printn(ndo, cp, len, ndo->ndo_snapend))
                        return(NULL);
                        return(NULL);
-               fn_printn(cp, len, snapend);
                break;
                break;
+
+       case T_TSIG:
+           {
+               if (cp + len > ndo->ndo_snapend)
+                       return(NULL);
+               if (!ndo->ndo_vflag)
+                       break;
+               ND_PRINT((ndo, " "));
+               if ((cp = ns_nprint(ndo, cp, bp)) == NULL)
+                       return(NULL);
+               cp += 6;
+               if (!ND_TTEST_2(cp))
+                       return(NULL);
+               ND_PRINT((ndo, " fudge=%u", EXTRACT_BE_U_2(cp)));
+               cp += 2;
+               if (!ND_TTEST_2(cp))
+                       return(NULL);
+               ND_PRINT((ndo, " maclen=%u", EXTRACT_BE_U_2(cp)));
+               cp += 2 + EXTRACT_BE_U_2(cp);
+               if (!ND_TTEST_2(cp))
+                       return(NULL);
+               ND_PRINT((ndo, " origid=%u", EXTRACT_BE_U_2(cp)));
+               cp += 2;
+               if (!ND_TTEST_2(cp))
+                       return(NULL);
+               ND_PRINT((ndo, " error=%u", EXTRACT_BE_U_2(cp)));
+               cp += 2;
+               if (!ND_TTEST_2(cp))
+                       return(NULL);
+               ND_PRINT((ndo, " otherlen=%u", EXTRACT_BE_U_2(cp)));
+               cp += 2;
+           }
        }
        return (rp);            /* XXX This isn't always right */
 }
 
 void
        }
        return (rp);            /* XXX This isn't always right */
 }
 
 void
-ns_print(register const u_char *bp, u_int length)
+domain_print(netdissect_options *ndo,
+         register const u_char *bp, u_int length, int is_mdns)
 {
        register const HEADER *np;
        register int qdcount, ancount, nscount, arcount;
 {
        register const HEADER *np;
        register int qdcount, ancount, nscount, arcount;
-       register const u_char *cp = NULL;
+       register const u_char *cp;
+       uint16_t b2;
 
        np = (const HEADER *)bp;
 
        np = (const HEADER *)bp;
+       ND_TCHECK(*np);
        /* get the byte-order right */
        /* get the byte-order right */
-       qdcount = ntohs(np->qdcount);
-       ancount = ntohs(np->ancount);
-       nscount = ntohs(np->nscount);
-       arcount = ntohs(np->arcount);
+       qdcount = EXTRACT_BE_U_2(&np->qdcount);
+       ancount = EXTRACT_BE_U_2(&np->ancount);
+       nscount = EXTRACT_BE_U_2(&np->nscount);
+       arcount = EXTRACT_BE_U_2(&np->arcount);
 
        if (DNS_QR(np)) {
                /* this is a response */
 
        if (DNS_QR(np)) {
                /* this is a response */
-               printf(" %d%s%s%s%s%s%s",
-                       ntohs(np->id),
+               ND_PRINT((ndo, "%d%s%s%s%s%s%s",
+                       EXTRACT_BE_U_2(&np->id),
                        ns_ops[DNS_OPCODE(np)],
                        ns_resp[DNS_RCODE(np)],
                        DNS_AA(np)? "*" : "",
                        DNS_RA(np)? "" : "-",
                        DNS_TC(np)? "|" : "",
                        ns_ops[DNS_OPCODE(np)],
                        ns_resp[DNS_RCODE(np)],
                        DNS_AA(np)? "*" : "",
                        DNS_RA(np)? "" : "-",
                        DNS_TC(np)? "|" : "",
-                       DNS_CD(np)? "%" : "");
+                       DNS_AD(np)? "$" : ""));
 
                if (qdcount != 1)
 
                if (qdcount != 1)
-                       printf(" [%dq]", qdcount);
+                       ND_PRINT((ndo, " [%dq]", qdcount));
                /* Print QUESTION section on -vv */
                /* Print QUESTION section on -vv */
-               if (vflag > 1) {
-                       fputs(" q:", stdout);
-                       if ((cp = ns_qprint((const u_char *)(np + 1), bp))
-                           == NULL)
-                               goto trunc;
-               } else {
-                       if ((cp = ns_nskip((const u_char *)(np + 1), bp))
-                           == NULL)
-                               goto trunc;
-                       cp += 4;
+               cp = (const u_char *)(np + 1);
+               while (qdcount--) {
+                       if (qdcount < EXTRACT_BE_U_2(&np->qdcount) - 1)
+                               ND_PRINT((ndo, ","));
+                       if (ndo->ndo_vflag > 1) {
+                               ND_PRINT((ndo, " q:"));
+                               if ((cp = ns_qprint(ndo, cp, bp, is_mdns)) == NULL)
+                                       goto trunc;
+                       } else {
+                               if ((cp = ns_nskip(ndo, cp)) == NULL)
+                                       goto trunc;
+                               cp += 4;        /* skip QTYPE and QCLASS */
+                       }
                }
                }
-               printf(" %d/%d/%d", ancount, nscount, arcount);
+               ND_PRINT((ndo, " %d/%d/%d", ancount, nscount, arcount));
                if (ancount--) {
                if (ancount--) {
-                       if ((cp = ns_rprint(cp, bp)) == NULL)
+                       if ((cp = ns_rprint(ndo, cp, bp, is_mdns)) == NULL)
                                goto trunc;
                                goto trunc;
-                       while (ancount-- && cp < snapend) {
-                               putchar(',');
-                               if ((cp = ns_rprint(cp, bp)) == NULL)
+                       while (cp < ndo->ndo_snapend && ancount--) {
+                               ND_PRINT((ndo, ","));
+                               if ((cp = ns_rprint(ndo, cp, bp, is_mdns)) == NULL)
                                        goto trunc;
                        }
                }
                                        goto trunc;
                        }
                }
+               if (ancount > 0)
+                       goto trunc;
                /* Print NS and AR sections on -vv */
                /* Print NS and AR sections on -vv */
-               if (vflag > 1) {
-                       if (nscount-- && cp < snapend) {
-                               fputs(" ns:", stdout);
-                               if ((cp = ns_rprint(cp, bp)) == NULL)
+               if (ndo->ndo_vflag > 1) {
+                       if (cp < ndo->ndo_snapend && nscount--) {
+                               ND_PRINT((ndo, " ns:"));
+                               if ((cp = ns_rprint(ndo, cp, bp, is_mdns)) == NULL)
                                        goto trunc;
                                        goto trunc;
-                               while (nscount-- && cp < snapend) {
-                                       putchar(',');
-                                       if ((cp = ns_rprint(cp, bp)) == NULL)
+                               while (cp < ndo->ndo_snapend && nscount--) {
+                                       ND_PRINT((ndo, ","));
+                                       if ((cp = ns_rprint(ndo, cp, bp, is_mdns)) == NULL)
                                                goto trunc;
                                }
                        }
                                                goto trunc;
                                }
                        }
-                       if (arcount-- && cp < snapend) {
-                               fputs(" ar:", stdout);
-                               if ((cp = ns_rprint(cp, bp)) == NULL)
+                       if (nscount > 0)
+                               goto trunc;
+                       if (cp < ndo->ndo_snapend && arcount--) {
+                               ND_PRINT((ndo, " ar:"));
+                               if ((cp = ns_rprint(ndo, cp, bp, is_mdns)) == NULL)
                                        goto trunc;
                                        goto trunc;
-                               while (arcount-- && cp < snapend) {
-                                       putchar(',');
-                                       if ((cp = ns_rprint(cp, bp)) == NULL)
+                               while (cp < ndo->ndo_snapend && arcount--) {
+                                       ND_PRINT((ndo, ","));
+                                       if ((cp = ns_rprint(ndo, cp, bp, is_mdns)) == NULL)
                                                goto trunc;
                                }
                        }
                                                goto trunc;
                                }
                        }
+                       if (arcount > 0)
+                               goto trunc;
                }
        }
        else {
                /* this is a request */
                }
        }
        else {
                /* this is a request */
-               printf(" %d%s%s%s", ntohs(np->id), ns_ops[DNS_OPCODE(np)],
-                   DNS_RD(np) ? "+" : "",
-                   DNS_AD(np) ? "$" : "");
+               ND_PRINT((ndo, "%d%s%s%s", EXTRACT_BE_U_2(&np->id), ns_ops[DNS_OPCODE(np)],
+                         DNS_RD(np) ? "+" : "",
+                         DNS_CD(np) ? "%" : ""));
 
                /* any weirdness? */
 
                /* any weirdness? */
-               if (*(((u_short *)np)+1) & htons(0x6cf))
-                       printf(" [b2&3=0x%x]", ntohs(*(((u_short *)np)+1)));
+               b2 = EXTRACT_BE_U_2(((const u_short *)np) + 1);
+               if (b2 & 0x6cf)
+                       ND_PRINT((ndo, " [b2&3=0x%x]", b2));
 
                if (DNS_OPCODE(np) == IQUERY) {
                        if (qdcount)
 
                if (DNS_OPCODE(np) == IQUERY) {
                        if (qdcount)
-                               printf(" [%dq]", qdcount);
+                               ND_PRINT((ndo, " [%dq]", qdcount));
                        if (ancount != 1)
                        if (ancount != 1)
-                               printf(" [%da]", ancount);
+                               ND_PRINT((ndo, " [%da]", ancount));
                }
                else {
                        if (ancount)
                }
                else {
                        if (ancount)
-                               printf(" [%da]", ancount);
+                               ND_PRINT((ndo, " [%da]", ancount));
                        if (qdcount != 1)
                        if (qdcount != 1)
-                               printf(" [%dq]", qdcount);
+                               ND_PRINT((ndo, " [%dq]", qdcount));
                }
                if (nscount)
                }
                if (nscount)
-                       printf(" [%dn]", nscount);
+                       ND_PRINT((ndo, " [%dn]", nscount));
                if (arcount)
                if (arcount)
-                       printf(" [%dau]", arcount);
+                       ND_PRINT((ndo, " [%dau]", arcount));
 
 
+               cp = (const u_char *)(np + 1);
                if (qdcount--) {
                if (qdcount--) {
-                       cp = ns_qprint((const u_char *)(np + 1),
-                                      (const u_char *)np);
+                       cp = ns_qprint(ndo, cp, (const u_char *)np, is_mdns);
                        if (!cp)
                                goto trunc;
                        if (!cp)
                                goto trunc;
-                       if ((cp = ns_rprint(cp, bp)) == NULL)
-                               goto trunc;
-                       while (qdcount-- && cp < snapend) {
-                               cp = ns_qprint((const u_char *)cp,
-                                              (const u_char *)np);
+                       while (cp < ndo->ndo_snapend && qdcount--) {
+                               cp = ns_qprint(ndo, (const u_char *)cp,
+                                              (const u_char *)np,
+                                              is_mdns);
                                if (!cp)
                                        goto trunc;
                                if (!cp)
                                        goto trunc;
-                               if ((cp = ns_rprint(cp, bp)) == NULL)
-                                       goto trunc;
                        }
                }
                        }
                }
+               if (qdcount > 0)
+                       goto trunc;
 
                /* Print remaining sections on -vv */
 
                /* Print remaining sections on -vv */
-               if (vflag > 1) {
+               if (ndo->ndo_vflag > 1) {
                        if (ancount--) {
                        if (ancount--) {
-                               if ((cp = ns_rprint(cp, bp)) == NULL)
+                               if ((cp = ns_rprint(ndo, cp, bp, is_mdns)) == NULL)
                                        goto trunc;
                                        goto trunc;
-                               while (ancount-- && cp < snapend) {
-                                       putchar(',');
-                                       if ((cp = ns_rprint(cp, bp)) == NULL)
+                               while (cp < ndo->ndo_snapend && ancount--) {
+                                       ND_PRINT((ndo, ","));
+                                       if ((cp = ns_rprint(ndo, cp, bp, is_mdns)) == NULL)
                                                goto trunc;
                                }
                        }
                                                goto trunc;
                                }
                        }
-                       if (nscount-- && cp < snapend) {
-                               fputs(" ns:", stdout);
-                               if ((cp = ns_rprint(cp, bp)) == NULL)
+                       if (ancount > 0)
+                               goto trunc;
+                       if (cp < ndo->ndo_snapend && nscount--) {
+                               ND_PRINT((ndo, " ns:"));
+                               if ((cp = ns_rprint(ndo, cp, bp, is_mdns)) == NULL)
                                        goto trunc;
                                        goto trunc;
-                               while (nscount-- && cp < snapend) {
-                                       putchar(',');
-                                       if ((cp = ns_rprint(cp, bp)) == NULL)
+                               while (nscount-- && cp < ndo->ndo_snapend) {
+                                       ND_PRINT((ndo, ","));
+                                       if ((cp = ns_rprint(ndo, cp, bp, is_mdns)) == NULL)
                                                goto trunc;
                                }
                        }
                                                goto trunc;
                                }
                        }
-                       if (arcount-- && cp < snapend) {
-                               fputs(" ar:", stdout);
-                               if ((cp = ns_rprint(cp, bp)) == NULL)
+                       if (nscount > 0)
+                               goto trunc;
+                       if (cp < ndo->ndo_snapend && arcount--) {
+                               ND_PRINT((ndo, " ar:"));
+                               if ((cp = ns_rprint(ndo, cp, bp, is_mdns)) == NULL)
                                        goto trunc;
                                        goto trunc;
-                               while (arcount-- && cp < snapend) {
-                                       putchar(',');
-                                       if ((cp = ns_rprint(cp, bp)) == NULL)
+                               while (cp < ndo->ndo_snapend && arcount--) {
+                                       ND_PRINT((ndo, ","));
+                                       if ((cp = ns_rprint(ndo, cp, bp, is_mdns)) == NULL)
                                                goto trunc;
                                }
                        }
                                                goto trunc;
                                }
                        }
+                       if (arcount > 0)
+                               goto trunc;
                }
        }
                }
        }
-       printf(" (%d)", length);
+       ND_PRINT((ndo, " (%d)", length));
        return;
 
   trunc:
        return;
 
   trunc:
-       printf("[|domain]");
-       return;
+       ND_PRINT((ndo, "[|domain]"));
 }
 }
[mirror] the TCPdump network dissector