CI: Add warning exemptions for Sun C (suncc-5.15) on Solaris 10

[tcpdump] / update-test.sh

diff --git a/update-test.sh b/update-test.sh
index 6ee18cae9e4f9fb03ed3ff82d285660d297ebbe5..be93e1d3bee0e488ea638c30f34c664b696caee9 100755 (executable)
--- a/update-test.sh
+++ b/update-test.sh
@@ -7,14 +7,16 @@ TZ=GMT0; export TZ
 for TEST in "$@"; do
     PREFIX=tests
     MATCH=0
 for TEST in "$@"; do
     PREFIX=tests
     MATCH=0

-    while read name input output options
+    while read -r name input output options

     do
     do

-        [ _$name = _ ] && continue        # ignore empty lines
-        [ _${name#\#} != _$name ] && continue    # ignore comment lines
-        [ $name != "$TEST" ] && continue    # not the requested test
-        [ _$output = _ ] && continue    # ignore incomplete lines
+        [ -z "$name" ] && continue        # ignore empty lines
+        [ "${name#\#}" != "$name" ] && continue    # ignore comment lines
+        [ "$name" != "$TEST" ] && continue    # not the requested test
+        [ -z "$output" ] && continue    # ignore incomplete lines

         MATCH=1
         MATCH=1

-        ./tcpdump -# -n -r "$PREFIX/$input" $options >"$PREFIX/$output"
+        # Word splitting is intentional for $options.
+        # shellcheck disable=SC2086
+        ./tcpdump -# -n -tttt -r "$PREFIX/$input" $options >"$PREFIX/$output"

     done < $PREFIX/TESTLIST
     [ $MATCH = 0 ] && echo "test $TEST not found" >&2
 done
     done < $PREFIX/TESTLIST
     [ $MATCH = 0 ] && echo "test $TEST not found" >&2
 done