From: Denis Ovsienko <denis@ovsienko.info>
Date: Sun, 9 Mar 2025 14:45:48 +0000 (+0000)
Subject: Comment buffer sizes better in pcap_nametoproto().
X-Git-Url: https://git.tcpdump.org/libpcap/commitdiff_plain/f901282007f8b8638a44d1db660f11ffc3ea3a6b?ds=sidebyside

Comment buffer sizes better in pcap_nametoproto().
---

diff --git a/nametoaddr.c b/nametoaddr.c
index 342f95f3..38f5c712 100644
--- a/nametoaddr.c
+++ b/nametoaddr.c
@@ -487,7 +487,7 @@ pcap_nametoproto(const char *str)
 	 * We have Linux's reentrant getprotobyname_r().
 	 */
 	struct protoent result_buf;
-	char buf[1024];	/* arbitrary size */
+	char buf[1024];	// "...1024 bytes should be sufficient for most applications."
 	int err;
 
 	err = getprotobyname_r(str, &result_buf, buf, sizeof buf, &p);
@@ -517,7 +517,7 @@ pcap_nametoproto(const char *str)
 	 * We have Solaris's reentrant getprotobyname_r().
 	 */
 	struct protoent result_buf;
-	char buf[1024];	/* arbitrary size */
+	char buf[1024];	// "...must be at least 1024 bytes."
 
 	p = getprotobyname_r(str, &result_buf, buf, (int)sizeof buf);
   #elif defined(HAVE_AIX_GETPROTOBYNAME_R)