From: Guy Harris <guy@alum.mit.edu>
Date: Sun, 10 Feb 2019 20:08:04 +0000 (-0800)
Subject: Don't explicitly check for root permission.
X-Git-Tag: libpcap-1.10-bp~540
X-Git-Url: https://git.tcpdump.org/libpcap/commitdiff_plain/abeb357041f40ccf2dd715cab5e2860ceb851eb7

Don't explicitly check for root permission.

Let DPDK tell us if we don't have sufficient permission to use it;
rte_eal_init() appears to return -1 and set rte_errno to EACCES in that
case, and we now handle that case ourselves.
---

diff --git a/pcap-dpdk.c b/pcap-dpdk.c
index 9b324e6b..df4bfd49 100644
--- a/pcap-dpdk.c
+++ b/pcap-dpdk.c
@@ -581,16 +581,6 @@ static int dpdk_pre_init(char * ebuf)
 			return 1;
 		}
 	}
-	// check for root permission
-	// XXX - is it sufficient to call rte_eal_init() and check for
-	// EACCES?
-	if( geteuid() != 0)
-	{
-		RTE_LOG(ERR, USER1, "%s\n", DPDK_ERR_PERM_MSG);
-		pcap_snprintf(ebuf, PCAP_ERRBUF_SIZE,
-		    "DPDK requires that it run as root");
-		return PCAP_ERROR_PERM_DENIED;
-	}
 	// init EAL
 	ptr_dpdk_cfg = getenv(DPDK_CFG_ENV_NAME);
 	// set default log level to debug