From: Guy Harris <guy@alum.mit.edu>
Date: Sat, 12 Jan 2019 23:08:17 +0000 (-0800)
Subject: Don't log the error buffer before returning.
X-Git-Tag: libpcap-1.10-bp~617
X-Git-Url: https://git.tcpdump.org/libpcap/commitdiff_plain/4a3244de1424155ab4485cafd8299b9144c76ed7

Don't log the error buffer before returning.

If there was an error, a message should already have been logged at
priority LOGPRIO_ERROR; logging it again at LOGPRIO_DEBUG isn't useful.
---

diff --git a/rpcapd/daemon.c b/rpcapd/daemon.c
index eaf276e1..00717c93 100644
--- a/rpcapd/daemon.c
+++ b/rpcapd/daemon.c
@@ -1109,7 +1109,6 @@ end:
 
 	// Print message and return
 	rpcapd_log(LOGPRIO_DEBUG, "I'm exiting from the child loop");
-	rpcapd_log(LOGPRIO_DEBUG, "%s", errbuf);
 
 	return client_told_us_to_close;
 }