From: Francois-Xavier Le Bail <devel.fx.lebail@orange.fr>
Date: Wed, 17 Jun 2020 15:11:53 +0000 (+0200)
Subject: DAG: Fix a condition
X-Git-Tag: libpcap-1.10-bp~100
X-Git-Url: https://git.tcpdump.org/libpcap/commitdiff_plain/01afa17bf96ff719931c4f7dc644381132e72456

DAG: Fix a condition

Found with cppcheck.

The warning was:
pcap-dag.c:1117:6: style: Suspicious condition (assignment + comparison);
Clarify expression with parentheses. [clarifyCondition]
  if ((dag_error = dag_config_get_uint32_attribute_ex(pd->dag_ref,
       pd->drop_attr, &stream_drop) == kDagErrNone)) {
     ^
---

diff --git a/pcap-dag.c b/pcap-dag.c
index 928088fe..62f6e649 100644
--- a/pcap-dag.c
+++ b/pcap-dag.c
@@ -1114,7 +1114,7 @@ dag_stats(pcap_t *p, struct pcap_stat *ps) {
 		/* Note this counter is cleared at start of capture and will wrap at UINT_MAX.
 		 * The application is responsible for polling ps_drop frequently enough
 		 * to detect each wrap and integrate total drop with a wider counter */
-		if ((dag_error = dag_config_get_uint32_attribute_ex(pd->dag_ref, pd->drop_attr, &stream_drop) == kDagErrNone)) {
+		if ((dag_error = dag_config_get_uint32_attribute_ex(pd->dag_ref, pd->drop_attr, &stream_drop)) == kDagErrNone) {
 			pd->stat.ps_drop = stream_drop;
 		} else {
 			snprintf(p->errbuf, PCAP_ERRBUF_SIZE, "reading stream drop attribute: %s",