]> The Tcpdump Group git mirrors - libpcap/commitdiff
That comment was for tcpdump; adjust it to refer to libpcap code.
authorGuy Harris <[email protected]>
Tue, 30 Apr 2019 00:41:20 +0000 (17:41 -0700)
committerGuy Harris <[email protected]>
Tue, 30 Apr 2019 00:41:44 +0000 (17:41 -0700)
[skip ci]

CMakeLists.txt

index c0e16bd9ca0e17800964a87f4235e3d662d06dbb..3399c4835ccf0a9669e52d3b8d39e7e7e98c35b3 100644 (file)
@@ -1869,13 +1869,8 @@ if(EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/.devel OR EXISTS ${CMAKE_BINARY_DIR}/.deve
         #
         # We do *not* care about every single place the compiler would
         # have inserted Spectre mitigation if only we had told it to
-        # do so with /Qspectre.  I guess the theory is that it's seeing
-        # bounds checks that would prevent out-of-bounds loads and that
-        # those out-of-bounds loads could be done speculatively and that
-        # the Spectre attack could detect the value of the out-of-bounds
-        # data *if* it's within our address space, but unless I'm
-        # missing something I don't see that as being any form of
-        # security hole.
+        # do so with /Qspectre.  Maybe it's worth it, as that's in
+        # Bison-generated code that we don't control.
         #
         # XXX - add /Qspectre if that is really worth doing.
         #