Found with cppcheck.
The warning was:
pcap-dag.c:1117:6: style: Suspicious condition (assignment + comparison);
Clarify expression with parentheses. [clarifyCondition]
if ((dag_error = dag_config_get_uint32_attribute_ex(pd->dag_ref,
pd->drop_attr, &stream_drop) == kDagErrNone)) {
^
/* Note this counter is cleared at start of capture and will wrap at UINT_MAX.
* The application is responsible for polling ps_drop frequently enough
* to detect each wrap and integrate total drop with a wider counter */
- if ((dag_error = dag_config_get_uint32_attribute_ex(pd->dag_ref, pd->drop_attr, &stream_drop) == kDagErrNone)) {
+ if ((dag_error = dag_config_get_uint32_attribute_ex(pd->dag_ref, pd->drop_attr, &stream_drop)) == kDagErrNone) {
pd->stat.ps_drop = stream_drop;
} else {
snprintf(p->errbuf, PCAP_ERRBUF_SIZE, "reading stream drop attribute: %s",