diff options
| author | Markus Redeker <[email protected]> | 2025-04-23 15:57:20 +0200 |
|---|---|---|
| committer | Eike Ziller <[email protected]> | 2025-05-05 06:23:41 +0000 |
| commit | 775d12a2fc71f4dd9d01ef9934eec095c092a054 (patch) | |
| tree | 29ddeca5cccf9971fdd59552ea8da4f552cbb04d | |
| parent | fc5d289e7941d7e458ce8d003a0a4124ebfd4b29 (diff) | |
Coco: fix crash in CocoBuildStep
The bug was reported via Sentry and I could not reproduce it here, but
the immediate cause was clear: m_buildSettings was used when it was
still a null pointer - certainly because CocoBuildStep::display() was
not yet called.
I have added code that prevents this.
Fixes: QTCREATORBUG-32850
Change-Id: I8226e1466870e77749aff276de150b79f75332a4
Reviewed-by: David Schulz <[email protected]>
(cherry picked from commit c052dda76b3b3e64f13a39cc1adaec91b6195944)
| -rw-r--r-- | src/plugins/coco/cocobuildstep.cpp | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/plugins/coco/cocobuildstep.cpp b/src/plugins/coco/cocobuildstep.cpp index 1717abd027a..c9809932b7c 100644 --- a/src/plugins/coco/cocobuildstep.cpp +++ b/src/plugins/coco/cocobuildstep.cpp @@ -77,6 +77,8 @@ void CocoBuildStep::buildSystemUpdated() void CocoBuildStep::onButtonClicked() { + QTC_ASSERT(m_buildSettings, return); + m_valid = !m_valid; setSummaryText(Tr::tr("Coco Code Coverage: Reconfiguring...")); @@ -97,6 +99,8 @@ QWidget *CocoBuildStep::createConfigWidget() void CocoBuildStep::updateDisplay() { + QTC_ASSERT(m_buildSettings, return); + if (!cocoSettings().isValid()) { setSummaryText("<i>" + Tr::tr("Coco Code Coverage: No working Coco installation.") + "</i>"); emit setButtonState(false); |