Skip to content

Conversation

@busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Nov 19, 2020

image

Verified that the docs show up locally by doing nox -s docs

Fixes #99 🦕

@busunkim96 busunkim96 requested review from a team as code owners November 19, 2020 20:15
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label Nov 19, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 19, 2020
Copy link
Contributor

@daniel-sanche daniel-sanche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like lint is failing, but after that it LGTM!

@busunkim96 busunkim96 merged commit 6a46b46 into master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: logging Issues related to the googleapis/python-logging API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logger not showing up in public docs

2 participants