Conversation
0ce5226 to
2988c8a
Compare
added methods to assemble bundles, but not yet serialize them into length-prefixed json strings with tests for bundle assembly
e7fd160 to
4537bba
Compare
schmidt-sebastian
left a comment
There was a problem hiding this comment.
Some comments. Before merging, can you coordinate a test with wuandy@ to make sure that these Bundles load in our clients.
wu-hui
left a comment
There was a problem hiding this comment.
Thanks for incorporating the comments! I think we are close now.
I do want to discuss the possibility of accepting list of documents for addNamedQuery, please let me know what do you think.
|
That's reasonable, @wu-hui. Adding now. |
|
@wu-hui On second thought, accepting a list of |
|
@wu-hui Can we just treat queries and documents as independent? The Python SDK could offer APIs to add named queries and documents, but we don't necessarily need to associate the documents with the queries. The Mobile clients should still be able to handle this data (correct me if I am wrong). I'm also very surprised that Python still does not have QuerySnapshots and a bit scared to find out what this means for the Watch API :) |
I think we might have to accept |
|
LGTM! |
No description provided.