feat: support using client credentials with emulator#269
Merged
crwilcox merged 4 commits intogoogleapis:masterfrom Dec 14, 2020
Merged
feat: support using client credentials with emulator#269crwilcox merged 4 commits intogoogleapis:masterfrom
crwilcox merged 4 commits intogoogleapis:masterfrom
Conversation
Collaborator
|
This seems like a convenient thing to have, what do you think @crwilcox ? |
Contributor
|
Thanks for the contribution @paulharter. In order for us to accept this we would need it to pass linting and coverage. The linting can be fixed by running |
Contributor
Author
|
@crwilcox I've added a test and linted, I hope it's ok now. Thank you for accepting this, it will make testing much easier. |
crwilcox
approved these changes
Dec 14, 2020
Contributor
|
Thanks for the contribution @paulharter. This will go out in the next minor release of the library. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the
grpc.Channelused when connecting to a local emulator so that the client credentials are used. This allows for testing database rules against the emulator in python.Fixes ##268
thanks