feat: add support for not-in and not-eq query operators#202
feat: add support for not-in and not-eq query operators#202tseaver merged 10 commits intogoogleapis:masterfrom
Conversation
| Args: | ||
| op_string (str): A comparison operation in the form of a string. | ||
| Acceptable values are ``<``, ``<=``, ``==``, ``>=`` | ||
| Acceptable values are ``<``, ``<=``, ``==``, ``!=``, ``>=`` |
There was a problem hiding this comment.
does this method also accept "not-in, array_contains" and more? This may be accurate, but I wanted to double check :)
|
@HemangChothani Please fix the conformance test failure on this branch. |
| } | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
The upstream for this file is authoritative: we are not supposed to modify / remove the copied-in files.
@BenWhitehead please clarify the intention here.
There was a problem hiding this comment.
PR to update the operator in the upstream files: googleapis/conformance-tests#41
There was a problem hiding this comment.
Above PR has been merged and can be pulled into the project to test the actual case for a not supported operator.
There was a problem hiding this comment.
@HemangChothani Please revert (or git rebase -i to edit out) commit 420788b and copy in the version of query-invalid-operator.json updated by googleapis/conformance-tests#41.
This reverts commit 420788b.
Fixes #189