feat: asyncio microgen document#121
Merged
rafilong merged 8 commits intogoogleapis:v2-stagingfrom Jul 22, 2020
Merged
Conversation
BenWhitehead
approved these changes
Jul 21, 2020
Collaborator
BenWhitehead
left a comment
There was a problem hiding this comment.
Clear to merge after #119 is merged and this is rebased
28f023c to
8b8d613
Compare
tritone
reviewed
Jul 22, 2020
tritone
left a comment
There was a problem hiding this comment.
Generally looks fine to me here as well.
f22e12a to
1b974c3
Compare
tritone
reviewed
Jul 22, 2020
tritone
left a comment
There was a problem hiding this comment.
Thanks for rebasing, much clearer now what is going on. This looks good!
One last question-- I see that some of these functions have very long docstrings which I'm assuming are mostly copied from the non-async code. Is any further modification required because of these changes?
Contributor
Author
|
Nice catch, for the most part the docstrings were good, but there was one function that I overlooked during my refactor. |
tritone
approved these changes
Jul 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #77