Skip to content

Comments

feat: use DatetimeWithNanoseconds throughout library#116

Merged
crwilcox merged 5 commits intogoogleapis:v2-stagingfrom
crwilcox:v2-staging-minimum-proto-plus
Jul 24, 2020
Merged

feat: use DatetimeWithNanoseconds throughout library#116
crwilcox merged 5 commits intogoogleapis:v2-stagingfrom
crwilcox:v2-staging-minimum-proto-plus

Conversation

@crwilcox
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 17, 2020
@crwilcox crwilcox added this to the v2 milestone Jul 17, 2020
@crwilcox crwilcox requested a review from rafilong July 17, 2020 01:39
Copy link
Contributor

@rafilong rafilong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It looks like there are a couple unused imports that are causing lint to fail, but otherwise good!

@@ -17,6 +17,8 @@
import mock
import datetime
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is unused.

@crwilcox crwilcox merged commit 1801ba2 into googleapis:v2-staging Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants